-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource]aws_finspace_kx_volume #34833
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc TESTS=TestAccFinSpaceKxVolume_ PKG=finspace ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 1 -run='TestAccFinSpaceKxVolume_' -timeout 360m
=== RUN TestAccFinSpaceKxVolume_basic
=== PAUSE TestAccFinSpaceKxVolume_basic
=== RUN TestAccFinSpaceKxVolume_disappears
=== PAUSE TestAccFinSpaceKxVolume_disappears
=== RUN TestAccFinSpaceKxVolume_tags
=== PAUSE TestAccFinSpaceKxVolume_tags
=== CONT TestAccFinSpaceKxVolume_basic
--- PASS: TestAccFinSpaceKxVolume_basic (1704.73s)
=== CONT TestAccFinSpaceKxVolume_tags
kx_volume_test.go:101: Step 1/4 error: Error running apply: exit status 1
Error: waiting for creation Amazon FinSpace Kx Volume (q3ddjdtnmiyvwpkkcqo4ey,tf-acc-test-3386223232616498069): unexpected state 'CREATE_FAILED', wanted target 'ACTIVE'. last error: %!s(<nil>)
with aws_finspace_kx_volume.test,
on terraform_plugin_test.tf line 118, in resource "aws_finspace_kx_volume" "test":
118: resource "aws_finspace_kx_volume" "test" {
testing_new.go:91: Error running post-test destroy, there may be dangling resources: exit status 1
Error: waiting for delete Amazon FinSpace Kx Environment (q3ddjdtnmiyvwpkkcqo4ey): timeout while waiting for resource to be gone (last state: 'DELETING', timeout: 1h15m0s)
--- FAIL: TestAccFinSpaceKxVolume_tags (5014.65s)
=== CONT TestAccFinSpaceKxVolume_disappears
--- PASS: TestAccFinSpaceKxVolume_disappears (1720.39s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/finspace 8443.002s
In a separate run:
% make testacc TESTS=TestAccFinSpaceKxVolume_tags PKG=finspace ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 1 -run='TestAccFinSpaceKxVolume_tags' -timeout 360m
=== RUN TestAccFinSpaceKxVolume_tags
=== PAUSE TestAccFinSpaceKxVolume_tags
=== CONT TestAccFinSpaceKxVolume_tags
--- PASS: TestAccFinSpaceKxVolume_tags (1626.74s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/finspace 1630.055s
Thanks for your contribution, @hiranimd! |
This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Introduces a new resource for finspace_kx_volume. Includes resource handlers, tests, and documentation changes.
Relations
Relates #34831
References
https://github.com/aws/aws-sdk-go-v2/tree/main/service/finspace
https://docs.aws.amazon.com/finspace/latest/userguide/finspace-managed-kdb.html
Output from Acceptance Testing