Add opt_in_to_archive_for_supported_resources attribute to AWS Backup Plan resource

[mmourick]

Description

Adds opt_in_to_archive_for_supported_resources attribute to AWS Backup Plan resource

Relations

Closes #34880

References

Output from Acceptance Testing

❯ make testacc TESTS=TestAccBackupPlan_ PKG=backup
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 20 -run='TestAccBackupPlan_'  -timeout 360m
=== RUN   TestAccBackupPlan_basic
=== PAUSE TestAccBackupPlan_basic
=== RUN   TestAccBackupPlan_withTags
=== PAUSE TestAccBackupPlan_withTags
=== RUN   TestAccBackupPlan_withRules
=== PAUSE TestAccBackupPlan_withRules
=== RUN   TestAccBackupPlan_withLifecycle
=== PAUSE TestAccBackupPlan_withLifecycle
=== RUN   TestAccBackupPlan_withRecoveryPointTags
=== PAUSE TestAccBackupPlan_withRecoveryPointTags
=== RUN   TestAccBackupPlan_RuleCopyAction_sameRegion
=== PAUSE TestAccBackupPlan_RuleCopyAction_sameRegion
=== RUN   TestAccBackupPlan_RuleCopyAction_noLifecycle
=== PAUSE TestAccBackupPlan_RuleCopyAction_noLifecycle
=== RUN   TestAccBackupPlan_RuleCopyAction_multiple
=== PAUSE TestAccBackupPlan_RuleCopyAction_multiple
=== RUN   TestAccBackupPlan_RuleCopyAction_crossRegion
=== PAUSE TestAccBackupPlan_RuleCopyAction_crossRegion
=== RUN   TestAccBackupPlan_advancedBackupSetting
=== PAUSE TestAccBackupPlan_advancedBackupSetting
=== RUN   TestAccBackupPlan_enableContinuousBackup
=== PAUSE TestAccBackupPlan_enableContinuousBackup
=== RUN   TestAccBackupPlan_disappears
=== PAUSE TestAccBackupPlan_disappears
=== CONT  TestAccBackupPlan_basic
=== CONT  TestAccBackupPlan_RuleCopyAction_noLifecycle
=== CONT  TestAccBackupPlan_withRules
=== CONT  TestAccBackupPlan_advancedBackupSetting
=== CONT  TestAccBackupPlan_enableContinuousBackup
=== CONT  TestAccBackupPlan_disappears
=== CONT  TestAccBackupPlan_withLifecycle
=== CONT  TestAccBackupPlan_RuleCopyAction_sameRegion
=== CONT  TestAccBackupPlan_withRecoveryPointTags
=== CONT  TestAccBackupPlan_RuleCopyAction_crossRegion
=== CONT  TestAccBackupPlan_RuleCopyAction_multiple
=== CONT  TestAccBackupPlan_withTags
--- PASS: TestAccBackupPlan_disappears (32.94s)
--- PASS: TestAccBackupPlan_basic (38.80s)
--- PASS: TestAccBackupPlan_RuleCopyAction_multiple (38.85s)
--- PASS: TestAccBackupPlan_enableContinuousBackup (38.85s)
--- PASS: TestAccBackupPlan_RuleCopyAction_crossRegion (42.89s)
--- PASS: TestAccBackupPlan_advancedBackupSetting (49.63s)
--- PASS: TestAccBackupPlan_RuleCopyAction_sameRegion (66.56s)
--- PASS: TestAccBackupPlan_RuleCopyAction_noLifecycle (70.14s)
--- PASS: TestAccBackupPlan_withRules (70.25s)
--- PASS: TestAccBackupPlan_withRecoveryPointTags (70.27s)
--- PASS: TestAccBackupPlan_withTags (70.28s)
--- PASS: TestAccBackupPlan_withLifecycle (92.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/backup     94.603s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[bschaatsbergen]

LGTM! 🚀

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBackupPlan_' PKG=backup ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupPlan_ -timeout 360m
=== RUN   TestAccBackupPlan_basic
=== PAUSE TestAccBackupPlan_basic
=== RUN   TestAccBackupPlan_withTags
=== PAUSE TestAccBackupPlan_withTags
=== RUN   TestAccBackupPlan_withRules
=== PAUSE TestAccBackupPlan_withRules
=== RUN   TestAccBackupPlan_withLifecycle
=== PAUSE TestAccBackupPlan_withLifecycle
=== RUN   TestAccBackupPlan_withRecoveryPointTags
=== PAUSE TestAccBackupPlan_withRecoveryPointTags
=== RUN   TestAccBackupPlan_RuleCopyAction_sameRegion
=== PAUSE TestAccBackupPlan_RuleCopyAction_sameRegion
=== RUN   TestAccBackupPlan_RuleCopyAction_noLifecycle
=== PAUSE TestAccBackupPlan_RuleCopyAction_noLifecycle
=== RUN   TestAccBackupPlan_RuleCopyAction_multiple
=== PAUSE TestAccBackupPlan_RuleCopyAction_multiple
=== RUN   TestAccBackupPlan_RuleCopyAction_crossRegion
=== PAUSE TestAccBackupPlan_RuleCopyAction_crossRegion
=== RUN   TestAccBackupPlan_advancedBackupSetting
=== PAUSE TestAccBackupPlan_advancedBackupSetting
=== RUN   TestAccBackupPlan_enableContinuousBackup
=== PAUSE TestAccBackupPlan_enableContinuousBackup
=== RUN   TestAccBackupPlan_disappears
=== PAUSE TestAccBackupPlan_disappears
=== CONT  TestAccBackupPlan_basic
=== CONT  TestAccBackupPlan_RuleCopyAction_noLifecycle
=== CONT  TestAccBackupPlan_withLifecycle
--- PASS: TestAccBackupPlan_basic (25.28s)
=== CONT  TestAccBackupPlan_advancedBackupSetting
--- PASS: TestAccBackupPlan_RuleCopyAction_noLifecycle (53.91s)
=== CONT  TestAccBackupPlan_disappears
--- PASS: TestAccBackupPlan_advancedBackupSetting (36.45s)
=== CONT  TestAccBackupPlan_enableContinuousBackup
--- PASS: TestAccBackupPlan_disappears (19.61s)
=== CONT  TestAccBackupPlan_RuleCopyAction_crossRegion
--- PASS: TestAccBackupPlan_withLifecycle (81.96s)
=== CONT  TestAccBackupPlan_withRules
--- PASS: TestAccBackupPlan_enableContinuousBackup (23.27s)
=== CONT  TestAccBackupPlan_RuleCopyAction_multiple
--- PASS: TestAccBackupPlan_RuleCopyAction_crossRegion (34.48s)
=== CONT  TestAccBackupPlan_RuleCopyAction_sameRegion
--- PASS: TestAccBackupPlan_RuleCopyAction_multiple (24.47s)
=== CONT  TestAccBackupPlan_withRecoveryPointTags
--- PASS: TestAccBackupPlan_withRules (52.97s)
=== CONT  TestAccBackupPlan_withTags
--- PASS: TestAccBackupPlan_RuleCopyAction_sameRegion (52.15s)
--- PASS: TestAccBackupPlan_withRecoveryPointTags (50.78s)
--- PASS: TestAccBackupPlan_withTags (45.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	185.944s

[ewbankkit]

@mmourick Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[LLParse]

@mmourick @ewbankkit Moving from v5.32.1 to v5.33.0 breaks aws_backup_plan for AWS govcloud. I receive this error:

Error: creating Backup Plan: InvalidParameterValueException: Error in some rules due to : Invalid lifecycle. EBS Cold Tier is not yet supported.

This only happens on govcloud, commercial cloud deployment doesn't fail. I have tried setting opt_in_to_archive_for_supported_resources = false on every rule's lifecycle and I still get the error. As a hail mary, I have tried setting cold_storage_after = 0 on every rule's lifecycle as well and I still get the same error.

Unfortunately, we are pinned to 5.32.1 until this is remedied. Please feel free to correct me if I am using the module wrong. I have posted to this PR because it appears to be responsible, or at least related to the lifecycle changes for aws_backup_plan. Thanks.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.