Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redshift/cluster: Add multi_az configuration #35508

Merged
merged 4 commits into from
Jan 29, 2024
Merged

redshift/cluster: Add multi_az configuration #35508

merged 4 commits into from
Jan 29, 2024

Conversation

Giaco9
Copy link

@Giaco9 Giaco9 commented Jan 26, 2024

Description

Add supports for the multi_az configuration for Redshift cluster.

Relations

Closes #34926
Closes #32180

References

https://docs.aws.amazon.com/redshift/latest/mgmt/using-multi-az.html

Output from Acceptance Testing

make testacc TESTS=TestAccRedshiftCluster_basic PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftCluster_basic'  -timeout 360m
=== RUN   TestAccRedshiftCluster_basic
=== PAUSE TestAccRedshiftCluster_basic
=== CONT  TestAccRedshiftCluster_basic
--- PASS: TestAccRedshiftCluster_basic (154.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	180.059s
make testacc TESTS=TestAccRedshiftCluster_multiAZ PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftCluster_multiAZ'  -timeout 360m
=== RUN   TestAccRedshiftCluster_multiAZ
=== PAUSE TestAccRedshiftCluster_multiAZ
=== CONT  TestAccRedshiftCluster_multiAZ
--- PASS: TestAccRedshiftCluster_multiAZ (672.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	685.491s
make testacc TESTS=TestAccRedshiftCluster_changeAvailabilityZone PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftCluster_changeAvailabilityZone'  -timeout 360m
=== RUN   TestAccRedshiftCluster_changeAvailabilityZone
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZone
=== RUN   TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
=== RUN   TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
=== CONT  TestAccRedshiftCluster_changeAvailabilityZone
=== CONT  TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
=== CONT  TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet (221.07s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone (397.73s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation (401.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	413.642s
make testacc TESTS=TestAccRedshiftCluster_availabilityZoneRelocation PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftCluster_availabilityZoneRelocation'  -timeout 360m
=== RUN   TestAccRedshiftCluster_availabilityZoneRelocation
=== PAUSE TestAccRedshiftCluster_availabilityZoneRelocation
=== RUN   TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
=== PAUSE TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
=== CONT  TestAccRedshiftCluster_availabilityZoneRelocation
=== CONT  TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible (169.82s)
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation (200.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	213.610s
make testacc TESTS=TestAccRedshiftClusterDataSource_basic PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftClusterDataSource_basic'  -timeout 360m
=== RUN   TestAccRedshiftClusterDataSource_basic
=== PAUSE TestAccRedshiftClusterDataSource_basic
=== CONT  TestAccRedshiftClusterDataSource_basic
--- PASS: TestAccRedshiftClusterDataSource_basic (159.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	171.259s
make testacc TESTS=TestAccRedshiftClusterDataSource_multiAZEnabled PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftClusterDataSource_multiAZEnabled'  -timeout 360m
=== RUN   TestAccRedshiftClusterDataSource_multiAZEnabled
=== PAUSE TestAccRedshiftClusterDataSource_multiAZEnabled
=== CONT  TestAccRedshiftClusterDataSource_multiAZEnabled
--- PASS: TestAccRedshiftClusterDataSource_multiAZEnabled (258.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	279.625s
make testacc TESTS=TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled'  -timeout 360m
=== RUN   TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== PAUSE TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== CONT  TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
--- PASS: TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled (214.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	228.142s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/redshift Issues and PRs that pertain to the redshift service. and removed size/M Managed by automation to categorize the size of a PR. labels Jan 26, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 26, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Giaco9 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Jan 27, 2024
@Giaco9 Giaco9 marked this pull request as ready for review January 27, 2024 18:01
@Giaco9 Giaco9 changed the title [WIP] redshift/cluster: Add multi_az configuration redshift/cluster: Add multi_az configuration Jan 27, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 29, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftCluster_' PKG=redshift ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 3  -run=TestAccRedshiftCluster_ -timeout 360m
=== RUN   TestAccRedshiftCluster_basic
=== PAUSE TestAccRedshiftCluster_basic
=== RUN   TestAccRedshiftCluster_aqua
=== PAUSE TestAccRedshiftCluster_aqua
=== RUN   TestAccRedshiftCluster_disappears
=== PAUSE TestAccRedshiftCluster_disappears
=== RUN   TestAccRedshiftCluster_withFinalSnapshot
=== PAUSE TestAccRedshiftCluster_withFinalSnapshot
=== RUN   TestAccRedshiftCluster_kmsKey
=== PAUSE TestAccRedshiftCluster_kmsKey
=== RUN   TestAccRedshiftCluster_enhancedVPCRoutingEnabled
=== PAUSE TestAccRedshiftCluster_enhancedVPCRoutingEnabled
=== RUN   TestAccRedshiftCluster_loggingEnabled
=== PAUSE TestAccRedshiftCluster_loggingEnabled
=== RUN   TestAccRedshiftCluster_snapshotCopy
=== PAUSE TestAccRedshiftCluster_snapshotCopy
=== RUN   TestAccRedshiftCluster_iamRoles
=== PAUSE TestAccRedshiftCluster_iamRoles
=== RUN   TestAccRedshiftCluster_publiclyAccessible
=== PAUSE TestAccRedshiftCluster_publiclyAccessible
=== RUN   TestAccRedshiftCluster_updateNodeCount
=== PAUSE TestAccRedshiftCluster_updateNodeCount
=== RUN   TestAccRedshiftCluster_updateNodeType
=== PAUSE TestAccRedshiftCluster_updateNodeType
=== RUN   TestAccRedshiftCluster_tags
=== PAUSE TestAccRedshiftCluster_tags
=== RUN   TestAccRedshiftCluster_forceNewUsername
=== PAUSE TestAccRedshiftCluster_forceNewUsername
=== RUN   TestAccRedshiftCluster_changeAvailabilityZone
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZone
=== RUN   TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
=== RUN   TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
=== RUN   TestAccRedshiftCluster_changeEncryption1
=== PAUSE TestAccRedshiftCluster_changeEncryption1
=== RUN   TestAccRedshiftCluster_changeEncryption2
=== PAUSE TestAccRedshiftCluster_changeEncryption2
=== RUN   TestAccRedshiftCluster_availabilityZoneRelocation
=== PAUSE TestAccRedshiftCluster_availabilityZoneRelocation
=== RUN   TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
=== PAUSE TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
=== RUN   TestAccRedshiftCluster_restoreFromSnapshot
=== PAUSE TestAccRedshiftCluster_restoreFromSnapshot
=== RUN   TestAccRedshiftCluster_restoreFromSnapshotARN
=== PAUSE TestAccRedshiftCluster_restoreFromSnapshotARN
=== RUN   TestAccRedshiftCluster_manageMasterPassword
=== PAUSE TestAccRedshiftCluster_manageMasterPassword
=== RUN   TestAccRedshiftCluster_multiAZ
=== PAUSE TestAccRedshiftCluster_multiAZ
=== CONT  TestAccRedshiftCluster_basic
=== CONT  TestAccRedshiftCluster_forceNewUsername
=== CONT  TestAccRedshiftCluster_availabilityZoneRelocation
--- PASS: TestAccRedshiftCluster_basic (155.64s)
=== CONT  TestAccRedshiftCluster_snapshotCopy
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation (210.42s)
=== CONT  TestAccRedshiftCluster_tags
--- PASS: TestAccRedshiftCluster_forceNewUsername (310.30s)
=== CONT  TestAccRedshiftCluster_updateNodeType
--- PASS: TestAccRedshiftCluster_snapshotCopy (197.80s)
=== CONT  TestAccRedshiftCluster_updateNodeCount
--- PASS: TestAccRedshiftCluster_tags (180.61s)
=== CONT  TestAccRedshiftCluster_publiclyAccessible
--- PASS: TestAccRedshiftCluster_publiclyAccessible (238.66s)
=== CONT  TestAccRedshiftCluster_iamRoles
--- PASS: TestAccRedshiftCluster_iamRoles (231.84s)
=== CONT  TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
--- PASS: TestAccRedshiftCluster_updateNodeCount (685.02s)
=== CONT  TestAccRedshiftCluster_changeEncryption2
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet (204.65s)
=== CONT  TestAccRedshiftCluster_changeEncryption1
--- PASS: TestAccRedshiftCluster_updateNodeType (1141.24s)
=== CONT  TestAccRedshiftCluster_kmsKey
--- PASS: TestAccRedshiftCluster_kmsKey (159.11s)
=== CONT  TestAccRedshiftCluster_loggingEnabled
--- PASS: TestAccRedshiftCluster_changeEncryption1 (698.91s)
=== CONT  TestAccRedshiftCluster_enhancedVPCRoutingEnabled
--- PASS: TestAccRedshiftCluster_loggingEnabled (263.68s)
=== CONT  TestAccRedshiftCluster_restoreFromSnapshotARN
--- PASS: TestAccRedshiftCluster_changeEncryption2 (910.45s)
=== CONT  TestAccRedshiftCluster_multiAZ
--- PASS: TestAccRedshiftCluster_enhancedVPCRoutingEnabled (266.38s)
=== CONT  TestAccRedshiftCluster_manageMasterPassword
--- PASS: TestAccRedshiftCluster_manageMasterPassword (154.30s)
=== CONT  TestAccRedshiftCluster_restoreFromSnapshot
--- PASS: TestAccRedshiftCluster_restoreFromSnapshotARN (401.37s)
=== CONT  TestAccRedshiftCluster_disappears
--- PASS: TestAccRedshiftCluster_multiAZ (527.02s)
=== CONT  TestAccRedshiftCluster_withFinalSnapshot
--- PASS: TestAccRedshiftCluster_disappears (264.75s)
=== CONT  TestAccRedshiftCluster_aqua
--- PASS: TestAccRedshiftCluster_restoreFromSnapshot (431.22s)
=== CONT  TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
--- PASS: TestAccRedshiftCluster_withFinalSnapshot (215.84s)
=== CONT  TestAccRedshiftCluster_changeAvailabilityZone
--- PASS: TestAccRedshiftCluster_aqua (187.70s)
=== CONT  TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible (179.77s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone (314.13s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation (595.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	3222.974s
% make testacc TESTARGS='-run=TestAccRedshiftClusterDataSource_' PKG=redshift ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 3  -run=TestAccRedshiftClusterDataSource_ -timeout 360m
=== RUN   TestAccRedshiftClusterDataSource_basic
=== PAUSE TestAccRedshiftClusterDataSource_basic
=== RUN   TestAccRedshiftClusterDataSource_vpc
=== PAUSE TestAccRedshiftClusterDataSource_vpc
=== RUN   TestAccRedshiftClusterDataSource_logging
=== PAUSE TestAccRedshiftClusterDataSource_logging
=== RUN   TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== PAUSE TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== RUN   TestAccRedshiftClusterDataSource_multiAZEnabled
=== PAUSE TestAccRedshiftClusterDataSource_multiAZEnabled
=== CONT  TestAccRedshiftClusterDataSource_basic
=== CONT  TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== CONT  TestAccRedshiftClusterDataSource_logging
--- PASS: TestAccRedshiftClusterDataSource_basic (162.72s)
=== CONT  TestAccRedshiftClusterDataSource_multiAZEnabled
--- PASS: TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled (213.00s)
=== CONT  TestAccRedshiftClusterDataSource_vpc
--- PASS: TestAccRedshiftClusterDataSource_logging (305.63s)
--- PASS: TestAccRedshiftClusterDataSource_vpc (189.46s)
--- PASS: TestAccRedshiftClusterDataSource_multiAZEnabled (324.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	498.168s

@ewbankkit
Copy link
Contributor

@Giaco9 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ade2a3c into hashicorp:main Jan 29, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.35.0 milestone Jan 29, 2024
@Giaco9 Giaco9 deleted the f-redshift-multi-az-support branch January 30, 2024 04:06
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/redshift Issues and PRs that pertain to the redshift service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
4 participants