Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve logging_config consecutive diff issue #35694

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Resolve logging_config consecutive diff issue #35694

merged 1 commit into from
Feb 8, 2024

Conversation

JamesJJ
Copy link
Contributor

@JamesJJ JamesJJ commented Feb 7, 2024

Description

Suppresses incorrect diff on consecutive apply, and maintains existing log levels, when logging_config.application_log_level or logging_config.system_log_level have not been specified in configuration.

Relations

Closes #35301

Output from Acceptance Testing

make testacc 'TESTS=TestAccLambdaFunction(DataSource)?_(basic|loggingConfig)'  PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunction(DataSource)?_(basic|loggingConfig)'  -timeout 360m
=== RUN   TestAccLambdaFunctionDataSource_basic
=== PAUSE TestAccLambdaFunctionDataSource_basic
=== RUN   TestAccLambdaFunctionDataSource_loggingConfig
=== PAUSE TestAccLambdaFunctionDataSource_loggingConfig
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_loggingConfig
=== PAUSE TestAccLambdaFunction_loggingConfig
=== CONT  TestAccLambdaFunctionDataSource_basic
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaFunction_loggingConfig
=== CONT  TestAccLambdaFunctionDataSource_loggingConfig
--- PASS: TestAccLambdaFunctionDataSource_basic (54.18s)
--- PASS: TestAccLambdaFunction_basic (67.51s)
--- PASS: TestAccLambdaFunctionDataSource_loggingConfig (75.29s)
--- PASS: TestAccLambdaFunction_loggingConfig (144.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	152.545s

Copy link

github-actions bot commented Feb 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. labels Feb 7, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Feb 7, 2024
@JamesJJ JamesJJ changed the title Resolve Lambda logging_config consecutive diff issue Resolve logging_config consecutive diff issue Feb 7, 2024
@JamesJJ JamesJJ marked this pull request as ready for review February 7, 2024 16:30
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 8, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_logging' PKG=lambda ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 2  -run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_logging -timeout 360m
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_loggingConfig
=== PAUSE TestAccLambdaFunction_loggingConfig
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaFunction_loggingConfig
--- PASS: TestAccLambdaFunction_basic (49.63s)
--- PASS: TestAccLambdaFunction_loggingConfig (101.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	112.434s

@ewbankkit
Copy link
Contributor

@JamesJJ Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a1ae84e into hashicorp:main Feb 8, 2024
64 checks passed
@github-actions github-actions bot added this to the v5.36.0 milestone Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. service/lambda Issues and PRs that pertain to the lambda service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_lambda_function: perpetual drift in log levels
2 participants