Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws_verifiedpermissions_identity_source #35801

Closed
peterehik-px opened this issue Feb 13, 2024 · 10 comments · Fixed by #38181
Closed

[New Resource]: aws_verifiedpermissions_identity_source #35801

peterehik-px opened this issue Feb 13, 2024 · 10 comments · Fixed by #38181
Labels
new-resource Introduces a new resource. service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service.
Milestone

Comments

@peterehik-px
Copy link

peterehik-px commented Feb 13, 2024

Description

Add Verified Permission identity source

Requested Resource(s) and/or Data Source(s)

  • aws_verifiedpermission_identity_source

Potential Terraform Configuration

resource "aws_verifiedpermissions_identity_source" "test" {
  policy_store_id = aws_verifiedpermissions_identity_source.test.id

  configuration {
    cognito_user_pool_configuration {
      user_pool_arn = aws_cognito_user_pool.test.arn
      client_ids = []
    }
  }

  principal_entity_type = ""
  
}

References

Relates #32158.

Would you like to implement a fix?

None

Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service. label Feb 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 13, 2024
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 15, 2024
@hanoj-budime
Copy link

Hi team,

Any thoughts on this road too ?
@ewbankkit
@justinretzolk
@johnsonaj

@hanoj-budime
Copy link

Hi team,

Just a note : For group membership.. Token claims..
https://docs.aws.amazon.com/cli/latest/reference/verifiedpermissions/create-identity-source.html

image

@hanoj-budime
Copy link

Any updates ?

@hanoj-budime
Copy link

Hey.. Any updates ?

Include recent changes as well.

resource "aws_verifiedpermissions_identity_source" "test" {
  policy_store_id = aws_verifiedpermissions_identity_source.test.id

  configuration {
    cognito_user_pool_configuration {
      user_pool_arn = aws_cognito_user_pool.test.arn
      client_ids = []
      groupConfiguration {
       groupEntityType = ""
      }
    }
  }
  principal_entity_type = ""
}

@cbarensfeld
Copy link

I could really use this one, last piece for full avp deployment through terraform

@DanielRieske
Copy link
Contributor

Seeing that this is the last resource needed by the community for this service, I'll happily pick this up and will add the PR shortly.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.58.0 milestone Jul 11, 2024
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants