Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing use_off_peak_window arg to schema for aws_opensearch_domain data source #36298

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Mar 11, 2024

Description

This PR is to fix a regression introduced by #36067. The use_off_peak_window argument was added to the aws_opensearch_domain resource, however the the aws_openserach_domain data source wasn't updated accordingly.

Relations

Closes #36291

References

n/a

Output from Acceptance Testing

$ make testacc TESTARGS="-run=TestAccOpenSearchDomainDataSource_Data_" PKG=opensearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchDomainDataSource_Data_ -timeout 360m       
=== RUN   TestAccOpenSearchDomainDataSource_Data_basic
=== PAUSE TestAccOpenSearchDomainDataSource_Data_basic
=== RUN   TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT  TestAccOpenSearchDomainDataSource_Data_basic
=== CONT  TestAccOpenSearchDomainDataSource_Data_advanced
--- PASS: TestAccOpenSearchDomainDataSource_Data_basic (2215.90s)
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (2572.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 2572.460s

$

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/opensearch Issues and PRs that pertain to the opensearch service. labels Mar 11, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 11, 2024
@acwwat acwwat force-pushed the b-aws_opensearch_domain-fix_data_source_auto_tune_option_error branch from 9db3e02 to 8bcf222 Compare March 11, 2024 16:43
@acwwat acwwat changed the title [WIP] fix: Add missing use_off_peak_window arg to schema for aws_opensearch_domain data source fix: Add missing use_off_peak_window arg to schema for aws_opensearch_domain data source Mar 11, 2024
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 11, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOpenSearchDomainDataSource_Data_' PKG=opensearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchDomainDataSource_Data_ -timeout 360m
=== RUN   TestAccOpenSearchDomainDataSource_Data_basic
=== PAUSE TestAccOpenSearchDomainDataSource_Data_basic
=== RUN   TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT  TestAccOpenSearchDomainDataSource_Data_basic
=== CONT  TestAccOpenSearchDomainDataSource_Data_advanced
--- PASS: TestAccOpenSearchDomainDataSource_Data_basic (2265.73s)
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (2535.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	2542.391s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4b0e06b into hashicorp:main Mar 11, 2024
32 of 33 checks passed
@github-actions github-actions bot added this to the v5.41.0 milestone Mar 11, 2024
@ewbankkit ewbankkit mentioned this pull request Mar 11, 2024
Copy link

This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the b-aws_opensearch_domain-fix_data_source_auto_tune_option_error branch March 22, 2024 06:07
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. external-maintainer Contribution from a trusted external contributor. service/opensearch Issues and PRs that pertain to the opensearch service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_opesearch_domain data source not working in 1.40.0 release
3 participants