-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing use_off_peak_window arg to schema for aws_opensearch_domain data source #36298
fix: Add missing use_off_peak_window arg to schema for aws_opensearch_domain data source #36298
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…_domain data source
9db3e02
to
8bcf222
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccOpenSearchDomainDataSource_Data_' PKG=opensearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 20 -run=TestAccOpenSearchDomainDataSource_Data_ -timeout 360m
=== RUN TestAccOpenSearchDomainDataSource_Data_basic
=== PAUSE TestAccOpenSearchDomainDataSource_Data_basic
=== RUN TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT TestAccOpenSearchDomainDataSource_Data_basic
=== CONT TestAccOpenSearchDomainDataSource_Data_advanced
--- PASS: TestAccOpenSearchDomainDataSource_Data_basic (2265.73s)
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (2535.29s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 2542.391s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to fix a regression introduced by #36067. The
use_off_peak_window
argument was added to theaws_opensearch_domain
resource, however the theaws_openserach_domain
data source wasn't updated accordingly.Relations
Closes #36291
References
n/a
Output from Acceptance Testing