aws_ec2_transit_gateway_peering_attachment: add attachment status

[partcyborg]

Description

Add the Transit Gateway Peering Attachment status to the resource and data source.

Relations

Closes #36261

References

The same issue was reported in #26754, however this is an alternative solution

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccTransitGateway_serial/PeeringAttachment' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/PeeringAttachment -timeout 360m
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/PeeringAttachment
=== RUN   TestAccTransitGateway_serial/PeeringAttachment/disappears
=== RUN   TestAccTransitGateway_serial/PeeringAttachment/tags
=== RUN   TestAccTransitGateway_serial/PeeringAttachment/DifferentAccount
    transitgateway_peering_attachment_test.go:154: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccTransitGateway_serial/PeeringAttachment/basic
=== RUN   TestAccTransitGateway_serial/PeeringAttachmentAccepter
=== RUN   TestAccTransitGateway_serial/PeeringAttachmentAccepter/tags
=== RUN   TestAccTransitGateway_serial/PeeringAttachmentAccepter/DifferentAccount
    transitgateway_peering_attachment_accepter_test.go:121: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccTransitGateway_serial/PeeringAttachmentAccepter/basic
--- PASS: TestAccTransitGateway_serial (1895.67s)
    --- PASS: TestAccTransitGateway_serial/PeeringAttachment (791.78s)
        --- PASS: TestAccTransitGateway_serial/PeeringAttachment/disappears (230.56s)
        --- PASS: TestAccTransitGateway_serial/PeeringAttachment/tags (319.34s)
        --- SKIP: TestAccTransitGateway_serial/PeeringAttachment/DifferentAccount (0.07s)
        --- PASS: TestAccTransitGateway_serial/PeeringAttachment/basic (241.81s)
    --- PASS: TestAccTransitGateway_serial/PeeringAttachmentAccepter (1103.88s)
        --- PASS: TestAccTransitGateway_serial/PeeringAttachmentAccepter/tags (587.42s)
        --- SKIP: TestAccTransitGateway_serial/PeeringAttachmentAccepter/DifferentAccount (0.00s)
        --- PASS: TestAccTransitGateway_serial/PeeringAttachmentAccepter/basic (516.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1895.760

% make testacc TESTARGS='-run=TestAccTransitGatewayDataSource_serial/PeeringAttachment' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGatewayDataSource_serial/PeeringAttachment -timeout 360m
=== RUN   TestAccTransitGatewayDataSource_serial
=== PAUSE TestAccTransitGatewayDataSource_serial
=== CONT  TestAccTransitGatewayDataSource_serial
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment/FilterSameAccount
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment/FilterDifferentAccount
    transitgateway_peering_attachment_data_source_test.go:59: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment/IDSameAccount
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment/IDDifferentAccount
    transitgateway_peering_attachment_data_source_test.go:123: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment/Tags
--- PASS: TestAccTransitGatewayDataSource_serial (1016.83s)
    --- PASS: TestAccTransitGatewayDataSource_serial/PeeringAttachment (1016.83s)
        --- PASS: TestAccTransitGatewayDataSource_serial/PeeringAttachment/FilterSameAccount (321.82s)
        --- SKIP: TestAccTransitGatewayDataSource_serial/PeeringAttachment/FilterDifferentAccount (0.07s)
        --- PASS: TestAccTransitGatewayDataSource_serial/PeeringAttachment/IDSameAccount (360.79s)
        --- SKIP: TestAccTransitGatewayDataSource_serial/PeeringAttachment/IDDifferentAccount (0.07s)
        --- PASS: TestAccTransitGatewayDataSource_serial/PeeringAttachment/Tags (334.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1016.942s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @partcyborg 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransitGatewayDataSource_serial/^PeeringAttachment$$/FilterSameAccount\|TestAccTransitGateway_serial/^PeeringAttachment$$/basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGatewayDataSource_serial/^PeeringAttachment$/FilterSameAccount\|TestAccTransitGateway_serial/^PeeringAttachment$/basic -timeout 360m
=== RUN   TestAccTransitGatewayDataSource_serial
=== PAUSE TestAccTransitGatewayDataSource_serial
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGatewayDataSource_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment
=== RUN   TestAccTransitGateway_serial/PeeringAttachment
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment/FilterSameAccount
=== RUN   TestAccTransitGateway_serial/PeeringAttachment/basic
--- PASS: TestAccTransitGateway_serial (319.04s)
    --- PASS: TestAccTransitGateway_serial/PeeringAttachment (319.04s)
        --- PASS: TestAccTransitGateway_serial/PeeringAttachment/basic (319.04s)
--- PASS: TestAccTransitGatewayDataSource_serial (324.54s)
    --- PASS: TestAccTransitGatewayDataSource_serial/PeeringAttachment (324.54s)
        --- PASS: TestAccTransitGatewayDataSource_serial/PeeringAttachment/FilterSameAccount (324.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	332.100s

[ewbankkit]

@partcyborg Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.