r/aws_redshift_cluster: skip_final_snapshot updates state only

[jar-b]

Description

Previously an update to skip_final_snapshot would trigger a call to the ModifyCluster API, which fails if no other arguments are modified.

Before:

Terraform will perform the following actions:

# aws_redshift_cluster.example will be updated in-place
~ resource "aws_redshift_cluster" "example" {
      id                                   = "tf-redshift-cluster"
    ~ skip_final_snapshot                  = false -> true
      tags                                 = {}
      # (38 unchanged attributes hidden)

      # (1 unchanged block hidden)
  }

Plan: 0 to add, 1 to change, 0 to destroy.
aws_redshift_cluster.example: Modifying... [id=tf-redshift-cluster] ╷
│ Error: modifying Redshift Cluster (tf-redshift-cluster): InvalidParameterCombination: No modifications were requested
│       status code: 400, request id: 0b087c95-ac6b-4ad6-8eed-ded497fb4a2e
│
│   with aws_redshift_cluster.example,
│   on main.tf line 13, in resource "aws_redshift_cluster" "example":
│   13: resource "aws_redshift_cluster" "example" {
│
╵

After:

Terraform will perform the following actions:

  # aws_redshift_cluster.example will be updated in-place
  ~ resource "aws_redshift_cluster" "example" {
        id                                   = "tf-redshift-cluster"
      ~ skip_final_snapshot                  = false -> true
        tags                                 = {}
        # (38 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
aws_redshift_cluster.example: Modifying... [id=tf-redshift-cluster]
aws_redshift_cluster.example: Modifications complete after 1s [id=tf-redshift-cluster]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

Relations

Relates #30160

References

Output from Acceptance Testing

% make testacc PKG=redshift TESTS=TestAccRedshiftCluster_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftCluster_'  -timeout 360m

--- PASS: TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet (363.56s)
=== CONT  TestAccRedshiftCluster_updateNodeCount
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible (367.74s)
=== CONT  TestAccRedshiftCluster_updateNodeType
--- PASS: TestAccRedshiftCluster_aqua (413.01s)
=== CONT  TestAccRedshiftCluster_iamRoles
--- PASS: TestAccRedshiftCluster_kmsKey (422.21s)
=== CONT  TestAccRedshiftCluster_changeAvailabilityZone
--- PASS: TestAccRedshiftCluster_disappears (423.58s)
=== CONT  TestAccRedshiftCluster_publiclyAccessible
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation (437.10s)
--- PASS: TestAccRedshiftCluster_tags (445.99s)
--- PASS: TestAccRedshiftCluster_basic (449.41s)
--- PASS: TestAccRedshiftCluster_snapshotCopy (454.19s)
--- PASS: TestAccRedshiftCluster_loggingEnabled (478.74s)
--- PASS: TestAccRedshiftCluster_withFinalSnapshot (479.88s)
--- PASS: TestAccRedshiftCluster_manageMasterPassword (531.65s)
--- PASS: TestAccRedshiftCluster_enhancedVPCRoutingEnabled (663.40s)
--- PASS: TestAccRedshiftCluster_forceNewUsername (797.23s)
--- PASS: TestAccRedshiftCluster_iamRoles (406.81s)
--- PASS: TestAccRedshiftCluster_multiAZ (867.56s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation (872.22s)
--- PASS: TestAccRedshiftCluster_publiclyAccessible (452.18s)
--- PASS: TestAccRedshiftCluster_restoreFromSnapshotARN (965.99s)
--- PASS: TestAccRedshiftCluster_restoreFromSnapshot (991.94s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone (769.91s)
--- PASS: TestAccRedshiftCluster_changeEncryption1 (1215.88s)
--- PASS: TestAccRedshiftCluster_changeEncryption2 (1360.85s)
--- PASS: TestAccRedshiftCluster_updateNodeType (1281.25s)
--- PASS: TestAccRedshiftCluster_updateNodeCount (1425.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   1794.511s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.