Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: snowflake destination addition in firehose kinesis stream #36646

Merged
merged 18 commits into from
Apr 22, 2024

Conversation

mayank0202
Copy link
Contributor

@mayank0202 mayank0202 commented Mar 29, 2024

Description

Addition of snowflake destination in firehose kinesis stream

Release notes for Kinesis Firehose direct to Snowflake streaming: https://aws.amazon.com/about-aws/whats-new/2024/01/stream-data-snowflake-kinesis-data-firehose-snowpipe-streaming-preview/

See the --snowflake-destination-configuration flag in the AWS CLI Docs here: https://docs.aws.amazon.com/cli/latest/reference/firehose/create-delivery-stream.html

Closes #35647.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/firehose Issues and PRs that pertain to the firehose service. labels Mar 29, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 29, 2024
@mayank0202
Copy link
Contributor Author

mayank0202 commented Mar 29, 2024

I have contributed first time in go lang and have a minimal knowledge of this language so any modifications or any additions are much appreciated . Thanks!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mayank0202 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 29, 2024
% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_snowflakeUpdates' PKG=firehose
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/firehose/... -v -count 1 -parallel 20  -run=TestAccFirehoseDeliveryStream_snowflakeUpdates -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_snowflakeUpdates
=== PAUSE TestAccFirehoseDeliveryStream_snowflakeUpdates
=== CONT  TestAccFirehoseDeliveryStream_snowflakeUpdates
--- PASS: TestAccFirehoseDeliveryStream_snowflakeUpdates (102.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	114.313s
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_snowflakeUpdates' PKG=firehose
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/firehose/... -v -count 1 -parallel 20  -run=TestAccFirehoseDeliveryStream_snowflakeUpdates -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_snowflakeUpdates
=== PAUSE TestAccFirehoseDeliveryStream_snowflakeUpdates
=== CONT  TestAccFirehoseDeliveryStream_snowflakeUpdates
--- PASS: TestAccFirehoseDeliveryStream_snowflakeUpdates (102.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	114.313s
% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_basic' PKG=firehose
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/firehose/... -v -count 1 -parallel 20  -run=TestAccFirehoseDeliveryStream_basic -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_basic
=== PAUSE TestAccFirehoseDeliveryStream_basic
=== CONT  TestAccFirehoseDeliveryStream_basic
--- PASS: TestAccFirehoseDeliveryStream_basic (80.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	92.235s

@ewbankkit
Copy link
Contributor

@mayank0202 Thanks for the contribution 🎉 👏.

@mayank0202
Copy link
Contributor Author

@mayank0202 Thanks for the contribution 🎉 👏.

Thanks for the help @ewbankkit 💯

@ewbankkit ewbankkit merged commit 98d7955 into hashicorp:main Apr 22, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.47.0 milestone Apr 22, 2024
@mayank0202 mayank0202 deleted the enhancement-snowflake-destination branch April 25, 2024 22:24
Copy link

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support for new direct to Snowflake streaming for aws_kinesis_firehose_delivery_stream
2 participants