-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_amplify_domain_association: add certificate_settings
attribute
#37105
r/aws_amplify_domain_association: add certificate_settings
attribute
#37105
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTS=TestAccAmplify_serial/DomainAssociation PKG=amplify
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/amplify/... -v -count 1 -parallel 20 -run='TestAccAmplify_serial/DomainAssociation' -timeout 360m
=== RUN TestAccAmplify_serial
=== PAUSE TestAccAmplify_serial
=== CONT TestAccAmplify_serial
=== RUN TestAccAmplify_serial/DomainAssociation
=== RUN TestAccAmplify_serial/DomainAssociation/basic
domain_association_test.go:29: Environment variable AMPLIFY_DOMAIN_NAME is not set
=== RUN TestAccAmplify_serial/DomainAssociation/certificateSettings
domain_association_test.go:164: Environment variable AMPLIFY_DOMAIN_NAME is not set
=== RUN TestAccAmplify_serial/DomainAssociation/disappears
domain_association_test.go:72: Environment variable AMPLIFY_DOMAIN_NAME is not set
=== RUN TestAccAmplify_serial/DomainAssociation/update
domain_association_test.go:102: Environment variable AMPLIFY_DOMAIN_NAME is not set
--- PASS: TestAccAmplify_serial (0.00s)
--- PASS: TestAccAmplify_serial/DomainAssociation (0.00s)
--- SKIP: TestAccAmplify_serial/DomainAssociation/basic (0.00s)
--- SKIP: TestAccAmplify_serial/DomainAssociation/certificateSettings (0.00s)
--- SKIP: TestAccAmplify_serial/DomainAssociation/disappears (0.00s)
--- SKIP: TestAccAmplify_serial/DomainAssociation/update (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/amplify 5.464s
certificate_settings
attribute
@nikhil-goenka thank you for the contribution! 🎉 |
This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #37070
References
Output from Acceptance Testing