-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add skip_resource_in_use_check arg to aws_bedrockagent_agent #37586
feat: Add skip_resource_in_use_check arg to aws_bedrockagent_agent #37586
Conversation
Community NoteVoting for Prioritization
For Submitters
|
e303973
to
76b9bff
Compare
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccBedrockAgentAgent_' PKG=bedrockagent ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/bedrockagent/... -v -count 1 -parallel 3 -run=TestAccBedrockAgentAgent_ -timeout 360m
=== RUN TestAccBedrockAgentAgent_basic
=== PAUSE TestAccBedrockAgentAgent_basic
=== RUN TestAccBedrockAgentAgent_full
=== PAUSE TestAccBedrockAgentAgent_full
=== RUN TestAccBedrockAgentAgent_update
=== PAUSE TestAccBedrockAgentAgent_update
=== RUN TestAccBedrockAgentAgent_tags
=== PAUSE TestAccBedrockAgentAgent_tags
=== CONT TestAccBedrockAgentAgent_basic
=== CONT TestAccBedrockAgentAgent_full
=== CONT TestAccBedrockAgentAgent_update
--- PASS: TestAccBedrockAgentAgent_basic (19.97s)
=== CONT TestAccBedrockAgentAgent_tags
--- PASS: TestAccBedrockAgentAgent_full (23.08s)
--- PASS: TestAccBedrockAgentAgent_update (39.86s)
--- PASS: TestAccBedrockAgentAgent_tags (34.07s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent 59.021s
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the
skip_resource_in_use_check
argument to theaws_bedrockagent_agent
resource, so that there is an option to get past the validation error if the agent still has aliases before its deletion. Note that the this is not a standard parameter in theAgent
API object, but it is an attribute to pass along to theDeleteAgent
API.Relations
Closes #37161
References
Referred to DeleteAgent for spec and
aws_bedrockagent_agent_action_group
resource doc for wordings (the AWS API ref description is too verbose).Output from Acceptance Testing