Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lambda_runtime_management_config: new resource #37643

Merged
merged 1 commit into from
May 23, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented May 22, 2024

Description

This resource will allow practitioners to manage AWS Lambda runtime management configurations via Terraform.

Relations

Closes #29210
Closes #32138

References

Output from Acceptance Testing

% make testacc PKG=lambda TESTS="TestAccLambdaRuntimeManagementConfig_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaRuntimeManagementConfig_'  -timeout 360m

--- PASS: TestAccLambdaRuntimeManagementConfig_disappears_Function (37.05s)
--- PASS: TestAccLambdaRuntimeManagementConfig_basic (38.77s)
--- PASS: TestAccLambdaRuntimeManagementConfig_runtimeVersionARN (40.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     45.265s

@jar-b jar-b marked this pull request as draft May 22, 2024 20:34
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. generators Relates to code generators. labels May 22, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 22, 2024
This resource will allow practitioners to manage AWS Lambda runtime management configurations via Terraform.

```console
% make testacc PKG=lambda TESTS="TestAccLambdaRuntimeManagementConfig_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaRuntimeManagementConfig_'  -timeout 360m

--- PASS: TestAccLambdaRuntimeManagementConfig_disappears_Function (37.05s)
--- PASS: TestAccLambdaRuntimeManagementConfig_basic (38.77s)
--- PASS: TestAccLambdaRuntimeManagementConfig_runtimeVersionARN (40.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     45.265s
```
@jar-b jar-b force-pushed the f-lambda_runtime_management_config branch from 33104e6 to 69b4d62 Compare May 22, 2024 20:42
@jar-b jar-b marked this pull request as ready for review May 22, 2024 21:50
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

make testacc TESTARGS="-run=TestAccLambdaRuntimeManagementConfig_" PKG=lambda

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaRuntimeManagementConfig_ -timeout 360m
--- PASS: TestAccLambdaRuntimeManagementConfig_runtimeVersionARN (35.67s)
--- PASS: TestAccLambdaRuntimeManagementConfig_basic (37.82s)
--- PASS: TestAccLambdaRuntimeManagementConfig_disappears_Function (39.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	44.778s

@jar-b jar-b merged commit 7e01d26 into main May 23, 2024
53 checks passed
@jar-b jar-b deleted the f-lambda_runtime_management_config branch May 23, 2024 15:28
@github-actions github-actions bot added this to the v5.51.0 milestone May 23, 2024
github-actions bot pushed a commit that referenced this pull request May 23, 2024
Copy link

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 24, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/lambda Issues and PRs that pertain to the lambda service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: lambda runtime management controls
2 participants