Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_sagemaker_endpoint_configuration: supports inputandoutput #37726

Merged

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented May 27, 2024

Description

Relations

Closes #37330

References

Output from Acceptance Testing

% make testacc TESTS=TestAccSageMakerEndpointConfiguration_dataCapture PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerEndpointConfiguration_dataCapture'  -timeout 360m
=== RUN   TestAccSageMakerEndpointConfiguration_dataCapture
=== PAUSE TestAccSageMakerEndpointConfiguration_dataCapture
=== RUN   TestAccSageMakerEndpointConfiguration_dataCapture_inputAndOutput
=== PAUSE TestAccSageMakerEndpointConfiguration_dataCapture_inputAndOutput
=== CONT  TestAccSageMakerEndpointConfiguration_dataCapture
=== CONT  TestAccSageMakerEndpointConfiguration_dataCapture_inputAndOutput
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture (61.03s)
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture_inputAndOutput (63.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	89.533s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels May 27, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 27, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label May 27, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 28, 2024
@DrFaust92
Copy link
Collaborator

nikhil-goenka missing changelog. otherwise LGTM

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner June 21, 2024 20:17
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewbankkit ewbankkit self-assigned this Jun 28, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 28, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerEndpointConfiguration_dataCapture' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMakerEndpointConfiguration_dataCapture -timeout 360m
=== RUN   TestAccSageMakerEndpointConfiguration_dataCapture
=== PAUSE TestAccSageMakerEndpointConfiguration_dataCapture
=== RUN   TestAccSageMakerEndpointConfiguration_dataCapture_inputAndOutput
=== PAUSE TestAccSageMakerEndpointConfiguration_dataCapture_inputAndOutput
=== CONT  TestAccSageMakerEndpointConfiguration_dataCapture
=== CONT  TestAccSageMakerEndpointConfiguration_dataCapture_inputAndOutput
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture_inputAndOutput (21.87s)
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture (24.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	29.256s

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 361584a into hashicorp:main Jun 28, 2024
63 checks passed
@github-actions github-actions bot added this to the v5.57.0 milestone Jun 28, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@nikhil-goenka nikhil-goenka deleted the t/aws_sagemaker_endpoint_configuration branch July 16, 2024 16:59
@tyegagne
Copy link

tyegagne commented Jul 23, 2024

For awareness, we are attempting to implement this endpoint configuration:

  data_capture_config {
    initial_sampling_percentage = 100
    destination_s3_uri          = "s3://xx/xx/inferences/"
    capture_options {
      capture_mode = "InputAndOutput"
    }
    enable_capture = true
  }

We have successful builds for both capture_mode = 'Input' OR capture_mode = 'Output' however our build attempts with 'InputAndOutput' are generating this error:

Error: creating SageMaker Endpoint: ValidationException: Cannot create endpoint using DeploymentConfig due to unsupported features in the requested endpoint configuration. Please refer documentation for a list of exclusions.

status code: 400, request id: xx

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: SageMaker Endpoints: add InputAndOutput capture options mode
5 participants