Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codebuild: support unsetting project concurrency #37748

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

bendrucker
Copy link
Contributor

Description

Allows aws_codebuild_projects to remove concurrent_build_limit and have the concurrency value properly unset in the API.

References

https://docs.aws.amazon.com/codebuild/latest/APIReference/API_UpdateProject.html#CodeBuild-UpdateProject-request-concurrentBuildLimit

The maximum number of concurrent builds that are allowed for this project.
To remove this limit, set this value to -1.

Output from Acceptance Testing

I'm not able to run these tests currently:

Error: creating CodeBuild Project (tf-acc-test-8200118214281412065): operation error CodeBuild: CreateProject, https response error StatusCode: 400, RequestID: c3137ef4-7fd0-4bc1-9c93-5390d05080aa, InvalidInputException: Project-level concurrent build limit cannot exceed the account-level concurrent build limit of 1.

When I get approved for an increase from AWS support I'll update this with output.

% make testacc PKG=codebuild TESTS=TestAccCodeBuildProject_concurrentBuildLimit

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codebuild Issues and PRs that pertain to the codebuild service. labels May 28, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 28, 2024
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 29, 2024
@ewbankkit ewbankkit requested a review from a team as a code owner July 15, 2024 14:30
@ewbankkit ewbankkit self-assigned this Jul 15, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCodeBuildProject_concurrentBuildLimit' PKG=codebuild
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/codebuild/... -v -count 1 -parallel 20  -run=TestAccCodeBuildProject_concurrentBuildLimit -timeout 360m
=== RUN   TestAccCodeBuildProject_concurrentBuildLimit
=== PAUSE TestAccCodeBuildProject_concurrentBuildLimit
=== CONT  TestAccCodeBuildProject_concurrentBuildLimit
--- PASS: TestAccCodeBuildProject_concurrentBuildLimit (36.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	41.330s

@ewbankkit
Copy link
Contributor

@bendrucker Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed enhancement Requests to existing resources that expand the functionality or scope. labels Jul 15, 2024
@ewbankkit ewbankkit merged commit 9d4f75c into hashicorp:main Jul 15, 2024
39 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 15, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/codebuild Issues and PRs that pertain to the codebuild service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants