-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for "EncryptionConfiguration" in StateMachine and Activity Resources #38574
Added support for "EncryptionConfiguration" in StateMachine and Activity Resources #38574
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSFNActivity_\|TestAccSFNStateMachine_' PKG=sfn ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/sfn/... -v -count 1 -parallel 3 -run=TestAccSFNActivity_\|TestAccSFNStateMachine_ -timeout 360m
=== RUN TestAccSFNActivity_basic
=== PAUSE TestAccSFNActivity_basic
=== RUN TestAccSFNActivity_disappears
=== PAUSE TestAccSFNActivity_disappears
=== RUN TestAccSFNActivity_tags
=== PAUSE TestAccSFNActivity_tags
=== RUN TestAccSFNActivity_encryptionConfigurationCustomerManagedKMSKey
--- PASS: TestAccSFNActivity_encryptionConfigurationCustomerManagedKMSKey (70.14s)
=== RUN TestAccSFNActivity_encryptionConfigurationServiceOwnedKey
--- PASS: TestAccSFNActivity_encryptionConfigurationServiceOwnedKey (67.71s)
=== RUN TestAccSFNStateMachine_createUpdate
=== PAUSE TestAccSFNStateMachine_createUpdate
=== RUN TestAccSFNStateMachine_expressUpdate
=== PAUSE TestAccSFNStateMachine_expressUpdate
=== RUN TestAccSFNStateMachine_standardUpdate
=== PAUSE TestAccSFNStateMachine_standardUpdate
=== RUN TestAccSFNStateMachine_nameGenerated
=== PAUSE TestAccSFNStateMachine_nameGenerated
=== RUN TestAccSFNStateMachine_namePrefix
=== PAUSE TestAccSFNStateMachine_namePrefix
=== RUN TestAccSFNStateMachine_publish
=== PAUSE TestAccSFNStateMachine_publish
=== RUN TestAccSFNStateMachine_tags
=== PAUSE TestAccSFNStateMachine_tags
=== RUN TestAccSFNStateMachine_tracing
=== PAUSE TestAccSFNStateMachine_tracing
=== RUN TestAccSFNStateMachine_disappears
=== PAUSE TestAccSFNStateMachine_disappears
=== RUN TestAccSFNStateMachine_expressLogging
=== PAUSE TestAccSFNStateMachine_expressLogging
=== RUN TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey
--- PASS: TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey (57.20s)
=== RUN TestAccSFNStateMachine_encryptionConfigurationServiceOwnedKey
--- PASS: TestAccSFNStateMachine_encryptionConfigurationServiceOwnedKey (80.92s)
=== CONT TestAccSFNActivity_basic
=== CONT TestAccSFNStateMachine_namePrefix
=== CONT TestAccSFNStateMachine_expressUpdate
--- PASS: TestAccSFNStateMachine_namePrefix (61.28s)
=== CONT TestAccSFNStateMachine_tracing
--- PASS: TestAccSFNActivity_basic (68.04s)
=== CONT TestAccSFNStateMachine_expressLogging
--- PASS: TestAccSFNStateMachine_expressUpdate (84.47s)
=== CONT TestAccSFNStateMachine_disappears
--- PASS: TestAccSFNStateMachine_tracing (61.16s)
=== CONT TestAccSFNActivity_tags
--- PASS: TestAccSFNStateMachine_disappears (48.76s)
=== CONT TestAccSFNStateMachine_createUpdate
--- PASS: TestAccSFNStateMachine_expressLogging (67.85s)
=== CONT TestAccSFNStateMachine_nameGenerated
--- PASS: TestAccSFNActivity_tags (51.08s)
=== CONT TestAccSFNStateMachine_standardUpdate
--- PASS: TestAccSFNStateMachine_createUpdate (60.94s)
=== CONT TestAccSFNActivity_disappears
--- PASS: TestAccSFNStateMachine_nameGenerated (64.59s)
=== CONT TestAccSFNStateMachine_tags
--- PASS: TestAccSFNActivity_disappears (9.21s)
=== CONT TestAccSFNStateMachine_publish
--- PASS: TestAccSFNStateMachine_tags (59.14s)
--- PASS: TestAccSFNStateMachine_publish (64.47s)
--- PASS: TestAccSFNStateMachine_standardUpdate (99.33s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sfn 553.765s
@madhavvishnubhatta Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
…ity resources.
Description
Relations
Closes #38556
References
https://aws.amazon.com/about-aws/whats-new/2024/07/aws-step-functions-customer-managed-keys/
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/sfn#Client.CreateStateMachine
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/sfn#Client.CreateActivity
Output from Acceptance Testing