Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for "EncryptionConfiguration" in StateMachine and Activity Resources #38574

Merged
merged 8 commits into from
Jul 29, 2024

Conversation

madhavvishnubhatta
Copy link
Contributor

@madhavvishnubhatta madhavvishnubhatta commented Jul 28, 2024

…ity resources.

Description

Relations

Closes #38556

References

https://aws.amazon.com/about-aws/whats-new/2024/07/aws-step-functions-customer-managed-keys/
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/sfn#Client.CreateStateMachine
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/sfn#Client.CreateActivity

Output from Acceptance Testing

bash-3.2$ make testacc TESTS=TestAccSFNActivity_* PKG=sfn
make testacc TESTS=TestAccSFNStateMachine_* PKG=sfn
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/sfn/... -v -count 1 -parallel 20 -run='TestAccSFNActivity_*'  -timeout 360m
=== RUN   TestAccSFNActivityDataSource_basic
=== PAUSE TestAccSFNActivityDataSource_basic
=== RUN   TestAccSFNActivity_basic
=== PAUSE TestAccSFNActivity_basic
=== RUN   TestAccSFNActivity_disappears
=== PAUSE TestAccSFNActivity_disappears
=== RUN   TestAccSFNActivity_tags
=== PAUSE TestAccSFNActivity_tags
=== RUN   TestAccSFNActivity_encryptionConfigurationCustomerManagedKMSKey
--- PASS: TestAccSFNActivity_encryptionConfigurationCustomerManagedKMSKey (67.63s)
=== RUN   TestAccSFNActivity_encryptionConfigurationServiceOwnedKey
--- PASS: TestAccSFNActivity_encryptionConfigurationServiceOwnedKey (73.53s)
=== CONT  TestAccSFNActivity_disappears
=== CONT  TestAccSFNActivity_basic
=== CONT  TestAccSFNActivityDataSource_basic
=== CONT  TestAccSFNActivity_tags
--- PASS: TestAccSFNActivityDataSource_basic (16.54s)
--- PASS: TestAccSFNActivity_disappears (16.65s)
--- PASS: TestAccSFNActivity_basic (19.55s)
--- PASS: TestAccSFNActivity_tags (75.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sfn        221.990s
bash-3.2$ make testacc TESTS=TestAccSFNStateMachine_* PKG=sfn
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/sfn/... -v -count 1 -parallel 20 -run='TestAccSFNStateMachine_*'  -timeout 360m
=== RUN   TestAccSFNStateMachineDataSource_basic
=== PAUSE TestAccSFNStateMachineDataSource_basic
=== RUN   TestAccSFNStateMachine_createUpdate
=== PAUSE TestAccSFNStateMachine_createUpdate
=== RUN   TestAccSFNStateMachine_expressUpdate
=== PAUSE TestAccSFNStateMachine_expressUpdate
=== RUN   TestAccSFNStateMachine_standardUpdate
=== PAUSE TestAccSFNStateMachine_standardUpdate
=== RUN   TestAccSFNStateMachine_nameGenerated
=== PAUSE TestAccSFNStateMachine_nameGenerated
=== RUN   TestAccSFNStateMachine_namePrefix
=== PAUSE TestAccSFNStateMachine_namePrefix
=== RUN   TestAccSFNStateMachine_publish
=== PAUSE TestAccSFNStateMachine_publish
=== RUN   TestAccSFNStateMachine_tags
=== PAUSE TestAccSFNStateMachine_tags
=== RUN   TestAccSFNStateMachine_tracing
=== PAUSE TestAccSFNStateMachine_tracing
=== RUN   TestAccSFNStateMachine_disappears
=== PAUSE TestAccSFNStateMachine_disappears
=== RUN   TestAccSFNStateMachine_expressLogging
=== PAUSE TestAccSFNStateMachine_expressLogging
=== RUN   TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey
--- PASS: TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey (111.67s)
=== RUN   TestAccSFNStateMachine_encryptionConfigurationServiceOwnedKey
--- PASS: TestAccSFNStateMachine_encryptionConfigurationServiceOwnedKey (64.50s)
=== RUN   TestAccSFNStateMachineVersionsDataSource_basic
=== PAUSE TestAccSFNStateMachineVersionsDataSource_basic
=== CONT  TestAccSFNStateMachineDataSource_basic
=== CONT  TestAccSFNStateMachine_publish
=== CONT  TestAccSFNStateMachine_disappears
=== CONT  TestAccSFNStateMachine_tracing
=== CONT  TestAccSFNStateMachineVersionsDataSource_basic
=== CONT  TestAccSFNStateMachine_standardUpdate
=== CONT  TestAccSFNStateMachine_expressUpdate
=== CONT  TestAccSFNStateMachine_tags
=== CONT  TestAccSFNStateMachine_createUpdate
=== CONT  TestAccSFNStateMachine_expressLogging
=== CONT  TestAccSFNStateMachine_namePrefix
=== CONT  TestAccSFNStateMachine_nameGenerated
--- PASS: TestAccSFNStateMachineVersionsDataSource_basic (62.52s)
--- PASS: TestAccSFNStateMachine_nameGenerated (96.23s)
--- PASS: TestAccSFNStateMachine_publish (102.61s)
--- PASS: TestAccSFNStateMachine_expressLogging (131.65s)
--- PASS: TestAccSFNStateMachine_tags (132.56s)
--- PASS: TestAccSFNStateMachine_tracing (132.78s)
--- PASS: TestAccSFNStateMachine_standardUpdate (136.74s)
--- PASS: TestAccSFNStateMachine_namePrefix (146.30s)
--- PASS: TestAccSFNStateMachine_createUpdate (146.91s)
--- PASS: TestAccSFNStateMachineDataSource_basic (147.72s)
--- PASS: TestAccSFNStateMachine_disappears (148.95s)
--- PASS: TestAccSFNStateMachine_expressUpdate (159.52s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sfn        340.684s

@madhavvishnubhatta madhavvishnubhatta requested a review from a team as a code owner July 28, 2024 08:21
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sfn Issues and PRs that pertain to the sfn service. size/XL Managed by automation to categorize the size of a PR. labels Jul 28, 2024
@ewbankkit ewbankkit self-assigned this Jul 29, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSFNActivity_\|TestAccSFNStateMachine_' PKG=sfn ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/sfn/... -v -count 1 -parallel 3  -run=TestAccSFNActivity_\|TestAccSFNStateMachine_ -timeout 360m
=== RUN   TestAccSFNActivity_basic
=== PAUSE TestAccSFNActivity_basic
=== RUN   TestAccSFNActivity_disappears
=== PAUSE TestAccSFNActivity_disappears
=== RUN   TestAccSFNActivity_tags
=== PAUSE TestAccSFNActivity_tags
=== RUN   TestAccSFNActivity_encryptionConfigurationCustomerManagedKMSKey
--- PASS: TestAccSFNActivity_encryptionConfigurationCustomerManagedKMSKey (70.14s)
=== RUN   TestAccSFNActivity_encryptionConfigurationServiceOwnedKey
--- PASS: TestAccSFNActivity_encryptionConfigurationServiceOwnedKey (67.71s)
=== RUN   TestAccSFNStateMachine_createUpdate
=== PAUSE TestAccSFNStateMachine_createUpdate
=== RUN   TestAccSFNStateMachine_expressUpdate
=== PAUSE TestAccSFNStateMachine_expressUpdate
=== RUN   TestAccSFNStateMachine_standardUpdate
=== PAUSE TestAccSFNStateMachine_standardUpdate
=== RUN   TestAccSFNStateMachine_nameGenerated
=== PAUSE TestAccSFNStateMachine_nameGenerated
=== RUN   TestAccSFNStateMachine_namePrefix
=== PAUSE TestAccSFNStateMachine_namePrefix
=== RUN   TestAccSFNStateMachine_publish
=== PAUSE TestAccSFNStateMachine_publish
=== RUN   TestAccSFNStateMachine_tags
=== PAUSE TestAccSFNStateMachine_tags
=== RUN   TestAccSFNStateMachine_tracing
=== PAUSE TestAccSFNStateMachine_tracing
=== RUN   TestAccSFNStateMachine_disappears
=== PAUSE TestAccSFNStateMachine_disappears
=== RUN   TestAccSFNStateMachine_expressLogging
=== PAUSE TestAccSFNStateMachine_expressLogging
=== RUN   TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey
--- PASS: TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey (57.20s)
=== RUN   TestAccSFNStateMachine_encryptionConfigurationServiceOwnedKey
--- PASS: TestAccSFNStateMachine_encryptionConfigurationServiceOwnedKey (80.92s)
=== CONT  TestAccSFNActivity_basic
=== CONT  TestAccSFNStateMachine_namePrefix
=== CONT  TestAccSFNStateMachine_expressUpdate
--- PASS: TestAccSFNStateMachine_namePrefix (61.28s)
=== CONT  TestAccSFNStateMachine_tracing
--- PASS: TestAccSFNActivity_basic (68.04s)
=== CONT  TestAccSFNStateMachine_expressLogging
--- PASS: TestAccSFNStateMachine_expressUpdate (84.47s)
=== CONT  TestAccSFNStateMachine_disappears
--- PASS: TestAccSFNStateMachine_tracing (61.16s)
=== CONT  TestAccSFNActivity_tags
--- PASS: TestAccSFNStateMachine_disappears (48.76s)
=== CONT  TestAccSFNStateMachine_createUpdate
--- PASS: TestAccSFNStateMachine_expressLogging (67.85s)
=== CONT  TestAccSFNStateMachine_nameGenerated
--- PASS: TestAccSFNActivity_tags (51.08s)
=== CONT  TestAccSFNStateMachine_standardUpdate
--- PASS: TestAccSFNStateMachine_createUpdate (60.94s)
=== CONT  TestAccSFNActivity_disappears
--- PASS: TestAccSFNStateMachine_nameGenerated (64.59s)
=== CONT  TestAccSFNStateMachine_tags
--- PASS: TestAccSFNActivity_disappears (9.21s)
=== CONT  TestAccSFNStateMachine_publish
--- PASS: TestAccSFNStateMachine_tags (59.14s)
--- PASS: TestAccSFNStateMachine_publish (64.47s)
--- PASS: TestAccSFNStateMachine_standardUpdate (99.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sfn	553.765s

@ewbankkit
Copy link
Contributor

@madhavvishnubhatta Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit cbd253d into hashicorp:main Jul 29, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.61.0 milestone Jul 29, 2024
@justinretzolk justinretzolk added the partner Contribution from a partner. label Jul 30, 2024
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/sfn Issues and PRs that pertain to the sfn service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add Customer Managed KMS key support for Step Funtions
3 participants