Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core CoreNetworkPolicyException when a policy has a single wildcard in when_sent_to #38595

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Jul 30, 2024

Description

Customise marshalling for single wildcards to match services expectation.

Relations

Closes #38145

References

Output from Acceptance Testing

make testacc TESTS=TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource PKG=networkmanager
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource'  -timeout 360m
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (9.58s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo (9.58s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion (9.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     14.322s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/networkmanager Issues and PRs that pertain to the networkmanager service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jul 30, 2024
@drewtul drewtul force-pushed the bug-network-function-groups-wildcard branch from d1a8592 to 0a21345 Compare July 30, 2024 12:25
@drewtul drewtul changed the title Fix #38145 Core CoreNetworkPolicyException when a policy has a single wildcard in when_sent_to Jul 30, 2024
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Jul 30, 2024
@drewtul drewtul marked this pull request as ready for review July 30, 2024 13:24
@drewtul drewtul requested a review from a team as a code owner July 30, 2024 13:24
@jar-b jar-b self-assigned this Jul 30, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 30, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=networkmanager TESTS=TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_'  -timeout 360m
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion (8.31s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo (8.31s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (8.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     14.325s

@jar-b
Copy link
Member

jar-b commented Jul 30, 2024

Thanks for your contribution, @drewtul! 👍

@jar-b jar-b merged commit 024ca45 into hashicorp:main Jul 30, 2024
52 checks passed
@github-actions github-actions bot added this to the v5.61.0 milestone Jul 30, 2024
@drewtul drewtul deleted the bug-network-function-groups-wildcard branch July 31, 2024 10:38
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partner Contribution from a partner. service/networkmanager Issues and PRs that pertain to the networkmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: network-function-groups wildcard fails in data source aws_networkmanager_core_network_policy_document
2 participants