-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_ecs_service: add tag_specification support #38662
aws_ecs_service: add tag_specification support #38662
Conversation
Community NoteVoting for Prioritization
For Submitters
|
F_ACC=1 go1.22.5 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_VolumeConfiguration_TagSpecifications' -timeout 360m
go: downloading github.com/aws/aws-sdk-go-v2/service/datazone v1.16.0
go: downloading github.com/aws/aws-sdk-go-v2/service/ecr v1.31.0
go: downloading github.com/aws/aws-sdk-go-v2/service/resiliencehub v1.23.3
go: downloading github.com/aws/aws-sdk-go-v2/service/workspaces v1.44.3
go: downloading github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.17.9
=== RUN TestAccECSService_VolumeConfiguration_TagSpecifications
=== PAUSE TestAccECSService_VolumeConfiguration_TagSpecifications
=== CONT TestAccECSService_VolumeConfiguration_TagSpecifications
--- PASS: TestAccECSService_VolumeConfiguration_TagSpecifications (68.77s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 74.724s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccECSService_VolumeConfiguration_\|TestAccECSService_basic\|TestAccECSService_disappears' PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run=TestAccECSService_VolumeConfiguration_\|TestAccECSService_basic\|TestAccECSService_disappears -timeout 360m
--- PASS: TestAccECSService_basic (71.83s)
--- PASS: TestAccECSService_VolumeConfiguration_basic (73.43s)
--- PASS: TestAccECSService_VolumeConfiguration_tagSpecifications (73.55s)
--- PASS: TestAccECSService_VolumeConfiguration_throughputTypeChange (81.99s)
--- PASS: TestAccECSService_VolumeConfiguration_update (114.32s)
--- PASS: TestAccECSService_basicImport (187.66s)
--- PASS: TestAccECSService_disappears (191.82s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 198.078s
@trutled3 thank you for the contribution! 🎉 |
This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This adds the tag specifications capability from the CreateService API for AWS ECS. I am unable to perform the acceptance testing, if someone could please run it for me. I have provided the command below.
Relations
Closes #38486
References
Output from Acceptance Testing
% make testacc TESTS=TestAccECSService_VolumeConfiguration_TagSpecifications PKG=ecs