Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ecs_service: add tag_specification support #38662

Merged

Conversation

trutled3
Copy link
Contributor

@trutled3 trutled3 commented Aug 2, 2024

Description

This adds the tag specifications capability from the CreateService API for AWS ECS. I am unable to perform the acceptance testing, if someone could please run it for me. I have provided the command below.

Relations

Closes #38486

References

Output from Acceptance Testing

% make testacc TESTS=TestAccECSService_VolumeConfiguration_TagSpecifications PKG=ecs

@trutled3 trutled3 requested a review from a team as a code owner August 2, 2024 16:20
Copy link

github-actions bot commented Aug 2, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. needs-triage Waiting for first response or review from a maintainer. labels Aug 2, 2024
@trutled3 trutled3 changed the title F aws ecs service tag specifications aws_ecs_service: add tag_specification support Aug 2, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 6, 2024
@breathingdust
Copy link
Member

F_ACC=1 go1.22.5 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_VolumeConfiguration_TagSpecifications'  -timeout 360m
go: downloading github.com/aws/aws-sdk-go-v2/service/datazone v1.16.0
go: downloading github.com/aws/aws-sdk-go-v2/service/ecr v1.31.0
go: downloading github.com/aws/aws-sdk-go-v2/service/resiliencehub v1.23.3
go: downloading github.com/aws/aws-sdk-go-v2/service/workspaces v1.44.3
go: downloading github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.17.9
=== RUN   TestAccECSService_VolumeConfiguration_TagSpecifications
=== PAUSE TestAccECSService_VolumeConfiguration_TagSpecifications
=== CONT  TestAccECSService_VolumeConfiguration_TagSpecifications
--- PASS: TestAccECSService_VolumeConfiguration_TagSpecifications (68.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	74.724s

Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccECSService_VolumeConfiguration_\|TestAccECSService_basic\|TestAccECSService_disappears' PKG=ecs

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSService_VolumeConfiguration_\|TestAccECSService_basic\|TestAccECSService_disappears -timeout 360m
--- PASS: TestAccECSService_basic (71.83s)
--- PASS: TestAccECSService_VolumeConfiguration_basic (73.43s)
--- PASS: TestAccECSService_VolumeConfiguration_tagSpecifications (73.55s)
--- PASS: TestAccECSService_VolumeConfiguration_throughputTypeChange (81.99s)
--- PASS: TestAccECSService_VolumeConfiguration_update (114.32s)
--- PASS: TestAccECSService_basicImport (187.66s)
--- PASS: TestAccECSService_disappears (191.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	198.078s

@johnsonaj
Copy link
Contributor

johnsonaj commented Sep 20, 2024

@trutled3 thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 5fdaef6 into hashicorp:main Sep 20, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.69.0 milestone Sep 20, 2024
Copy link

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@trutled3 trutled3 deleted the f-aws_ecs_service_tag_specifications branch September 27, 2024 19:20
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: add ecs_service support for tag_specifications in volume_configuration with managed_ebs_volume
5 participants