Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: check_certificate_revocation_status ignored on aws_networkfirewall_tls_inspection_configuration #38690

Closed
t0yv0 opened this issue Aug 5, 2024 · 4 comments · Fixed by #39211
Labels
bug Addresses a defect in current functionality. service/networkfirewall Issues and PRs that pertain to the networkfirewall service.
Milestone

Comments

@t0yv0
Copy link
Contributor

t0yv0 commented Aug 5, 2024

Terraform Core Version

1.6.3

AWS Provider Version

5.61.0

Affected Resource(s)

  • aws_networkfirewall_tls_inspection_configuration

Expected Behavior

Expected Certificate revocation status to be Enabled after terraform apply, or receive an error indicating what to fix in the HCL configuration.

Actual Behavior

Expected Certificate revocation status is Disabled, terraform apply succeeds.

Relevant Error/Panic Output Snippet

N/A

Terraform Configuration Files

resource "tls_private_key" "pca-key" {
  algorithm = "RSA"
}

resource "tls_self_signed_cert" "self-signed-cert-resource" {
  private_key_pem = tls_private_key.pca-key.private_key_pem

  subject {
    common_name  = "test"
    country      = "us"
    organization = "testing"
  }

  dns_names = [
    "firewall.test.com"
  ]

  is_ca_certificate = true
  set_subject_key_id = true
  set_authority_key_id = true

  validity_period_hours = 9000

  allowed_uses = [
    "cert_signing",
    "crl_signing",
    "digital_signature",
  ]
}

resource aws_acm_certificate "acm-cert" {
  private_key       = tls_private_key.pca-key.private_key_pem
  certificate_body  = tls_self_signed_cert.self-signed-cert-resource.cert_pem
  certificate_chain = tls_self_signed_cert.self-signed-cert-resource.cert_pem
}

resource "aws_networkfirewall_tls_inspection_configuration" "example" {
  name        = "tls-inspection-test"
  tls_inspection_configuration {
    server_certificate_configuration {
      certificate_authority_arn = aws_acm_certificate.acm-cert.arn
      check_certificate_revocation_status {
        revoked_status_action = "REJECT"
        unknown_status_action = "REJECT"
      }
      scope {
        protocols = [6]
        destination_ports {
          from_port = 443
          to_port   = 443
        }
        destination {
          address_definition = "0.0.0.0/0"
        }
        source_ports {
          from_port = 0
          to_port   = 65535
        }
        source {
          address_definition = "0.0.0.0/0"
        }
      }
    }
  }
}

Steps to Reproduce

Debug Output

N/A

Panic Output

N/A

Important Factoids

N/A

References

N/A

Would you like to implement a fix?

No

@t0yv0 t0yv0 added the bug Addresses a defect in current functionality. label Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/acm Issues and PRs that pertain to the acm service. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. labels Aug 5, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 5, 2024
@justinretzolk justinretzolk removed service/acm Issues and PRs that pertain to the acm service. needs-triage Waiting for first response or review from a maintainer. labels Aug 14, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.67.0 milestone Sep 11, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/networkfirewall Issues and PRs that pertain to the networkfirewall service.
Projects
None yet
2 participants