r/aws_networkmanager_connect_peer: return all BGP configurations

[jtdoepke]

Description

When you create a connect peer in AWS Network Manager, AWS sets up two BGP endpoints. However, the code for the aws_networkmanager_connect_peer resource only returns the first entry in the list. This commit updates the resource to loop over all BGP configurations returned by the API.

Relations

Closes #29680

References

Output from Acceptance Testing

% make testacc TESTS='TestAccNetworkManagerConnectPeer_.*' PKG=networkmanager
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerConnectPeer_.*'  -timeout 360m
=== RUN   TestAccNetworkManagerConnectPeer_basic
=== PAUSE TestAccNetworkManagerConnectPeer_basic
=== RUN   TestAccNetworkManagerConnectPeer_noDependsOn
=== PAUSE TestAccNetworkManagerConnectPeer_noDependsOn
=== RUN   TestAccNetworkManagerConnectPeer_subnetARN
=== PAUSE TestAccNetworkManagerConnectPeer_subnetARN
=== RUN   TestAccNetworkManagerConnectPeer_tags
=== PAUSE TestAccNetworkManagerConnectPeer_tags
=== CONT  TestAccNetworkManagerConnectPeer_basic
=== CONT  TestAccNetworkManagerConnectPeer_subnetARN
=== CONT  TestAccNetworkManagerConnectPeer_tags
=== CONT  TestAccNetworkManagerConnectPeer_noDependsOn
--- PASS: TestAccNetworkManagerConnectPeer_noDependsOn (1627.02s)
--- PASS: TestAccNetworkManagerConnectPeer_basic (1647.69s)
--- PASS: TestAccNetworkManagerConnectPeer_tags (1663.89s)
--- PASS: TestAccNetworkManagerConnectPeer_subnetARN (1903.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	1903.337s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkManagerConnectPeer_' PKG=networkmanager ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/networkmanager/... -v -count 1 -parallel 3  -run=TestAccNetworkManagerConnectPeer_ -timeout 360m
=== RUN   TestAccNetworkManagerConnectPeer_basic
=== PAUSE TestAccNetworkManagerConnectPeer_basic
=== RUN   TestAccNetworkManagerConnectPeer_noDependsOn
=== PAUSE TestAccNetworkManagerConnectPeer_noDependsOn
=== RUN   TestAccNetworkManagerConnectPeer_subnetARN
=== PAUSE TestAccNetworkManagerConnectPeer_subnetARN
=== RUN   TestAccNetworkManagerConnectPeer_tags
=== PAUSE TestAccNetworkManagerConnectPeer_tags
=== CONT  TestAccNetworkManagerConnectPeer_basic
=== CONT  TestAccNetworkManagerConnectPeer_subnetARN
=== CONT  TestAccNetworkManagerConnectPeer_tags
--- PASS: TestAccNetworkManagerConnectPeer_basic (1717.63s)
=== CONT  TestAccNetworkManagerConnectPeer_noDependsOn
--- PASS: TestAccNetworkManagerConnectPeer_tags (1761.75s)
--- PASS: TestAccNetworkManagerConnectPeer_subnetARN (1799.36s)
--- PASS: TestAccNetworkManagerConnectPeer_noDependsOn (1515.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	3238.413s

[ewbankkit]

@jtdoepke Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.