Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_cloudhsm_v2_cluster - add support for hsm2m.medium hsm_type #39018

Closed
guiyang2011 opened this issue Aug 23, 2024 · 6 comments · Fixed by #39206
Closed

[Enhancement]: aws_cloudhsm_v2_cluster - add support for hsm2m.medium hsm_type #39018

guiyang2011 opened this issue Aug 23, 2024 · 6 comments · Fixed by #39206
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service.
Milestone

Comments

@guiyang2011
Copy link

Description

The cloudhsm type "hsm2m.medium" was supported in aws-sdk-go v1.54.1, which had been added to the terraform-provider-aws already. However, it doesn't seem the current terraform-provider-aws exposes the new type yet

ValidateFunc: validation.StringInSlice([]string{"hsm1.medium"}, false),

Affected Resource(s) and/or Data Source(s)

aws_cloudhsm_v2_cluster

Potential Terraform Configuration

resource "aws_cloudhsm_v2_cluster" "cloudhsm_v2_cluster" {
  hsm_type   = "hsm2m.medium"
}

References

aws-sdk-go https://github.com/aws/aws-sdk-go/blob/02c1f723b528251a45068001bee8b56d904d7484/models/apis/cloudhsmv2/2017-04-28/docs-2.json#L382

Would you like to implement a fix?

None

@guiyang2011 guiyang2011 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 23, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. label Aug 23, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 23, 2024
@guiyang2011 guiyang2011 changed the title [Enhancement]: [Enhancement]: aws_cloudhsm_v2_cluster - add support for hsm2m.medium hsm_type Aug 23, 2024
@stefanfreitag
Copy link
Contributor

stefanfreitag commented Aug 25, 2024

Hi @guiyang2011!

Thanks for reporting the issue.
Let me have a look into this.

AWS Blog "AWS CloudHSM launches new hsm2m.medium instance type"

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 26, 2024
@prestonprice57
Copy link
Contributor

Hey I can take a crack at this one. PR incoming.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.67.0 milestone Sep 10, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service.
Projects
None yet
4 participants