Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_iam_user_login_profile - The validation function validates a string length for an integer. #3912

Closed
chdorb opened this issue Mar 26, 2018 · 5 comments · Fixed by #3919
Closed
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/iam Issues and PRs that pertain to the iam service.
Milestone

Comments

@chdorb
Copy link

chdorb commented Mar 26, 2018

Hi,

Commit #3702

https://github.com/terraform-providers/terraform-provider-aws/blob/639332e4e82a50ecb5cfcd931a86287848bbe4cb/aws/resource_aws_iam_user_login_profile.go#L39

The password length is an integer, the validate function checks string length (between 4 and 128), so terraform raises an error:
expected type of password_length to be string.

Step to reproduce:

  • set password_length to an aws_iam_user_login_profile resource
@bflad bflad added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/iam Issues and PRs that pertain to the iam service. labels Mar 26, 2018
@bflad bflad added this to the v1.13.0 milestone Mar 26, 2018
@bflad
Copy link
Contributor

bflad commented Mar 26, 2018

Hi @chdorb 👋 Sorry you ran into trouble with this resource and that a regression was introduced in the v1.12.0 release with some technical debt cleanup. Thank you very much for pointing to the PR that introduced this. It turns out there was not an acceptance test covering the password_length attribute on the aws_iam_user_login_profile resource. 😓

I have submitted #3919 which adds an acceptance test and fixes the regression. We'll get this merged ASAP.

@bflad
Copy link
Contributor

bflad commented Mar 26, 2018

The fix for this has been merged into master and will release with v1.13.0 of the AWS provider, likely at the end of next week.

@chdorb
Copy link
Author

chdorb commented Mar 26, 2018

Thanks !

For other users:
use version = "1.11" on your provider "aws" {} block is a workaround until v1.13.0 is released.

@bflad
Copy link
Contributor

bflad commented Mar 29, 2018

Ahead of schedule, this has been released in version 1.13.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/iam Issues and PRs that pertain to the iam service.
Projects
None yet
2 participants