Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Allow empty string in assume_role.role_arn #39328

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Sep 13, 2024

Description

For backwards compatibility, defining an assume_role block with a null or empty role_arn is supported, and does not attempt to assume a role. The PR #39255 did not check the empty string case.

Relations

Closes #39296.
Closes #39306.
Closes #39331.

@gdavison gdavison requested a review from a team as a code owner September 13, 2024 21:44
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 13, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test ./internal/provider 
ok  	github.com/hashicorp/terraform-provider-aws/internal/provider	7.804s

@gdavison gdavison merged commit 2d12e5f into main Sep 16, 2024
43 checks passed
@gdavison gdavison deleted the b-assume-role-empty-string branch September 16, 2024 12:57
@github-actions github-actions bot added this to the v5.68.0 milestone Sep 16, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 16, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 20, 2024
Copy link

This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants