Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_bedrockagent_agent_action_group: use configured prepare_agent value #39486

Conversation

sasidhar-aws
Copy link
Contributor

Description

This change implements the logic of prepare agent after creation or updating of bedrock agent action group.

Relations

Closes #39400

References

Output from Acceptance Testing

make testacc TESTS=TestAccBedrockAgentAgentActionGroup PKG=bedrockagent
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentAgentActionGroup'  -timeout 360m
=== RUN   TestAccBedrockAgentAgentActionGroup_basic
=== PAUSE TestAccBedrockAgentAgentActionGroup_basic
=== RUN   TestAccBedrockAgentAgentActionGroup_APISchema_s3
=== PAUSE TestAccBedrockAgentAgentActionGroup_APISchema_s3
=== RUN   TestAccBedrockAgentAgentActionGroup_update
=== PAUSE TestAccBedrockAgentAgentActionGroup_update
=== RUN   TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions
=== PAUSE TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions
=== RUN   TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl
=== PAUSE TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl
=== CONT  TestAccBedrockAgentAgentActionGroup_basic
=== CONT  TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions
=== CONT  TestAccBedrockAgentAgentActionGroup_update
=== CONT  TestAccBedrockAgentAgentActionGroup_APISchema_s3
=== CONT  TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl
--- PASS: TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl (349.43s)
--- PASS: TestAccBedrockAgentAgentActionGroup_basic (364.49s)
--- PASS: TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions (371.92s)
--- PASS: TestAccBedrockAgentAgentActionGroup_APISchema_s3 (408.84s)
--- PASS: TestAccBedrockAgentAgentActionGroup_update (532.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	537.267s

@sasidhar-aws sasidhar-aws requested a review from a team as a code owner September 25, 2024 19:41
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Sep 25, 2024
@sasidhar-aws sasidhar-aws force-pushed the f-aws_bedrockagent_agent_action_group-prepare_agent_arg branch from d1cb972 to 1c5d15f Compare September 25, 2024 19:59
@sasidhar-aws sasidhar-aws force-pushed the f-aws_bedrockagent_agent_action_group-prepare_agent_arg branch from 1c5d15f to 812f8cb Compare September 25, 2024 20:01
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 3, 2024
@ewbankkit ewbankkit self-assigned this Oct 3, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 3, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBedrockAgentAgentActionGroup_' PKG=bedrockagent ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/bedrockagent/... -v -count 1 -parallel 3  -run=TestAccBedrockAgentAgentActionGroup_ -timeout 360m
=== RUN   TestAccBedrockAgentAgentActionGroup_basic
=== PAUSE TestAccBedrockAgentAgentActionGroup_basic
=== RUN   TestAccBedrockAgentAgentActionGroup_upgradeToPrepareAgent
=== PAUSE TestAccBedrockAgentAgentActionGroup_upgradeToPrepareAgent
=== RUN   TestAccBedrockAgentAgentActionGroup_APISchema_s3
=== PAUSE TestAccBedrockAgentAgentActionGroup_APISchema_s3
=== RUN   TestAccBedrockAgentAgentActionGroup_update
=== PAUSE TestAccBedrockAgentAgentActionGroup_update
=== RUN   TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions
=== PAUSE TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions
=== RUN   TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl
=== PAUSE TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl
=== CONT  TestAccBedrockAgentAgentActionGroup_basic
=== CONT  TestAccBedrockAgentAgentActionGroup_update
=== CONT  TestAccBedrockAgentAgentActionGroup_APISchema_s3
--- PASS: TestAccBedrockAgentAgentActionGroup_APISchema_s3 (42.33s)
=== CONT  TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl
--- PASS: TestAccBedrockAgentAgentActionGroup_basic (47.69s)
=== CONT  TestAccBedrockAgentAgentActionGroup_upgradeToPrepareAgent
--- PASS: TestAccBedrockAgentAgentActionGroup_update (51.05s)
=== CONT  TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions
--- PASS: TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl (33.37s)
--- PASS: TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions (31.79s)
--- PASS: TestAccBedrockAgentAgentActionGroup_upgradeToPrepareAgent (68.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	121.045s

@ewbankkit
Copy link
Contributor

@sasidhar-aws Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7b5017f into hashicorp:main Oct 3, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.70.0 milestone Oct 3, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants