-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RequiresReplace to attributes that can't be modified by update #39567
Add RequiresReplace to attributes that can't be modified by update #39567
Conversation
Community NoteVoting for Prioritization
For Submitters
|
12f8b7a
to
fadd64e
Compare
…tes of 'knowledge_base_configuration' and 'storage_configuration'.
0b3a343
to
f16b146
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccBedrockAgent_serial/KnowledgeBase' PKG=bedrockagent
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run=TestAccBedrockAgent_serial/KnowledgeBase -timeout 720m
=== RUN TestAccBedrockAgent_serial
=== PAUSE TestAccBedrockAgent_serial
=== CONT TestAccBedrockAgent_serial
=== RUN TestAccBedrockAgent_serial/KnowledgeBase
=== RUN TestAccBedrockAgent_serial/KnowledgeBase/basicOpenSearch
knowledge_base_test.go:243: Bedrock Agent Knowledge Base requires external configuration of a vector index
=== RUN TestAccBedrockAgent_serial/KnowledgeBase/updateOpenSearch
knowledge_base_test.go:288: Bedrock Agent Knowledge Base requires external configuration of a vector index
=== RUN TestAccBedrockAgent_serial/KnowledgeBase/basicRDS
=== RUN TestAccBedrockAgent_serial/KnowledgeBase/disappears
=== RUN TestAccBedrockAgent_serial/KnowledgeBase/tags
--- PASS: TestAccBedrockAgent_serial (4156.45s)
--- PASS: TestAccBedrockAgent_serial/KnowledgeBase (4156.45s)
--- SKIP: TestAccBedrockAgent_serial/KnowledgeBase/basicOpenSearch (0.00s)
--- SKIP: TestAccBedrockAgent_serial/KnowledgeBase/updateOpenSearch (0.00s)
--- PASS: TestAccBedrockAgent_serial/KnowledgeBase/basicRDS (1544.41s)
--- PASS: TestAccBedrockAgent_serial/KnowledgeBase/disappears (1636.44s)
--- PASS: TestAccBedrockAgent_serial/KnowledgeBase/tags (975.60s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent 4161.935s
@drewtul Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Marks attributes that can't be updated as RequiresReplace.
Relations
Closes #38022
References
Output from Acceptance Testing