Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RequiresReplace to attributes that can't be modified by update #39567

Merged
merged 8 commits into from
Oct 2, 2024

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Oct 2, 2024

Description

Marks attributes that can't be updated as RequiresReplace.

Relations

Closes #38022

References

Output from Acceptance Testing

%  make testacc TESTS=TestAccBedrockAgent_serial/KnowledgeBase PKG=bedrockagent
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgent_serial/KnowledgeBase'  -timeout 360m
=== RUN   TestAccBedrockAgent_serial
=== PAUSE TestAccBedrockAgent_serial
=== CONT  TestAccBedrockAgent_serial
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/basicRDS
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/disappears
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/tags
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/basicOpenSearch
    knowledge_base_test.go:181: Bedrock Agent Knowledge Base requires external configuration of a vector index
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/updateOpenSearch
    knowledge_base_test.go:226: Bedrock Agent Knowledge Base requires external configuration of a vector index
--- PASS: TestAccBedrockAgent_serial (4929.64s)
    --- PASS: TestAccBedrockAgent_serial/KnowledgeBase (4929.64s)
        --- PASS: TestAccBedrockAgent_serial/KnowledgeBase/basicRDS (1688.12s)
        --- PASS: TestAccBedrockAgent_serial/KnowledgeBase/disappears (1636.17s)
        --- PASS: TestAccBedrockAgent_serial/KnowledgeBase/tags (1605.34s)
        --- SKIP: TestAccBedrockAgent_serial/KnowledgeBase/basicOpenSearch (0.00s)
        --- SKIP: TestAccBedrockAgent_serial/KnowledgeBase/updateOpenSearch (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       4933.903s

Copy link

github-actions bot commented Oct 2, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/bedrockagent Issues and PRs that pertain to the bedrockagent service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 2, 2024
@drewtul drewtul force-pushed the bug-bedrockagent-kb-update-error branch from 12f8b7a to fadd64e Compare October 2, 2024 14:48
@drewtul drewtul marked this pull request as ready for review October 2, 2024 14:59
@drewtul drewtul requested a review from a team as a code owner October 2, 2024 15:00
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 2, 2024
@ewbankkit ewbankkit self-assigned this Oct 2, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 2, 2024
@ewbankkit ewbankkit force-pushed the bug-bedrockagent-kb-update-error branch from 0b3a343 to f16b146 Compare October 2, 2024 20:00
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccBedrockAgent_serial/KnowledgeBase' PKG=bedrockagent
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20  -run=TestAccBedrockAgent_serial/KnowledgeBase -timeout 720m
=== RUN   TestAccBedrockAgent_serial
=== PAUSE TestAccBedrockAgent_serial
=== CONT  TestAccBedrockAgent_serial
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/basicOpenSearch
    knowledge_base_test.go:243: Bedrock Agent Knowledge Base requires external configuration of a vector index
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/updateOpenSearch
    knowledge_base_test.go:288: Bedrock Agent Knowledge Base requires external configuration of a vector index
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/basicRDS
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/disappears
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/tags
--- PASS: TestAccBedrockAgent_serial (4156.45s)
    --- PASS: TestAccBedrockAgent_serial/KnowledgeBase (4156.45s)
        --- SKIP: TestAccBedrockAgent_serial/KnowledgeBase/basicOpenSearch (0.00s)
        --- SKIP: TestAccBedrockAgent_serial/KnowledgeBase/updateOpenSearch (0.00s)
        --- PASS: TestAccBedrockAgent_serial/KnowledgeBase/basicRDS (1544.41s)
        --- PASS: TestAccBedrockAgent_serial/KnowledgeBase/disappears (1636.44s)
        --- PASS: TestAccBedrockAgent_serial/KnowledgeBase/tags (975.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	4161.935s

@ewbankkit
Copy link
Contributor

@drewtul Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3dc7d03 into hashicorp:main Oct 2, 2024
34 checks passed
@github-actions github-actions bot added this to the v5.70.0 milestone Oct 2, 2024
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. service/bedrockagent Issues and PRs that pertain to the bedrockagent service.
Projects
None yet
2 participants