-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update batch_compute_environment update_policy job_execution_timeout_minutes to validate range between 1 and 360 #39583
Update batch_compute_environment update_policy job_execution_timeout_minutes to validate range between 1 and 360 #39583
Conversation
…minutes to validate range between 1 and 360
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccBatchComputeEnvironment_updatePolicy' PKG=batch
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/batch/... -v -count 1 -parallel 20 -run=TestAccBatchComputeEnvironment_updatePolicy -timeout 360m
=== RUN TestAccBatchComputeEnvironment_updatePolicyCreate
=== PAUSE TestAccBatchComputeEnvironment_updatePolicyCreate
=== RUN TestAccBatchComputeEnvironment_updatePolicyUpdate
=== PAUSE TestAccBatchComputeEnvironment_updatePolicyUpdate
=== CONT TestAccBatchComputeEnvironment_updatePolicyCreate
=== CONT TestAccBatchComputeEnvironment_updatePolicyUpdate
--- PASS: TestAccBatchComputeEnvironment_updatePolicyUpdate (37.26s)
--- PASS: TestAccBatchComputeEnvironment_updatePolicyCreate (37.28s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/batch 42.818s
@frosforever Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Update the validation on
batch_compute_environment
'sjob_execution_timeout_minutes
to the valid range of 1 to 360 minutes per docs https://docs.aws.amazon.com/batch/latest/APIReference/API_UpdatePolicy.html