-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new resource aws_pinpointsmsvoicev2_configuration_set
#39620
Conversation
Community NoteVoting for Prioritization
For Submitters
|
aws_pinpointsmsvoicev2_configuration_set
aws_pinpointsmsvoicev2_configuration_set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccPinpointSMSVoiceV2ConfigurationSet_' PKG=pinpointsmsvoicev2 ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 2 -run=TestAccPinpointSMSVoiceV2ConfigurationSet_ -timeout 360m
=== RUN TestAccPinpointSMSVoiceV2ConfigurationSet_basic
=== PAUSE TestAccPinpointSMSVoiceV2ConfigurationSet_basic
=== RUN TestAccPinpointSMSVoiceV2ConfigurationSet_disappears
=== PAUSE TestAccPinpointSMSVoiceV2ConfigurationSet_disappears
=== RUN TestAccPinpointSMSVoiceV2ConfigurationSet_tags
=== PAUSE TestAccPinpointSMSVoiceV2ConfigurationSet_tags
=== CONT TestAccPinpointSMSVoiceV2ConfigurationSet_basic
=== CONT TestAccPinpointSMSVoiceV2ConfigurationSet_tags
--- PASS: TestAccPinpointSMSVoiceV2ConfigurationSet_basic (15.12s)
=== CONT TestAccPinpointSMSVoiceV2ConfigurationSet_disappears
--- PASS: TestAccPinpointSMSVoiceV2ConfigurationSet_disappears (10.22s)
--- PASS: TestAccPinpointSMSVoiceV2ConfigurationSet_tags (30.98s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2 36.279s
% make golangci-lint PKG=pinpointsmsvoicev2
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`.
make: golangci-lint Checks / 3 of 3... |
@WestonReed Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds support for a new resource,
aws_pinpointsmsvoicev2_configuration_set
. The provider code was mostly written followingaws_pinpointsmsvoicev2_opt_out_list
as an example.Relations
Closes #39606
References
Output from Acceptance Testing