Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource aws_pinpointsmsvoicev2_configuration_set #39620

Merged
merged 9 commits into from
Oct 8, 2024

Conversation

WestonReed
Copy link
Contributor

@WestonReed WestonReed commented Oct 8, 2024

Description

This PR adds support for a new resource, aws_pinpointsmsvoicev2_configuration_set. The provider code was mostly written following aws_pinpointsmsvoicev2_opt_out_list as an example.

Relations

Closes #39606

References

Output from Acceptance Testing

$ make testacc PKG=pinpointsmsvoicev2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 20   -timeout 360m
=== RUN   TestAccPinpointSMSVoiceV2ConfigurationSet_basic
=== PAUSE TestAccPinpointSMSVoiceV2ConfigurationSet_basic
=== RUN   TestAccPinpointSMSVoiceV2ConfigurationSet_disappears
=== PAUSE TestAccPinpointSMSVoiceV2ConfigurationSet_disappears
=== RUN   TestAccPinpointSMSVoiceV2ConfigurationSet_tags
=== PAUSE TestAccPinpointSMSVoiceV2ConfigurationSet_tags
=== RUN   TestAccPinpointSMSVoiceV2OptOutList_basic
=== PAUSE TestAccPinpointSMSVoiceV2OptOutList_basic
=== RUN   TestAccPinpointSMSVoiceV2OptOutList_disappears
=== PAUSE TestAccPinpointSMSVoiceV2OptOutList_disappears
=== RUN   TestAccPinpointSMSVoiceV2OptOutList_tags
=== PAUSE TestAccPinpointSMSVoiceV2OptOutList_tags
=== RUN   TestAccPinpointSMSVoiceV2PhoneNumber_basic
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_basic
=== RUN   TestAccPinpointSMSVoiceV2PhoneNumber_full
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_full
=== RUN   TestAccPinpointSMSVoiceV2PhoneNumber_disappears
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_disappears
=== RUN   TestAccPinpointSMSVoiceV2PhoneNumber_tags
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_tags
=== RUN   TestEndpointConfiguration
=== RUN   TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file
=== RUN   TestEndpointConfiguration/package_name_endpoint_config
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_envvar
=== RUN   TestEndpointConfiguration/no_config
=== RUN   TestEndpointConfiguration/service_config_file_overrides_base_config_file
=== RUN   TestEndpointConfiguration/base_endpoint_config_file
=== RUN   TestEndpointConfiguration/use_fips_config
=== RUN   TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar
=== RUN   TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file
=== RUN   TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file
=== RUN   TestEndpointConfiguration/service_config_file
=== RUN   TestEndpointConfiguration/service_aws_envvar
--- PASS: TestEndpointConfiguration (0.68s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config (0.04s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar (0.03s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar (0.02s)
    --- PASS: TestEndpointConfiguration/no_config (0.02s)
    --- PASS: TestEndpointConfiguration/service_config_file_overrides_base_config_file (0.02s)
    --- PASS: TestEndpointConfiguration/base_endpoint_config_file (0.02s)
    --- PASS: TestEndpointConfiguration/use_fips_config (0.02s)
    --- PASS: TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config (0.04s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar (0.04s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar (0.04s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file (0.02s)
    --- PASS: TestEndpointConfiguration/service_config_file (0.02s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar (0.03s)
=== CONT  TestAccPinpointSMSVoiceV2ConfigurationSet_basic
=== CONT  TestAccPinpointSMSVoiceV2OptOutList_tags
=== CONT  TestAccPinpointSMSVoiceV2PhoneNumber_disappears
=== CONT  TestAccPinpointSMSVoiceV2PhoneNumber_tags
=== CONT  TestAccPinpointSMSVoiceV2OptOutList_basic
=== CONT  TestAccPinpointSMSVoiceV2OptOutList_disappears
=== CONT  TestAccPinpointSMSVoiceV2PhoneNumber_full
=== CONT  TestAccPinpointSMSVoiceV2PhoneNumber_basic
=== CONT  TestAccPinpointSMSVoiceV2ConfigurationSet_tags
=== CONT  TestAccPinpointSMSVoiceV2ConfigurationSet_disappears
--- PASS: TestAccPinpointSMSVoiceV2OptOutList_disappears (25.43s)
--- PASS: TestAccPinpointSMSVoiceV2ConfigurationSet_disappears (25.71s)
--- PASS: TestAccPinpointSMSVoiceV2ConfigurationSet_basic (29.94s)
--- PASS: TestAccPinpointSMSVoiceV2OptOutList_basic (29.94s)
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_basic (37.00s)
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_disappears (41.42s)
--- PASS: TestAccPinpointSMSVoiceV2OptOutList_tags (50.56s)
--- PASS: TestAccPinpointSMSVoiceV2ConfigurationSet_tags (50.59s)
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_tags (51.17s)
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_full (55.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2	56.565s

@WestonReed WestonReed requested a review from a team as a code owner October 8, 2024 02:57
Copy link

github-actions bot commented Oct 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/pinpointsmsvoicev2 Issues and PRs that pertain to the pinpointsmsvoicev2 service. needs-triage Waiting for first response or review from a maintainer. labels Oct 8, 2024
@WestonReed WestonReed changed the title feat: add new resource aws_pinpointsmsvoicev2_configuration_set Add new resource aws_pinpointsmsvoicev2_configuration_set Oct 8, 2024
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 8, 2024
@ewbankkit ewbankkit self-assigned this Oct 8, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 8, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccPinpointSMSVoiceV2ConfigurationSet_' PKG=pinpointsmsvoicev2 ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 2  -run=TestAccPinpointSMSVoiceV2ConfigurationSet_ -timeout 360m
=== RUN   TestAccPinpointSMSVoiceV2ConfigurationSet_basic
=== PAUSE TestAccPinpointSMSVoiceV2ConfigurationSet_basic
=== RUN   TestAccPinpointSMSVoiceV2ConfigurationSet_disappears
=== PAUSE TestAccPinpointSMSVoiceV2ConfigurationSet_disappears
=== RUN   TestAccPinpointSMSVoiceV2ConfigurationSet_tags
=== PAUSE TestAccPinpointSMSVoiceV2ConfigurationSet_tags
=== CONT  TestAccPinpointSMSVoiceV2ConfigurationSet_basic
=== CONT  TestAccPinpointSMSVoiceV2ConfigurationSet_tags
--- PASS: TestAccPinpointSMSVoiceV2ConfigurationSet_basic (15.12s)
=== CONT  TestAccPinpointSMSVoiceV2ConfigurationSet_disappears
--- PASS: TestAccPinpointSMSVoiceV2ConfigurationSet_disappears (10.22s)
--- PASS: TestAccPinpointSMSVoiceV2ConfigurationSet_tags (30.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2	36.279s

@ewbankkit
Copy link
Contributor

% make golangci-lint PKG=pinpointsmsvoicev2
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. 
make: golangci-lint Checks / 3 of 3...

@ewbankkit
Copy link
Contributor

@WestonReed Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e1ea096 into hashicorp:main Oct 8, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.71.0 milestone Oct 8, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 15, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. new-resource Introduces a new resource. service/pinpointsmsvoicev2 Issues and PRs that pertain to the pinpointsmsvoicev2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_pinpointsmsvoicev2_configuration_set
2 participants