-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_sagemaker_workteam: Fix workforce_name
: WorkforceName is misconfigured as Required.
#39630
resource/aws_sagemaker_workteam: Fix workforce_name
: WorkforceName is misconfigured as Required.
#39630
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…am_cognitoOmitWorkforceName'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSageMaker_serial/Workteam/Cognito' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccSageMaker_serial/Workteam/Cognito -timeout 360m
=== RUN TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT TestAccSageMaker_serial
=== RUN TestAccSageMaker_serial/Workteam
=== RUN TestAccSageMaker_serial/Workteam/CognitoConfig
=== RUN TestAccSageMaker_serial/Workteam/CognitoOmitWorkforceName
--- PASS: TestAccSageMaker_serial (125.23s)
--- PASS: TestAccSageMaker_serial/Workteam (125.23s)
--- PASS: TestAccSageMaker_serial/Workteam/CognitoConfig (108.77s)
--- PASS: TestAccSageMaker_serial/Workteam/CognitoOmitWorkforceName (16.47s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 130.479s
@trutled3 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This pull request fixes the
workforce_name
argument to be Optional. This argument is optional via the AWS SDK v2 for Golang here and is documented as optional on AWS official documentation hereRelations
Closes #39488
References
Output from Acceptance Testing