-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/sagemaker_space - support app lifecycle management #39800
Conversation
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Community NoteVoting for Prioritization
For Submitters
|
@DrFaust92 Could you add a CHANGELOG entry please? |
@ewbankkit Whoops, missed that. Will do |
@ewbankkit seems i did it already but forgot to push 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSageMaker_serial/^Space$$' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccSageMaker_serial/^Space$ -timeout 360m
2024/10/21 08:24:31 Initializing Terraform AWS Provider...
=== RUN TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT TestAccSageMaker_serial
=== RUN TestAccSageMaker_serial/Space
=== RUN TestAccSageMaker_serial/Space/disappears
=== RUN TestAccSageMaker_serial/Space/jupyterServerAppSettings
=== RUN TestAccSageMaker_serial/Space/jupyterLabAppSettings
=== RUN TestAccSageMaker_serial/Space/jupyterLabAppSettingsLifecycle
=== RUN TestAccSageMaker_serial/Space/basic
=== RUN TestAccSageMaker_serial/Space/tags
=== RUN TestAccSageMaker_serial/Space/kernelGatewayAppSettings
=== RUN TestAccSageMaker_serial/Space/kernelGatewayAppSettings_lifecycleConfig
=== RUN TestAccSageMaker_serial/Space/kernelGatewayAppSettings_imageConfig
space_test.go:203: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN TestAccSageMaker_serial/Space/codeEditorAppSettings
=== RUN TestAccSageMaker_serial/Space/storageSettings
=== RUN TestAccSageMaker_serial/Space/customFileSystem
--- PASS: TestAccSageMaker_serial (2855.65s)
--- PASS: TestAccSageMaker_serial/Space (2855.65s)
--- PASS: TestAccSageMaker_serial/Space/disappears (276.56s)
--- PASS: TestAccSageMaker_serial/Space/jupyterServerAppSettings (255.28s)
--- PASS: TestAccSageMaker_serial/Space/jupyterLabAppSettings (272.39s)
--- PASS: TestAccSageMaker_serial/Space/jupyterLabAppSettingsLifecycle (275.14s)
--- PASS: TestAccSageMaker_serial/Space/basic (255.02s)
--- PASS: TestAccSageMaker_serial/Space/tags (252.81s)
--- PASS: TestAccSageMaker_serial/Space/kernelGatewayAppSettings (214.71s)
--- PASS: TestAccSageMaker_serial/Space/kernelGatewayAppSettings_lifecycleConfig (215.95s)
--- SKIP: TestAccSageMaker_serial/Space/kernelGatewayAppSettings_imageConfig (0.00s)
--- PASS: TestAccSageMaker_serial/Space/codeEditorAppSettings (216.87s)
--- PASS: TestAccSageMaker_serial/Space/storageSettings (255.37s)
--- PASS: TestAccSageMaker_serial/Space/customFileSystem (365.57s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 2860.767s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Relations
Closes #0000
References
Output from Acceptance Testing