Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: SageMaker Built In Life Cycle Config #39851

Closed
oliverguy1 opened this issue Oct 23, 2024 · 4 comments
Closed

[Enhancement]: SageMaker Built In Life Cycle Config #39851

oliverguy1 opened this issue Oct 23, 2024 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.

Comments

@oliverguy1
Copy link

oliverguy1 commented Oct 23, 2024

Description

In the AWS Create Domain API there is an option to set a "Built In Life Cycle Config" to set the LCC that runs every time a new Jupyter Notebook or Code Editor is set up.

This does not currently exist within the aws_sagemaker_domain resource as of version 5.72.1 of the provider

Affected Resource(s) and/or Data Source(s)

aws_sagemaker_domain

Potential Terraform Configuration

resource "aws_sagemaker_studio_lifecycle_config" "jupyterlab_config" {
  studio_lifecycle_config_name     = "jupyterlab"
  studio_lifecycle_config_app_type = "JupyterLab"
  studio_lifecycle_config_content  = filebase64("${path.module}/jupyterlab.sh")
}

resource "aws_sagemaker_domain" "domain" {
  domain_name = var.sagemaker_domain_name

  default_user_settings {
    code_editor_app_settings {
      built_in_lifecycle_config_arn = aws_sagemaker_studio_lifecycle_config.jupyterlab_config.arn
    }
}

References

AWS Create Domain API Reference
AWS Create Domain API - BuiltInLifeCycleConfigArn parameter

Would you like to implement a fix?

No

@oliverguy1 oliverguy1 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 23, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/sagemaker Issues and PRs that pertain to the sagemaker service. needs-triage Waiting for first response or review from a maintainer. labels Oct 23, 2024
@deepakbshetty
Copy link
Contributor

Hi @oliverguy1

I believe this is now released in 5.73.0 [ https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.73.0 ]

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sagemaker_domain#built_in_lifecycle_config_arn

@justinretzolk
Copy link
Member

Hey @oliverguy1 👋 Thank you for taking the time to raise this! This was indeed released in 5.73.0 via #39774. With that in mind, I'm going to close this issue. If you have any future enhancement requests, please do let us know!

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Projects
None yet
Development

No branches or pull requests

3 participants