Remove CodeDeploy alarm limit

[AnitaErnszt]

Description

Removing the alarm limit from CodeDeploy.
The provider currently only support max 10 alarms, a limit which was set 8 years ago (ref)

AWS now supports 50 alarms per deployment group, and this limit is adjustable

Relations

Haven't opened issue, but happy to if needed, this is currently a blocker for us

Output from Acceptance Testing

make testacc PKG=deploy TESTS=TestAccDeployDeploymentGroup_                

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/deploy/... -v -count 1 -parallel 20 -run='TestAccDeployDeploymentGroup_'  -timeout 360m
=== RUN   TestAccDeployDeploymentGroup_basic
=== PAUSE TestAccDeployDeploymentGroup_basic
=== RUN   TestAccDeployDeploymentGroup_Basic_tagSet
=== PAUSE TestAccDeployDeploymentGroup_Basic_tagSet
=== RUN   TestAccDeployDeploymentGroup_onPremiseTag
=== PAUSE TestAccDeployDeploymentGroup_onPremiseTag
=== RUN   TestAccDeployDeploymentGroup_disappears
=== PAUSE TestAccDeployDeploymentGroup_disappears
=== RUN   TestAccDeployDeploymentGroup_Disappears_app
=== PAUSE TestAccDeployDeploymentGroup_Disappears_app
=== RUN   TestAccDeployDeploymentGroup_tags
=== PAUSE TestAccDeployDeploymentGroup_tags
=== RUN   TestAccDeployDeploymentGroup_Trigger_basic
=== PAUSE TestAccDeployDeploymentGroup_Trigger_basic
=== RUN   TestAccDeployDeploymentGroup_Trigger_multiple
=== PAUSE TestAccDeployDeploymentGroup_Trigger_multiple
=== RUN   TestAccDeployDeploymentGroup_AutoRollback_create
=== PAUSE TestAccDeployDeploymentGroup_AutoRollback_create
=== RUN   TestAccDeployDeploymentGroup_AutoRollback_update
=== PAUSE TestAccDeployDeploymentGroup_AutoRollback_update
=== RUN   TestAccDeployDeploymentGroup_AutoRollback_delete
=== PAUSE TestAccDeployDeploymentGroup_AutoRollback_delete
=== RUN   TestAccDeployDeploymentGroup_AutoRollback_disable
=== PAUSE TestAccDeployDeploymentGroup_AutoRollback_disable
=== RUN   TestAccDeployDeploymentGroup_Alarm_create
=== PAUSE TestAccDeployDeploymentGroup_Alarm_create
=== RUN   TestAccDeployDeploymentGroup_Alarm_update
=== PAUSE TestAccDeployDeploymentGroup_Alarm_update
=== RUN   TestAccDeployDeploymentGroup_Alarm_delete
=== PAUSE TestAccDeployDeploymentGroup_Alarm_delete
=== RUN   TestAccDeployDeploymentGroup_Alarm_disable
=== PAUSE TestAccDeployDeploymentGroup_Alarm_disable
=== RUN   TestAccDeployDeploymentGroup_DeploymentStyle_default
=== PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_default
=== RUN   TestAccDeployDeploymentGroup_DeploymentStyle_create
=== PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_create
=== RUN   TestAccDeployDeploymentGroup_DeploymentStyle_update
=== PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_update
=== RUN   TestAccDeployDeploymentGroup_DeploymentStyle_delete
=== PAUSE TestAccDeployDeploymentGroup_DeploymentStyle_delete
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfo_create
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_create
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfo_update
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_update
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update
=== RUN   TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete
=== PAUSE TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete
=== RUN   TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create
=== PAUSE TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create
=== RUN   TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update
=== PAUSE TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_create
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_create
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_update
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_update
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_delete
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_delete
=== RUN   TestAccDeployDeploymentGroup_BlueGreenDeployment_complete
=== PAUSE TestAccDeployDeploymentGroup_BlueGreenDeployment_complete
=== RUN   TestAccDeployDeploymentGroup_ECS_blueGreen
=== PAUSE TestAccDeployDeploymentGroup_ECS_blueGreen
=== RUN   TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update
=== PAUSE TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update
=== RUN   TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore
=== PAUSE TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore
=== CONT  TestAccDeployDeploymentGroup_basic
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_update
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_update
=== CONT  TestAccDeployDeploymentGroup_Alarm_delete
=== CONT  TestAccDeployDeploymentGroup_Alarm_create
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_default
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_create
=== CONT  TestAccDeployDeploymentGroup_Alarm_disable
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_disable
=== CONT  TestAccDeployDeploymentGroup_Alarm_update
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_delete
=== CONT  TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update
=== CONT  TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore
=== CONT  TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update
=== CONT  TestAccDeployDeploymentGroup_ECS_blueGreen
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_complete
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_delete
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_update
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
=== CONT  TestAccDeployDeploymentGroup_BlueGreenDeployment_create
    acctest.go:1780: skipping test for aws/us-west-2: Error running apply: exit status 1

        Error: creating Auto Scaling Launch Configuration (tf-acc-test-2575896641944299396): operation error Auto Scaling: CreateLaunchConfiguration, https response error StatusCode: 400, RequestID: 33fa569b-53a1-4102-be4b-6e05840f1669, api error UnsupportedOperation: The Launch Configuration creation operation is not available in your account. Use launch templates to create configuration templates for your Auto Scaling groups.

          with aws_launch_configuration.test,
          on terraform_plugin_test.tf line 109, in resource "aws_launch_configuration" "test":
         109: resource "aws_launch_configuration" "test" {

=== NAME  TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG
    acctest.go:1780: skipping test for aws/us-west-2: Error running apply: exit status 1

        Error: creating Auto Scaling Launch Configuration (tf-acc-test-4888664551477343508): operation error Auto Scaling: CreateLaunchConfiguration, https response error StatusCode: 400, RequestID: 5f2e3357-45d8-4c95-ab0f-45af232ede07, api error UnsupportedOperation: The Launch Configuration creation operation is not available in your account. Use launch templates to create configuration templates for your Auto Scaling groups.

          with aws_launch_configuration.test,
          on terraform_plugin_test.tf line 109, in resource "aws_launch_configuration" "test":
         109: resource "aws_launch_configuration" "test" {

--- SKIP: TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG (18.54s)
=== CONT  TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create
--- SKIP: TestAccDeployDeploymentGroup_BlueGreenDeployment_create (18.58s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_default (42.55s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update
--- PASS: TestAccDeployDeploymentGroup_Alarm_create (49.14s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create
--- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create (41.05s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_create (61.35s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_update
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_update (62.18s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_create
--- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore (68.29s)
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_delete
--- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update (69.81s)
=== CONT  TestAccDeployDeploymentGroup_tags
--- PASS: TestAccDeployDeploymentGroup_Alarm_update (70.28s)
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_create
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_update (75.46s)
=== CONT  TestAccDeployDeploymentGroup_Trigger_multiple
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete (64.25s)
=== CONT  TestAccDeployDeploymentGroup_Trigger_basic
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_delete (84.25s)
=== CONT  TestAccDeployDeploymentGroup_disappears
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_delete (84.54s)
=== CONT  TestAccDeployDeploymentGroup_Disappears_app
--- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update (84.84s)
=== CONT  TestAccDeployDeploymentGroup_onPremiseTag
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_update (88.81s)
=== CONT  TestAccDeployDeploymentGroup_Basic_tagSet
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_disable (92.49s)
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_complete (93.54s)
--- PASS: TestAccDeployDeploymentGroup_Alarm_disable (93.55s)
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create (45.94s)
--- PASS: TestAccDeployDeploymentGroup_Alarm_delete (95.22s)
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_create (39.08s)
--- PASS: TestAccDeployDeploymentGroup_basic (101.33s)
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update (59.65s)
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_create (33.67s)
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_update (51.39s)
--- PASS: TestAccDeployDeploymentGroup_disappears (29.07s)
--- PASS: TestAccDeployDeploymentGroup_onPremiseTag (30.99s)
--- PASS: TestAccDeployDeploymentGroup_Disappears_app (33.64s)
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_delete (50.64s)
--- PASS: TestAccDeployDeploymentGroup_Trigger_multiple (45.52s)
--- PASS: TestAccDeployDeploymentGroup_tags (59.52s)
--- PASS: TestAccDeployDeploymentGroup_Trigger_basic (47.36s)
--- PASS: TestAccDeployDeploymentGroup_Basic_tagSet (53.82s)
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_delete (84.03s)
--- PASS: TestAccDeployDeploymentGroup_ECS_blueGreen (360.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	366.159s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

% make testacc PKG=deploy TESTS=TestAccDeployDeploymentGroup_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/deploy/... -v -count 1 -parallel 20 -run='TestAccDeployDeploymentGroup_'  -timeout 360m

--- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_update (41.89s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_delete
--- PASS: TestAccDeployDeploymentGroup_TermationHook_disabled (46.23s)
=== CONT  TestAccDeployDeploymentGroup_LoadBalancerInfo_update
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_create (56.17s)
=== CONT  TestAccDeployDeploymentGroup_tags
--- PASS: TestAccDeployDeploymentGroup_TermationHook_enabled (66.13s)
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_update
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_delete (74.41s)
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_create
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_update (74.73s)
=== CONT  TestAccDeployDeploymentGroup_Trigger_multiple
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_update (75.26s)
=== CONT  TestAccDeployDeploymentGroup_Trigger_basic
--- PASS: TestAccDeployDeploymentGroup_OutdatedInstancesStrategy_ignore (75.28s)
=== CONT  TestAccDeployDeploymentGroup_Alarm_disable
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_create (76.62s)
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_update
--- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_update (80.19s)
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_create
--- PASS: TestAccDeployDeploymentGroup_InPlaceDeploymentWithTrafficControl_create (81.31s)
=== CONT  TestAccDeployDeploymentGroup_DeploymentStyle_default
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_multiple (82.04s)
=== CONT  TestAccDeployDeploymentGroup_Alarm_update
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_delete (94.62s)
=== CONT  TestAccDeployDeploymentGroup_Alarm_delete
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_delete (96.83s)
=== CONT  TestAccDeployDeploymentGroup_disappears
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_complete (97.50s)
=== CONT  TestAccDeployDeploymentGroup_Disappears_app
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfoTargetGroupInfo_delete (98.27s)
=== CONT  TestAccDeployDeploymentGroup_onPremiseTag
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_delete (62.87s)
=== CONT  TestAccDeployDeploymentGroup_Alarm_create
--- PASS: TestAccDeployDeploymentGroup_basic (104.78s)
=== CONT  TestAccDeployDeploymentGroup_AutoRollback_disable
--- PASS: TestAccDeployDeploymentGroup_LoadBalancerInfo_update (61.97s)
=== CONT  TestAccDeployDeploymentGroup_Basic_tagSet
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_create (31.69s)
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_default (31.43s)
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_update (48.05s)
--- PASS: TestAccDeployDeploymentGroup_tags (64.95s)
--- PASS: TestAccDeployDeploymentGroup_onPremiseTag (23.40s)
--- PASS: TestAccDeployDeploymentGroup_Disappears_app (27.85s)
--- PASS: TestAccDeployDeploymentGroup_disappears (30.85s)
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_disable (35.04s)
--- PASS: TestAccDeployDeploymentGroup_Alarm_create (36.02s)
--- PASS: TestAccDeployDeploymentGroup_AutoRollback_create (68.47s)
--- PASS: TestAccDeployDeploymentGroup_Alarm_update (69.92s)
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_create (151.96s)
--- PASS: TestAccDeployDeploymentGroup_Basic_tagSet (45.54s)
--- PASS: TestAccDeployDeploymentGroup_Trigger_multiple (80.06s)
--- PASS: TestAccDeployDeploymentGroup_Trigger_basic (81.34s)
--- PASS: TestAccDeployDeploymentGroup_DeploymentStyle_update (86.68s)
--- PASS: TestAccDeployDeploymentGroup_Alarm_disable (89.81s)
--- PASS: TestAccDeployDeploymentGroup_Alarm_delete (77.91s)
--- PASS: TestAccDeployDeploymentGroup_BlueGreenDeployment_updateWithASG (191.06s)
--- PASS: TestAccDeployDeploymentGroup_ECS_blueGreen (360.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/deploy     366.627s

[jar-b]

Thanks for your contribution, @AnitaErnszt! 👍

[github-actions]

This functionality has been released in v5.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!