feat: Add description arg/attr for aws_cloudwatch_event_bus resource and data source

[acwwat]

Description

This PR is to add the description argument/attribute to the aws_cloudwatch_event_bus resource and data source.

Note that there is a quirk with the AWS API where you cannot unset the description on update when it is previously set. The only way is to set the description to am empty string, which is coincidentally mapped to the zero string value. So in the state, the value is never null, only empty string for now.

Relations

Closes #39900

References

Referred to CreateTask for specs and wordings.

Output from Acceptance Testing

For the aws_cloudwatch_event_bus resource:

$ make testacc TESTS=TestAccEventsBus_basic PKG=events
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus_basic'  -timeout 360m
2024/10/31 23:46:42 Initializing Terraform AWS Provider...
=== RUN   TestAccEventsBus_basic
=== PAUSE TestAccEventsBus_basic
=== CONT  TestAccEventsBus_basic
--- PASS: TestAccEventsBus_basic (50.18s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     50.394s

$

For the aws_cloudwatch_event_bus data source:

$ make testacc TESTS=TestAccEventsBusDataSource_kmsKeyIdentifier PKG=events
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBusDataSource_kmsKeyIdentifier'  -timeout 360m
2024/10/31 23:58:15 Initializing Terraform AWS Provider...
=== RUN   TestAccEventsBusDataSource_kmsKeyIdentifier
=== PAUSE TestAccEventsBusDataSource_kmsKeyIdentifier
=== CONT  TestAccEventsBusDataSource_kmsKeyIdentifier
--- PASS: TestAccEventsBusDataSource_kmsKeyIdentifier (25.18s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     25.392s

$

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

% make testacc PKG=events TESTS="TestAccEventsBus_|TestAccEventsBusDataSource_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus_|TestAccEventsBusDataSource_'  -timeout 360m
2024/11/08 09:30:55 Initializing Terraform AWS Provider...

--- PASS: TestAccEventsBus_default (1.74s)
--- PASS: TestAccEventsBusDataSource_basic (13.01s)
--- PASS: TestAccEventsBus_disappears (13.64s)
--- PASS: TestAccEventsBusDataSource_kmsKeyIdentifier (22.93s)
--- PASS: TestAccEventsBus_tags (32.67s)
--- PASS: TestAccEventsBus_basic (49.73s)
--- PASS: TestAccEventsBus_kmsKeyIdentifier (88.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     94.779s

[jar-b]

Thanks for your contribution, @acwwat! 👍 👏

[github-actions]

This functionality has been released in v5.75.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!