Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing h265 codec settings for medialive channels #40071

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

lvthillo
Copy link
Contributor

@lvthillo lvthillo commented Nov 9, 2024

Description

Add missing h265 codec settings for Medialive channels

Relations

Closes #39485

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings PKG=medialive
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings'  -timeout 360m
2024/11/09 15:28:26 Initializing Terraform AWS Provider...
=== RUN   TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings
=== PAUSE TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings
=== CONT  TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings (88.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/medialive  102.614s

@lvthillo lvthillo requested a review from a team as a code owner November 9, 2024 14:31
Copy link

github-actions bot commented Nov 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/medialive Issues and PRs that pertain to the medialive service. needs-triage Waiting for first response or review from a maintainer. labels Nov 9, 2024
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Nov 11, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=medialive TESTS=TestAccMediaLiveChannel_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_'  -timeout 360m
2024/11/11 10:13:05 Initializing Terraform AWS Provider...

--- PASS: TestAccMediaLiveChannel_noAudio (90.99s)
=== CONT  TestAccMediaLiveChannel_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccMediaLiveChannel_AudioDescriptions_codecSettings (91.42s)
=== CONT  TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h264Settings
--- PASS: TestAccMediaLiveChannel_basic (94.96s)
=== CONT  TestAccMediaLiveChannel_update
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings (102.04s)
=== CONT  TestAccMediaLiveChannel_disappears
--- PASS: TestAccMediaLiveChannel_hls (104.39s)
=== CONT  TestAccMediaLiveChannel_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h264Settings (75.07s)
=== CONT  TestAccMediaLiveChannel_tags_DefaultTags_providerOnly
--- PASS: TestAccMediaLiveChannel_tags_DefaultTags_updateToResourceOnly (176.11s)
=== CONT  TestAccMediaLiveChannel_tags_DefaultTags_nonOverlapping
--- PASS: TestAccMediaLiveChannel_update (87.96s)
=== CONT  TestAccMediaLiveChannel_tags_AddOnUpdate
--- PASS: TestAccMediaLiveChannel_tags_DefaultTags_updateToProviderOnly (95.82s)
=== CONT  TestAccMediaLiveChannel_tags_EmptyTag_OnCreate
--- PASS: TestAccMediaLiveChannel_tags (219.66s)
=== CONT  TestAccMediaLiveChannel_M2TS_settings
--- PASS: TestAccMediaLiveChannel_tags_AddOnUpdate (84.27s)
=== CONT  TestAccMediaLiveChannel_tags_EmptyMap
--- PASS: TestAccMediaLiveChannel_tags_DefaultTags_nonOverlapping (108.97s)
=== CONT  TestAccMediaLiveChannel_tags_null
--- PASS: TestAccMediaLiveChannel_tags_EmptyTag_OnCreate (98.94s)
=== CONT  TestAccMediaLiveChannel_status
--- PASS: TestAccMediaLiveChannel_tags_DefaultTags_providerOnly (132.55s)
=== CONT  TestAccMediaLiveChannel_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccMediaLiveChannel_tags_IgnoreTags_Overlap_ResourceTag (317.35s)
--- PASS: TestAccMediaLiveChannel_M2TS_settings (120.02s)
--- PASS: TestAccMediaLiveChannel_tags_null (77.24s)
--- PASS: TestAccMediaLiveChannel_captionDescriptions (387.19s)
--- PASS: TestAccMediaLiveChannel_tags_EmptyTag_OnUpdate_Replace (89.70s)
--- PASS: TestAccMediaLiveChannel_tags_EmptyMap (160.43s)
--- PASS: TestAccMediaLiveChannel_tags_DefaultTags_emptyResourceTag (442.71s)
--- PASS: TestAccMediaLiveChannel_MsSmooth_outputSettings (461.16s)
--- PASS: TestAccMediaLiveChannel_status (178.98s)
--- PASS: TestAccMediaLiveChannel_tags_IgnoreTags_Overlap_DefaultTag (494.22s)
--- PASS: TestAccMediaLiveChannel_tags_ComputedTag_OnUpdate_Replace (404.81s)
--- PASS: TestAccMediaLiveChannel_tags_ComputedTag_OnCreate (515.87s)
--- PASS: TestAccMediaLiveChannel_disappears (458.42s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (663.83s)
--- PASS: TestAccMediaLiveChannel_tags_DefaultTags_nullNonOverlappingResourceTag (672.12s)
--- PASS: TestAccMediaLiveChannel_tags_EmptyTag_OnUpdate_Add (714.93s)
--- PASS: TestAccMediaLiveChannel_tags_DefaultTags_nullOverlappingResourceTag (728.75s)
--- PASS: TestAccMediaLiveChannel_tags_DefaultTags_emptyProviderOnlyTag (772.43s)
--- PASS: TestAccMediaLiveChannel_tags_ComputedTag_OnUpdate_Add (829.59s)
--- PASS: TestAccMediaLiveChannel_tags_DefaultTags_overlapping (851.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/medialive  857.888s

@jar-b
Copy link
Member

jar-b commented Nov 11, 2024

Thanks for your contribution, @lvthillo! 👍

@jar-b jar-b merged commit 24c9cfa into hashicorp:main Nov 11, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.76.0 milestone Nov 11, 2024
Copy link

This functionality has been released in v5.76.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/medialive Issues and PRs that pertain to the medialive service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_medialive_channel missing H264 Color Space Settings
2 participants