Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Import functionality for aws_waf_ipset #4279

Closed
iancward opened this issue Apr 20, 2018 · 4 comments · Fixed by #4979
Closed

Feature Request: Import functionality for aws_waf_ipset #4279

iancward opened this issue Apr 20, 2018 · 4 comments · Fixed by #4979
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service.
Milestone

Comments

@iancward
Copy link
Contributor

Hi there,

Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.

Terraform Version

Terraform v0.11.7

  • provider.aws v1.15.0

Affected Resource(s)

  • aws_waf_ipset

Terraform Configuration Files

resource "aws_waf_ipset" "ipset" {
  name = "tfIPSet"

  ip_set_descriptors {
    type  = "IPV4"
    value = "192.0.7.0/24"
  }

  ip_set_descriptors {
    type  = "IPV4"
    value = "10.16.16.0/16"
  }
}

Debug Output

N/A

Panic Output

N/A

Expected Behavior

I would like to be able to import a waf_ipset. We created one manually in haste and now we'd like to properly manage it with terraform.

Actual Behavior

aws_waf_ipset.dgn: Importing from ID "a1b2c3d4-d5f6-7777-8888-9999aaaabbbbcccc"...

terraform import aws_waf_ipset.ok_cidrs a1b2c3d4-d5f6-7777-8888-9999aaaabbbbcccc
Error: aws_waf_ipset.dgn (import id: a1b2c3d4-d5f6-7777-8888-9999aaaabbbbcccc): import aws_waf_ipset.ok_cidrs (id: a1b2c3d4-d5f6-7777-8888-9999aaaabbbbcccc): resource aws_waf_ipset doesn't support import

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

  1. terraform import aws_waf_ipset.main <id>

Important Factoids

N/A

References

There are probably more WAF resources that don't support import; this is just the first one I ran into.

@radeksimko radeksimko added enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. labels Apr 24, 2018
@bflad
Copy link
Contributor

bflad commented Jun 25, 2018

Pull request submitted: #4979

@bflad bflad added this to the v1.25.0 milestone Jun 25, 2018
@bflad
Copy link
Contributor

bflad commented Jun 25, 2018

Resource import support for aws_waf_ipset has been merged in and will release with version 1.25.0 of the AWS provider, likely later this week.

@bflad
Copy link
Contributor

bflad commented Jun 27, 2018

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants