Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processing_configuration not available for AWS Splunk Firehose Delivery Stream #5054

Closed
cwiggs opened this issue Jul 2, 2018 · 4 comments · Fixed by #5102
Closed

processing_configuration not available for AWS Splunk Firehose Delivery Stream #5054

cwiggs opened this issue Jul 2, 2018 · 4 comments · Fixed by #5102
Labels
documentation Introduces or discusses updates to documentation. service/kinesis Issues and PRs that pertain to the kinesis service.
Milestone

Comments

@cwiggs
Copy link

cwiggs commented Jul 2, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Should be able to define lambda transformer for Splunk destination the same way a processor can be defined for extended s3 destinations.

New or Affected Resource(s)

  • aws_kinesis_firehose_delivery_stream

Potential Terraform Configuration

resource "aws_kinesis_firehose_delivery_stream" "vpc_flow_logs" {
  name = "splunk_ingrestion_stream"
  destination = "splunk"

  s3_configuration {
    role_arn = "firehose-iam-role"
    bucket_arn = "arn:aws:s3:::bucket"
    prefix = "logs/logs"
    buffer_size = 10
    buffer_interval = 400
    compression_format = "GZIP"
  }

  splunk_configuration {
    hec_endpoint = "${var.hec_endpoint}"
    hec_token = "${var.hec_token}"
    hec_acknowledgment_timeout = 600
    hec_endpoint_type = "Event"
    s3_backup_mode = "FailedEventsOnly"
  }

  processing_configuration = [
    {
      enabled = "true"

      processors = [
        {
          type = "Lambda"

          parameters = [
            {
              parameter_name  = "LambdaArn"
              parameter_value = "${aws_lambda_function.transform.arn}:$LATEST"
            },
          ]
        },
      ]
    },
  ]

References

Same issue for elasticsearch: #2729

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/kinesis Issues and PRs that pertain to the kinesis service. labels Jul 4, 2018
@bflad
Copy link
Contributor

bflad commented Jul 4, 2018

Hi @cwiggs 👋 Sorry you're running into trouble here.

I am presuming this issue is a continuation of #3944 (comment), on the merged pull request that added the functionality requested here.

In that comment you mention:

I'm using the aws provider version 1.25 but i'm getting this error when I try to use the "processing_configuration" option under "splunk_configuration"

Error: module.kinesis-firehose.aws_kinesis_firehose_delivery_stream.vpc_flow_logs: : invalid or unknown key: processing_configuration

There's two possibilities that we can easily check:

  • Double check terraform -v to ensure your AWS provider is at least 1.14.0 as expected
  • Ensure that your processing_configuration is nested under splunk_configuration -- the configuration example above has it outside splunk_configuration

We explicitly acceptance test this functionality daily without issue, using this test configuration: https://github.com/terraform-providers/terraform-provider-aws/blob/867b227ca892f5d609cf721651a92e20e439b45c/aws/resource_aws_kinesis_firehose_delivery_stream_test.go#L1751-L1798

Please let us know, thanks.

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jul 4, 2018
@bflad bflad added this to the v1.14.0 milestone Jul 4, 2018
@cwiggs
Copy link
Author

cwiggs commented Jul 6, 2018

Hello @bflad!

moving the processing_configuration into the splunk_configuration block fixed the issue. I was a bit confused because the docs here don't show "processing_configuration" as an option under "splunk_configuration"

@bflad
Copy link
Contributor

bflad commented Jul 6, 2018

You are correct! Let me submit a fix to the documentation. Here we go: #5102

@bflad bflad added documentation Introduces or discusses updates to documentation. and removed enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. labels Jul 6, 2018
@bflad bflad modified the milestones: v1.14.0, v1.27.0 Jul 6, 2018
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/kinesis Issues and PRs that pertain to the kinesis service.
Projects
None yet
2 participants