PR #7454 Ignore AWS internals tags - RegEx matches all tags starting with aws not only aws: #531
Labels
bug
Addresses a defect in current functionality.
service/ec2
Issues and PRs that pertain to the ec2 service.
This issue was originally opened by @Dan1el42 as hashicorp/terraform#11939. It was migrated here as part of the provider split. The original body of the issue is below.
I've discovered at work that the
aws:
tags filter introduced with v0.7.11 is unfortunately, matching all tags starting withaws
because the regular expression is missing a dot before the greedy character.Issue
We're using an internally developed service called awsns that is responsible for the registration of DNS records in our internal DNS system. We want to be able to modify the behaviour of our service and with a tag named
awsns_optons
. At the moment our tag is being ignored during the creation of resources but displayed in the plan output due to an incorrect regex in the tagsIgnore functions.Fix
The fix is simple. Just replace the regular expression
aws:*
in all relevant files withaws:.*
to ensure we're still ignoringaws:xyz
tags but allow tags similar to ours to be created.I'm happy to submit a PR to fix it if you agree.
Affected resources
All AWS resources supporting tags
References
PR hashicorp/terraform#7454
Issue hashicorp/terraform#4513
The text was updated successfully, but these errors were encountered: