Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #7454 Ignore AWS internals tags - RegEx matches all tags starting with aws not only aws: #531

Closed
hashibot opened this issue Jun 13, 2017 · 2 comments
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.

Comments

@hashibot
Copy link

This issue was originally opened by @Dan1el42 as hashicorp/terraform#11939. It was migrated here as part of the provider split. The original body of the issue is below.


I've discovered at work that the aws: tags filter introduced with v0.7.11 is unfortunately, matching all tags starting with aws because the regular expression is missing a dot before the greedy character.

Issue

We're using an internally developed service called awsns that is responsible for the registration of DNS records in our internal DNS system. We want to be able to modify the behaviour of our service and with a tag named awsns_optons. At the moment our tag is being ignored during the creation of resources but displayed in the plan output due to an incorrect regex in the tagsIgnore functions.

Fix

The fix is simple. Just replace the regular expression aws:* in all relevant files with aws:.* to ensure we're still ignoring aws:xyz tags but allow tags similar to ours to be created.

I'm happy to submit a PR to fix it if you agree.

Affected resources

All AWS resources supporting tags

References

PR hashicorp/terraform#7454
Issue hashicorp/terraform#4513

@hashibot hashibot added the bug Addresses a defect in current functionality. label Jun 13, 2017
@andyspiers
Copy link

This was fixed by hashicorp/terraform#14321 and could be closed off

@radeksimko radeksimko added the service/ec2 Issues and PRs that pertain to the ec2 service. label Jan 25, 2018
@bflad bflad closed this as completed Jul 2, 2018
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

No branches or pull requests

4 participants