Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate aws_ami* Resource Schemas #5431

Closed
bflad opened this issue Aug 2, 2018 · 1 comment · Fixed by #5433
Closed

Duplicate aws_ami* Resource Schemas #5431

bflad opened this issue Aug 2, 2018 · 1 comment · Fixed by #5433
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Aug 2, 2018

Common schema functions are harder to understand and can cause regressions when attributes are changed. As part of some potential upcoming rework of aws_ami, aws_ami_from_instance, and aws_ami_copy resources, break out the "common" schema function into each of those resources for now.

@bflad bflad added service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Aug 2, 2018
@bflad bflad added this to the v1.31.0 milestone Aug 2, 2018
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
1 participant