Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to AWS Storage Gateway #5618

Closed
ghost opened this issue Aug 20, 2018 · 3 comments
Closed

Add tags to AWS Storage Gateway #5618

ghost opened this issue Aug 20, 2018 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service.
Milestone

Comments

@ghost
Copy link

ghost commented Aug 20, 2018

Description

Add the ability to use tags on AWS Storage Gateway resources.

New or Affected Resource(s)

aws_storagegateway_gateway

Potential Terraform Configuration

resource "aws_storagegateway_gateway" "hmsgw" {
  gateway_ip_address = "${var.gateway-ip-address}"
  gateway_name       = "${var.gateway-name}"
  gateway_timezone   = "${var.gateway-timezone}"
  gateway_type       = "${var.gateway-type}"

  smb_active_directory_settings {
    domain_name = "${var.domain-name}"
    username    = "${var.username}"
    password    = "${var.password}"
  }
  tags {
    AppName        = "${var.AppName}"
    AppRole        = "${var.AppRole}"
    Environment    = "${var.Environment}"
    Owner          = "${var.Owner}"
    DeptOwner      = "${var.DeptOwner}"
    Developer      = "${var.Developer}"
    WorkTeamLeader = "${var.WorkTeamLeader}"
    Billing        = "${var.Billing}"
    BillingDept    = "${var.BillingDept}"
    ShowBackDept   = "${var.ShowBackDept}"
  }
}

Currently unavailable Eror: aws_storagegateway_gateway: invalid or unknown key: tags
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Aug 20, 2018
@bflad bflad added this to the v2.35.0 milestone Nov 4, 2019
@bflad
Copy link
Contributor

bflad commented Nov 4, 2019

Support for tagging Storage Gateway resources has been merged and will release with version 2.35.0 of the Terraform AWS Provider, Thursday. Thanks to @DrFaust92 for the implementation work here. 👍

@bflad bflad closed this as completed Nov 4, 2019
@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service.
Projects
None yet
Development

No branches or pull requests

1 participant