aws_cloudwatch_metric_alarm does not validate input on alarm_actions

[ghost]

This issue was originally opened by @sprutner as hashicorp/terraform#19015. It was migrated here as a result of the provider split. The original body of the issue is below.

---

Terraform Version

0.11.8

Terraform Configuration Files

resource "aws_cloudwatch_metric_alarm" "down-blue" {
  alarm_name          = "${var.blue_asg_name}-High-CPU-Utilization-LT-10"
  comparison_operator = "LessThanThreshold"
  evaluation_periods  = "${var.scale_down_evaluation_periods}"
  metric_name         = "${var.scaling_metric}"
  namespace           = "AWS/EC2"
  period              = "${var.scale_down_evaluation_period}"
  statistic           = "Average"
  threshold           = "${var.scale_down_threshold}"

  dimensions {
    AutoScalingGroupName = "${var.blue_asg_name}"
  }

  alarm_description = "This metric monitors ec2 cpu utilization"
  **alarm_actions     = ["${aws_autoscaling_policy.down-blue.name}"]**
}

Expected Behavior

Actual Behavior

Steps to Reproduce

1. Simply put an autoscaling group name in alarm_actions instead of an ARN.

Additional Context

This should be an easy fix if you just use a regex or something to check if it's an ARN being passed in.

[tkbky]

I've made a PR for this.

[bflad]

The ARN validation has been merged and will release in version 1.41.0 of the AWS provider, likely middle of this week. 👍

[bflad]

This has been released in version 1.41.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!