r/aws_dx_private_virtual_interface: Error running parallel acceptance tests

[ewbankkit]

Discovered while testing #6141:

$ DX_CONNECTION_ID=dxcon-xxxxxxxx AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAwsDxPrivateVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsDxPrivateVirtualInterface_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsDxPrivateVirtualInterface_basic
=== PAUSE TestAccAwsDxPrivateVirtualInterface_basic
=== RUN   TestAccAwsDxPrivateVirtualInterface_dxGateway
=== PAUSE TestAccAwsDxPrivateVirtualInterface_dxGateway
=== RUN   TestAccAwsDxPrivateVirtualInterface_mtuUpdate
--- PASS: TestAccAwsDxPrivateVirtualInterface_mtuUpdate (1053.03s)
=== CONT  TestAccAwsDxPrivateVirtualInterface_basic
=== CONT  TestAccAwsDxPrivateVirtualInterface_dxGateway
--- FAIL: TestAccAwsDxPrivateVirtualInterface_dxGateway (29.78s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_dx_private_virtual_interface.foo: 1 error occurred:
        	* aws_dx_private_virtual_interface.foo: Error creating Direct Connect private virtual interface: DirectConnectClientException: Vlan 4094 is already in use
        	status code: 400, request id: 86051c8b-d6d5-11e8-b3f8-99e875bb6fe2
        
        
        
        
--- PASS: TestAccAwsDxPrivateVirtualInterface_basic (672.23s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	1726.117s
make: *** [testacc] Error 1

[ewbankkit]

Need to randomize the VLAN which is hard-coded to 4094 today.

[ewbankkit]

This will also need to be applied to the other DX VIF resource tests:

• aws_dx_hosted_private_virtual_interface
• aws_dx_hosted_public_virtual_interface
• aws_dx_public_virtual_interface

[ewbankkit]

I suggest waiting for #6141 and #6142 to land before fixing this as additional relevant test cases were added in those two PRs.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!