Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glue Crawler role accepts ARN but returns plan difference #6292

Closed
bflad opened this issue Oct 28, 2018 · 4 comments · Fixed by #6293
Closed

Glue Crawler role accepts ARN but returns plan difference #6292

bflad opened this issue Oct 28, 2018 · 4 comments · Fixed by #6293
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Oct 28, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

  • terraform v0.11.10
  • terraform-provider-aws v1.41.0

Affected Resource(s)

  • aws_glue_crawler

Terraform Configuration Files

resource "aws_glue_crawler" "test" {
  # ... other configuration ...

  role = "${aws_iam_role.test.arn}"
}

Debug Output

--- FAIL: TestAccAWSGlueCrawler_DynamodbTarget (18.09s)
    testing.go:538: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        UPDATE: aws_glue_crawler.test
          role: "tf-acc-test-5817417459117994664" => "arn:aws:iam::187416307283:role/tf-acc-test-5817417459117994664"

Expected Behavior

Terraform should report no difference in the attribute.

Actual Behavior

Terraform reports a difference in the attribute.

Steps to Reproduce

Reproducible via acceptance testing update and run:

  1. Change .name to .arn at https://github.com/terraform-providers/terraform-provider-aws/blob/5aaf64f80342d36f55185b778a372bf50175813d/aws/resource_aws_glue_crawler_test.go#L926
  2. make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCrawler_DynamodbTarget'

References

@bflad bflad added bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. labels Oct 28, 2018
@bflad
Copy link
Contributor Author

bflad commented Oct 28, 2018

Pull request submitted: #6293

@bflad bflad added this to the v1.42.0 milestone Oct 30, 2018
@bflad
Copy link
Contributor Author

bflad commented Oct 30, 2018

The fix for this has been merged into master and will release with version 1.42.0 of the AWS provider, likely today or tomorrow.

@bflad
Copy link
Contributor Author

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant