Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Gateway basePath import options for OpenAPI #7374

Merged
merged 9 commits into from
Jan 12, 2021
Merged

API Gateway basePath import options for OpenAPI #7374

merged 9 commits into from
Jan 12, 2021

Conversation

dooreelko
Copy link
Contributor

Fixes #4402

Changes proposed in this pull request:

  • New parameter on aws_api_gateway_rest_api resource
  • Tests for the 3 modes
  • Docs about the parameter

Output from acceptance testing:
did not run, sorry Is there a way to run it without actually creating resources? Let's talk :)

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'
...

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 29, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 12, 2019
@djweinheimer
Copy link

@dooreelko, any movement on this PR? We could use this fix for importing our OpenAPI docs into API Gateway.

@dooreelko
Copy link
Contributor Author

@djweinheimer i wish to see it merged too. do you think i missed something in the submission? (well, except it diverged and has merge conflicts now).
it's either something's missing in the PR or Hashicorp is too busy with other things...

@djweinheimer
Copy link

@dooreelko , maybe add @bflad as a reviewer

@djweinheimer
Copy link

This would be great to have because we are using terraform to provision our API Gateway and have to set the api version in every uri path.

@dooreelko
Copy link
Contributor Author

@djweinheimer, i don't seem to have rights to add @bflad as a reviewer. he did change some tags on the PR, though, I guess it's just a low priority :(

@aeschright aeschright requested a review from a team June 25, 2019 22:10
Sascha (Oleksandr) Fedorenko added 3 commits January 20, 2020 10:54
Merge remote-tracking branch 'upstream/master' into body_base_path
4caa9aa 
# Conflicts:
#	README.md
#	aws/resource_aws_api_gateway_rest_api_test.go
#	website/docs/r/api_gateway_rest_api.html.markdown
Merge branch 'body_base_path' of https://github.com/dooreelko/terrafo…
29f6849 
…rm-provider-aws into body_base_path
fixing merge problem
31319f1
@hijakebye
Copy link

Desperately need this capability! What's the status on this? doesn't look like it's been merged yet

@dooreelko
Copy link
Contributor Author

I wish I knew how I could speed this up
¯_(ツ)_/¯

@bflad
Copy link
Contributor

bflad commented Jan 12, 2021

Hi @dooreelko 👋 Thank you for submitting this and apologies for the delayed review. We typically use the number of 👍 reactions to help prioritize pull requests, but we have been shorthanded to follow an alternate path to catch pull requests that have been lingering. The team will be implementing that additional process this year.

In this case, we would prefer to follow the PutRestApi API and CloudFormation lead of just accepting a map of strings named parameters. This leaves it generic should other parameter keys be accepted, such as ignore=documentation.

What I'll do in this case is refactor the implementation into functionality, on top of your commits, so you still get contribution credit. 👍

@bflad bflad requested a review from a team as a code owner January 12, 2021 21:16
@bflad bflad added this to the v3.24.0 milestone Jan 12, 2021
@bflad bflad merged commit 6486e93 into hashicorp:master Jan 12, 2021
bflad added a commit that referenced this pull request Jan 12, 2021
@bflad
Update CHANGELOG for #7374
737d1e1
@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.24.0
Development

Successfully merging this pull request may close these issues.

AWS integration with Swagger does not seem to consider basePath
4 participants
@dooreelko @djweinheimer @hijakebye @bflad