-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Gateway basePath import options for OpenAPI #7374
Conversation
@dooreelko, any movement on this PR? We could use this fix for importing our OpenAPI docs into API Gateway. |
@djweinheimer i wish to see it merged too. do you think i missed something in the submission? (well, except it diverged and has merge conflicts now). |
@dooreelko , maybe add @bflad as a reviewer |
This would be great to have because we are using terraform to provision our API Gateway and have to set the api version in every uri path. |
@djweinheimer, i don't seem to have rights to add @bflad as a reviewer. he did change some tags on the PR, though, I guess it's just a low priority :( |
# Conflicts: # README.md # aws/resource_aws_api_gateway_rest_api_test.go # website/docs/r/api_gateway_rest_api.html.markdown
Desperately need this capability! What's the status on this? doesn't look like it's been merged yet |
I wish I knew how I could speed this up |
Hi @dooreelko 👋 Thank you for submitting this and apologies for the delayed review. We typically use the number of 👍 reactions to help prioritize pull requests, but we have been shorthanded to follow an alternate path to catch pull requests that have been lingering. The team will be implementing that additional process this year. In this case, we would prefer to follow the What I'll do in this case is refactor the implementation into functionality, on top of your commits, so you still get contribution credit. 👍 |
This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #4402
Changes proposed in this pull request:
aws_api_gateway_rest_api
resourceOutput from acceptance testing:
did not run, sorry Is there a way to run it without actually creating resources? Let's talk :)