Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws eks private link support #8022

Closed
stijndehaes opened this issue Mar 20, 2019 · 7 comments · Fixed by #8024
Closed

aws eks private link support #8022

stijndehaes opened this issue Mar 20, 2019 · 7 comments · Fixed by #8024
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.
Milestone

Comments

@stijndehaes
Copy link
Contributor

stijndehaes commented Mar 20, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Private link support to eks got added very recently see following issue.

I would like to configure this from terraform.

New or Affected Resource(s)

  • resource_aws_eks_cluster

Potential Terraform Configuration

I would add this to the vpc config of the aws_eks_resource something like:

resource "aws_eks_cluster" "this" {
  name     = "${var.cluster_name}"
  role_arn = "${aws_iam_role.cluster.arn}"
  version  = "${var.cluster_version}"

  vpc_config {
    security_group_ids = ["${local.cluster_security_group_id}"]
    subnet_ids         = ["${var.subnets}"]
    private_access = true
    public_access = true
  }

  timeouts {
    create = "${var.cluster_create_timeout}"
    delete = "${var.cluster_delete_timeout}"
  }

}

References

@stijndehaes stijndehaes added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 20, 2019
@bflad bflad added the service/eks Issues and PRs that pertain to the eks service. label Mar 20, 2019
@bflad
Copy link
Contributor

bflad commented Mar 20, 2019

Work in progress pull request can be found here: #8024

@ewbankkit
Copy link
Contributor

@bflad bflad added this to the v2.3.0 milestone Mar 20, 2019
@bflad
Copy link
Contributor

bflad commented Mar 20, 2019

Support for managing the EKS Cluster endpoint access has been merged and will release with version 2.3.0 of the Terraform AWS Provider, likely in the next day or two.

@paulkendobnc
Copy link

Wonderful! Just what i need right now.

@stephenmuss
Copy link

That was fast. Looking forward to this. Thanks!

@bflad
Copy link
Contributor

bflad commented Mar 21, 2019

This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants