Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend LB Listener Rule Condition Support #9360

Closed
stack72 opened this issue Jul 16, 2019 · 4 comments
Closed

Extend LB Listener Rule Condition Support #9360

stack72 opened this issue Jul 16, 2019 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope.

Comments

@stack72
Copy link
Contributor

stack72 commented Jul 16, 2019

The lb_listener_rule condition needs to have extensions that allow not just host-header and path-pattern conditions.

It needs to be able to support:

  • http-header
  • http-request-method
  • query-string
  • source-ip

Each of these new condition types have their struct in the AWS SDK, therefore the schema will need to adapt to allow them - this will more than likely mean a state migration due to condition being schema.TypeSet

@stack72 stack72 added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 16, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 16, 2019
@ewbankkit
Copy link
Contributor

I THINK (not 100% positive, please check PR) that this is being addressed in #8126, #8268.

@stack72
Copy link
Contributor Author

stack72 commented Jul 16, 2019

Duplicate of #8126

@stack72 stack72 closed this as completed Jul 16, 2019
@stack72
Copy link
Contributor Author

stack72 commented Jul 16, 2019

Thanks for that @ewbankkit :)

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

No branches or pull requests

3 participants