Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When Lambda function name change, alias must be replace #11170

Merged
merged 1 commit into from
Mar 16, 2020
Merged

When Lambda function name change, alias must be replace #11170

merged 1 commit into from
Mar 16, 2020

Conversation

eservent
Copy link
Contributor

@eservent eservent commented Dec 6, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10298

Release note for CHANGELOG:

BUG FIXES:
- resource/aws_lambda_alias: Force new resource on function_name change (#10298)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. labels Dec 6, 2019
@bflad
Copy link
Contributor

bflad commented Feb 20, 2020

Hi @eservent 👋 This change looks correct for this bug. Is there any reason this is a draft pull request?

@bflad bflad added bug Addresses a defect in current functionality. waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 20, 2020
@bflad bflad self-assigned this Feb 20, 2020
@harryw
Copy link

harryw commented Mar 9, 2020

Hi @eservent, and @bflad. Thanks for the work on this so far. It would be really nice to see this fix make it into a release - this bug is a real pain for me right now.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 9, 2020
@harryw harryw mentioned this pull request Mar 12, 2020
Closed
@bflad
Copy link
Contributor

bflad commented Mar 16, 2020

Hi @eservent 👋 Since we haven't heard back from you and the fix appears to be correct in this case, we are going to go ahead and mark the pull request ready and merge it.

@bflad bflad marked this pull request as ready for review March 16, 2020 20:08
@bflad bflad requested a review from a team March 16, 2020 20:08
@bflad bflad added this to the v2.54.0 milestone Mar 16, 2020
bflad
bflad approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bflad bflad merged commit 7c7a9fb into hashicorp:master Mar 16, 2020
bflad added a commit that referenced this pull request Mar 16, 2020
@bflad
Update CHANGELOG for #11170
d63943e
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.54.0
Development

Successfully merging this pull request may close these issues.

aws_lambda_alias try and fail being updated in line when Lambda function name is changed
3 participants
@eservent @bflad @harryw