Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_elasticache_replication_group - Add ReaderEndpoint attribute #11513

Closed
wants to merge 1 commit into from
Closed

resource/aws_elasticache_replication_group - Add ReaderEndpoint attribute #11513

wants to merge 1 commit into from

Conversation

commarla
Copy link
Contributor

@commarla commarla commented Jan 7, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

@commarla commarla requested a review from a team January 7, 2020 16:20
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/elasticache Issues and PRs that pertain to the elasticache service. documentation Introduces or discusses updates to documentation. labels Jan 7, 2020
@commarla commarla changed the title Add ReaderEndpoint attributes to elasticache_replication_group Add ReaderEndpoint attribute to elasticache_replication_group Jan 7, 2020
@commarla commarla force-pushed the replication-group-reader-endpoint branch from 4359ce4 to 6c6a8ad Compare January 8, 2020 08:41
@commarla commarla changed the title Add ReaderEndpoint attribute to elasticache_replication_group resource/aws_elasticache_replication_group - Add ReaderEndpoint attribute Jan 8, 2020
@alexjurkiewicz
Copy link
Contributor

This is a tiny improvement that would make my life much easier! Please consider it for an upcoming release 🙏 .

@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 24, 2020
@anGie44 anGie44 linked an issue Aug 24, 2020 that may be closed by this pull request
Reader endpoint in aws_elasticache_replication_group #10519
Closed
@alexjurkiewicz alexjurkiewicz mentioned this pull request Nov 6, 2020
Closed
@gdavison
Copy link
Contributor

gdavison commented Jan 5, 2021

Thanks for the PR, @commarla. We've merged #9979, which also supports the data source

@gdavison gdavison closed this Jan 5, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reader endpoint in aws_elasticache_replication_group
4 participants
@commarla @alexjurkiewicz @gdavison @anGie44