Service Catalog Provisioned Product and related resources #13797
Conversation
…t-and-pp fix trivial conflicts where master has changed how resources are listed (in website and in aws/provider), to reference servicecatalog_product in the right way also revert the mode change against the servicecatalog_portfolio markdown
only pulling in the relevant provisioned-product changes
* create needs to block for completion, then the test (as written) will work in our account * then we need product_portfolio_association and make the test work in any account (create a product, not hard-coded) * then other TODOs marked in code
* master: (79 commits) Update CHANGELOG for hashicorp#8457 resource/aws_ec2_tag: Finish implementation CodeArtifact new service support (hashicorp#13735) internal/keyvaluetags: Support servicediscovery and worklink (hashicorp#13732) tests/provider: Remove TravisCI (hashicorp#13730) update method params in web_acl test check Update CHANGELOG for hashicorp#12688 Fix rebase change Fix docs Improve error message Apply review comments Refactor after rebase Apply review comments Apply changes based on review Format test config Fix failing build Add calculated wcus attribute Add documentation Add rule_group_reference_statement Add rate_based_statement ...
Match the same method used in other places within the provider to create idempotency tokens.
…io-product-association
…servicecatalog-provisioned-product-and-friends
…f-servicecatalog-provisioned-product-and-friends
…isioned-product-and-friends
|
This has been updated as per the 18 Aug notification to use the v2 sdk and remove |
|
The This PR is subsumed by #14281 where |
|
Retest this please |
|
Closed and reopened to trigger re-testing as previous failure appeared to be unrelated. |
|
@ahgittin Thank you for your work on this PR! I will be working on this before long. In order to expedite the process, I will likely make some changes. Make sure that you have checked the box "Allow edits from maintainers." (Don't worry though, you will receive all credit for your contribution and code!) Also, please coordinate with us before making any commits to this branch. Again, thank you for your help and we look forward to this popular addition to the AWS provider! |
|
@ahgittin @cloudsoft Thank you very much for all your work on this PR! I'm excited to work with you on this. However, in order to work with this PR, I need two things:
Since we look forward to adding this feature to the AWS Provider, we need you to make these changes by March 11, 2021. If you are unable to do this, we understand and thank you for your work. However, we will not be able to use this contribution. |
YakDriver
added
the
waiting-response
|
Replaced by #18074 |
ghost
removed
the
waiting-response
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
This PR adds four resources:
servicecatalog_portfolio_principal_associationresource_aws_servicecatalog_portfolio_product_associationresource_aws_servicecatalog_productresource_aws_servicecatalog_provisioned_productOur goal was just to add
provisioned_product-- so that Terraform can provision things from the AWS Service Catalog.However in order to have a test which runs and doesn't require custom AWS setup, we needed
portfolio(which existed and worked well),product(where most of the work was already done in #4980, included here with minor fixes) , and the twoporfolio-{principal,product}-associations(because in order to provision a product, it must be associated to a portfolio, and the portfolio must be associated to a principal).Thus please forgive the size of this PR. And we are new contributors to this codebase so please also forgive any deviations from best practices!
This has tests for each -- the test for product creates all the pre-req objects noted above and then successfully provisions the product. We also have the markdown documentation for each. If there is anything we've omitted let us know.
We have time blocked out this week and next to correct/improve anything y'all spot.
We also intend to add the remaining Service Catalog resources (8 left) as we use quite a few of them.
We'll do this in a follow-on PR. So any tips are welcome, even things that aren't necessary to address in this PR.
Thanks.