Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Elasticsearch domain in a VPC #14973

Closed

Conversation

johndavies91
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@johndavies91 johndavies91 requested a review from a team September 2, 2020 12:48
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/firehose Issues and PRs that pertain to the firehose service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Sep 2, 2020
@ewbankkit
Copy link
Contributor

@johndavies91 Thank you for the contribution.
This functionality has been implemented in #13269 (closing #13015) and was just merged a couple of days ago. It will release with version 3.5.0 of the Terraform AWS Provider, later this week.
I am going to close this PR as a duplicate.
If the new functionality does not meet your use case please open a new issue.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 2, 2020
@ewbankkit ewbankkit closed this Sep 2, 2020
@johnkeates
Copy link

Very cool to see this get picket up fast! We'll be using it as soon as it's released so if it doesn't work as intended we'll know relatively quickly.

@ghost
Copy link

ghost commented Oct 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/firehose Issues and PRs that pertain to the firehose service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants