From a554f5d0b43310924c8f697ebf7c20ee9a8ed31c Mon Sep 17 00:00:00 2001 From: Simon Davis Date: Tue, 27 Oct 2020 10:58:08 -0700 Subject: [PATCH 1/7] search replace to move links to new org --- .github/CODEOWNERS | 54 +- .github/ISSUE_TEMPLATE/config.yml | 2 +- .github/PULL_REQUEST_TEMPLATE.md | 4 +- .github/workflows/changelog.yml | 2 +- .github/workflows/dependencies.yml | 4 +- .github/workflows/team_slack_bot.yml | 2 +- .hashibot.hcl | 2 +- CHANGELOG.md | 830 +++++++++--------- GNUmakefile | 2 +- aws/data_source_aws_instance.go | 4 +- aws/data_source_aws_route53_resolver_rule.go | 2 +- aws/resource_aws_acm_certificate_test.go | 6 +- ...resource_aws_ami_launch_permission_test.go | 2 +- ...ce_aws_api_gateway_method_settings_test.go | 4 +- aws/resource_aws_api_gateway_stage_test.go | 2 +- ...esource_aws_api_gateway_usage_plan_test.go | 2 +- ...resource_aws_appautoscaling_policy_test.go | 2 +- aws/resource_aws_autoscaling_group_test.go | 4 +- aws/resource_aws_batch_job_queue_test.go | 2 +- ...ource_aws_cloudformation_stack_set_test.go | 2 +- ...source_aws_cloudfront_distribution_test.go | 4 +- aws/resource_aws_cognito_user_pool_test.go | 2 +- ...resource_aws_datasync_location_smb_test.go | 2 +- aws/resource_aws_db_instance_test.go | 6 +- aws/resource_aws_db_option_group_test.go | 4 +- ...esource_aws_default_security_group_test.go | 2 +- aws/resource_aws_dynamodb_table_test.go | 6 +- aws/resource_aws_ebs_volume.go | 2 +- aws/resource_aws_ebs_volume_test.go | 2 +- aws/resource_aws_ec2_fleet_test.go | 2 +- aws/resource_aws_ecs_service_test.go | 4 +- aws/resource_aws_ecs_task_definition_test.go | 2 +- aws/resource_aws_efs_mount_target_test.go | 2 +- aws/resource_aws_eip_test.go | 2 +- aws/resource_aws_eks_fargate_profile_test.go | 2 +- ...urce_aws_elastic_transcoder_preset_test.go | 4 +- ...ce_aws_elasticache_parameter_group_test.go | 2 +- aws/resource_aws_elasticsearch_domain_test.go | 2 +- aws/resource_aws_elb_test.go | 2 +- aws/resource_aws_emr_instance_group_test.go | 4 +- aws/resource_aws_glue_catalog_table_test.go | 6 +- ...source_aws_iam_service_linked_role_test.go | 2 +- aws/resource_aws_instance.go | 10 +- aws/resource_aws_instance_test.go | 30 +- 44 files changed, 520 insertions(+), 520 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 589d0de6ef0..a38ee507194 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,42 +1,42 @@ # Default owner for all pull requests -* @terraform-providers/aws-provider +* @hashicorp/aws-provider # Service specific owners -/aws/*apigatewayv2* @ewbankkit @terraform-providers/aws-provider -/website/**/apigatewayv2* @ewbankkit @terraform-providers/aws-provider +/aws/*apigatewayv2* @ewbankkit @hashicorp/aws-provider +/website/**/apigatewayv2* @ewbankkit @hashicorp/aws-provider -/aws/*appmesh* @ewbankkit @terraform-providers/aws-provider -/website/**/appmesh* @ewbankkit @terraform-providers/aws-provider +/aws/*appmesh* @ewbankkit @hashicorp/aws-provider +/website/**/appmesh* @ewbankkit @hashicorp/aws-provider -/aws/*backup* @ewbankkit @terraform-providers/aws-provider -/website/**/backup* @ewbankkit @terraform-providers/aws-provider +/aws/*backup* @ewbankkit @hashicorp/aws-provider +/website/**/backup* @ewbankkit @hashicorp/aws-provider -/aws/*_aws_codeartifact_*.go @DrFaust92 @terraform-providers/aws-provider -/website/**/codeartifact* @DrFaust92 @terraform-providers/aws-provider +/aws/*_aws_codeartifact_*.go @DrFaust92 @hashicorp/aws-provider +/website/**/codeartifact* @DrFaust92 @hashicorp/aws-provider -/aws/*_aws_fsx_*.go @DrFaust92 @terraform-providers/aws-provider -/website/**/fsx* @DrFaust92 @terraform-providers/aws-provider +/aws/*_aws_fsx_*.go @DrFaust92 @hashicorp/aws-provider +/website/**/fsx* @DrFaust92 @hashicorp/aws-provider -/aws/*globalaccelerator* @ewbankkit @terraform-providers/aws-provider -/website/**/globalaccelerator* @ewbankkit @terraform-providers/aws-provider +/aws/*globalaccelerator* @ewbankkit @hashicorp/aws-provider +/website/**/globalaccelerator* @ewbankkit @hashicorp/aws-provider -/aws/*_aws_glue_*.go @DrFaust92 @terraform-providers/aws-provider -/website/**/glue* @DrFaust92 @terraform-providers/aws-provider +/aws/*_aws_glue_*.go @DrFaust92 @hashicorp/aws-provider +/website/**/glue* @DrFaust92 @hashicorp/aws-provider -/aws/*kinesis_analytics* @ewbankkit @terraform-providers/aws-provider -/website/**/kinesis_analytics* @ewbankkit @terraform-providers/aws-provider +/aws/*kinesis_analytics* @ewbankkit @hashicorp/aws-provider +/website/**/kinesis_analytics* @ewbankkit @hashicorp/aws-provider -/aws/*kinesisanalyticsv2* @ewbankkit @terraform-providers/aws-provider -/website/**/kinesisanalyticsv2* @ewbankkit @terraform-providers/aws-provider +/aws/*kinesisanalyticsv2* @ewbankkit @hashicorp/aws-provider +/website/**/kinesisanalyticsv2* @ewbankkit @hashicorp/aws-provider -/aws/*route53_resolver* @ewbankkit @terraform-providers/aws-provider -/website/**/route53_resolver* @ewbankkit @terraform-providers/aws-provider +/aws/*route53_resolver* @ewbankkit @hashicorp/aws-provider +/website/**/route53_resolver* @ewbankkit @hashicorp/aws-provider -/aws/*_aws_storagegateway_*.go @DrFaust92 @terraform-providers/aws-provider -/website/**/storagegateway* @DrFaust92 @terraform-providers/aws-provider +/aws/*_aws_storagegateway_*.go @DrFaust92 @hashicorp/aws-provider +/website/**/storagegateway* @DrFaust92 @hashicorp/aws-provider -/aws/*_aws_sagemaker_*.go @DrFaust92 @terraform-providers/aws-provider -/website/**/sagemaker* @DrFaust92 @terraform-providers/aws-provider +/aws/*_aws_sagemaker_*.go @DrFaust92 @hashicorp/aws-provider +/website/**/sagemaker* @DrFaust92 @hashicorp/aws-provider -/aws/*_aws_workspaces_*.go @Tensho @terraform-providers/aws-provider -/website/**/workspaces* @Tensho @terraform-providers/aws-provider +/aws/*_aws_workspaces_*.go @Tensho @hashicorp/aws-provider +/website/**/workspaces* @Tensho @hashicorp/aws-provider diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 0887344cefa..5e0c5be97c5 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,7 +1,7 @@ blank_issues_enabled: false contact_links: - name: Terraform AWS Provider Roadmap - url: https://github.com/terraform-providers/terraform-provider-aws/blob/master/ROADMAP.md + url: https://github.com/hashicorp/terraform-provider-aws/blob/master/ROADMAP.md about: View the Roadmap for the upcoming work planned on the AWS provider. - name: Terraform AWS Provider Questions url: https://discuss.hashicorp.com/c/terraform-providers/tf-aws diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2d7f686e259..14938b37499 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ - + @@ -12,7 +12,7 @@ Relates OR Closes #0000 -Release note for [CHANGELOG](https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md): +Release note for [CHANGELOG](https://github.com/hashicorp/terraform-provider-aws/blob/master/CHANGELOG.md): diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml index 9c936197c2f..6efd1ac737e 100644 --- a/.github/workflows/changelog.yml +++ b/.github/workflows/changelog.yml @@ -51,7 +51,7 @@ jobs: body: |- Thank you for your contribution! :rocket: - Please note that the `CHANGELOG.md` file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the [Contributing Guide](https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/CONTRIBUTING.md) for additional pull request review items. + Please note that the `CHANGELOG.md` file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the [Contributing Guide](https://github.com/hashicorp/terraform-provider-aws/blob/master/docs/CONTRIBUTING.md) for additional pull request review items. Remove any changes to the `CHANGELOG.md` file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request. misspell: diff --git a/.github/workflows/dependencies.yml b/.github/workflows/dependencies.yml index 52c85117af3..a61dfa20d04 100644 --- a/.github/workflows/dependencies.yml +++ b/.github/workflows/dependencies.yml @@ -54,10 +54,10 @@ jobs: Additional details: - * Check [open pull requests with the `dependencies` label](https://github.com/terraform-providers/terraform-provider-aws/pulls?q=is%3Aopen+is%3Apr+label%3Adependencies) to view other dependency updates. + * Check [open pull requests with the `dependencies` label](https://github.com/hashicorp/terraform-provider-aws/pulls?q=is%3Aopen+is%3Apr+label%3Adependencies) to view other dependency updates. * If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed. * If this pull request is for supporting a new AWS service: - * Ensure the new AWS service changes are following the [Contributing Guide section on new services](https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/contribution-checklists.md#new-service), in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split. + * Ensure the new AWS service changes are following the [Contributing Guide section on new services](https://github.com/hashicorp/terraform-provider-aws/blob/master/docs/contributing/contribution-checklists.md#new-service), in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split. * If this pull request is already a separate pull request from the above item, you can ignore this message. go_mod: name: go mod diff --git a/.github/workflows/team_slack_bot.yml b/.github/workflows/team_slack_bot.yml index 14937271a82..8d150e8034e 100644 --- a/.github/workflows/team_slack_bot.yml +++ b/.github/workflows/team_slack_bot.yml @@ -13,7 +13,7 @@ jobs: uses: breathingdust/github-team-slackbot@v17 with: github_token: ${{ secrets.GITHUB_ACTIONS_TOKEN}} - org: terraform-providers + org: hashicorp repo: terraform-provider-aws team_slug: aws-provider slack_token: ${{ secrets.SLACK_BOT_TOKEN }} diff --git a/.hashibot.hcl b/.hashibot.hcl index e61481f1b12..1c6ff6053dc 100644 --- a/.hashibot.hcl +++ b/.hashibot.hcl @@ -76,7 +76,7 @@ queued_behavior "release_commenter" "releases" { message = <<-EOF This has been released in [version ${var.release_version} of the Terraform AWS provider](${var.changelog_link}). Please see the [Terraform documentation on provider versioning](https://www.terraform.io/docs/configuration/providers.html#provider-versions) or reach out if you need any assistance upgrading. - For further feature requests or bug reports with this functionality, please create a [new GitHub issue](https://github.com/terraform-providers/terraform-provider-aws/issues/new/choose) following the template for triage. Thanks! + For further feature requests or bug reports with this functionality, please create a [new GitHub issue](https://github.com/hashicorp/terraform-provider-aws/issues/new/choose) following the template for triage. Thanks! EOF } diff --git a/CHANGELOG.md b/CHANGELOG.md index 522c687a40b..6dc986ddab7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -98,453 +98,453 @@ BUG FIXES FEATURES -* **New Data Source:** `aws_rds_certificate` ([#15789](https://github.com/terraform-providers/terraform-provider-aws/issues/15789)) -* **New Resource:** `aws_autoscalingplans_scaling_plan` ([#8965](https://github.com/terraform-providers/terraform-provider-aws/issues/8965)) -* **New Resource:** `aws_cloudwatch_event_bus` ([#10256](https://github.com/terraform-providers/terraform-provider-aws/issues/10256)) -* **New Resource:** `aws_kinesisanalyticsv2_application` ([#11652](https://github.com/terraform-providers/terraform-provider-aws/issues/11652)) -* **New Resource:** `aws_storagegateway_stored_iscsi_volume` ([#12027](https://github.com/terraform-providers/terraform-provider-aws/issues/12027)) +* **New Data Source:** `aws_rds_certificate` ([#15789](https://github.com/hashicorp/terraform-provider-aws/issues/15789)) +* **New Resource:** `aws_autoscalingplans_scaling_plan` ([#8965](https://github.com/hashicorp/terraform-provider-aws/issues/8965)) +* **New Resource:** `aws_cloudwatch_event_bus` ([#10256](https://github.com/hashicorp/terraform-provider-aws/issues/10256)) +* **New Resource:** `aws_kinesisanalyticsv2_application` ([#11652](https://github.com/hashicorp/terraform-provider-aws/issues/11652)) +* **New Resource:** `aws_storagegateway_stored_iscsi_volume` ([#12027](https://github.com/hashicorp/terraform-provider-aws/issues/12027)) ENHANCEMENTS -* resource/aws_cloudwatch_event_target: Add validation to `input_transformer.input_paths` map ([#15669](https://github.com/terraform-providers/terraform-provider-aws/issues/15669)) -* resource/aws_codeartifact_repository - support external connections ([#15569](https://github.com/terraform-providers/terraform-provider-aws/issues/15569)) -* resource/aws_fsx_lustre_file_system: Add `copy_tags_to_backups` support ([#15687](https://github.com/terraform-providers/terraform-provider-aws/issues/15687)) -* resource/aws_fsx_lustre_file_system: Increased maximum `automatic_backup_retention_days` from 35 to 90 ([#15641](https://github.com/terraform-providers/terraform-provider-aws/issues/15641)) -* resource/aws_fsx_windows_file_system: Increased maximum `automatic_backup_retention_days` from 35 to 90 ([#15641](https://github.com/terraform-providers/terraform-provider-aws/issues/15641)) -* resource/aws_glue_catalog_table: add validation checks for resource properties ([#12523](https://github.com/terraform-providers/terraform-provider-aws/issues/12523)) -* resource/aws_network_interface: Add `ipv6_addresses` and `ipv6_address_count` arguments ([#12281](https://github.com/terraform-providers/terraform-provider-aws/issues/12281)) -* resource/aws_sagemaker_notebook_instance: `lifecycle_config_name` and `root_access` are updateable. ([#15385](https://github.com/terraform-providers/terraform-provider-aws/issues/15385)) -* resource/aws_sagemaker_notebook_instance: plan time validation for `role_arn`, `instance_type`. ([#15385](https://github.com/terraform-providers/terraform-provider-aws/issues/15385)) +* resource/aws_cloudwatch_event_target: Add validation to `input_transformer.input_paths` map ([#15669](https://github.com/hashicorp/terraform-provider-aws/issues/15669)) +* resource/aws_codeartifact_repository - support external connections ([#15569](https://github.com/hashicorp/terraform-provider-aws/issues/15569)) +* resource/aws_fsx_lustre_file_system: Add `copy_tags_to_backups` support ([#15687](https://github.com/hashicorp/terraform-provider-aws/issues/15687)) +* resource/aws_fsx_lustre_file_system: Increased maximum `automatic_backup_retention_days` from 35 to 90 ([#15641](https://github.com/hashicorp/terraform-provider-aws/issues/15641)) +* resource/aws_fsx_windows_file_system: Increased maximum `automatic_backup_retention_days` from 35 to 90 ([#15641](https://github.com/hashicorp/terraform-provider-aws/issues/15641)) +* resource/aws_glue_catalog_table: add validation checks for resource properties ([#12523](https://github.com/hashicorp/terraform-provider-aws/issues/12523)) +* resource/aws_network_interface: Add `ipv6_addresses` and `ipv6_address_count` arguments ([#12281](https://github.com/hashicorp/terraform-provider-aws/issues/12281)) +* resource/aws_sagemaker_notebook_instance: `lifecycle_config_name` and `root_access` are updateable. ([#15385](https://github.com/hashicorp/terraform-provider-aws/issues/15385)) +* resource/aws_sagemaker_notebook_instance: plan time validation for `role_arn`, `instance_type`. ([#15385](https://github.com/hashicorp/terraform-provider-aws/issues/15385)) BUGFIXES -* resource/aws_workspaces_workspace: Fix terminated state resolution ([#15705](https://github.com/terraform-providers/terraform-provider-aws/issues/15705)) -* resource/aws_glue_table_catalog_table: Prevent errors on `unset` of `ser_de_info.name` ([#15127](https://github.com/terraform-providers/terraform-provider-aws/issues/15127)) -* resource/aws_glue_security_configuration: Don't send empty `kms_arn` if mode is `DISABLED` ([#13618](https://github.com/terraform-providers/terraform-provider-aws/issues/13618)) +* resource/aws_workspaces_workspace: Fix terminated state resolution ([#15705](https://github.com/hashicorp/terraform-provider-aws/issues/15705)) +* resource/aws_glue_table_catalog_table: Prevent errors on `unset` of `ser_de_info.name` ([#15127](https://github.com/hashicorp/terraform-provider-aws/issues/15127)) +* resource/aws_glue_security_configuration: Don't send empty `kms_arn` if mode is `DISABLED` ([#13618](https://github.com/hashicorp/terraform-provider-aws/issues/13618)) ## 3.11.0 (October 15, 2020) FEATURES -* **New Data Source:** `aws_codeartifact_repository_endpoint` ([#15566](https://github.com/terraform-providers/terraform-provider-aws/issues/15566)) -* **New Resource:** `aws_appmesh_gateway_route` ([#15638](https://github.com/terraform-providers/terraform-provider-aws/issues/15638)) -* **New Resource:** `aws_appmesh_virtual_gateway` ([#15611](https://github.com/terraform-providers/terraform-provider-aws/issues/15611)) +* **New Data Source:** `aws_codeartifact_repository_endpoint` ([#15566](https://github.com/hashicorp/terraform-provider-aws/issues/15566)) +* **New Resource:** `aws_appmesh_gateway_route` ([#15638](https://github.com/hashicorp/terraform-provider-aws/issues/15638)) +* **New Resource:** `aws_appmesh_virtual_gateway` ([#15611](https://github.com/hashicorp/terraform-provider-aws/issues/15611)) BUG FIXES -* resource/aws_ec2_transit_gateway_route: Prevent plan errors with compressed IPv6 addresses ([#14846](https://github.com/terraform-providers/terraform-provider-aws/issues/14846)) +* resource/aws_ec2_transit_gateway_route: Prevent plan errors with compressed IPv6 addresses ([#14846](https://github.com/hashicorp/terraform-provider-aws/issues/14846)) ENHANCEMENTS -* data-source/aws_workspaces_directory: Add workspaces creation properties ([#14577](https://github.com/terraform-providers/terraform-provider-aws/issues/14577)) -* resource/aws_backup_plan: Add support for AdvancedBackupSettings ([#15341](https://github.com/terraform-providers/terraform-provider-aws/issues/15341)) -* resource/aws_sagemaker_notebook_instance: Add `default_code_repository` attribute ([#13772](https://github.com/terraform-providers/terraform-provider-aws/issues/13772)) -* resource/aws_sagemaker_notebook_instance: Add `volume_size` attribute ([#15521](https://github.com/terraform-providers/terraform-provider-aws/issues/15521)) -* resource/aws_workspaces_directory: Add workspaces creation properties ([#14577](https://github.com/terraform-providers/terraform-provider-aws/issues/14577)) +* data-source/aws_workspaces_directory: Add workspaces creation properties ([#14577](https://github.com/hashicorp/terraform-provider-aws/issues/14577)) +* resource/aws_backup_plan: Add support for AdvancedBackupSettings ([#15341](https://github.com/hashicorp/terraform-provider-aws/issues/15341)) +* resource/aws_sagemaker_notebook_instance: Add `default_code_repository` attribute ([#13772](https://github.com/hashicorp/terraform-provider-aws/issues/13772)) +* resource/aws_sagemaker_notebook_instance: Add `volume_size` attribute ([#15521](https://github.com/hashicorp/terraform-provider-aws/issues/15521)) +* resource/aws_workspaces_directory: Add workspaces creation properties ([#14577](https://github.com/hashicorp/terraform-provider-aws/issues/14577)) ## 3.10.0 (October 09, 2020) FEATURES -* **New Data Source:** `aws_codeartifact_authorization_token` ([#15425](https://github.com/terraform-providers/terraform-provider-aws/issues/15425)) -* **New Data Source:** `aws_ec2_instance_type` ([#13124](https://github.com/terraform-providers/terraform-provider-aws/issues/13124)) -* **New Data Source:** `aws_lex_bot_alias` ([#8919](https://github.com/terraform-providers/terraform-provider-aws/issues/8919)) -* **New Data Source:** `aws_redshift_orderable_cluster` ([#15438](https://github.com/terraform-providers/terraform-provider-aws/issues/15438)) -* **New Resource:** `aws_codeartifact_repository_permissions_policy` ([#15562](https://github.com/terraform-providers/terraform-provider-aws/issues/15562)) -* **New Resource:** `aws_lex_bot_alias` ([#8919](https://github.com/terraform-providers/terraform-provider-aws/issues/8919)) -* **New Resource:** `aws_s3_bucket_ownership_controls` ([#15482](https://github.com/terraform-providers/terraform-provider-aws/issues/15482)) +* **New Data Source:** `aws_codeartifact_authorization_token` ([#15425](https://github.com/hashicorp/terraform-provider-aws/issues/15425)) +* **New Data Source:** `aws_ec2_instance_type` ([#13124](https://github.com/hashicorp/terraform-provider-aws/issues/13124)) +* **New Data Source:** `aws_lex_bot_alias` ([#8919](https://github.com/hashicorp/terraform-provider-aws/issues/8919)) +* **New Data Source:** `aws_redshift_orderable_cluster` ([#15438](https://github.com/hashicorp/terraform-provider-aws/issues/15438)) +* **New Resource:** `aws_codeartifact_repository_permissions_policy` ([#15562](https://github.com/hashicorp/terraform-provider-aws/issues/15562)) +* **New Resource:** `aws_lex_bot_alias` ([#8919](https://github.com/hashicorp/terraform-provider-aws/issues/8919)) +* **New Resource:** `aws_s3_bucket_ownership_controls` ([#15482](https://github.com/hashicorp/terraform-provider-aws/issues/15482)) NOTES -* data-source/aws_acm_certificate: The `id` attribute has changed to the ARN of the ACM Certificate. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_autoscaling_group: The `id` attribute has changed to the name of the Auto Scaling Group. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_availability_zones: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_db_event_categories: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_ebs_default_kms_key: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_ebs_encryption_by_default: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_ec2_instance_type_offering: The `id` attribute has changed to the EC2 Instance Type. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_ecr_authorization_token: The `id` attribute has changed to the AWS Region. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_ecr_image: The `id` attribute has changed to the SHA256 digest of the ECR Image. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_eks_cluster_auth: The `id` attribute has changed to the name of the EKS Cluster. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_iam_account_alias: The `id` attribute has changed to the AWS Account Alias. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_kms_alias: The `id` attribute has changed to the ARN of the KMS Alias. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_partition: The `id` attribute has changed to the identifier of the AWS Partition. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_regions: The `id` attribute has changed to the identifier of the AWS Partition. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_sns_topic: The `id` attribute has changed to the ARN of the SNS Topic. The first apply of this updated data source may show this difference. ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) +* data-source/aws_acm_certificate: The `id` attribute has changed to the ARN of the ACM Certificate. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_autoscaling_group: The `id` attribute has changed to the name of the Auto Scaling Group. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_availability_zones: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_db_event_categories: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_ebs_default_kms_key: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_ebs_encryption_by_default: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_ec2_instance_type_offering: The `id` attribute has changed to the EC2 Instance Type. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_ecr_authorization_token: The `id` attribute has changed to the AWS Region. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_ecr_image: The `id` attribute has changed to the SHA256 digest of the ECR Image. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_eks_cluster_auth: The `id` attribute has changed to the name of the EKS Cluster. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_iam_account_alias: The `id` attribute has changed to the AWS Account Alias. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_kms_alias: The `id` attribute has changed to the ARN of the KMS Alias. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_partition: The `id` attribute has changed to the identifier of the AWS Partition. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_regions: The `id` attribute has changed to the identifier of the AWS Partition. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_sns_topic: The `id` attribute has changed to the ARN of the SNS Topic. The first apply of this updated data source may show this difference. ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) ENHANCEMENTS -* data-source/aws_batch_compute_environment: Add `tags` attribute ([#15470](https://github.com/terraform-providers/terraform-provider-aws/issues/15470)) -* data-source/aws_batch_job_queue: Add `tags` attribute ([#15470](https://github.com/terraform-providers/terraform-provider-aws/issues/15470)) -* data-source/aws_vpc_endpoint_service: Accept `service_type` as argument ([#15467](https://github.com/terraform-providers/terraform-provider-aws/issues/15467)) -* resource/aws_appmesh_route: Add `timeout` configuration block to `grpc_route`, `http_route`, `http2_route` and `tcp_route` attributes. ([#14361](https://github.com/terraform-providers/terraform-provider-aws/issues/14361)) -* resource/aws_appmesh_virtual_node: Add `timeout` configuration block to `listener` attribute. ([#14361](https://github.com/terraform-providers/terraform-provider-aws/issues/14361)) -* resource/aws_batch_compute_environment: Add `tags` argument ([#15470](https://github.com/terraform-providers/terraform-provider-aws/issues/15470)) -* resource/aws_batch_job_definition: Add `tags` argument ([#15470](https://github.com/terraform-providers/terraform-provider-aws/issues/15470)) -* resource/aws_batch_job_queue: Add `tags` argument ([#15470](https://github.com/terraform-providers/terraform-provider-aws/issues/15470)) -* resource/aws_lb_target_group: Add `source_ip` as an option for the `stickiness.type` argument. ([#15295](https://github.com/terraform-providers/terraform-provider-aws/issues/15295)) -* resource/aws_sns_topic_subscription: Create subscriptions with attributes (delivery policy, filter policy, etc.) instead of separate API calls ([#10496](https://github.com/terraform-providers/terraform-provider-aws/issues/10496)) +* data-source/aws_batch_compute_environment: Add `tags` attribute ([#15470](https://github.com/hashicorp/terraform-provider-aws/issues/15470)) +* data-source/aws_batch_job_queue: Add `tags` attribute ([#15470](https://github.com/hashicorp/terraform-provider-aws/issues/15470)) +* data-source/aws_vpc_endpoint_service: Accept `service_type` as argument ([#15467](https://github.com/hashicorp/terraform-provider-aws/issues/15467)) +* resource/aws_appmesh_route: Add `timeout` configuration block to `grpc_route`, `http_route`, `http2_route` and `tcp_route` attributes. ([#14361](https://github.com/hashicorp/terraform-provider-aws/issues/14361)) +* resource/aws_appmesh_virtual_node: Add `timeout` configuration block to `listener` attribute. ([#14361](https://github.com/hashicorp/terraform-provider-aws/issues/14361)) +* resource/aws_batch_compute_environment: Add `tags` argument ([#15470](https://github.com/hashicorp/terraform-provider-aws/issues/15470)) +* resource/aws_batch_job_definition: Add `tags` argument ([#15470](https://github.com/hashicorp/terraform-provider-aws/issues/15470)) +* resource/aws_batch_job_queue: Add `tags` argument ([#15470](https://github.com/hashicorp/terraform-provider-aws/issues/15470)) +* resource/aws_lb_target_group: Add `source_ip` as an option for the `stickiness.type` argument. ([#15295](https://github.com/hashicorp/terraform-provider-aws/issues/15295)) +* resource/aws_sns_topic_subscription: Create subscriptions with attributes (delivery policy, filter policy, etc.) instead of separate API calls ([#10496](https://github.com/hashicorp/terraform-provider-aws/issues/10496)) BUG FIXES -* data-source/aws_acm_certificate: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_autoscaling_group: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_availability_zones: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_db_event_categories: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_ebs_default_kms_key: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_ebs_encryption_by_default: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_ec2_instance_type_offering: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_ecr_authorization_token: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_ecr_image: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_eks_cluster_auth: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_iam_account_alias: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_kms_alias: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_partition: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_regions: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* data-source/aws_sns_topic: Prevent plan differences with the `id` attribute ([#15399](https://github.com/terraform-providers/terraform-provider-aws/issues/15399)) -* resource/aws_acm_certificate: Prevent unexpected timeout error on deletion due to API retries ([#15522](https://github.com/terraform-providers/terraform-provider-aws/issues/15522)) -* resource/aws_batch_job_definition: Prevent unexpected plan difference for `container_properties` argument value with new secrets support ([#15470](https://github.com/terraform-providers/terraform-provider-aws/issues/15470)) -* resource/aws_codestarnotifications_notification_rule: Prevent unexpected timeout error during target deletion due to API retries ([#15523](https://github.com/terraform-providers/terraform-provider-aws/issues/15523)) -* resource/aws_config_remediation_configuration: Prevent unexpected timeout error on deletion due to API retries ([#15524](https://github.com/terraform-providers/terraform-provider-aws/issues/15524)) -* resource/aws_db_proxy: Increase default deletion timeout to 60 minutes ([#15537](https://github.com/terraform-providers/terraform-provider-aws/issues/15537)) -* resource/aws_db_proxy_target: Ensure `db_proxy_name` and `target_group_name` attributes are properly imported ([#15537](https://github.com/terraform-providers/terraform-provider-aws/issues/15537)) -* resource/aws_ecs_cluster: Prevent IAM Service Linked Role error on first ECS provision ([#15457](https://github.com/terraform-providers/terraform-provider-aws/issues/15457)) -* resource/aws_emr_instance_fleet: Prevent error on deletion when EMR Cluster is no longer running ([#15548](https://github.com/terraform-providers/terraform-provider-aws/issues/15548)) -* resource/aws_emr_managed_scaling_policy: Ensure `cluster_id` attribute is properly saved during import ([#15541](https://github.com/terraform-providers/terraform-provider-aws/issues/15541)) -* resource/aws_emr_managed_scaling_policy: Handle additional cases where resource should be removed from Terraform state ([#15541](https://github.com/terraform-providers/terraform-provider-aws/issues/15541)) -* resource/aws_gamelift_fleet: Prevent unexpected timeout error on creation due to API retries ([#15526](https://github.com/terraform-providers/terraform-provider-aws/issues/15526)) -* resource/aws_glue_workflow: Ensure `max_concurrent_runs` attribute is properly saved during import ([#15538](https://github.com/terraform-providers/terraform-provider-aws/issues/15538)) -* resource/aws_lex_bot: Prevent unexpected timeout error on creation due to API retries ([#15527](https://github.com/terraform-providers/terraform-provider-aws/issues/15527)) -* resource/aws_lex_bot_alias: Prevent unexpected timeout error on creation due to API retries ([#15527](https://github.com/terraform-providers/terraform-provider-aws/issues/15527)) -* resource/aws_lex_intent: Prevent unexpected timeout error on creation due to API retries ([#15527](https://github.com/terraform-providers/terraform-provider-aws/issues/15527)) -* resource/aws_lex_slot_type: Prevent unexpected timeout error on creation due to API retries ([#15527](https://github.com/terraform-providers/terraform-provider-aws/issues/15527)) -* resource/aws_organizations_policy: Prevent errors with imported AWS-managed Organizations policies ([#15446](https://github.com/terraform-providers/terraform-provider-aws/issues/15446)) -* resource/aws_s3_bucket: Correctly handle provider-level ignored tag configuration ([#12013](https://github.com/terraform-providers/terraform-provider-aws/issues/12013)) -* resource/aws_s3_bucket: Correctly set expiration for lifecycle_rule with abort_incomplete_multipart_upload_days set ([#15263](https://github.com/terraform-providers/terraform-provider-aws/issues/15263)) -* resource/aws_s3_bucket_analytics_configuration: Prevent unexpected timeout error on deletion due to API retries ([#15529](https://github.com/terraform-providers/terraform-provider-aws/issues/15529)) -* resource/aws_s3_bucket_object: Correctly handle provider-level ignored tag configuration ([#12013](https://github.com/terraform-providers/terraform-provider-aws/issues/12013)) +* data-source/aws_acm_certificate: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_autoscaling_group: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_availability_zones: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_db_event_categories: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_ebs_default_kms_key: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_ebs_encryption_by_default: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_ec2_instance_type_offering: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_ecr_authorization_token: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_ecr_image: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_eks_cluster_auth: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_iam_account_alias: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_kms_alias: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_partition: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_regions: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* data-source/aws_sns_topic: Prevent plan differences with the `id` attribute ([#15399](https://github.com/hashicorp/terraform-provider-aws/issues/15399)) +* resource/aws_acm_certificate: Prevent unexpected timeout error on deletion due to API retries ([#15522](https://github.com/hashicorp/terraform-provider-aws/issues/15522)) +* resource/aws_batch_job_definition: Prevent unexpected plan difference for `container_properties` argument value with new secrets support ([#15470](https://github.com/hashicorp/terraform-provider-aws/issues/15470)) +* resource/aws_codestarnotifications_notification_rule: Prevent unexpected timeout error during target deletion due to API retries ([#15523](https://github.com/hashicorp/terraform-provider-aws/issues/15523)) +* resource/aws_config_remediation_configuration: Prevent unexpected timeout error on deletion due to API retries ([#15524](https://github.com/hashicorp/terraform-provider-aws/issues/15524)) +* resource/aws_db_proxy: Increase default deletion timeout to 60 minutes ([#15537](https://github.com/hashicorp/terraform-provider-aws/issues/15537)) +* resource/aws_db_proxy_target: Ensure `db_proxy_name` and `target_group_name` attributes are properly imported ([#15537](https://github.com/hashicorp/terraform-provider-aws/issues/15537)) +* resource/aws_ecs_cluster: Prevent IAM Service Linked Role error on first ECS provision ([#15457](https://github.com/hashicorp/terraform-provider-aws/issues/15457)) +* resource/aws_emr_instance_fleet: Prevent error on deletion when EMR Cluster is no longer running ([#15548](https://github.com/hashicorp/terraform-provider-aws/issues/15548)) +* resource/aws_emr_managed_scaling_policy: Ensure `cluster_id` attribute is properly saved during import ([#15541](https://github.com/hashicorp/terraform-provider-aws/issues/15541)) +* resource/aws_emr_managed_scaling_policy: Handle additional cases where resource should be removed from Terraform state ([#15541](https://github.com/hashicorp/terraform-provider-aws/issues/15541)) +* resource/aws_gamelift_fleet: Prevent unexpected timeout error on creation due to API retries ([#15526](https://github.com/hashicorp/terraform-provider-aws/issues/15526)) +* resource/aws_glue_workflow: Ensure `max_concurrent_runs` attribute is properly saved during import ([#15538](https://github.com/hashicorp/terraform-provider-aws/issues/15538)) +* resource/aws_lex_bot: Prevent unexpected timeout error on creation due to API retries ([#15527](https://github.com/hashicorp/terraform-provider-aws/issues/15527)) +* resource/aws_lex_bot_alias: Prevent unexpected timeout error on creation due to API retries ([#15527](https://github.com/hashicorp/terraform-provider-aws/issues/15527)) +* resource/aws_lex_intent: Prevent unexpected timeout error on creation due to API retries ([#15527](https://github.com/hashicorp/terraform-provider-aws/issues/15527)) +* resource/aws_lex_slot_type: Prevent unexpected timeout error on creation due to API retries ([#15527](https://github.com/hashicorp/terraform-provider-aws/issues/15527)) +* resource/aws_organizations_policy: Prevent errors with imported AWS-managed Organizations policies ([#15446](https://github.com/hashicorp/terraform-provider-aws/issues/15446)) +* resource/aws_s3_bucket: Correctly handle provider-level ignored tag configuration ([#12013](https://github.com/hashicorp/terraform-provider-aws/issues/12013)) +* resource/aws_s3_bucket: Correctly set expiration for lifecycle_rule with abort_incomplete_multipart_upload_days set ([#15263](https://github.com/hashicorp/terraform-provider-aws/issues/15263)) +* resource/aws_s3_bucket_analytics_configuration: Prevent unexpected timeout error on deletion due to API retries ([#15529](https://github.com/hashicorp/terraform-provider-aws/issues/15529)) +* resource/aws_s3_bucket_object: Correctly handle provider-level ignored tag configuration ([#12013](https://github.com/hashicorp/terraform-provider-aws/issues/12013)) ## 3.9.0 (October 02, 2020) FEATURES -* **New Resource:** `aws_backup_vault_notifications` ([#12501](https://github.com/terraform-providers/terraform-provider-aws/issues/12501)) -* **New Resource:** `aws_codeartifact_domain` ([#13743](https://github.com/terraform-providers/terraform-provider-aws/issues/13743)) -* **New Resource:** `aws_codeartifact_domain_permissions` ([#13753](https://github.com/terraform-providers/terraform-provider-aws/issues/13753)) -* **New Resource:** `aws_codeartifact_repository` ([#14429](https://github.com/terraform-providers/terraform-provider-aws/issues/14429)) -* **New Resource:** `aws_db_proxy_target` ([#12784](https://github.com/terraform-providers/terraform-provider-aws/issues/12784)) -* **New Resource:** `aws_glue_data_catalog_encryption_settings` ([#14916](https://github.com/terraform-providers/terraform-provider-aws/issues/14916)) -* **New Resource:** `aws_glue_ml_transform` ([#14909](https://github.com/terraform-providers/terraform-provider-aws/issues/14909)) -* **New Resource:** `aws_glue_partition` ([#12547](https://github.com/terraform-providers/terraform-provider-aws/issues/12547)) -* **New Resource:** `aws_lex_bot` ([#8918](https://github.com/terraform-providers/terraform-provider-aws/issues/8918)) -* **New Resource:** `aws_lex_intent` ([#8917](https://github.com/terraform-providers/terraform-provider-aws/issues/8917)) -* **New Data Source:** `aws_lex_bot` ([#8918](https://github.com/terraform-providers/terraform-provider-aws/issues/8918)) -* **New Data Source:** `aws_lex_intent` ([#8917](https://github.com/terraform-providers/terraform-provider-aws/issues/8917)) +* **New Resource:** `aws_backup_vault_notifications` ([#12501](https://github.com/hashicorp/terraform-provider-aws/issues/12501)) +* **New Resource:** `aws_codeartifact_domain` ([#13743](https://github.com/hashicorp/terraform-provider-aws/issues/13743)) +* **New Resource:** `aws_codeartifact_domain_permissions` ([#13753](https://github.com/hashicorp/terraform-provider-aws/issues/13753)) +* **New Resource:** `aws_codeartifact_repository` ([#14429](https://github.com/hashicorp/terraform-provider-aws/issues/14429)) +* **New Resource:** `aws_db_proxy_target` ([#12784](https://github.com/hashicorp/terraform-provider-aws/issues/12784)) +* **New Resource:** `aws_glue_data_catalog_encryption_settings` ([#14916](https://github.com/hashicorp/terraform-provider-aws/issues/14916)) +* **New Resource:** `aws_glue_ml_transform` ([#14909](https://github.com/hashicorp/terraform-provider-aws/issues/14909)) +* **New Resource:** `aws_glue_partition` ([#12547](https://github.com/hashicorp/terraform-provider-aws/issues/12547)) +* **New Resource:** `aws_lex_bot` ([#8918](https://github.com/hashicorp/terraform-provider-aws/issues/8918)) +* **New Resource:** `aws_lex_intent` ([#8917](https://github.com/hashicorp/terraform-provider-aws/issues/8917)) +* **New Data Source:** `aws_lex_bot` ([#8918](https://github.com/hashicorp/terraform-provider-aws/issues/8918)) +* **New Data Source:** `aws_lex_intent` ([#8917](https://github.com/hashicorp/terraform-provider-aws/issues/8917)) ENHANCEMENTS -* resource/aws_appmesh_route: Add `grpc_route` and `http2_route` attributes to support gRPC and HTTP/2 services ([#11669](https://github.com/terraform-providers/terraform-provider-aws/issues/11669)) -* resource/aws_appmesh_route: Add `retry_policy` attribute to support App Mesh retry policies ([#11660](https://github.com/terraform-providers/terraform-provider-aws/issues/11660)) -* resource/aws_appmesh_virtual_node: Add `grpc` and `http2` as valid values for the `protocol` attribute ([#11669](https://github.com/terraform-providers/terraform-provider-aws/issues/11669)) -* resource/aws_appmesh_virtual_node: Add `spec.backend_defaults`, `spec.backend.virtual_service.client_policy` and `spec.listener.tls` attributes to support TLS in transit encryption ([#12541](https://github.com/terraform-providers/terraform-provider-aws/issues/12541)) -* resource/aws_appmesh_virtual_router: Add `grpc` and `http2` as valid values for the `protocol` attribute ([#11669](https://github.com/terraform-providers/terraform-provider-aws/issues/11669)) -* resource/aws_fsx_lustre_file_system: Add `auto_import_policy` argument ([#15231](https://github.com/terraform-providers/terraform-provider-aws/issues/15231)) -* resource/aws_fsx_lustre_file_system: Support `daily_automatic_backup_start_time` ([#15299](https://github.com/terraform-providers/terraform-provider-aws/issues/15299)) -* resource/aws_fsx_lustre_file_system: Add `storage_type` and `drive_cache_type` ([#14727](https://github.com/terraform-providers/terraform-provider-aws/issues/14727)) -* resource/aws_glue_crawler: Add `connection_name` field to `s3_target` block ([#15350](https://github.com/terraform-providers/terraform-provider-aws/issues/15350)) -* resource/aws_sagemaker_notebook_instance: Ability to configure root access for Sagemaker notebook instances ([#14184](https://github.com/terraform-providers/terraform-provider-aws/issues/14184)) +* resource/aws_appmesh_route: Add `grpc_route` and `http2_route` attributes to support gRPC and HTTP/2 services ([#11669](https://github.com/hashicorp/terraform-provider-aws/issues/11669)) +* resource/aws_appmesh_route: Add `retry_policy` attribute to support App Mesh retry policies ([#11660](https://github.com/hashicorp/terraform-provider-aws/issues/11660)) +* resource/aws_appmesh_virtual_node: Add `grpc` and `http2` as valid values for the `protocol` attribute ([#11669](https://github.com/hashicorp/terraform-provider-aws/issues/11669)) +* resource/aws_appmesh_virtual_node: Add `spec.backend_defaults`, `spec.backend.virtual_service.client_policy` and `spec.listener.tls` attributes to support TLS in transit encryption ([#12541](https://github.com/hashicorp/terraform-provider-aws/issues/12541)) +* resource/aws_appmesh_virtual_router: Add `grpc` and `http2` as valid values for the `protocol` attribute ([#11669](https://github.com/hashicorp/terraform-provider-aws/issues/11669)) +* resource/aws_fsx_lustre_file_system: Add `auto_import_policy` argument ([#15231](https://github.com/hashicorp/terraform-provider-aws/issues/15231)) +* resource/aws_fsx_lustre_file_system: Support `daily_automatic_backup_start_time` ([#15299](https://github.com/hashicorp/terraform-provider-aws/issues/15299)) +* resource/aws_fsx_lustre_file_system: Add `storage_type` and `drive_cache_type` ([#14727](https://github.com/hashicorp/terraform-provider-aws/issues/14727)) +* resource/aws_glue_crawler: Add `connection_name` field to `s3_target` block ([#15350](https://github.com/hashicorp/terraform-provider-aws/issues/15350)) +* resource/aws_sagemaker_notebook_instance: Ability to configure root access for Sagemaker notebook instances ([#14184](https://github.com/hashicorp/terraform-provider-aws/issues/14184)) BUG FIXES -* data-source/aws_s3_bucket_object: Prevent crash when S3 HeadObject returns empty response ([#14154](https://github.com/terraform-providers/terraform-provider-aws/issues/14154)) -* resource/aws_db_instance: Prevent ordering differences with `enabled_cloudwatch_logs_exports` argument ([#15404](https://github.com/terraform-providers/terraform-provider-aws/issues/15404)) -* resource/aws_ec2_client_vpn_authorization_rule: Increased active and revoked timeouts from 5 to 10 minutes ([#15367](https://github.com/terraform-providers/terraform-provider-aws/issues/15367)) -* resource/aws_rds_cluster: Prevent ordering differences with `enabled_cloudwatch_logs_exports` argument ([#15404](https://github.com/terraform-providers/terraform-provider-aws/issues/15404)) -* resource/aws_redshift_cluster: Increase default update timeout to 75 minutes ([#15339](https://github.com/terraform-providers/terraform-provider-aws/issues/15339)) +* data-source/aws_s3_bucket_object: Prevent crash when S3 HeadObject returns empty response ([#14154](https://github.com/hashicorp/terraform-provider-aws/issues/14154)) +* resource/aws_db_instance: Prevent ordering differences with `enabled_cloudwatch_logs_exports` argument ([#15404](https://github.com/hashicorp/terraform-provider-aws/issues/15404)) +* resource/aws_ec2_client_vpn_authorization_rule: Increased active and revoked timeouts from 5 to 10 minutes ([#15367](https://github.com/hashicorp/terraform-provider-aws/issues/15367)) +* resource/aws_rds_cluster: Prevent ordering differences with `enabled_cloudwatch_logs_exports` argument ([#15404](https://github.com/hashicorp/terraform-provider-aws/issues/15404)) +* resource/aws_redshift_cluster: Increase default update timeout to 75 minutes ([#15339](https://github.com/hashicorp/terraform-provider-aws/issues/15339)) ## 3.8.0 (September 24, 2020) FEATURES -* **New Resource:** `aws_datasync_location_fsx_windows` ([#12686](https://github.com/terraform-providers/terraform-provider-aws/pull/12686)) -* **New Resource:** `aws_route53_resolver_query_log_config`. ([#14897](https://github.com/terraform-providers/terraform-provider-aws/pull/14897)) -* **New Resource:** `aws_route53_resolver_query_log_config_association`. ([#14901](https://github.com/terraform-providers/terraform-provider-aws/pull/14901)) -* **New Data Source:** `aws_rds_engine_version` ([#15228](https://github.com/terraform-providers/terraform-provider-aws/pull/15228)) -* **New Data Source:** `aws_docdb_engine_version` ([#15253](https://github.com/terraform-providers/terraform-provider-aws/pull/15253)) -* **New Data Source:** `aws_neptune_engine_version` ([#15259](https://github.com/terraform-providers/terraform-provider-aws/pull/15259)) -* **New Data Source:** `aws_workspaces_image` ([#11428](https://github.com/terraform-providers/terraform-provider-aws/issues/11428)) +* **New Resource:** `aws_datasync_location_fsx_windows` ([#12686](https://github.com/hashicorp/terraform-provider-aws/pull/12686)) +* **New Resource:** `aws_route53_resolver_query_log_config`. ([#14897](https://github.com/hashicorp/terraform-provider-aws/pull/14897)) +* **New Resource:** `aws_route53_resolver_query_log_config_association`. ([#14901](https://github.com/hashicorp/terraform-provider-aws/pull/14901)) +* **New Data Source:** `aws_rds_engine_version` ([#15228](https://github.com/hashicorp/terraform-provider-aws/pull/15228)) +* **New Data Source:** `aws_docdb_engine_version` ([#15253](https://github.com/hashicorp/terraform-provider-aws/pull/15253)) +* **New Data Source:** `aws_neptune_engine_version` ([#15259](https://github.com/hashicorp/terraform-provider-aws/pull/15259)) +* **New Data Source:** `aws_workspaces_image` ([#11428](https://github.com/hashicorp/terraform-provider-aws/issues/11428)) ENHANCEMENTS -* data-source/aws_lb: Add `customer_owned_ipv4_pool` and `subnet_mapping` `outpost_id` attributes ([#15170](https://github.com/terraform-providers/terraform-provider-aws/issues/15170)) -* resource/aws_apigatewayv2_api: Add `disable_execute_api_endpoint` attribute ([#15250](https://github.com/terraform-providers/terraform-provider-aws/issues/15250)) -* resource/aws_apigatewayv2_authorizer: Add `authorizer_payload_format_version`, `authorizer_result_ttl_in_seconds` and `enable_simple_responses` attribute to support Lambda authorizers for HTTP APIs ([#15232](https://github.com/terraform-providers/terraform-provider-aws/issues/15232)) -* resource/aws_apigatewayv2_authorizer: Change `identity_sources` to an optional attribute ([#15232](https://github.com/terraform-providers/terraform-provider-aws/issues/15232)) -* resource/aws_appmesh_mesh: Add `mesh_owner` and `resource_owner` attributes ([#14349](https://github.com/terraform-providers/terraform-provider-aws/issues/14349)) -* resource/aws_appmesh_route: Add `mesh_owner` argument and `resource_owner` attribute ([#14349](https://github.com/terraform-providers/terraform-provider-aws/issues/14349)) -* resource/aws_appmesh_virtual_node: Add `mesh_owner` argument and `resource_owner` attribute ([#14349](https://github.com/terraform-providers/terraform-provider-aws/issues/14349)) -* resource/aws_appmesh_virtual_router: Add `mesh_owner` argument and `resource_owner` attribute ([#14349](https://github.com/terraform-providers/terraform-provider-aws/issues/14349)) -* resource/aws_appmesh_virtual_service: Add `mesh_owner` argument and `resource_owner` attribute ([#14349](https://github.com/terraform-providers/terraform-provider-aws/issues/14349)) -* resource/aws_elasticsearch_domain: Support `AUDIT_LOGS` log type ([#15218](https://github.com/terraform-providers/terraform-provider-aws/issues/15218)) -* resource/aws_glue_connection: Support `NETWORK` connection type ([#14818](https://github.com/terraform-providers/terraform-provider-aws/issues/14818)) -* resource/aws_glue_crawler: Add support for `scan_all` and `scan_rate` arguments for ddb targets ([#14819](https://github.com/terraform-providers/terraform-provider-aws/issues/14819)) -* resource/aws_glue_crawler: Allow removing `table_prefix` ([#15268](https://github.com/terraform-providers/terraform-provider-aws/issues/15268)) -* resource/aws_glue_job: Add `non_overridable_arguments` argument ([#14793](https://github.com/terraform-providers/terraform-provider-aws/issues/14793)) -* resource/aws_glue_workflow: Add `tags` argument ([#14910](https://github.com/terraform-providers/terraform-provider-aws/issues/14910)) -* resource/aws_glue_workflow: Add `arn` attribute ([#14910](https://github.com/terraform-providers/terraform-provider-aws/issues/14910)) -* resource/aws_glue_workflow: Add `max_concurrent_runs` argument ([#14910](https://github.com/terraform-providers/terraform-provider-aws/issues/14910)) -* resource/aws_glue_workflow: Plan time validation for `name` ([#14910](https://github.com/terraform-providers/terraform-provider-aws/issues/14910)) -* resource/aws_fsx_lustre_file_system: Add support for backup retention ([#14446](https://github.com/terraform-providers/terraform-provider-aws/issues/14446)) -* resource/aws_fsx_lustre_file_system: Add `kms_key_id` argument ([#15057](https://github.com/terraform-providers/terraform-provider-aws/issues/15057)) -* resource/aws_fsx_lustre_file_system: Add `mount_name` argument ([#14313](https://github.com/terraform-providers/terraform-provider-aws/issues/14313)) -* resource/aws_lb: Add `customer_owned_ipv4_pool` argument and `subnet_mapping` `outpost_id` attribute ([#15170](https://github.com/terraform-providers/terraform-provider-aws/issues/15170)) -* resource/aws_organizations_policy: Add `tags` argument ([#15316](https://github.com/terraform-providers/terraform-provider-aws/issues/15316)) -* resource/aws_rds_cluster: Add `allow_major_version_upgrade` argument ([#14709](https://github.com/terraform-providers/terraform-provider-aws/issues/14709)) -* resource/aws_storagegateway_smb_file_share: Add `admin_user_list` argument ([#12196](https://github.com/terraform-providers/terraform-provider-aws/issues/12196)) -* resource/aws_transfer_server: Support `VPC` value for `endpoint_type` argument and add `endpoint_details` configuration block `address_allocation_ids`, `subnet_ids`, and `vpc_id` arguments ([#12599](https://github.com/terraform-providers/terraform-provider-aws/issues/12599)) -* resource/aws_transfer_user: Add `home_directory_mappings` configuration blocks and `home_directory_type` argument ([#13591](https://github.com/terraform-providers/terraform-provider-aws/issues/13591)) +* data-source/aws_lb: Add `customer_owned_ipv4_pool` and `subnet_mapping` `outpost_id` attributes ([#15170](https://github.com/hashicorp/terraform-provider-aws/issues/15170)) +* resource/aws_apigatewayv2_api: Add `disable_execute_api_endpoint` attribute ([#15250](https://github.com/hashicorp/terraform-provider-aws/issues/15250)) +* resource/aws_apigatewayv2_authorizer: Add `authorizer_payload_format_version`, `authorizer_result_ttl_in_seconds` and `enable_simple_responses` attribute to support Lambda authorizers for HTTP APIs ([#15232](https://github.com/hashicorp/terraform-provider-aws/issues/15232)) +* resource/aws_apigatewayv2_authorizer: Change `identity_sources` to an optional attribute ([#15232](https://github.com/hashicorp/terraform-provider-aws/issues/15232)) +* resource/aws_appmesh_mesh: Add `mesh_owner` and `resource_owner` attributes ([#14349](https://github.com/hashicorp/terraform-provider-aws/issues/14349)) +* resource/aws_appmesh_route: Add `mesh_owner` argument and `resource_owner` attribute ([#14349](https://github.com/hashicorp/terraform-provider-aws/issues/14349)) +* resource/aws_appmesh_virtual_node: Add `mesh_owner` argument and `resource_owner` attribute ([#14349](https://github.com/hashicorp/terraform-provider-aws/issues/14349)) +* resource/aws_appmesh_virtual_router: Add `mesh_owner` argument and `resource_owner` attribute ([#14349](https://github.com/hashicorp/terraform-provider-aws/issues/14349)) +* resource/aws_appmesh_virtual_service: Add `mesh_owner` argument and `resource_owner` attribute ([#14349](https://github.com/hashicorp/terraform-provider-aws/issues/14349)) +* resource/aws_elasticsearch_domain: Support `AUDIT_LOGS` log type ([#15218](https://github.com/hashicorp/terraform-provider-aws/issues/15218)) +* resource/aws_glue_connection: Support `NETWORK` connection type ([#14818](https://github.com/hashicorp/terraform-provider-aws/issues/14818)) +* resource/aws_glue_crawler: Add support for `scan_all` and `scan_rate` arguments for ddb targets ([#14819](https://github.com/hashicorp/terraform-provider-aws/issues/14819)) +* resource/aws_glue_crawler: Allow removing `table_prefix` ([#15268](https://github.com/hashicorp/terraform-provider-aws/issues/15268)) +* resource/aws_glue_job: Add `non_overridable_arguments` argument ([#14793](https://github.com/hashicorp/terraform-provider-aws/issues/14793)) +* resource/aws_glue_workflow: Add `tags` argument ([#14910](https://github.com/hashicorp/terraform-provider-aws/issues/14910)) +* resource/aws_glue_workflow: Add `arn` attribute ([#14910](https://github.com/hashicorp/terraform-provider-aws/issues/14910)) +* resource/aws_glue_workflow: Add `max_concurrent_runs` argument ([#14910](https://github.com/hashicorp/terraform-provider-aws/issues/14910)) +* resource/aws_glue_workflow: Plan time validation for `name` ([#14910](https://github.com/hashicorp/terraform-provider-aws/issues/14910)) +* resource/aws_fsx_lustre_file_system: Add support for backup retention ([#14446](https://github.com/hashicorp/terraform-provider-aws/issues/14446)) +* resource/aws_fsx_lustre_file_system: Add `kms_key_id` argument ([#15057](https://github.com/hashicorp/terraform-provider-aws/issues/15057)) +* resource/aws_fsx_lustre_file_system: Add `mount_name` argument ([#14313](https://github.com/hashicorp/terraform-provider-aws/issues/14313)) +* resource/aws_lb: Add `customer_owned_ipv4_pool` argument and `subnet_mapping` `outpost_id` attribute ([#15170](https://github.com/hashicorp/terraform-provider-aws/issues/15170)) +* resource/aws_organizations_policy: Add `tags` argument ([#15316](https://github.com/hashicorp/terraform-provider-aws/issues/15316)) +* resource/aws_rds_cluster: Add `allow_major_version_upgrade` argument ([#14709](https://github.com/hashicorp/terraform-provider-aws/issues/14709)) +* resource/aws_storagegateway_smb_file_share: Add `admin_user_list` argument ([#12196](https://github.com/hashicorp/terraform-provider-aws/issues/12196)) +* resource/aws_transfer_server: Support `VPC` value for `endpoint_type` argument and add `endpoint_details` configuration block `address_allocation_ids`, `subnet_ids`, and `vpc_id` arguments ([#12599](https://github.com/hashicorp/terraform-provider-aws/issues/12599)) +* resource/aws_transfer_user: Add `home_directory_mappings` configuration blocks and `home_directory_type` argument ([#13591](https://github.com/hashicorp/terraform-provider-aws/issues/13591)) BUG FIXES -* resource/aws_dynamodb_table: Ensure changes in `name`, `range_key`, `projection_type`, or `non_key_attributes` of a `local_secondary_index` configuration block force resource recreation ([#12335](https://github.com/terraform-providers/terraform-provider-aws/issues/12335)) -* resource/aws_dynamodb_table: Ensure `local_secondary_index` `non_key_attributes` are sent through API requests on resource creation ([#15115](https://github.com/terraform-providers/terraform-provider-aws/issues/15115)) -* resource/aws_efs_mount_target: Increase create timeout to 30 minutes ([#15293](https://github.com/terraform-providers/terraform-provider-aws/issues/15293)) -* resource/aws_fsx_lustre_file_system: Change `aws_fsx_lustre_file_system's`'s `network_interface_ids` to `TypeList` to preserve ordering. ([#14314](https://github.com/terraform-providers/terraform-provider-aws/issues/14314)) -* resource/aws_neptune_cluster_instance: Add `configuring-enhanced-monitoring` to expected states when creating and updating ([#15284](https://github.com/terraform-providers/terraform-provider-aws/issues/15284)) -* resource/aws_vpn_gateway: Increase VPC detachment timeout to 30 minutes ([#15201](https://github.com/terraform-providers/terraform-provider-aws/issues/15201)) -* resource/aws_vpn_gateway_attachment: Increase VPC detachment timeout to 30 minutes ([#15201](https://github.com/terraform-providers/terraform-provider-aws/issues/15201)) +* resource/aws_dynamodb_table: Ensure changes in `name`, `range_key`, `projection_type`, or `non_key_attributes` of a `local_secondary_index` configuration block force resource recreation ([#12335](https://github.com/hashicorp/terraform-provider-aws/issues/12335)) +* resource/aws_dynamodb_table: Ensure `local_secondary_index` `non_key_attributes` are sent through API requests on resource creation ([#15115](https://github.com/hashicorp/terraform-provider-aws/issues/15115)) +* resource/aws_efs_mount_target: Increase create timeout to 30 minutes ([#15293](https://github.com/hashicorp/terraform-provider-aws/issues/15293)) +* resource/aws_fsx_lustre_file_system: Change `aws_fsx_lustre_file_system's`'s `network_interface_ids` to `TypeList` to preserve ordering. ([#14314](https://github.com/hashicorp/terraform-provider-aws/issues/14314)) +* resource/aws_neptune_cluster_instance: Add `configuring-enhanced-monitoring` to expected states when creating and updating ([#15284](https://github.com/hashicorp/terraform-provider-aws/issues/15284)) +* resource/aws_vpn_gateway: Increase VPC detachment timeout to 30 minutes ([#15201](https://github.com/hashicorp/terraform-provider-aws/issues/15201)) +* resource/aws_vpn_gateway_attachment: Increase VPC detachment timeout to 30 minutes ([#15201](https://github.com/hashicorp/terraform-provider-aws/issues/15201)) ## 3.7.0 (September 17, 2020) FEATURES -* **New Resource:** `aws_config_remediation_configuration` ([#13884](https://github.com/terraform-providers/terraform-provider-aws/issues/13884)) +* **New Resource:** `aws_config_remediation_configuration` ([#13884](https://github.com/hashicorp/terraform-provider-aws/issues/13884)) ENHANCEMENTS -* resource/aws_db_cluster_snapshot: Add plan-time validation for `db_cluster_snapshot_identifier` argument ([#15132](https://github.com/terraform-providers/terraform-provider-aws/issues/15132)) -* resource/aws_kinesis_firehose_delivery_stream: Add `server_side_encryption` `key_arn` and `key_type` arguments (support KMS Customer Managed Key encryption) ([#11954](https://github.com/terraform-providers/terraform-provider-aws/issues/11954)) +* resource/aws_db_cluster_snapshot: Add plan-time validation for `db_cluster_snapshot_identifier` argument ([#15132](https://github.com/hashicorp/terraform-provider-aws/issues/15132)) +* resource/aws_kinesis_firehose_delivery_stream: Add `server_side_encryption` `key_arn` and `key_type` arguments (support KMS Customer Managed Key encryption) ([#11954](https://github.com/hashicorp/terraform-provider-aws/issues/11954)) BUG FIXES -* data-source/aws_kms_secrets: Prevent `plaintext` values to appear in CLI output with Terraform 0.13 ([#15169](https://github.com/terraform-providers/terraform-provider-aws/issues/15169)) -* resource/aws_acm_certificate: Prevent tagging is not permitted on re-import error ([#15060](https://github.com/terraform-providers/terraform-provider-aws/issues/15060)) -* resource/aws_cognito_identity_pool: Prevent ordering differences for `openid_connect_provider_arns` argument ([#15178](https://github.com/terraform-providers/terraform-provider-aws/issues/15178)) +* data-source/aws_kms_secrets: Prevent `plaintext` values to appear in CLI output with Terraform 0.13 ([#15169](https://github.com/hashicorp/terraform-provider-aws/issues/15169)) +* resource/aws_acm_certificate: Prevent tagging is not permitted on re-import error ([#15060](https://github.com/hashicorp/terraform-provider-aws/issues/15060)) +* resource/aws_cognito_identity_pool: Prevent ordering differences for `openid_connect_provider_arns` argument ([#15178](https://github.com/hashicorp/terraform-provider-aws/issues/15178)) ## 3.6.0 (September 11, 2020) FEATURES -* **New Resource:** `aws_db_proxy_default_target_group` ([#12743](https://github.com/terraform-providers/terraform-provider-aws/issues/12743)) +* **New Resource:** `aws_db_proxy_default_target_group` ([#12743](https://github.com/hashicorp/terraform-provider-aws/issues/12743)) BUG FIXES -* resource/aws_ec2_client_vpn_authorization_rule: Increase active and revoked timeouts from 1 to 5 minutes ([#15037](https://github.com/terraform-providers/terraform-provider-aws/issues/15037)) +* resource/aws_ec2_client_vpn_authorization_rule: Increase active and revoked timeouts from 1 to 5 minutes ([#15037](https://github.com/hashicorp/terraform-provider-aws/issues/15037)) ## 3.5.0 (September 03, 2020) FEATURES -* **New Data Source:** `aws_docdb_orderable_db_instance` ([#14931](https://github.com/terraform-providers/terraform-provider-aws/issues/14931)) -* **New Data Source:** `aws_lex_slot_type` ([#8916](https://github.com/terraform-providers/terraform-provider-aws/issues/8916)) -* **New Data Source:** `aws_neptune_orderable_db_instance` ([#14953](https://github.com/terraform-providers/terraform-provider-aws/issues/14953)) -* **New Data Source:** `aws_rds_orderable_db_instance` ([#14834](https://github.com/terraform-providers/terraform-provider-aws/issues/14834)) -* **New Data Source:** `aws_vpc_peering_connections` ([#9491](https://github.com/terraform-providers/terraform-provider-aws/issues/9491)) -* **New Resource:** `aws_codebuild_report_group` ([#12573](https://github.com/terraform-providers/terraform-provider-aws/issues/12573)) -* **New Resource:** `aws_db_proxy` ([#12704](https://github.com/terraform-providers/terraform-provider-aws/issues/12704)) -* **New Resource:** `aws_emr_instance_fleet` ([#14813](https://github.com/terraform-providers/terraform-provider-aws/issues/14813)) -* **New Resource:** `aws_glue_user_defined_function` ([#12537](https://github.com/terraform-providers/terraform-provider-aws/issues/12537)) -* **New Resource:** `aws_guardduty_filter` ([#14876](https://github.com/terraform-providers/terraform-provider-aws/issues/14876)) -* **New Resource:** `aws_lex_slot_type` ([#8916](https://github.com/terraform-providers/terraform-provider-aws/issues/8916)) +* **New Data Source:** `aws_docdb_orderable_db_instance` ([#14931](https://github.com/hashicorp/terraform-provider-aws/issues/14931)) +* **New Data Source:** `aws_lex_slot_type` ([#8916](https://github.com/hashicorp/terraform-provider-aws/issues/8916)) +* **New Data Source:** `aws_neptune_orderable_db_instance` ([#14953](https://github.com/hashicorp/terraform-provider-aws/issues/14953)) +* **New Data Source:** `aws_rds_orderable_db_instance` ([#14834](https://github.com/hashicorp/terraform-provider-aws/issues/14834)) +* **New Data Source:** `aws_vpc_peering_connections` ([#9491](https://github.com/hashicorp/terraform-provider-aws/issues/9491)) +* **New Resource:** `aws_codebuild_report_group` ([#12573](https://github.com/hashicorp/terraform-provider-aws/issues/12573)) +* **New Resource:** `aws_db_proxy` ([#12704](https://github.com/hashicorp/terraform-provider-aws/issues/12704)) +* **New Resource:** `aws_emr_instance_fleet` ([#14813](https://github.com/hashicorp/terraform-provider-aws/issues/14813)) +* **New Resource:** `aws_glue_user_defined_function` ([#12537](https://github.com/hashicorp/terraform-provider-aws/issues/12537)) +* **New Resource:** `aws_guardduty_filter` ([#14876](https://github.com/hashicorp/terraform-provider-aws/issues/14876)) +* **New Resource:** `aws_lex_slot_type` ([#8916](https://github.com/hashicorp/terraform-provider-aws/issues/8916)) ENHANCEMENTS -* data-source/aws_cur_report_definition: Add `refresh_closed_reports` and `report_versioning` attributes ([#12428](https://github.com/terraform-providers/terraform-provider-aws/issues/12428)) -* data-source/aws_outposts_outpost: Add `arn` argument ([#14967](https://github.com/terraform-providers/terraform-provider-aws/issues/14967)) -* data-source/aws_route: Add `local_gateway_id` attribute ([#14864](https://github.com/terraform-providers/terraform-provider-aws/issues/14864)) -* data-source/aws_route_table: Add `route` `local_gateway_id` attribute ([#14864](https://github.com/terraform-providers/terraform-provider-aws/issues/14864)) -* resource/aws_acm_certificate: Provide additional plan-time validation for `subject_alternative_names` argument values ([#14782](https://github.com/terraform-providers/terraform-provider-aws/issues/14782)) -* resource/aws_ami: Support `io2` value for `volume_type` argument plan-time validation ([#14906](https://github.com/terraform-providers/terraform-provider-aws/issues/14906)) -* resource/aws_autoscaling_group: Support provider-level `ignore_tags` configuration ([#13868](https://github.com/terraform-providers/terraform-provider-aws/issues/13868)) -* resource/aws_cloudtrail: Add `insight_selector` configuration block ([#12390](https://github.com/terraform-providers/terraform-provider-aws/issues/12390)) -* resource/aws_cur_report_definition: Add `refresh_closed_reports` and `report_versioning` arguments ([#12428](https://github.com/terraform-providers/terraform-provider-aws/issues/12428)) -* resource/aws_cur_report_definition: Support `ATHENA` value in `additional_artifacts` argument plan-time validation ([#12428](https://github.com/terraform-providers/terraform-provider-aws/issues/12428)) -* resource/aws_cur_report_definition: Support `Parquet` value in `compression` and `format` argument plan-time validations ([#12428](https://github.com/terraform-providers/terraform-provider-aws/issues/12428)) -* resource/aws_cur_report_definition: Support `MONTHLY` value in `time_unit` argument plan-time validation ([#12428](https://github.com/terraform-providers/terraform-provider-aws/issues/12428)) -* resource/aws_ebs_volume: Support io2 type ([#14894](https://github.com/terraform-providers/terraform-provider-aws/issues/14894)) -* resource/aws_ec2_client_vpn_endpoint: Support `authentication_options` `type` argument `federated-authentication` value and new `saml_provider_arn` argument ([#14171](https://github.com/terraform-providers/terraform-provider-aws/issues/14171)) -* resource/aws_emr_cluster: Add `core_instance_fleet` and `master_instance_fleet` configuration blocks ([#14788](https://github.com/terraform-providers/terraform-provider-aws/issues/14788)) -* resource/aws_instance: Support `io2` value for `volume_type` argument plan-time validation ([#14906](https://github.com/terraform-providers/terraform-provider-aws/issues/14906)) -* resource/aws_kinesis_firehose_delivery_stream: Add `elasticsearch_configuration` `vpc_config` configuration block ([#13269](https://github.com/terraform-providers/terraform-provider-aws/issues/13269)) -* resource/aws_kinesis_firehose_delivery_stream: Add `elasticsearch_configuration` `cluster_endpoint` argument ([#12484](https://github.com/terraform-providers/terraform-provider-aws/issues/12484)) -* resource/aws_kinesis_firehose_delivery_stream: Add various plan-time validations for arguments ([#12484](https://github.com/terraform-providers/terraform-provider-aws/issues/12484)) -* resource/aws_launch_template: Support `io2` value for `volume_type` argument plan-time validation ([#14906](https://github.com/terraform-providers/terraform-provider-aws/issues/14906)) -* resource/aws_msk_configuration: Support resource in-place updates and deletion ([#14826](https://github.com/terraform-providers/terraform-provider-aws/issues/14826)) -* resource/aws_route: Add `local_gateway_id` argument ([#14864](https://github.com/terraform-providers/terraform-provider-aws/issues/14864)) -* resource/aws_route_table: Add `route` `local_gateway_id` argument ([#14864](https://github.com/terraform-providers/terraform-provider-aws/issues/14864)) -* resource/aws_spot_fleet_request: Support `io2` value for `volume_type` argument plan-time validation ([#14906](https://github.com/terraform-providers/terraform-provider-aws/issues/14906)) -* resource/aws_wafv2_rule_group: Add `ip_set_forwarded_ip_config` configuration block to `ip_set_reference_statement` ([#14902](https://github.com/terraform-providers/terraform-provider-aws/issues/14902)) -* resource/aws_wafv2_web_acl: Add `ip_set_forwarded_ip_config` configuration block to `ip_set_reference_statement` ([#14902](https://github.com/terraform-providers/terraform-provider-aws/issues/14902)) +* data-source/aws_cur_report_definition: Add `refresh_closed_reports` and `report_versioning` attributes ([#12428](https://github.com/hashicorp/terraform-provider-aws/issues/12428)) +* data-source/aws_outposts_outpost: Add `arn` argument ([#14967](https://github.com/hashicorp/terraform-provider-aws/issues/14967)) +* data-source/aws_route: Add `local_gateway_id` attribute ([#14864](https://github.com/hashicorp/terraform-provider-aws/issues/14864)) +* data-source/aws_route_table: Add `route` `local_gateway_id` attribute ([#14864](https://github.com/hashicorp/terraform-provider-aws/issues/14864)) +* resource/aws_acm_certificate: Provide additional plan-time validation for `subject_alternative_names` argument values ([#14782](https://github.com/hashicorp/terraform-provider-aws/issues/14782)) +* resource/aws_ami: Support `io2` value for `volume_type` argument plan-time validation ([#14906](https://github.com/hashicorp/terraform-provider-aws/issues/14906)) +* resource/aws_autoscaling_group: Support provider-level `ignore_tags` configuration ([#13868](https://github.com/hashicorp/terraform-provider-aws/issues/13868)) +* resource/aws_cloudtrail: Add `insight_selector` configuration block ([#12390](https://github.com/hashicorp/terraform-provider-aws/issues/12390)) +* resource/aws_cur_report_definition: Add `refresh_closed_reports` and `report_versioning` arguments ([#12428](https://github.com/hashicorp/terraform-provider-aws/issues/12428)) +* resource/aws_cur_report_definition: Support `ATHENA` value in `additional_artifacts` argument plan-time validation ([#12428](https://github.com/hashicorp/terraform-provider-aws/issues/12428)) +* resource/aws_cur_report_definition: Support `Parquet` value in `compression` and `format` argument plan-time validations ([#12428](https://github.com/hashicorp/terraform-provider-aws/issues/12428)) +* resource/aws_cur_report_definition: Support `MONTHLY` value in `time_unit` argument plan-time validation ([#12428](https://github.com/hashicorp/terraform-provider-aws/issues/12428)) +* resource/aws_ebs_volume: Support io2 type ([#14894](https://github.com/hashicorp/terraform-provider-aws/issues/14894)) +* resource/aws_ec2_client_vpn_endpoint: Support `authentication_options` `type` argument `federated-authentication` value and new `saml_provider_arn` argument ([#14171](https://github.com/hashicorp/terraform-provider-aws/issues/14171)) +* resource/aws_emr_cluster: Add `core_instance_fleet` and `master_instance_fleet` configuration blocks ([#14788](https://github.com/hashicorp/terraform-provider-aws/issues/14788)) +* resource/aws_instance: Support `io2` value for `volume_type` argument plan-time validation ([#14906](https://github.com/hashicorp/terraform-provider-aws/issues/14906)) +* resource/aws_kinesis_firehose_delivery_stream: Add `elasticsearch_configuration` `vpc_config` configuration block ([#13269](https://github.com/hashicorp/terraform-provider-aws/issues/13269)) +* resource/aws_kinesis_firehose_delivery_stream: Add `elasticsearch_configuration` `cluster_endpoint` argument ([#12484](https://github.com/hashicorp/terraform-provider-aws/issues/12484)) +* resource/aws_kinesis_firehose_delivery_stream: Add various plan-time validations for arguments ([#12484](https://github.com/hashicorp/terraform-provider-aws/issues/12484)) +* resource/aws_launch_template: Support `io2` value for `volume_type` argument plan-time validation ([#14906](https://github.com/hashicorp/terraform-provider-aws/issues/14906)) +* resource/aws_msk_configuration: Support resource in-place updates and deletion ([#14826](https://github.com/hashicorp/terraform-provider-aws/issues/14826)) +* resource/aws_route: Add `local_gateway_id` argument ([#14864](https://github.com/hashicorp/terraform-provider-aws/issues/14864)) +* resource/aws_route_table: Add `route` `local_gateway_id` argument ([#14864](https://github.com/hashicorp/terraform-provider-aws/issues/14864)) +* resource/aws_spot_fleet_request: Support `io2` value for `volume_type` argument plan-time validation ([#14906](https://github.com/hashicorp/terraform-provider-aws/issues/14906)) +* resource/aws_wafv2_rule_group: Add `ip_set_forwarded_ip_config` configuration block to `ip_set_reference_statement` ([#14902](https://github.com/hashicorp/terraform-provider-aws/issues/14902)) +* resource/aws_wafv2_web_acl: Add `ip_set_forwarded_ip_config` configuration block to `ip_set_reference_statement` ([#14902](https://github.com/hashicorp/terraform-provider-aws/issues/14902)) BUG FIXES -* resource/aws_autoscaling_group: Prevent unnecessary tag removal and recreation within tag updates ([#13868](https://github.com/terraform-providers/terraform-provider-aws/issues/13868)) -* resource/aws_cloudfront_distribution: Prevent panic with missing `ForwardedValues` ([#14993](https://github.com/terraform-providers/terraform-provider-aws/issues/14993)) -* resource/aws_dynamodb_table: Properly update `global_secondary_index` `non_key_attributes` values ([#9988](https://github.com/terraform-providers/terraform-provider-aws/issues/9988)) -* resource/aws_emr_cluster: Prevent recreation when `ebs_config.volumes_per_instance` is greater than 1 ([#14858](https://github.com/terraform-providers/terraform-provider-aws/issues/14858)) -* resource/aws_lambda_function_event_invoke_config: Prevent unexpected format of function resource error ([#14851](https://github.com/terraform-providers/terraform-provider-aws/issues/14851)) -* resource/aws_lightsail_instance: Prevent panic with key-only tags ([#13868](https://github.com/terraform-providers/terraform-provider-aws/issues/13868)) -* resource/aws_mq_configuration: Prevent additional revision creation with `tags` only updates ([#14850](https://github.com/terraform-providers/terraform-provider-aws/issues/14850)) -* resource/aws_opsworks_stack: Suppress equivalent `custom_json` differences ([#14886](https://github.com/terraform-providers/terraform-provider-aws/issues/14886)) -* resource/aws_rds_cluster_endpoint: Increase creation timeout to 30 minutes ([#14862](https://github.com/terraform-providers/terraform-provider-aws/issues/14862)) -* resource/aws_route53_resolver_rule: Correct handling for single period (`.`) value in `domain_name` argument ([#15015](https://github.com/terraform-providers/terraform-provider-aws/issues/15015)) -* resource/aws_route53_zone_association: Correctly handle zones with over 100 VPC associations ([#14885](https://github.com/terraform-providers/terraform-provider-aws/issues/14885)) -* resource/aws_waf_rate_based_rule: Properly update `rate_limit` value ([#14964](https://github.com/terraform-providers/terraform-provider-aws/issues/14964)) -* resource/aws_workspaces_workspace: Prevent error when `workspace_properties` `running_mode` is set to `ALWAYS_ON` ([#13976](https://github.com/terraform-providers/terraform-provider-aws/issues/13976)) +* resource/aws_autoscaling_group: Prevent unnecessary tag removal and recreation within tag updates ([#13868](https://github.com/hashicorp/terraform-provider-aws/issues/13868)) +* resource/aws_cloudfront_distribution: Prevent panic with missing `ForwardedValues` ([#14993](https://github.com/hashicorp/terraform-provider-aws/issues/14993)) +* resource/aws_dynamodb_table: Properly update `global_secondary_index` `non_key_attributes` values ([#9988](https://github.com/hashicorp/terraform-provider-aws/issues/9988)) +* resource/aws_emr_cluster: Prevent recreation when `ebs_config.volumes_per_instance` is greater than 1 ([#14858](https://github.com/hashicorp/terraform-provider-aws/issues/14858)) +* resource/aws_lambda_function_event_invoke_config: Prevent unexpected format of function resource error ([#14851](https://github.com/hashicorp/terraform-provider-aws/issues/14851)) +* resource/aws_lightsail_instance: Prevent panic with key-only tags ([#13868](https://github.com/hashicorp/terraform-provider-aws/issues/13868)) +* resource/aws_mq_configuration: Prevent additional revision creation with `tags` only updates ([#14850](https://github.com/hashicorp/terraform-provider-aws/issues/14850)) +* resource/aws_opsworks_stack: Suppress equivalent `custom_json` differences ([#14886](https://github.com/hashicorp/terraform-provider-aws/issues/14886)) +* resource/aws_rds_cluster_endpoint: Increase creation timeout to 30 minutes ([#14862](https://github.com/hashicorp/terraform-provider-aws/issues/14862)) +* resource/aws_route53_resolver_rule: Correct handling for single period (`.`) value in `domain_name` argument ([#15015](https://github.com/hashicorp/terraform-provider-aws/issues/15015)) +* resource/aws_route53_zone_association: Correctly handle zones with over 100 VPC associations ([#14885](https://github.com/hashicorp/terraform-provider-aws/issues/14885)) +* resource/aws_waf_rate_based_rule: Properly update `rate_limit` value ([#14964](https://github.com/hashicorp/terraform-provider-aws/issues/14964)) +* resource/aws_workspaces_workspace: Prevent error when `workspace_properties` `running_mode` is set to `ALWAYS_ON` ([#13976](https://github.com/hashicorp/terraform-provider-aws/issues/13976)) ## 3.4.0 (August 27, 2020) FEATURES -* **New Data Source:** `aws_db_subnet_group` ([#9525](https://github.com/terraform-providers/terraform-provider-aws/issues/9525)) -* **New Resource:** `aws_emr_managed_scaling_policy` ([#13965](https://github.com/terraform-providers/terraform-provider-aws/issues/13965)) -* **New Resource:** `aws_guardduty_publishing_destination` ([#13894](https://github.com/terraform-providers/terraform-provider-aws/issues/13894)) -* **New Resource:** `aws_securityhub_action_target` ([#10493](https://github.com/terraform-providers/terraform-provider-aws/issues/10493)) -* **New Resource:** `aws_xray_encryption_config` ([#13600](https://github.com/terraform-providers/terraform-provider-aws/issues/13600)) -* **New Resource:** `aws_xray_group` ([#13597](https://github.com/terraform-providers/terraform-provider-aws/issues/13597)) +* **New Data Source:** `aws_db_subnet_group` ([#9525](https://github.com/hashicorp/terraform-provider-aws/issues/9525)) +* **New Resource:** `aws_emr_managed_scaling_policy` ([#13965](https://github.com/hashicorp/terraform-provider-aws/issues/13965)) +* **New Resource:** `aws_guardduty_publishing_destination` ([#13894](https://github.com/hashicorp/terraform-provider-aws/issues/13894)) +* **New Resource:** `aws_securityhub_action_target` ([#10493](https://github.com/hashicorp/terraform-provider-aws/issues/10493)) +* **New Resource:** `aws_xray_encryption_config` ([#13600](https://github.com/hashicorp/terraform-provider-aws/issues/13600)) +* **New Resource:** `aws_xray_group` ([#13597](https://github.com/hashicorp/terraform-provider-aws/issues/13597)) ENHANCEMENTS -* resource/aws_apigatewayv2_integration: Add `integration_subtype` argument (Support AWS service integrations for HTTP APIs) ([#14860](https://github.com/terraform-providers/terraform-provider-aws/issues/14860)) -* resource/aws_elasticache_replication_group: Add plan-time validation for `notification_topic_arn` and `snapshot_arns` arguments ([#12974](https://github.com/terraform-providers/terraform-provider-aws/issues/12974)) -* resource/aws_globalaccelerator_endpoint_group: Add `client_ip_preservation_enabled` argument to the `endpoint_configuration` configuration block ([#14486](https://github.com/terraform-providers/terraform-provider-aws/issues/14486)) -* resource/aws_storagegateway_cached_iscsi_volume: Add `kms_encrypted` and `kms_key` arguments ([#12066](https://github.com/terraform-providers/terraform-provider-aws/issues/12066)) -* resource/aws_storagegateway_gateway: Add `smb_security_strategy` argument ([#13563](https://github.com/terraform-providers/terraform-provider-aws/issues/13563)) -* resource/aws_storagegateway_gateway: Add plan-time validation for `gateway_ip_address` argument ([#13563](https://github.com/terraform-providers/terraform-provider-aws/issues/13563)) -* resource/aws_storagegateway_gateway: Add `average_download_rate_limit_in_bits_per_sec` and `average_upload_rate_limit_in_bits_per_sec` arguments ([#13568](https://github.com/terraform-providers/terraform-provider-aws/issues/13568)) -* resource/aws_storagegateway_nfs_file_share: Add `cache_attributes` configuration block ([#14759](https://github.com/terraform-providers/terraform-provider-aws/issues/14759)) -* resource/aws_storagegateway_nfs_file_share: Support `S3_INTELLIGENT_TIERING` value in `default_storage_class` argument plan-time validation ([#14759](https://github.com/terraform-providers/terraform-provider-aws/issues/14759)) -* resource/aws_storagegateway_smb_file_share: Add `cache_attributes` configuration block and `case_sensitivity` argument ([#14790](https://github.com/terraform-providers/terraform-provider-aws/issues/14790)) -* resource/aws_storagegateway_smb_file_share: Support `S3_INTELLIGENT_TIERING` value in `default_storage_class` argument plan-time validation ([#14790](https://github.com/terraform-providers/terraform-provider-aws/issues/14790)) -* resource/aws_xray_sampling_rule: Add `tags` argument ([#14831](https://github.com/terraform-providers/terraform-provider-aws/issues/14831)) +* resource/aws_apigatewayv2_integration: Add `integration_subtype` argument (Support AWS service integrations for HTTP APIs) ([#14860](https://github.com/hashicorp/terraform-provider-aws/issues/14860)) +* resource/aws_elasticache_replication_group: Add plan-time validation for `notification_topic_arn` and `snapshot_arns` arguments ([#12974](https://github.com/hashicorp/terraform-provider-aws/issues/12974)) +* resource/aws_globalaccelerator_endpoint_group: Add `client_ip_preservation_enabled` argument to the `endpoint_configuration` configuration block ([#14486](https://github.com/hashicorp/terraform-provider-aws/issues/14486)) +* resource/aws_storagegateway_cached_iscsi_volume: Add `kms_encrypted` and `kms_key` arguments ([#12066](https://github.com/hashicorp/terraform-provider-aws/issues/12066)) +* resource/aws_storagegateway_gateway: Add `smb_security_strategy` argument ([#13563](https://github.com/hashicorp/terraform-provider-aws/issues/13563)) +* resource/aws_storagegateway_gateway: Add plan-time validation for `gateway_ip_address` argument ([#13563](https://github.com/hashicorp/terraform-provider-aws/issues/13563)) +* resource/aws_storagegateway_gateway: Add `average_download_rate_limit_in_bits_per_sec` and `average_upload_rate_limit_in_bits_per_sec` arguments ([#13568](https://github.com/hashicorp/terraform-provider-aws/issues/13568)) +* resource/aws_storagegateway_nfs_file_share: Add `cache_attributes` configuration block ([#14759](https://github.com/hashicorp/terraform-provider-aws/issues/14759)) +* resource/aws_storagegateway_nfs_file_share: Support `S3_INTELLIGENT_TIERING` value in `default_storage_class` argument plan-time validation ([#14759](https://github.com/hashicorp/terraform-provider-aws/issues/14759)) +* resource/aws_storagegateway_smb_file_share: Add `cache_attributes` configuration block and `case_sensitivity` argument ([#14790](https://github.com/hashicorp/terraform-provider-aws/issues/14790)) +* resource/aws_storagegateway_smb_file_share: Support `S3_INTELLIGENT_TIERING` value in `default_storage_class` argument plan-time validation ([#14790](https://github.com/hashicorp/terraform-provider-aws/issues/14790)) +* resource/aws_xray_sampling_rule: Add `tags` argument ([#14831](https://github.com/hashicorp/terraform-provider-aws/issues/14831)) BUG FIXES -* resource/aws_acmpca_certificate_authority: Ensure `DELETED` status triggers state removal ([#13684](https://github.com/terraform-providers/terraform-provider-aws/issues/13684)) -* resource/aws_appmesh_virtual_node: Prevent panics with empty `backend` configuration blocks ([#14074](https://github.com/terraform-providers/terraform-provider-aws/issues/14074)) -* resource/aws_cloudfront_distribution: Preview panics during resource import with empty `forwarded_values.query_string` ([#14844](https://github.com/terraform-providers/terraform-provider-aws/issues/14844)) -* resource/aws_elasticache_replication_group: Ensure `tags` are stored in Terraform state and properly updated ([#12974](https://github.com/terraform-providers/terraform-provider-aws/issues/12974)) -* resource/aws_emr_instance_group: Increase creation and update timeout to 30 minutes ([#13077](https://github.com/terraform-providers/terraform-provider-aws/issues/13077)] / [[#14106](https://github.com/terraform-providers/terraform-provider-aws/issues/14106)) -* resource/aws_globalaccelerator_accelerator: Increase creation timeout to 10 minutes ([#14486](https://github.com/terraform-providers/terraform-provider-aws/issues/14486)) -* resource/aws_globalaccelerator_endpoint_group: Prevent differences with `health_check_path` defaults ([#14486](https://github.com/terraform-providers/terraform-provider-aws/issues/14486)) -* resource/aws_glue_crawler: Properly update `schedule` value ([#14792](https://github.com/terraform-providers/terraform-provider-aws/issues/14792)) +* resource/aws_acmpca_certificate_authority: Ensure `DELETED` status triggers state removal ([#13684](https://github.com/hashicorp/terraform-provider-aws/issues/13684)) +* resource/aws_appmesh_virtual_node: Prevent panics with empty `backend` configuration blocks ([#14074](https://github.com/hashicorp/terraform-provider-aws/issues/14074)) +* resource/aws_cloudfront_distribution: Preview panics during resource import with empty `forwarded_values.query_string` ([#14844](https://github.com/hashicorp/terraform-provider-aws/issues/14844)) +* resource/aws_elasticache_replication_group: Ensure `tags` are stored in Terraform state and properly updated ([#12974](https://github.com/hashicorp/terraform-provider-aws/issues/12974)) +* resource/aws_emr_instance_group: Increase creation and update timeout to 30 minutes ([#13077](https://github.com/hashicorp/terraform-provider-aws/issues/13077)] / [[#14106](https://github.com/hashicorp/terraform-provider-aws/issues/14106)) +* resource/aws_globalaccelerator_accelerator: Increase creation timeout to 10 minutes ([#14486](https://github.com/hashicorp/terraform-provider-aws/issues/14486)) +* resource/aws_globalaccelerator_endpoint_group: Prevent differences with `health_check_path` defaults ([#14486](https://github.com/hashicorp/terraform-provider-aws/issues/14486)) +* resource/aws_glue_crawler: Properly update `schedule` value ([#14792](https://github.com/hashicorp/terraform-provider-aws/issues/14792)) ## 3.3.0 (August 20, 2020) ENHANCEMENTS -* data-source/aws_lambda_layer_version: Support `java8.al2` and `provided.al2` in `runtime` argument plan-time validation ([#14663](https://github.com/terraform-providers/terraform-provider-aws/issues/14663)) -* provider: Support for appending information to User-Agent request headers with the `TF_APPEND_USER_AGENT` environment variable ([#14555](https://github.com/terraform-providers/terraform-provider-aws/issues/14555)) -* resource/aws_apigatewayv2_api: Add `body` argument ([#12567](https://github.com/terraform-providers/terraform-provider-aws/issues/12567)) -* resource/aws_customer_gateway: Support tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_dms_replication_instance: Add `allow_major_version_upgrade` argument ([#14550](https://github.com/terraform-providers/terraform-provider-aws/issues/14550)) -* resource/aws_ec2_client_vpn_network_association: Allow specifying custom security groups ([#14146](https://github.com/terraform-providers/terraform-provider-aws/issues/14146)) -* resource/aws_ec2_client_vpn_network_association: Support resource import ([#14146](https://github.com/terraform-providers/terraform-provider-aws/issues/14146)) -* resource/aws_egress_only_intrenet_gateway:-Ssupport tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_eks_node_group: Support `AL2_ARM_64` value for `ami_type` argument plan-time validation ([#14729](https://github.com/terraform-providers/terraform-provider-aws/issues/14729)) -* resource/aws_eks_node_group: Add `launch_template` configuration block ([#14639](https://github.com/terraform-providers/terraform-provider-aws/issues/14639)) -* resource/aws_internet_gateway: Support tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_lambda_function: Support `java8.al2` and `provided.al2` in `runtime` argument plan-time validation ([#14663](https://github.com/terraform-providers/terraform-provider-aws/issues/14663)) -* resource/aws_lambda_layer_version: Support `java8.al2` and `provided.al2` in `compatible_runtimes` argument plan-time validation ([#14663](https://github.com/terraform-providers/terraform-provider-aws/issues/14663)) -* resource/aws_launch_template: Support `elastic-gpu` and `spot-instances-request` in `tag_specifications` `resource_type` argument plan-time validation ([#14662](https://github.com/terraform-providers/terraform-provider-aws/issues/14662)) -* resource/aws_network_acl: Support tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_network_interface: Support tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_route_table: Support tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_security_group: Support tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_spot_instance_request: Support tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_storagegatway_smb_file_share: Add `audit_destination_arn` and `smb_acl_enabled` arguments ([#13572](https://github.com/terraform-providers/terraform-provider-aws/issues/13572)) -* resource/aws_subnet: Support tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_subnet: Add plan-time validation to `ipv6_cidr_block` argument ([#12303](https://github.com/terraform-providers/terraform-provider-aws/issues/12303)) -* resource/aws_vpc_dhcp_options: Support tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_vpc_peering_connection: Support tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_vpn_connection: Support tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_vpn_gateway: Support tag on create ([#14501](https://github.com/terraform-providers/terraform-provider-aws/issues/14501)) -* resource/aws_wafv2_rule_group: Add `forwarded_ip_config` configuration block to `geo_match_statement` ([#14685](https://github.com/terraform-providers/terraform-provider-aws/issues/14685)) -* resource/aws_wafv2_web_acl: Add `forwarded_ip_config` configuration block to `rate_based_statement` and `geo_match_statement` ([#14685](https://github.com/terraform-providers/terraform-provider-aws/issues/14685)) -* resource/aws_wafv2_web_acl: Support `FORWARDED_IP` value for `rate_based_statement` `aggregate_key_type` argument plan-time validation ([#14685](https://github.com/terraform-providers/terraform-provider-aws/issues/14685)) +* data-source/aws_lambda_layer_version: Support `java8.al2` and `provided.al2` in `runtime` argument plan-time validation ([#14663](https://github.com/hashicorp/terraform-provider-aws/issues/14663)) +* provider: Support for appending information to User-Agent request headers with the `TF_APPEND_USER_AGENT` environment variable ([#14555](https://github.com/hashicorp/terraform-provider-aws/issues/14555)) +* resource/aws_apigatewayv2_api: Add `body` argument ([#12567](https://github.com/hashicorp/terraform-provider-aws/issues/12567)) +* resource/aws_customer_gateway: Support tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_dms_replication_instance: Add `allow_major_version_upgrade` argument ([#14550](https://github.com/hashicorp/terraform-provider-aws/issues/14550)) +* resource/aws_ec2_client_vpn_network_association: Allow specifying custom security groups ([#14146](https://github.com/hashicorp/terraform-provider-aws/issues/14146)) +* resource/aws_ec2_client_vpn_network_association: Support resource import ([#14146](https://github.com/hashicorp/terraform-provider-aws/issues/14146)) +* resource/aws_egress_only_intrenet_gateway:-Ssupport tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_eks_node_group: Support `AL2_ARM_64` value for `ami_type` argument plan-time validation ([#14729](https://github.com/hashicorp/terraform-provider-aws/issues/14729)) +* resource/aws_eks_node_group: Add `launch_template` configuration block ([#14639](https://github.com/hashicorp/terraform-provider-aws/issues/14639)) +* resource/aws_internet_gateway: Support tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_lambda_function: Support `java8.al2` and `provided.al2` in `runtime` argument plan-time validation ([#14663](https://github.com/hashicorp/terraform-provider-aws/issues/14663)) +* resource/aws_lambda_layer_version: Support `java8.al2` and `provided.al2` in `compatible_runtimes` argument plan-time validation ([#14663](https://github.com/hashicorp/terraform-provider-aws/issues/14663)) +* resource/aws_launch_template: Support `elastic-gpu` and `spot-instances-request` in `tag_specifications` `resource_type` argument plan-time validation ([#14662](https://github.com/hashicorp/terraform-provider-aws/issues/14662)) +* resource/aws_network_acl: Support tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_network_interface: Support tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_route_table: Support tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_security_group: Support tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_spot_instance_request: Support tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_storagegatway_smb_file_share: Add `audit_destination_arn` and `smb_acl_enabled` arguments ([#13572](https://github.com/hashicorp/terraform-provider-aws/issues/13572)) +* resource/aws_subnet: Support tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_subnet: Add plan-time validation to `ipv6_cidr_block` argument ([#12303](https://github.com/hashicorp/terraform-provider-aws/issues/12303)) +* resource/aws_vpc_dhcp_options: Support tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_vpc_peering_connection: Support tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_vpn_connection: Support tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_vpn_gateway: Support tag on create ([#14501](https://github.com/hashicorp/terraform-provider-aws/issues/14501)) +* resource/aws_wafv2_rule_group: Add `forwarded_ip_config` configuration block to `geo_match_statement` ([#14685](https://github.com/hashicorp/terraform-provider-aws/issues/14685)) +* resource/aws_wafv2_web_acl: Add `forwarded_ip_config` configuration block to `rate_based_statement` and `geo_match_statement` ([#14685](https://github.com/hashicorp/terraform-provider-aws/issues/14685)) +* resource/aws_wafv2_web_acl: Support `FORWARDED_IP` value for `rate_based_statement` `aggregate_key_type` argument plan-time validation ([#14685](https://github.com/hashicorp/terraform-provider-aws/issues/14685)) BUG FIXES -* resource/aws_api_gateway_vpc_link: Increase create, update, and delete timeouts to 20 minutes ([#10407](https://github.com/terraform-providers/terraform-provider-aws/issues/10407)) -* resource/aws_apigatewayv2_stage: Set `execution_arn` attribute for HTTP APIs ([#14638](https://github.com/terraform-providers/terraform-provider-aws/issues/14638)) -* resource/aws_db_parameter_group: Restore ability to update `parameter` configuration values ([#12112](https://github.com/terraform-providers/terraform-provider-aws/issues/12112)) -* resource/aws_user_pool_domain: Ensure state removal when deleted outside Terraform ([#14732](https://github.com/terraform-providers/terraform-provider-aws/issues/14732)) -* resource/aws_rds_cluster_parameter_group: Restore ability to update `parameter` configuration values ([#12112](https://github.com/terraform-providers/terraform-provider-aws/issues/12112)) -* resource/aws_ssm_parameter: Handle retries after creation for asynchronous `data_type` validation process ([#14514](https://github.com/terraform-providers/terraform-provider-aws/issues/14514)) -* resource/aws_storagegateway_nfs_file_share: Skip `UpdateSMBFileShare` API call when only `tags` change and remove extraneous `ListTagsForResource` API call during read ([#13590](https://github.com/terraform-providers/terraform-provider-aws/issues/13590)) -* resource/aws_subnet: Ensure `ipv6_cidr_block` argument performs removal when removed from configuration ([#12303](https://github.com/terraform-providers/terraform-provider-aws/issues/12303)) +* resource/aws_api_gateway_vpc_link: Increase create, update, and delete timeouts to 20 minutes ([#10407](https://github.com/hashicorp/terraform-provider-aws/issues/10407)) +* resource/aws_apigatewayv2_stage: Set `execution_arn` attribute for HTTP APIs ([#14638](https://github.com/hashicorp/terraform-provider-aws/issues/14638)) +* resource/aws_db_parameter_group: Restore ability to update `parameter` configuration values ([#12112](https://github.com/hashicorp/terraform-provider-aws/issues/12112)) +* resource/aws_user_pool_domain: Ensure state removal when deleted outside Terraform ([#14732](https://github.com/hashicorp/terraform-provider-aws/issues/14732)) +* resource/aws_rds_cluster_parameter_group: Restore ability to update `parameter` configuration values ([#12112](https://github.com/hashicorp/terraform-provider-aws/issues/12112)) +* resource/aws_ssm_parameter: Handle retries after creation for asynchronous `data_type` validation process ([#14514](https://github.com/hashicorp/terraform-provider-aws/issues/14514)) +* resource/aws_storagegateway_nfs_file_share: Skip `UpdateSMBFileShare` API call when only `tags` change and remove extraneous `ListTagsForResource` API call during read ([#13590](https://github.com/hashicorp/terraform-provider-aws/issues/13590)) +* resource/aws_subnet: Ensure `ipv6_cidr_block` argument performs removal when removed from configuration ([#12303](https://github.com/hashicorp/terraform-provider-aws/issues/12303)) ## 3.2.0 (August 14, 2020) ENHANCEMENTS -* data-source/aws_launch_configuration: Add `ebs_block_device` `no_device` attribute ([#14583](https://github.com/terraform-providers/terraform-provider-aws/issues/14583)) -* data-source/aws_lb: Add `subnet_mapping` `private_ipv4_address` attribute ([#14545](https://github.com/terraform-providers/terraform-provider-aws/issues/14545)) -* provider: Upgrade to Terraform Plugin SDK V2. There should be no breaking changes from a practitioner's perspective. Some validation errors should now feature enhanced messaging. ([#14432](https://github.com/terraform-providers/terraform-provider-aws/issues/14432)) -* resource/aws_accessanalyzer_analyzer: Support `ORGANIZATION` value in `type` argument ([#14493](https://github.com/terraform-providers/terraform-provider-aws/issues/14493)) -* resource/aws_codebuild_project: Support `WINDOWS_SERVER_2019_CONTAINER` value in `environment` `type` argument plan-time validation ([#14532](https://github.com/terraform-providers/terraform-provider-aws/issues/14532)) -* resource/aws_organizations_organization: Support `AISERVICES_OPT_OUT_POLICY` value in `enabled_policy_types` argument plan-time validation (Support AI Opt Out policies) ([#14650](https://github.com/terraform-providers/terraform-provider-aws/issues/14650)) -* resource/aws_organizations_policy: Support `AISERVICES_OPT_OUT_POLICY` value in `type` argument plan-time validation (Support AI Opt Out policies) ([#14528](https://github.com/terraform-providers/terraform-provider-aws/issues/14528)) -* resource/aws_route53_health_check: Add `disabled` argument ([#14614](https://github.com/terraform-providers/terraform-provider-aws/issues/14614)) +* data-source/aws_launch_configuration: Add `ebs_block_device` `no_device` attribute ([#14583](https://github.com/hashicorp/terraform-provider-aws/issues/14583)) +* data-source/aws_lb: Add `subnet_mapping` `private_ipv4_address` attribute ([#14545](https://github.com/hashicorp/terraform-provider-aws/issues/14545)) +* provider: Upgrade to Terraform Plugin SDK V2. There should be no breaking changes from a practitioner's perspective. Some validation errors should now feature enhanced messaging. ([#14432](https://github.com/hashicorp/terraform-provider-aws/issues/14432)) +* resource/aws_accessanalyzer_analyzer: Support `ORGANIZATION` value in `type` argument ([#14493](https://github.com/hashicorp/terraform-provider-aws/issues/14493)) +* resource/aws_codebuild_project: Support `WINDOWS_SERVER_2019_CONTAINER` value in `environment` `type` argument plan-time validation ([#14532](https://github.com/hashicorp/terraform-provider-aws/issues/14532)) +* resource/aws_organizations_organization: Support `AISERVICES_OPT_OUT_POLICY` value in `enabled_policy_types` argument plan-time validation (Support AI Opt Out policies) ([#14650](https://github.com/hashicorp/terraform-provider-aws/issues/14650)) +* resource/aws_organizations_policy: Support `AISERVICES_OPT_OUT_POLICY` value in `type` argument plan-time validation (Support AI Opt Out policies) ([#14528](https://github.com/hashicorp/terraform-provider-aws/issues/14528)) +* resource/aws_route53_health_check: Add `disabled` argument ([#14614](https://github.com/hashicorp/terraform-provider-aws/issues/14614)) BUG FIXES -* data-source/aws_launch_template: Prevent type error with `network_interfaces` `delete_on_termination` attribute ([#14599](https://github.com/terraform-providers/terraform-provider-aws/issues/14599)) -* resource/aws_acm_certificate_validation: Prevent panic with missing `DomainValidationOptions` `ResourceRecord` attribute in API response [[#14590](https://github.com/terraform-providers/terraform-provider-aws/issues/14590)] -* resource/aws_ecr_repository: Prevent panic with missing `EncryptionConfiguration` attribute in API response ([#14584](https://github.com/terraform-providers/terraform-provider-aws/issues/14584)) -* resource/aws_wafv2_rule_group: Prevent unnecessary resource recreation with `rule` updates ([#14617](https://github.com/terraform-providers/terraform-provider-aws/issues/14617)) -* resource/aws_wafv2_web_acl: Prevent unnecessary resource recreation with `rule` updates ([#14616](https://github.com/terraform-providers/terraform-provider-aws/issues/14616)) +* data-source/aws_launch_template: Prevent type error with `network_interfaces` `delete_on_termination` attribute ([#14599](https://github.com/hashicorp/terraform-provider-aws/issues/14599)) +* resource/aws_acm_certificate_validation: Prevent panic with missing `DomainValidationOptions` `ResourceRecord` attribute in API response [[#14590](https://github.com/hashicorp/terraform-provider-aws/issues/14590)] +* resource/aws_ecr_repository: Prevent panic with missing `EncryptionConfiguration` attribute in API response ([#14584](https://github.com/hashicorp/terraform-provider-aws/issues/14584)) +* resource/aws_wafv2_rule_group: Prevent unnecessary resource recreation with `rule` updates ([#14617](https://github.com/hashicorp/terraform-provider-aws/issues/14617)) +* resource/aws_wafv2_web_acl: Prevent unnecessary resource recreation with `rule` updates ([#14616](https://github.com/hashicorp/terraform-provider-aws/issues/14616)) ## 3.1.0 (August 07, 2020) NOTES: -* resource/aws_route53_zone_association: The addition of cross-account zone association support required the use of new `ListHostedZonesByVPC` API call and adding the VPC Region to the resource ID for new resources. Restrictive IAM permissions for Terraform and cross-region imports may require updates. ([#14215](https://github.com/terraform-providers/terraform-provider-aws/issues/14215)) +* resource/aws_route53_zone_association: The addition of cross-account zone association support required the use of new `ListHostedZonesByVPC` API call and adding the VPC Region to the resource ID for new resources. Restrictive IAM permissions for Terraform and cross-region imports may require updates. ([#14215](https://github.com/hashicorp/terraform-provider-aws/issues/14215)) FEATURES -* **New Data Source:** `aws_ec2_spot_price` ([#12504](https://github.com/terraform-providers/terraform-provider-aws/issues/12504)) -* **New Resource**: `aws_route53_vpc_association_authorization` ([#14215](https://github.com/terraform-providers/terraform-provider-aws/issues/14215)) +* **New Data Source:** `aws_ec2_spot_price` ([#12504](https://github.com/hashicorp/terraform-provider-aws/issues/12504)) +* **New Resource**: `aws_route53_vpc_association_authorization` ([#14215](https://github.com/hashicorp/terraform-provider-aws/issues/14215)) ENHANCEMENTS -* data-source/aws_ecr_repository: Allow `registry_id` as an argument ([#14368](https://github.com/terraform-providers/terraform-provider-aws/issues/14368)) -* data-source/aws_ecr_repository: Add `image_scanning_configuration` and `image_tag_mutability` attributes ([#14368](https://github.com/terraform-providers/terraform-provider-aws/issues/14368)) -* data-source/aws_ecr_repository: Add `encryption_configuration` attribute ([#14520](https://github.com/terraform-providers/terraform-provider-aws/issues/14520)) -* resource/aws_api_gateway_method_settings: Plan-time validation added to `settings` `unauthorized_cache_control_header_strategy` and `logging_level` arguments ([#12651](https://github.com/terraform-providers/terraform-provider-aws/issues/12651)) -* resource/aws_ecr_repository: Add `encryption_configuration` attribute ([#14520](https://github.com/terraform-providers/terraform-provider-aws/issues/14520)) -* resource/aws_lb: Add `subnet_mapping` configuration block `private_ipv4_address` argument ([#11404](https://github.com/terraform-providers/terraform-provider-aws/issues/11404)) -* resource/aws_rds_global_cluster: Add `force_destroy` and `source_db_cluster_identifier` arguments ([#14487](https://github.com/terraform-providers/terraform-provider-aws/issues/14487)) -* resource/aws_rds_global_cluster: Add `global_cluster_members` attribute ([#14487](https://github.com/terraform-providers/terraform-provider-aws/issues/14487)) -* resource/aws_route53_zone_association: Cross-account zone associations can now be created in conjunction with the new `aws_route53_vpc_association_authorization` resource ([#14215](https://github.com/terraform-providers/terraform-provider-aws/issues/14215)) -* resource/aws_ssm_parameter: Add `data_type` argument (support `aws:ec2:image` parameters) ([#13326](https://github.com/terraform-providers/terraform-provider-aws/issues/13326)) +* data-source/aws_ecr_repository: Allow `registry_id` as an argument ([#14368](https://github.com/hashicorp/terraform-provider-aws/issues/14368)) +* data-source/aws_ecr_repository: Add `image_scanning_configuration` and `image_tag_mutability` attributes ([#14368](https://github.com/hashicorp/terraform-provider-aws/issues/14368)) +* data-source/aws_ecr_repository: Add `encryption_configuration` attribute ([#14520](https://github.com/hashicorp/terraform-provider-aws/issues/14520)) +* resource/aws_api_gateway_method_settings: Plan-time validation added to `settings` `unauthorized_cache_control_header_strategy` and `logging_level` arguments ([#12651](https://github.com/hashicorp/terraform-provider-aws/issues/12651)) +* resource/aws_ecr_repository: Add `encryption_configuration` attribute ([#14520](https://github.com/hashicorp/terraform-provider-aws/issues/14520)) +* resource/aws_lb: Add `subnet_mapping` configuration block `private_ipv4_address` argument ([#11404](https://github.com/hashicorp/terraform-provider-aws/issues/11404)) +* resource/aws_rds_global_cluster: Add `force_destroy` and `source_db_cluster_identifier` arguments ([#14487](https://github.com/hashicorp/terraform-provider-aws/issues/14487)) +* resource/aws_rds_global_cluster: Add `global_cluster_members` attribute ([#14487](https://github.com/hashicorp/terraform-provider-aws/issues/14487)) +* resource/aws_route53_zone_association: Cross-account zone associations can now be created in conjunction with the new `aws_route53_vpc_association_authorization` resource ([#14215](https://github.com/hashicorp/terraform-provider-aws/issues/14215)) +* resource/aws_ssm_parameter: Add `data_type` argument (support `aws:ec2:image` parameters) ([#13326](https://github.com/hashicorp/terraform-provider-aws/issues/13326)) BUG FIXES -* data-source/aws_availability_zones: Prevent unexpected plan output every apply with `group_names` attribute ([#14412](https://github.com/terraform-providers/terraform-provider-aws/issues/14412)) -* data-source/aws_s3_bucket: Ensure provider `s3_force_path_style` configuration is passed through for getting S3 Bucket location with non-AWS implementations ([#14481](https://github.com/terraform-providers/terraform-provider-aws/issues/14481)) -* resource/aws_api_gateway_method_settings: Allow `settings` `cache_ttl_in_seconds` argument to be set to 0 ([#12651](https://github.com/terraform-providers/terraform-provider-aws/issues/12651)) -* resource/aws_elastictranscoder_preset: Prevent empty configuration block panics ([#14092](https://github.com/terraform-providers/terraform-provider-aws/issues/14092)) -* resource/aws_lambda_event_source_mapping: Allow `maximum_retry_attempts` argument to be set to 0 ([#12479](https://github.com/terraform-providers/terraform-provider-aws/issues/12479)) -* resource/aws_rds_cluster: Add an `InvalidDBClusterStateFault` retryable error condition for clusters part of a global cluster ([#14420](https://github.com/terraform-providers/terraform-provider-aws/issues/14420)) -* resource/aws_rds_cluster: Increase retry timeout for deletion to 2 minutes ([#14420](https://github.com/terraform-providers/terraform-provider-aws/issues/14420)) -* resource/aws_rds_cluster: Prevent error when both `global_cluster_identifier` and `replication_source_identifier` are configured on creation ([#14490](https://github.com/terraform-providers/terraform-provider-aws/issues/14490)) -* resource/aws_s3_bucket: Ensure provider `s3_force_path_style` configuration is passed through for getting S3 Bucket location with non-AWS implementations ([#14481](https://github.com/terraform-providers/terraform-provider-aws/issues/14481)) -* resource/aws_secretsmanager_secret: Allow retries for IAM eventual consistency errors ([#14459](https://github.com/terraform-providers/terraform-provider-aws/issues/14459)) -* resource/aws_security_group: Ensure `name_prefix` argument with hex digits `a` through `f` is properly imported ([#14475](https://github.com/terraform-providers/terraform-provider-aws/issues/14475)) -* resource/aws_spot_fleet_request: Allow `target_capacity` argument to be updated to 0 ([#12759](https://github.com/terraform-providers/terraform-provider-aws/issues/12759)) -* resource/aws_spot_fleet_request: Wait for modify operation completion (default timeout of 10 minutes) ([#12759](https://github.com/terraform-providers/terraform-provider-aws/issues/12759)) -* resource/aws_vpc_dhcp_options_association: Properly trigger resource recreation when VPC is deleted outside Terraform ([#14367](https://github.com/terraform-providers/terraform-provider-aws/issues/14367)) +* data-source/aws_availability_zones: Prevent unexpected plan output every apply with `group_names` attribute ([#14412](https://github.com/hashicorp/terraform-provider-aws/issues/14412)) +* data-source/aws_s3_bucket: Ensure provider `s3_force_path_style` configuration is passed through for getting S3 Bucket location with non-AWS implementations ([#14481](https://github.com/hashicorp/terraform-provider-aws/issues/14481)) +* resource/aws_api_gateway_method_settings: Allow `settings` `cache_ttl_in_seconds` argument to be set to 0 ([#12651](https://github.com/hashicorp/terraform-provider-aws/issues/12651)) +* resource/aws_elastictranscoder_preset: Prevent empty configuration block panics ([#14092](https://github.com/hashicorp/terraform-provider-aws/issues/14092)) +* resource/aws_lambda_event_source_mapping: Allow `maximum_retry_attempts` argument to be set to 0 ([#12479](https://github.com/hashicorp/terraform-provider-aws/issues/12479)) +* resource/aws_rds_cluster: Add an `InvalidDBClusterStateFault` retryable error condition for clusters part of a global cluster ([#14420](https://github.com/hashicorp/terraform-provider-aws/issues/14420)) +* resource/aws_rds_cluster: Increase retry timeout for deletion to 2 minutes ([#14420](https://github.com/hashicorp/terraform-provider-aws/issues/14420)) +* resource/aws_rds_cluster: Prevent error when both `global_cluster_identifier` and `replication_source_identifier` are configured on creation ([#14490](https://github.com/hashicorp/terraform-provider-aws/issues/14490)) +* resource/aws_s3_bucket: Ensure provider `s3_force_path_style` configuration is passed through for getting S3 Bucket location with non-AWS implementations ([#14481](https://github.com/hashicorp/terraform-provider-aws/issues/14481)) +* resource/aws_secretsmanager_secret: Allow retries for IAM eventual consistency errors ([#14459](https://github.com/hashicorp/terraform-provider-aws/issues/14459)) +* resource/aws_security_group: Ensure `name_prefix` argument with hex digits `a` through `f` is properly imported ([#14475](https://github.com/hashicorp/terraform-provider-aws/issues/14475)) +* resource/aws_spot_fleet_request: Allow `target_capacity` argument to be updated to 0 ([#12759](https://github.com/hashicorp/terraform-provider-aws/issues/12759)) +* resource/aws_spot_fleet_request: Wait for modify operation completion (default timeout of 10 minutes) ([#12759](https://github.com/hashicorp/terraform-provider-aws/issues/12759)) +* resource/aws_vpc_dhcp_options_association: Properly trigger resource recreation when VPC is deleted outside Terraform ([#14367](https://github.com/hashicorp/terraform-provider-aws/issues/14367)) ## 3.0.0 (July 31, 2020) @@ -553,109 +553,109 @@ NOTES: BREAKING CHANGES -* provider: New versions of the provider can only be automatically installed on Terraform 0.12 and later ([#14143](https://github.com/terraform-providers/terraform-provider-aws/issues/14143)) -* provider: All "removed" attributes are cut, using them would result in a Terraform Core level error ([#14001](https://github.com/terraform-providers/terraform-provider-aws/issues/14001)) -* provider: Credential ordering has changed from static, environment, shared credentials, EC2 metadata, default AWS Go SDK (shared configuration, web identity, ECS, EC2 Metadata) to static, environment, shared credentials, default AWS Go SDK (shared configuration, web identity, ECS, EC2 Metadata) ([#14077](https://github.com/terraform-providers/terraform-provider-aws/issues/14077)) -* provider: The `AWS_METADATA_TIMEOUT` environment variable no longer has any effect as we now depend on the default AWS Go SDK EC2 Metadata client timeout of one second with two retries ([#14077](https://github.com/terraform-providers/terraform-provider-aws/issues/14077)) -* provider: Remove deprecated `kinesis_analytics` and `r53` custom service endpoint arguments ([#14238](https://github.com/terraform-providers/terraform-provider-aws/issues/14238)) -* data-source/aws_availability_zones: Remove deprecated `blacklisted_names` and `blacklisted_zone_ids` arguments ([#14134](https://github.com/terraform-providers/terraform-provider-aws/issues/14134)) -* data-source/aws_directory_service_directory: Return an error when a single result is not found ([#14006](https://github.com/terraform-providers/terraform-provider-aws/issues/14006)) -* data-source/aws_ecr_repository: Return an error when a single result is not found ([#10520](https://github.com/terraform-providers/terraform-provider-aws/issues/10520)) -* data-source/aws_efs_file_system: Return an error when a single result is not found ([#14005](https://github.com/terraform-providers/terraform-provider-aws/issues/14005)) -* data-source/aws_launch_template: Return an error when a single result is not found ([#10521](https://github.com/terraform-providers/terraform-provider-aws/issues/10521)) -* data-source/aws_route53_resolver_rule: Trailing period removed from `domain_name` argument set in data-source ([#14220](https://github.com/terraform-providers/terraform-provider-aws/issues/14220)) -* data-source/aws_route53_zone: Trailing period removed from `name` argument set in data-source ([#14220](https://github.com/terraform-providers/terraform-provider-aws/issues/14220)) -* resource/aws_acm_certificate: `certificate_body`, `certificate_chain`, and `private_key` attributes are no longer stored in the Terraform state with hash values ([#9685](https://github.com/terraform-providers/terraform-provider-aws/issues/9685)) -* resource/aws_acm_certificate: `domain_validation_options` attribute changed from list to set ([#14199](https://github.com/terraform-providers/terraform-provider-aws/issues/14199)) -* resource/aws_acm_certificate: Plan-time validation added to `domain_name` and `subject_alternative_names` arguments to prevent usage of strings with trailing periods ([#14220](https://github.com/terraform-providers/terraform-provider-aws/issues/14220)) -* resource/aws_api_gateway_method_settings: Remove `Computed` property from `throttling_burst_limit` and `throttling_rate_limit` arguments, enabling drift detection ([#14266](https://github.com/terraform-providers/terraform-provider-aws/issues/14266)) -* resource/aws_api_gateway_method_settings: Update `throttling_burst_limit` and `throttling_rate_limit` argument defaults to match API default of `-1` to keep throttling disabled ([#14266](https://github.com/terraform-providers/terraform-provider-aws/issues/14266)) -* resource/aws_autoscaling_group: `availability_zones` and `vpc_zone_identifier` argument conflict now reported at plan-time ([#12927](https://github.com/terraform-providers/terraform-provider-aws/issues/12927)) -* resource/aws_autoscaling_group: Remove `Computed` property from `load_balancers` and `target_group_arns` arguments, enabling drift detection ([#14064](https://github.com/terraform-providers/terraform-provider-aws/issues/14064)) -* resource/aws_cloudfront_distribution: `active_trusted_signers` argument renamed to `trusted_signers` to support accessing `items` in Terraform 0.12 ([#14339](https://github.com/terraform-providers/terraform-provider-aws/issues/14339)) -* resource/aws_cloudwatch_log_group: Automatically trim `:*` suffix from `arn` attribute ([#14214](https://github.com/terraform-providers/terraform-provider-aws/issues/14214)) -* resource/aws_codepipeline: Removes `GITHUB_TOKEN` environment variable ([#14175](https://github.com/terraform-providers/terraform-provider-aws/issues/14175)) -* resource/aws_cognito_user_pool: Remove deprecated `admin_create_user_config` configuration block `unused_account_validity_days` argument ([#14294](https://github.com/terraform-providers/terraform-provider-aws/issues/14294)) -* resource/aws_dx_gateway: Remove automatic `aws_dx_gateway_association` resource import ([#14124](https://github.com/terraform-providers/terraform-provider-aws/issues/14124)) -* resource/aws_dx_gateway_association: Remove deprecated `vpn_gateway_id` argument ([#14144](https://github.com/terraform-providers/terraform-provider-aws/issues/14144)) -* resource/aws_dx_gateway_association_proposal: Remove deprecated `vpn_gateway_id` argument ([#14144](https://github.com/terraform-providers/terraform-provider-aws/issues/14144)) -* resource/aws_ebs_volume: Return an error when `iops` argument set to a value greater than 0 for volume types other than `io1` ([#14310](https://github.com/terraform-providers/terraform-provider-aws/issues/14310)) -* resource/aws_elastic_transcoder_preset: Remove `video` configuration block `max_frame_rate` argument default value ([#7141](https://github.com/terraform-providers/terraform-provider-aws/issues/7141)) -* resource/aws_emr_cluster: Remove deprecated `instance_group` configuration block, `core_instance_count`, `core_instance_type`, and `master_instance_type` arguments ([#14137](https://github.com/terraform-providers/terraform-provider-aws/issues/14137)) -* resource/aws_glue_job: Remove deprecated `allocated_capacity` argument ([#14296](https://github.com/terraform-providers/terraform-provider-aws/issues/14296)) -* resource/aws_iam_access_key: Remove deprecated `ses_smtp_password` attribute ([#14299](https://github.com/terraform-providers/terraform-provider-aws/issues/14299)) -* resource/aws_iam_instance_profile: Remove deprecated `roles` argument ([#14303](https://github.com/terraform-providers/terraform-provider-aws/issues/14303)) -* resource/aws_iam_server_certificate: Remove state hashing from `certificate_body`, `certificate_chain`, and `private_key` arguments for new or recreated resources ([#14187](https://github.com/terraform-providers/terraform-provider-aws/issues/14187)) -* resource/aws_instance: Return an error when `ebs_block_device` `iops` or `root_block_device` `iops` argument set to a value greater than `0` for volume types other than `io1` ([#14310](https://github.com/terraform-providers/terraform-provider-aws/issues/14310)) -* resource/aws_lambda_alias: Resource import no longer converts Lambda Function name to ARN ([#12876](https://github.com/terraform-providers/terraform-provider-aws/issues/12876)) -* resource/aws_launch_template: `network_interfaces` `delete_on_termination` argument changed from `bool` to `string` type ([#8612](https://github.com/terraform-providers/terraform-provider-aws/issues/8612)) -* resource/aws_lb_listener_rule: Remove deprecated `condition` configuration block `field` and `values` arguments ([#14309](https://github.com/terraform-providers/terraform-provider-aws/issues/14309)) -* resource/aws_msk_cluster: Update `encryption_info` `encryption_in_transit` `client_broker` argument default to match API default of `TLS` ([#14132](https://github.com/terraform-providers/terraform-provider-aws/issues/14132)) -* resource/aws_rds_cluster: Update `scaling_configuration` `min_capacity` argument default to match API default of `1` ([#14268](https://github.com/terraform-providers/terraform-provider-aws/issues/14268)) -* resource/aws_route53_resolver_rule: Trailing period removed from `domain_name` argument set in resource ([#14220](https://github.com/terraform-providers/terraform-provider-aws/issues/14220)) -* resource/aws_route53_zone: Trailing period removed from `name` argument set in resource ([#14220](https://github.com/terraform-providers/terraform-provider-aws/issues/14220)) -* resource/aws_s3_bucket: Remove automatic `aws_s3_bucket_policy` resource import ([#14121](https://github.com/terraform-providers/terraform-provider-aws/issues/14121)) -* resource/aws_s3_bucket: Convert `region` to read-only attribute ([#14127](https://github.com/terraform-providers/terraform-provider-aws/issues/14127)) -* resource/aws_s3_bucket_metric: Update `filter` argument to require at least one of the `prefix` or `tags` nested arguments ([#14230](https://github.com/terraform-providers/terraform-provider-aws/issues/14230)) -* resource/aws_security_group: Remove automatic `aws_security_group_rule` resource import ([#12616](https://github.com/terraform-providers/terraform-provider-aws/issues/12616)) -* resource/aws_ses_domain_identity: Plan-time validation added to `domain` argument to prevent usage of strings with trailing periods ([#14220](https://github.com/terraform-providers/terraform-provider-aws/issues/14220)) -* resource/aws_ses_domain_identity_verification: Plan-time validation added to `domain` argument to prevent usage of strings with trailing periods ([#14220](https://github.com/terraform-providers/terraform-provider-aws/issues/14220)) -* resource/aws_sns_platform_application: `platform_credential` and `platform_principal` attributes are no longer stored in the Terraform state with hash values ([#3894](https://github.com/terraform-providers/terraform-provider-aws/issues/3894)) -* resource/aws_spot_fleet_request: Remove 24 hour default for `valid_until` argument ([#9718](https://github.com/terraform-providers/terraform-provider-aws/issues/9718)) -* resource/aws_ssm_maintenance_window_task: Remove deprecated `logging_info` and `task_parameters` configuration blocks ([#14311](https://github.com/terraform-providers/terraform-provider-aws/issues/14311)) +* provider: New versions of the provider can only be automatically installed on Terraform 0.12 and later ([#14143](https://github.com/hashicorp/terraform-provider-aws/issues/14143)) +* provider: All "removed" attributes are cut, using them would result in a Terraform Core level error ([#14001](https://github.com/hashicorp/terraform-provider-aws/issues/14001)) +* provider: Credential ordering has changed from static, environment, shared credentials, EC2 metadata, default AWS Go SDK (shared configuration, web identity, ECS, EC2 Metadata) to static, environment, shared credentials, default AWS Go SDK (shared configuration, web identity, ECS, EC2 Metadata) ([#14077](https://github.com/hashicorp/terraform-provider-aws/issues/14077)) +* provider: The `AWS_METADATA_TIMEOUT` environment variable no longer has any effect as we now depend on the default AWS Go SDK EC2 Metadata client timeout of one second with two retries ([#14077](https://github.com/hashicorp/terraform-provider-aws/issues/14077)) +* provider: Remove deprecated `kinesis_analytics` and `r53` custom service endpoint arguments ([#14238](https://github.com/hashicorp/terraform-provider-aws/issues/14238)) +* data-source/aws_availability_zones: Remove deprecated `blacklisted_names` and `blacklisted_zone_ids` arguments ([#14134](https://github.com/hashicorp/terraform-provider-aws/issues/14134)) +* data-source/aws_directory_service_directory: Return an error when a single result is not found ([#14006](https://github.com/hashicorp/terraform-provider-aws/issues/14006)) +* data-source/aws_ecr_repository: Return an error when a single result is not found ([#10520](https://github.com/hashicorp/terraform-provider-aws/issues/10520)) +* data-source/aws_efs_file_system: Return an error when a single result is not found ([#14005](https://github.com/hashicorp/terraform-provider-aws/issues/14005)) +* data-source/aws_launch_template: Return an error when a single result is not found ([#10521](https://github.com/hashicorp/terraform-provider-aws/issues/10521)) +* data-source/aws_route53_resolver_rule: Trailing period removed from `domain_name` argument set in data-source ([#14220](https://github.com/hashicorp/terraform-provider-aws/issues/14220)) +* data-source/aws_route53_zone: Trailing period removed from `name` argument set in data-source ([#14220](https://github.com/hashicorp/terraform-provider-aws/issues/14220)) +* resource/aws_acm_certificate: `certificate_body`, `certificate_chain`, and `private_key` attributes are no longer stored in the Terraform state with hash values ([#9685](https://github.com/hashicorp/terraform-provider-aws/issues/9685)) +* resource/aws_acm_certificate: `domain_validation_options` attribute changed from list to set ([#14199](https://github.com/hashicorp/terraform-provider-aws/issues/14199)) +* resource/aws_acm_certificate: Plan-time validation added to `domain_name` and `subject_alternative_names` arguments to prevent usage of strings with trailing periods ([#14220](https://github.com/hashicorp/terraform-provider-aws/issues/14220)) +* resource/aws_api_gateway_method_settings: Remove `Computed` property from `throttling_burst_limit` and `throttling_rate_limit` arguments, enabling drift detection ([#14266](https://github.com/hashicorp/terraform-provider-aws/issues/14266)) +* resource/aws_api_gateway_method_settings: Update `throttling_burst_limit` and `throttling_rate_limit` argument defaults to match API default of `-1` to keep throttling disabled ([#14266](https://github.com/hashicorp/terraform-provider-aws/issues/14266)) +* resource/aws_autoscaling_group: `availability_zones` and `vpc_zone_identifier` argument conflict now reported at plan-time ([#12927](https://github.com/hashicorp/terraform-provider-aws/issues/12927)) +* resource/aws_autoscaling_group: Remove `Computed` property from `load_balancers` and `target_group_arns` arguments, enabling drift detection ([#14064](https://github.com/hashicorp/terraform-provider-aws/issues/14064)) +* resource/aws_cloudfront_distribution: `active_trusted_signers` argument renamed to `trusted_signers` to support accessing `items` in Terraform 0.12 ([#14339](https://github.com/hashicorp/terraform-provider-aws/issues/14339)) +* resource/aws_cloudwatch_log_group: Automatically trim `:*` suffix from `arn` attribute ([#14214](https://github.com/hashicorp/terraform-provider-aws/issues/14214)) +* resource/aws_codepipeline: Removes `GITHUB_TOKEN` environment variable ([#14175](https://github.com/hashicorp/terraform-provider-aws/issues/14175)) +* resource/aws_cognito_user_pool: Remove deprecated `admin_create_user_config` configuration block `unused_account_validity_days` argument ([#14294](https://github.com/hashicorp/terraform-provider-aws/issues/14294)) +* resource/aws_dx_gateway: Remove automatic `aws_dx_gateway_association` resource import ([#14124](https://github.com/hashicorp/terraform-provider-aws/issues/14124)) +* resource/aws_dx_gateway_association: Remove deprecated `vpn_gateway_id` argument ([#14144](https://github.com/hashicorp/terraform-provider-aws/issues/14144)) +* resource/aws_dx_gateway_association_proposal: Remove deprecated `vpn_gateway_id` argument ([#14144](https://github.com/hashicorp/terraform-provider-aws/issues/14144)) +* resource/aws_ebs_volume: Return an error when `iops` argument set to a value greater than 0 for volume types other than `io1` ([#14310](https://github.com/hashicorp/terraform-provider-aws/issues/14310)) +* resource/aws_elastic_transcoder_preset: Remove `video` configuration block `max_frame_rate` argument default value ([#7141](https://github.com/hashicorp/terraform-provider-aws/issues/7141)) +* resource/aws_emr_cluster: Remove deprecated `instance_group` configuration block, `core_instance_count`, `core_instance_type`, and `master_instance_type` arguments ([#14137](https://github.com/hashicorp/terraform-provider-aws/issues/14137)) +* resource/aws_glue_job: Remove deprecated `allocated_capacity` argument ([#14296](https://github.com/hashicorp/terraform-provider-aws/issues/14296)) +* resource/aws_iam_access_key: Remove deprecated `ses_smtp_password` attribute ([#14299](https://github.com/hashicorp/terraform-provider-aws/issues/14299)) +* resource/aws_iam_instance_profile: Remove deprecated `roles` argument ([#14303](https://github.com/hashicorp/terraform-provider-aws/issues/14303)) +* resource/aws_iam_server_certificate: Remove state hashing from `certificate_body`, `certificate_chain`, and `private_key` arguments for new or recreated resources ([#14187](https://github.com/hashicorp/terraform-provider-aws/issues/14187)) +* resource/aws_instance: Return an error when `ebs_block_device` `iops` or `root_block_device` `iops` argument set to a value greater than `0` for volume types other than `io1` ([#14310](https://github.com/hashicorp/terraform-provider-aws/issues/14310)) +* resource/aws_lambda_alias: Resource import no longer converts Lambda Function name to ARN ([#12876](https://github.com/hashicorp/terraform-provider-aws/issues/12876)) +* resource/aws_launch_template: `network_interfaces` `delete_on_termination` argument changed from `bool` to `string` type ([#8612](https://github.com/hashicorp/terraform-provider-aws/issues/8612)) +* resource/aws_lb_listener_rule: Remove deprecated `condition` configuration block `field` and `values` arguments ([#14309](https://github.com/hashicorp/terraform-provider-aws/issues/14309)) +* resource/aws_msk_cluster: Update `encryption_info` `encryption_in_transit` `client_broker` argument default to match API default of `TLS` ([#14132](https://github.com/hashicorp/terraform-provider-aws/issues/14132)) +* resource/aws_rds_cluster: Update `scaling_configuration` `min_capacity` argument default to match API default of `1` ([#14268](https://github.com/hashicorp/terraform-provider-aws/issues/14268)) +* resource/aws_route53_resolver_rule: Trailing period removed from `domain_name` argument set in resource ([#14220](https://github.com/hashicorp/terraform-provider-aws/issues/14220)) +* resource/aws_route53_zone: Trailing period removed from `name` argument set in resource ([#14220](https://github.com/hashicorp/terraform-provider-aws/issues/14220)) +* resource/aws_s3_bucket: Remove automatic `aws_s3_bucket_policy` resource import ([#14121](https://github.com/hashicorp/terraform-provider-aws/issues/14121)) +* resource/aws_s3_bucket: Convert `region` to read-only attribute ([#14127](https://github.com/hashicorp/terraform-provider-aws/issues/14127)) +* resource/aws_s3_bucket_metric: Update `filter` argument to require at least one of the `prefix` or `tags` nested arguments ([#14230](https://github.com/hashicorp/terraform-provider-aws/issues/14230)) +* resource/aws_security_group: Remove automatic `aws_security_group_rule` resource import ([#12616](https://github.com/hashicorp/terraform-provider-aws/issues/12616)) +* resource/aws_ses_domain_identity: Plan-time validation added to `domain` argument to prevent usage of strings with trailing periods ([#14220](https://github.com/hashicorp/terraform-provider-aws/issues/14220)) +* resource/aws_ses_domain_identity_verification: Plan-time validation added to `domain` argument to prevent usage of strings with trailing periods ([#14220](https://github.com/hashicorp/terraform-provider-aws/issues/14220)) +* resource/aws_sns_platform_application: `platform_credential` and `platform_principal` attributes are no longer stored in the Terraform state with hash values ([#3894](https://github.com/hashicorp/terraform-provider-aws/issues/3894)) +* resource/aws_spot_fleet_request: Remove 24 hour default for `valid_until` argument ([#9718](https://github.com/hashicorp/terraform-provider-aws/issues/9718)) +* resource/aws_ssm_maintenance_window_task: Remove deprecated `logging_info` and `task_parameters` configuration blocks ([#14311](https://github.com/hashicorp/terraform-provider-aws/issues/14311)) FEATURES -* **New Data Source:** aws_workspaces_directory ([#13529](https://github.com/terraform-providers/terraform-provider-aws/issues/13529)) +* **New Data Source:** aws_workspaces_directory ([#13529](https://github.com/hashicorp/terraform-provider-aws/issues/13529)) ENHANCEMENTS -* provider: Always enable shared configuration file support (no longer require `AWS_SDK_LOAD_CONFIG` environment variable) ([#14077](https://github.com/terraform-providers/terraform-provider-aws/issues/14077)) -* provider: Add `assume_role` configuration block `duration_seconds`, `policy_arns`, `tags`, and `transitive_tag_keys` arguments ([#14077](https://github.com/terraform-providers/terraform-provider-aws/issues/14077)) -* data-source/aws_instance: Add `secondary_private_ips` attribute ([#14079](https://github.com/terraform-providers/terraform-provider-aws/issues/14079)) -* data-source/aws_s3_bucket: Replace `GetBucketLocation` API call with custom HTTP call for FIPS endpoint support ([#14221](https://github.com/terraform-providers/terraform-provider-aws/issues/14221)) -* resource/aws_acm_certificate: Enable `domain_validation_options` usage in downstream resource `count` and `for_each` references ([#14199](https://github.com/terraform-providers/terraform-provider-aws/issues/14199)) -* resource/aws_api_gateway_authorizer: Add plan-time validation to `authorizer_credentials` argument ([#12643](https://github.com/terraform-providers/terraform-provider-aws/issues/12643)) -* resource/aws_api_gateway_method_settings: Add import support ([#14266](https://github.com/terraform-providers/terraform-provider-aws/issues/14266)) -* resource/aws_apigatewayv2_integration: Add `request_parameters` attribute ([#14080](https://github.com/terraform-providers/terraform-provider-aws/issues/14080)) -* resource/aws_apigatewayv2_integration: Add `tls_config` attribute ([#13013](https://github.com/terraform-providers/terraform-provider-aws/issues/13013)) -* resource/aws_apigatewayv2_route: Support for updating route key ([#13833](https://github.com/terraform-providers/terraform-provider-aws/issues/13833)) -* resource/aws_apigatewayv2_stage: Make `deployment_id` a `Computed` attribute ([#13644](https://github.com/terraform-providers/terraform-provider-aws/issues/13644)) -* resource/aws_fsx_lustre_file_system: Add `deployment_type` and `per_unit_storage_throughput` attributes ([#13639](https://github.com/terraform-providers/terraform-provider-aws/issues/13639)) -* resource_aws_fsx_windows_file_system - add `storage_type` argument. ([#14316](https://github.com/terraform-providers/terraform-provider-aws/issues/14316)) -* resource_aws_fsx_windows_file_system: add support for multi-az ([#12676](https://github.com/terraform-providers/terraform-provider-aws/issues/12676)) -* resource_aws_fsx_windows_file_system: add `SINGLE_AZ_2` deployment type ([#12676](https://github.com/terraform-providers/terraform-provider-aws/issues/12676)) -* resource_aws_fsx_windows_file_system: adds `preferred_file_server_ip`, `remote_administration_endpoint` attributes ([#12676](https://github.com/terraform-providers/terraform-provider-aws/issues/12676)) -* resource/aws_instance: Add `secondary_private_ips` argument (conflicts with `network_interface` configuration block) ([#14079](https://github.com/terraform-providers/terraform-provider-aws/issues/14079)) +* provider: Always enable shared configuration file support (no longer require `AWS_SDK_LOAD_CONFIG` environment variable) ([#14077](https://github.com/hashicorp/terraform-provider-aws/issues/14077)) +* provider: Add `assume_role` configuration block `duration_seconds`, `policy_arns`, `tags`, and `transitive_tag_keys` arguments ([#14077](https://github.com/hashicorp/terraform-provider-aws/issues/14077)) +* data-source/aws_instance: Add `secondary_private_ips` attribute ([#14079](https://github.com/hashicorp/terraform-provider-aws/issues/14079)) +* data-source/aws_s3_bucket: Replace `GetBucketLocation` API call with custom HTTP call for FIPS endpoint support ([#14221](https://github.com/hashicorp/terraform-provider-aws/issues/14221)) +* resource/aws_acm_certificate: Enable `domain_validation_options` usage in downstream resource `count` and `for_each` references ([#14199](https://github.com/hashicorp/terraform-provider-aws/issues/14199)) +* resource/aws_api_gateway_authorizer: Add plan-time validation to `authorizer_credentials` argument ([#12643](https://github.com/hashicorp/terraform-provider-aws/issues/12643)) +* resource/aws_api_gateway_method_settings: Add import support ([#14266](https://github.com/hashicorp/terraform-provider-aws/issues/14266)) +* resource/aws_apigatewayv2_integration: Add `request_parameters` attribute ([#14080](https://github.com/hashicorp/terraform-provider-aws/issues/14080)) +* resource/aws_apigatewayv2_integration: Add `tls_config` attribute ([#13013](https://github.com/hashicorp/terraform-provider-aws/issues/13013)) +* resource/aws_apigatewayv2_route: Support for updating route key ([#13833](https://github.com/hashicorp/terraform-provider-aws/issues/13833)) +* resource/aws_apigatewayv2_stage: Make `deployment_id` a `Computed` attribute ([#13644](https://github.com/hashicorp/terraform-provider-aws/issues/13644)) +* resource/aws_fsx_lustre_file_system: Add `deployment_type` and `per_unit_storage_throughput` attributes ([#13639](https://github.com/hashicorp/terraform-provider-aws/issues/13639)) +* resource_aws_fsx_windows_file_system - add `storage_type` argument. ([#14316](https://github.com/hashicorp/terraform-provider-aws/issues/14316)) +* resource_aws_fsx_windows_file_system: add support for multi-az ([#12676](https://github.com/hashicorp/terraform-provider-aws/issues/12676)) +* resource_aws_fsx_windows_file_system: add `SINGLE_AZ_2` deployment type ([#12676](https://github.com/hashicorp/terraform-provider-aws/issues/12676)) +* resource_aws_fsx_windows_file_system: adds `preferred_file_server_ip`, `remote_administration_endpoint` attributes ([#12676](https://github.com/hashicorp/terraform-provider-aws/issues/12676)) +* resource/aws_instance: Add `secondary_private_ips` argument (conflicts with `network_interface` configuration block) ([#14079](https://github.com/hashicorp/terraform-provider-aws/issues/14079)) BUG FIXES -* provider: Ensure nil is not passed to RetryError helpers, may result in some bug fixes ([#14104](https://github.com/terraform-providers/terraform-provider-aws/issues/14104)) -* provider: Ensure configured STS endpoint is used during `AssumeRole` API calls ([#14077](https://github.com/terraform-providers/terraform-provider-aws/issues/14077)) -* provider: Prefer AWS shared configuration over EC2 metadata credentials by default ([#14077](https://github.com/terraform-providers/terraform-provider-aws/issues/14077)) -* provider: Prefer CodeBuild, ECS, EKS credentials over EC2 metadata credentials by default ([#14077](https://github.com/terraform-providers/terraform-provider-aws/issues/14077)) -* data-source/aws_lb: `enable_http2` now properly set ([#14167](https://github.com/terraform-providers/terraform-provider-aws/issues/14167)) -* resource/aws_acm_certificate: Prevent unexpected ordering differences with `domain_validation_options` attribute ([#14199](https://github.com/terraform-providers/terraform-provider-aws/issues/14199)) -* resource/aws_api_gateway_authorizer: Allow `authorizer_result_ttl_in_seconds` to be set to 0 ([#12643](https://github.com/terraform-providers/terraform-provider-aws/issues/12643)) -* resource/aws_apigatewayv2_integration: Correctly handle the `integration_method` attribute for AWS Lambda integrations([#13266](https://github.com/terraform-providers/terraform-provider-aws/issues/13266)) -* resource/aws_apigatewayv2_integration: Correctly handle the `passthrough_behavior` attribute for HTTP APIs ([#13062](https://github.com/terraform-providers/terraform-provider-aws/issues/13062)) -* resource/aws_apigatewayv2_stage: Correctly handle `default_route_setting` and `route_setting` `data_trace_enabled` and `logging_level` for HTTP APIs. `logging_level` is now `Computed`, meaning Terraform will only perform drift detection of its value when present in a configuration. ([#13809](https://github.com/terraform-providers/terraform-provider-aws/issues/13809)) -* resource/aws_appautoscaling_target: Only retry `DeregisterScalableTarget` retries on all errors on deletion ([#14259](https://github.com/terraform-providers/terraform-provider-aws/issues/14259)) -* resource/aws_dx_gateway_association: Increase default create/update/delete timeouts to 30 minutes ([#14144](https://github.com/terraform-providers/terraform-provider-aws/issues/14144)) -* resource/aws_codepipeline: Only retry `CreatePipeline` errors for IAM eventual consistency errors ([#14264](https://github.com/terraform-providers/terraform-provider-aws/issues/14264)) -* resource/aws_elasticsearch_domain: Update method to properly set `advanced_security_options` ([#14167](https://github.com/terraform-providers/terraform-provider-aws/issues/14167)) -* resource/aws_lambda_function: Increase IAM retry timeout for creation to standard 2 minute timeout ([#14291](https://github.com/terraform-providers/terraform-provider-aws/issues/14291)) -* resource/aws_lb_cookie_stickiness_policy: `lb_port` now properly set ([#14167](https://github.com/terraform-providers/terraform-provider-aws/issues/14167)) -* resource/aws_network_acl_rule: Immediately return `DescribeNetworkAcls` errors on creation ([#14261](https://github.com/terraform-providers/terraform-provider-aws/issues/14261)) -* resource/aws_s3_bucket: Replace `GetBucketLocation` API call with custom HTTP call for FIPS endpoint support ([#14221](https://github.com/terraform-providers/terraform-provider-aws/issues/14221)) -* resource/aws_sns_topic_subscription: Immediately return `ListSubscriptionsByTopic` errors ([#14262](https://github.com/terraform-providers/terraform-provider-aws/issues/14262)) -* resource/aws_spot_fleet_request: Only retry `RequestSpotFleet` on IAM eventual consistency errors and use standard 2 minute timeout ([#14265](https://github.com/terraform-providers/terraform-provider-aws/issues/14265)) -* resource/aws_spot_instance_request: `primary_network_interface_id` now properly set ([#14167](https://github.com/terraform-providers/terraform-provider-aws/issues/14167)) -* resource/aws_ssm_activation: Only retry `CreateActivation` on IAM eventual consistency errors and use standard 2 minute timeout ([#14263](https://github.com/terraform-providers/terraform-provider-aws/issues/14263)) -* resource/aws_ssm_association: `parameters` now properly set ([#14167](https://github.com/terraform-providers/terraform-provider-aws/issues/14167)) +* provider: Ensure nil is not passed to RetryError helpers, may result in some bug fixes ([#14104](https://github.com/hashicorp/terraform-provider-aws/issues/14104)) +* provider: Ensure configured STS endpoint is used during `AssumeRole` API calls ([#14077](https://github.com/hashicorp/terraform-provider-aws/issues/14077)) +* provider: Prefer AWS shared configuration over EC2 metadata credentials by default ([#14077](https://github.com/hashicorp/terraform-provider-aws/issues/14077)) +* provider: Prefer CodeBuild, ECS, EKS credentials over EC2 metadata credentials by default ([#14077](https://github.com/hashicorp/terraform-provider-aws/issues/14077)) +* data-source/aws_lb: `enable_http2` now properly set ([#14167](https://github.com/hashicorp/terraform-provider-aws/issues/14167)) +* resource/aws_acm_certificate: Prevent unexpected ordering differences with `domain_validation_options` attribute ([#14199](https://github.com/hashicorp/terraform-provider-aws/issues/14199)) +* resource/aws_api_gateway_authorizer: Allow `authorizer_result_ttl_in_seconds` to be set to 0 ([#12643](https://github.com/hashicorp/terraform-provider-aws/issues/12643)) +* resource/aws_apigatewayv2_integration: Correctly handle the `integration_method` attribute for AWS Lambda integrations([#13266](https://github.com/hashicorp/terraform-provider-aws/issues/13266)) +* resource/aws_apigatewayv2_integration: Correctly handle the `passthrough_behavior` attribute for HTTP APIs ([#13062](https://github.com/hashicorp/terraform-provider-aws/issues/13062)) +* resource/aws_apigatewayv2_stage: Correctly handle `default_route_setting` and `route_setting` `data_trace_enabled` and `logging_level` for HTTP APIs. `logging_level` is now `Computed`, meaning Terraform will only perform drift detection of its value when present in a configuration. ([#13809](https://github.com/hashicorp/terraform-provider-aws/issues/13809)) +* resource/aws_appautoscaling_target: Only retry `DeregisterScalableTarget` retries on all errors on deletion ([#14259](https://github.com/hashicorp/terraform-provider-aws/issues/14259)) +* resource/aws_dx_gateway_association: Increase default create/update/delete timeouts to 30 minutes ([#14144](https://github.com/hashicorp/terraform-provider-aws/issues/14144)) +* resource/aws_codepipeline: Only retry `CreatePipeline` errors for IAM eventual consistency errors ([#14264](https://github.com/hashicorp/terraform-provider-aws/issues/14264)) +* resource/aws_elasticsearch_domain: Update method to properly set `advanced_security_options` ([#14167](https://github.com/hashicorp/terraform-provider-aws/issues/14167)) +* resource/aws_lambda_function: Increase IAM retry timeout for creation to standard 2 minute timeout ([#14291](https://github.com/hashicorp/terraform-provider-aws/issues/14291)) +* resource/aws_lb_cookie_stickiness_policy: `lb_port` now properly set ([#14167](https://github.com/hashicorp/terraform-provider-aws/issues/14167)) +* resource/aws_network_acl_rule: Immediately return `DescribeNetworkAcls` errors on creation ([#14261](https://github.com/hashicorp/terraform-provider-aws/issues/14261)) +* resource/aws_s3_bucket: Replace `GetBucketLocation` API call with custom HTTP call for FIPS endpoint support ([#14221](https://github.com/hashicorp/terraform-provider-aws/issues/14221)) +* resource/aws_sns_topic_subscription: Immediately return `ListSubscriptionsByTopic` errors ([#14262](https://github.com/hashicorp/terraform-provider-aws/issues/14262)) +* resource/aws_spot_fleet_request: Only retry `RequestSpotFleet` on IAM eventual consistency errors and use standard 2 minute timeout ([#14265](https://github.com/hashicorp/terraform-provider-aws/issues/14265)) +* resource/aws_spot_instance_request: `primary_network_interface_id` now properly set ([#14167](https://github.com/hashicorp/terraform-provider-aws/issues/14167)) +* resource/aws_ssm_activation: Only retry `CreateActivation` on IAM eventual consistency errors and use standard 2 minute timeout ([#14263](https://github.com/hashicorp/terraform-provider-aws/issues/14263)) +* resource/aws_ssm_association: `parameters` now properly set ([#14167](https://github.com/hashicorp/terraform-provider-aws/issues/14167)) ## Previous Releases For information on prior major releases, see their changelogs: -* [2.x and earlier](https://github.com/terraform-providers/terraform-provider-aws/blob/release/2.x/CHANGELOG.md) +* [2.x and earlier](https://github.com/hashicorp/terraform-provider-aws/blob/release/2.x/CHANGELOG.md) diff --git a/GNUmakefile b/GNUmakefile index 2ac25194d74..ffefb88073e 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -31,7 +31,7 @@ testacc: fmtcheck echo "For example if updating aws/resource_aws_acm_certificate.go, use the test names in aws/resource_aws_acm_certificate_test.go starting with TestAcc and up to the underscore:"; \ echo "make testacc TESTARGS='-run=TestAccAWSAcmCertificate_'"; \ echo ""; \ - echo "See the contributing guide for more information: https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/running-and-writing-acceptance-tests.md"; \ + echo "See the contributing guide for more information: https://github.com/hashicorp/terraform-provider-aws/blob/master/docs/contributing/running-and-writing-acceptance-tests.md"; \ exit 1; \ fi TF_ACC=1 go test ./$(PKG_NAME) -v -count $(TEST_COUNT) -parallel $(ACCTEST_PARALLELISM) $(TESTARGS) -timeout $(ACCTEST_TIMEOUT) diff --git a/aws/data_source_aws_instance.go b/aws/data_source_aws_instance.go index d74b77ab507..826322a6503 100644 --- a/aws/data_source_aws_instance.go +++ b/aws/data_source_aws_instance.go @@ -515,13 +515,13 @@ func instanceDescriptionAttributes(d *schema.ResourceData, instance *ec2.Instanc var creditSpecifications []map[string]interface{} // AWS Standard will return InstanceCreditSpecification.NotSupported errors for EC2 Instance IDs outside T2 and T3 instance types - // Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/8055 + // Reference: https://github.com/hashicorp/terraform-provider-aws/issues/8055 if strings.HasPrefix(aws.StringValue(instance.InstanceType), "t2") || strings.HasPrefix(aws.StringValue(instance.InstanceType), "t3") { var err error creditSpecifications, err = getCreditSpecifications(conn, d.Id()) // Ignore UnsupportedOperation errors for AWS China and GovCloud (US) - // Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/4362 + // Reference: https://github.com/hashicorp/terraform-provider-aws/pull/4362 if err != nil && !isAWSErr(err, "UnsupportedOperation", "") { return fmt.Errorf("error getting EC2 Instance (%s) Credit Specifications: %s", d.Id(), err) } diff --git a/aws/data_source_aws_route53_resolver_rule.go b/aws/data_source_aws_route53_resolver_rule.go index 853a4a56aec..ec5bda8b26f 100644 --- a/aws/data_source_aws_route53_resolver_rule.go +++ b/aws/data_source_aws_route53_resolver_rule.go @@ -132,7 +132,7 @@ func dataSourceAwsRoute53ResolverRuleRead(d *schema.ResourceData, meta interface d.Set("rule_type", rule.RuleType) shareStatus := aws.StringValue(rule.ShareStatus) d.Set("share_status", shareStatus) - // https://github.com/terraform-providers/terraform-provider-aws/issues/10211 + // https://github.com/hashicorp/terraform-provider-aws/issues/10211 if shareStatus != route53resolver.ShareStatusSharedWithMe { tags, err := keyvaluetags.Route53resolverListTags(conn, arn) diff --git a/aws/resource_aws_acm_certificate_test.go b/aws/resource_aws_acm_certificate_test.go index 80c04cfa9ce..bd200871658 100644 --- a/aws/resource_aws_acm_certificate_test.go +++ b/aws/resource_aws_acm_certificate_test.go @@ -250,7 +250,7 @@ func TestAccAWSAcmCertificate_privateCert(t *testing.T) { } // TestAccAWSAcmCertificate_root_TrailingPeriod updated in 3.0 to account for domain_name plan-time validation -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13510 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/13510 func TestAccAWSAcmCertificate_root_TrailingPeriod(t *testing.T) { rootDomain := testAccAwsAcmCertificateDomainFromEnv(t) domain := fmt.Sprintf("%s.", rootDomain) @@ -667,7 +667,7 @@ func TestAccAWSAcmCertificate_imported_DomainName(t *testing.T) { } //lintignore:AT002 -func TestAccAWSAcmCertificate_imported_IpAddress(t *testing.T) { // Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7103 +func TestAccAWSAcmCertificate_imported_IpAddress(t *testing.T) { // Reference: https://github.com/hashicorp/terraform-provider-aws/issues/7103 resourceName := "aws_acm_certificate.test" resource.ParallelTest(t, resource.TestCase{ @@ -694,7 +694,7 @@ func TestAccAWSAcmCertificate_imported_IpAddress(t *testing.T) { // Reference: h }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/15055 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/15055 func TestAccAWSAcmCertificate_PrivateKey_Tags(t *testing.T) { resourceName := "aws_acm_certificate.test" diff --git a/aws/resource_aws_ami_launch_permission_test.go b/aws/resource_aws_ami_launch_permission_test.go index db8b2a6c8f7..417ba85c2cf 100644 --- a/aws/resource_aws_ami_launch_permission_test.go +++ b/aws/resource_aws_ami_launch_permission_test.go @@ -57,7 +57,7 @@ func TestAccAWSAMILaunchPermission_Disappears_LaunchPermission(t *testing.T) { }) } -// Bug reference: https://github.com/terraform-providers/terraform-provider-aws/issues/6222 +// Bug reference: https://github.com/hashicorp/terraform-provider-aws/issues/6222 // Images with all will not have and can cause a panic func TestAccAWSAMILaunchPermission_Disappears_LaunchPermission_Public(t *testing.T) { resourceName := "aws_ami_launch_permission.test" diff --git a/aws/resource_aws_api_gateway_method_settings_test.go b/aws/resource_aws_api_gateway_method_settings_test.go index b39a7ed2cec..1fe37b10ba7 100644 --- a/aws/resource_aws_api_gateway_method_settings_test.go +++ b/aws/resource_aws_api_gateway_method_settings_test.go @@ -382,7 +382,7 @@ func TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimit(t *testing }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/5690 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/5690 func TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimitDisabledByDefault(t *testing.T) { var stage1, stage2 apigateway.Stage rName := acctest.RandomWithPrefix("tf-acc-test") @@ -455,7 +455,7 @@ func TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimit(t *testing. }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/5690 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/5690 func TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimitDisabledByDefault(t *testing.T) { var stage1, stage2 apigateway.Stage rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_api_gateway_stage_test.go b/aws/resource_aws_api_gateway_stage_test.go index 71b3d77c7c1..40e497378b5 100644 --- a/aws/resource_aws_api_gateway_stage_test.go +++ b/aws/resource_aws_api_gateway_stage_test.go @@ -77,7 +77,7 @@ func TestAccAWSAPIGatewayStage_basic(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/12756 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/12756 func TestAccAWSAPIGatewayStage_disappears_ReferencingDeployment(t *testing.T) { var stage apigateway.Stage rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_api_gateway_usage_plan_test.go b/aws/resource_aws_api_gateway_usage_plan_test.go index 02eef916964..a5713310e40 100644 --- a/aws/resource_aws_api_gateway_usage_plan_test.go +++ b/aws/resource_aws_api_gateway_usage_plan_test.go @@ -252,7 +252,7 @@ func TestAccAWSAPIGatewayUsagePlan_throttling(t *testing.T) { }) } -// https://github.com/terraform-providers/terraform-provider-aws/issues/2057 +// https://github.com/hashicorp/terraform-provider-aws/issues/2057 func TestAccAWSAPIGatewayUsagePlan_throttlingInitialRateLimit(t *testing.T) { var conf apigateway.UsagePlan rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_appautoscaling_policy_test.go b/aws/resource_aws_appautoscaling_policy_test.go index cbdfd39250e..20e55b8583b 100644 --- a/aws/resource_aws_appautoscaling_policy_test.go +++ b/aws/resource_aws_appautoscaling_policy_test.go @@ -390,7 +390,7 @@ func TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7963 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/7963 func TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew(t *testing.T) { var policy applicationautoscaling.ScalingPolicy appAutoscalingTargetResourceName := "aws_appautoscaling_target.test" diff --git a/aws/resource_aws_autoscaling_group_test.go b/aws/resource_aws_autoscaling_group_test.go index 7a569a99989..5121d429d78 100644 --- a/aws/resource_aws_autoscaling_group_test.go +++ b/aws/resource_aws_autoscaling_group_test.go @@ -866,7 +866,7 @@ func TestAccAWSAutoScalingGroup_ALB_TargetGroups(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/256 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/256 func TestAccAWSAutoScalingGroup_TargetGroupArns(t *testing.T) { var group autoscaling.Group resourceName := "aws_autoscaling_group.test" @@ -1435,7 +1435,7 @@ func TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile(t *testing.T) }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/256 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/256 func TestAccAWSAutoScalingGroup_LoadBalancers(t *testing.T) { var group autoscaling.Group resourceName := "aws_autoscaling_group.test" diff --git a/aws/resource_aws_batch_job_queue_test.go b/aws/resource_aws_batch_job_queue_test.go index ca377ceb8a2..b6e6a8ac404 100644 --- a/aws/resource_aws_batch_job_queue_test.go +++ b/aws/resource_aws_batch_job_queue_test.go @@ -107,7 +107,7 @@ func TestAccAWSBatchJobQueue_disappears(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/8083 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/8083 func TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate(t *testing.T) { var jobQueue1 batch.JobQueueDetail resourceName := "aws_batch_job_queue.test" diff --git a/aws/resource_aws_cloudformation_stack_set_test.go b/aws/resource_aws_cloudformation_stack_set_test.go index faded198fa6..026c0a6117d 100644 --- a/aws/resource_aws_cloudformation_stack_set_test.go +++ b/aws/resource_aws_cloudformation_stack_set_test.go @@ -407,7 +407,7 @@ func TestAccAWSCloudFormationStackSet_Parameters_Default(t *testing.T) { func TestAccAWSCloudFormationStackSet_Parameters_NoEcho(t *testing.T) { TestAccSkip(t, "this resource does not currently ignore CloudFormation template parameters with the NoEcho property") // Additional references: - // * https://github.com/terraform-providers/terraform-provider-aws/issues/55 + // * https://github.com/hashicorp/terraform-provider-aws/issues/55 var stackSet1, stackSet2 cloudformation.StackSet rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_cloudfront_distribution_test.go b/aws/resource_aws_cloudfront_distribution_test.go index ec5e35393a7..b2da75a65a1 100644 --- a/aws/resource_aws_cloudfront_distribution_test.go +++ b/aws/resource_aws_cloudfront_distribution_test.go @@ -249,7 +249,7 @@ func TestAccAWSCloudFrontDistribution_multiOrigin(t *testing.T) { }) } -// https://github.com/terraform-providers/terraform-provider-aws/issues/188 +// https://github.com/hashicorp/terraform-provider-aws/issues/188 // TestAccAWSCloudFrontDistribution_orderedCacheBehavior runs an // aws_cloudfront_distribution acceptance test with multiple and ordered cache behaviors. // @@ -786,7 +786,7 @@ func TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn(t *tes }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7773 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/7773 func TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate(t *testing.T) { var distribution cloudfront.Distribution var providers []*schema.Provider diff --git a/aws/resource_aws_cognito_user_pool_test.go b/aws/resource_aws_cognito_user_pool_test.go index 089817b85a2..66a701ed248 100644 --- a/aws/resource_aws_cognito_user_pool_test.go +++ b/aws/resource_aws_cognito_user_pool_test.go @@ -138,7 +138,7 @@ func TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/11858 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/11858 func TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy(t *testing.T) { name := acctest.RandomWithPrefix("tf-acc-test") resourceName := "aws_cognito_user_pool.test" diff --git a/aws/resource_aws_datasync_location_smb_test.go b/aws/resource_aws_datasync_location_smb_test.go index aada0b926f2..2c8a0de311a 100644 --- a/aws/resource_aws_datasync_location_smb_test.go +++ b/aws/resource_aws_datasync_location_smb_test.go @@ -435,7 +435,7 @@ data "aws_storagegateway_local_disk" "test" { resource "aws_storagegateway_cache" "test" { # ACCEPTANCE TESTING WORKAROUND: # (Shamelessly stolen from: - # https://github.com/terraform-providers/terraform-provider-aws/ + # https://github.com/hashicorp/terraform-provider-aws/ # blob/1647a5ba13c5abaf5cf65ecdeb7c5fdf0107e56f/aws # /resource_aws_storagegateway_cache_test.go#L219 ) # Data sources are not refreshed before plan after apply in TestStep diff --git a/aws/resource_aws_db_instance_test.go b/aws/resource_aws_db_instance_test.go index 31f4111868c..f36c2223760 100644 --- a/aws/resource_aws_db_instance_test.go +++ b/aws/resource_aws_db_instance_test.go @@ -1770,7 +1770,7 @@ func TestAccAWSDBInstance_SnapshotIdentifier_Tags(t *testing.T) { } func TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset(t *testing.T) { - TestAccSkip(t, "To be fixed: https://github.com/terraform-providers/terraform-provider-aws/issues/5959") + TestAccSkip(t, "To be fixed: https://github.com/hashicorp/terraform-provider-aws/issues/5959") // --- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset (1086.15s) // testing.go:527: Step 0 error: Check failed: Check 4/4 error: aws_db_instance.test: Attribute 'tags.%' expected "0", got "1" @@ -1826,7 +1826,7 @@ func TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds(t *testing.T) { }) } -// Regression reference: https://github.com/terraform-providers/terraform-provider-aws/issues/5360 +// Regression reference: https://github.com/hashicorp/terraform-provider-aws/issues/5360 // This acceptance test explicitly tests when snapshot_identifier is set, // vpc_security_group_ids is set (which triggered the resource update function), // and tags is set which was missing its ARN used for tagging @@ -2744,7 +2744,7 @@ func testAccCheckAWSDBInstanceExists(n string, v *rds.DBInstance) resource.TestC } } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/8792 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/8792 func TestAccAWSDBInstance_PerformanceInsightsEnabled_DisabledToEnabled(t *testing.T) { var dbInstance rds.DBInstance rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_db_option_group_test.go b/aws/resource_aws_db_option_group_test.go index 12f70cec257..6a12127fc55 100644 --- a/aws/resource_aws_db_option_group_test.go +++ b/aws/resource_aws_db_option_group_test.go @@ -392,7 +392,7 @@ func TestAccAWSDBOptionGroup_OracleOptionsUpdate(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/1876 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/1876 func TestAccAWSDBOptionGroup_Option_OptionSettings_MultipleNonDefault(t *testing.T) { var optionGroup1, optionGroup2 rds.OptionGroup rName := acctest.RandomWithPrefix("tf-acc-test") @@ -501,7 +501,7 @@ func TestAccAWSDBOptionGroup_Tags(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7114 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/7114 func TestAccAWSDBOptionGroup_Tags_WithOptions(t *testing.T) { var optionGroup1, optionGroup2, optionGroup3 rds.OptionGroup resourceName := "aws_db_option_group.test" diff --git a/aws/resource_aws_default_security_group_test.go b/aws/resource_aws_default_security_group_test.go index 1d6f0f5acda..b3c612f9442 100644 --- a/aws/resource_aws_default_security_group_test.go +++ b/aws/resource_aws_default_security_group_test.go @@ -148,7 +148,7 @@ func TestAccAWSDefaultSecurityGroup_Classic_empty(t *testing.T) { TestAccSkip(t, "This resource does not currently clear tags when adopting the resource") // Additional references: - // * https://github.com/terraform-providers/terraform-provider-aws/issues/14631 + // * https://github.com/hashicorp/terraform-provider-aws/issues/14631 oldvar := os.Getenv("AWS_DEFAULT_REGION") os.Setenv("AWS_DEFAULT_REGION", "us-east-1") diff --git a/aws/resource_aws_dynamodb_table_test.go b/aws/resource_aws_dynamodb_table_test.go index e7b6503dd6f..453b2de00d7 100644 --- a/aws/resource_aws_dynamodb_table_test.go +++ b/aws/resource_aws_dynamodb_table_test.go @@ -902,7 +902,7 @@ func TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/15115 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/15115 func TestAccAWSDynamoDbTable_lsiNonKeyAttributes(t *testing.T) { var conf dynamodb.DescribeTableOutput resourceName := "aws_dynamodb_table.test" @@ -936,7 +936,7 @@ func TestAccAWSDynamoDbTable_lsiNonKeyAttributes(t *testing.T) { }) } -// https://github.com/terraform-providers/terraform-provider-aws/issues/566 +// https://github.com/hashicorp/terraform-provider-aws/issues/566 func TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes(t *testing.T) { var conf dynamodb.DescribeTableOutput resourceName := "aws_dynamodb_table.test" @@ -1026,7 +1026,7 @@ func TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes(t *testing.T) { }) } -// https://github.com/terraform-providers/terraform-provider-aws/issues/671 +// https://github.com/hashicorp/terraform-provider-aws/issues/671 func TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes_emptyPlan(t *testing.T) { var conf dynamodb.DescribeTableOutput resourceName := "aws_dynamodb_table.test" diff --git a/aws/resource_aws_ebs_volume.go b/aws/resource_aws_ebs_volume.go index c7a1e3a388a..21036a257f3 100644 --- a/aws/resource_aws_ebs_volume.go +++ b/aws/resource_aws_ebs_volume.go @@ -117,7 +117,7 @@ func resourceAwsEbsVolumeCreate(d *schema.ResourceData, meta interface{}) error // IOPs are only valid, and required for, storage type io1 and io2. The current minimum // is 100. Hard validation in place to return an error if IOPs are provided // for an unsupported storage type. - // Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/12667 + // Reference: https://github.com/hashicorp/terraform-provider-aws/issues/12667 var t string if value, ok := d.GetOk("type"); ok { t = value.(string) diff --git a/aws/resource_aws_ebs_volume_test.go b/aws/resource_aws_ebs_volume_test.go index 279c3a7693d..36214365714 100644 --- a/aws/resource_aws_ebs_volume_test.go +++ b/aws/resource_aws_ebs_volume_test.go @@ -319,7 +319,7 @@ func TestAccAWSEBSVolume_NoIops(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/12667 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/12667 func TestAccAWSEBSVolume_InvalidIopsForType(t *testing.T) { resource.ParallelTest(t, resource.TestCase{ diff --git a/aws/resource_aws_ec2_fleet_test.go b/aws/resource_aws_ec2_fleet_test.go index 2eca076a4f0..200fb68c01c 100644 --- a/aws/resource_aws_ec2_fleet_test.go +++ b/aws/resource_aws_ec2_fleet_test.go @@ -988,7 +988,7 @@ func TestAccAWSEc2Fleet_Type(t *testing.T) { }) } -// Test for the bug described in https://github.com/terraform-providers/terraform-provider-aws/issues/6777 +// Test for the bug described in https://github.com/hashicorp/terraform-provider-aws/issues/6777 func TestAccAWSEc2Fleet_TemplateMultipleNetworkInterfaces(t *testing.T) { var fleet1 ec2.FleetData resourceName := "aws_ec2_fleet.test" diff --git a/aws/resource_aws_ecs_service_test.go b/aws/resource_aws_ecs_service_test.go index badbcb484b5..f544c3c6ae0 100644 --- a/aws/resource_aws_ecs_service_test.go +++ b/aws/resource_aws_ecs_service_test.go @@ -518,7 +518,7 @@ func TestAccAWSEcsService_withDeploymentValues(t *testing.T) { }) } -// Regression for https://github.com/terraform-providers/terraform-provider-aws/issues/6315 +// Regression for https://github.com/hashicorp/terraform-provider-aws/issues/6315 func TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred(t *testing.T) { var service ecs.Service rName := acctest.RandomWithPrefix("tf-acc-test") @@ -742,7 +742,7 @@ func TestAccAWSEcsService_withPlacementStrategy(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13146 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/13146 func TestAccAWSEcsService_withPlacementStrategy_Type_Missing(t *testing.T) { rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_ecs_task_definition_test.go b/aws/resource_aws_ecs_task_definition_test.go index cf556b78e88..58ea5e786c7 100644 --- a/aws/resource_aws_ecs_task_definition_test.go +++ b/aws/resource_aws_ecs_task_definition_test.go @@ -546,7 +546,7 @@ func TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource(t *testing.T) { }) } -// Regression for https://github.com/terraform-providers/terraform-provider-aws/issues/2336 +// Regression for https://github.com/hashicorp/terraform-provider-aws/issues/2336 func TestAccAWSEcsTaskDefinition_arrays(t *testing.T) { var conf ecs.TaskDefinition resourceName := "aws_ecs_task_definition.test" diff --git a/aws/resource_aws_efs_mount_target_test.go b/aws/resource_aws_efs_mount_target_test.go index b46045b933b..0297bb13792 100644 --- a/aws/resource_aws_efs_mount_target_test.go +++ b/aws/resource_aws_efs_mount_target_test.go @@ -177,7 +177,7 @@ func TestAccAWSEFSMountTarget_IpAddress(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13845 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/13845 func TestAccAWSEFSMountTarget_IpAddress_EmptyString(t *testing.T) { var mount efs.MountTargetDescription resourceName := "aws_efs_mount_target.test" diff --git a/aws/resource_aws_eip_test.go b/aws/resource_aws_eip_test.go index 6a46ddc8b1b..ef7a39fa7e6 100644 --- a/aws/resource_aws_eip_test.go +++ b/aws/resource_aws_eip_test.go @@ -275,7 +275,7 @@ func TestAccAWSEIP_associated_user_private_ip(t *testing.T) { } // Regression test for https://github.com/hashicorp/terraform/issues/3429 (now -// https://github.com/terraform-providers/terraform-provider-aws/issues/42) +// https://github.com/hashicorp/terraform-provider-aws/issues/42) func TestAccAWSEIP_Instance_Reassociate(t *testing.T) { instanceResourceName := "aws_instance.test" resourceName := "aws_eip.test" diff --git a/aws/resource_aws_eks_fargate_profile_test.go b/aws/resource_aws_eks_fargate_profile_test.go index b7fac06638e..3cae45f725b 100644 --- a/aws/resource_aws_eks_fargate_profile_test.go +++ b/aws/resource_aws_eks_fargate_profile_test.go @@ -338,7 +338,7 @@ func testAccPreCheckAWSEksFargateProfile(t *testing.T) { The allowed regions are hardcoded in the acceptance testing since dynamically determining the functionality requires creating and destroying a real EKS Cluster, which is a lengthy process. If this check is out of date, please create an issue in the Terraform AWS Provider -repository (https://github.com/terraform-providers/terraform-provider-aws) or submit a PR to update the +repository (https://github.com/hashicorp/terraform-provider-aws) or submit a PR to update the check itself (testAccPreCheckAWSEksFargateProfile). For the most up to date supported region information, see the EKS User Guide: diff --git a/aws/resource_aws_elastic_transcoder_preset_test.go b/aws/resource_aws_elastic_transcoder_preset_test.go index 74a55b3bfaa..815cc164bb8 100644 --- a/aws/resource_aws_elastic_transcoder_preset_test.go +++ b/aws/resource_aws_elastic_transcoder_preset_test.go @@ -58,7 +58,7 @@ func TestAccAWSElasticTranscoderPreset_disappears(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/14087 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/14087 func TestAccAWSElasticTranscoderPreset_AudioCodecOptions_empty(t *testing.T) { var preset elastictranscoder.Preset resourceName := "aws_elastictranscoder_preset.test" @@ -160,7 +160,7 @@ func TestAccAWSElasticTranscoderPreset_Full(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/695 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/695 func TestAccAWSElasticTranscoderPreset_Video_FrameRate(t *testing.T) { var preset elastictranscoder.Preset resourceName := "aws_elastictranscoder_preset.test" diff --git a/aws/resource_aws_elasticache_parameter_group_test.go b/aws/resource_aws_elasticache_parameter_group_test.go index 25331d5475c..74005664fab 100644 --- a/aws/resource_aws_elasticache_parameter_group_test.go +++ b/aws/resource_aws_elasticache_parameter_group_test.go @@ -86,7 +86,7 @@ func TestAccAWSElasticacheParameterGroup_addParameter(t *testing.T) { }) } -// Regression for https://github.com/terraform-providers/terraform-provider-aws/issues/116 +// Regression for https://github.com/hashicorp/terraform-provider-aws/issues/116 func TestAccAWSElasticacheParameterGroup_removeAllParameters(t *testing.T) { var v elasticache.CacheParameterGroup rName := fmt.Sprintf("parameter-group-test-terraform-%d", acctest.RandInt()) diff --git a/aws/resource_aws_elasticsearch_domain_test.go b/aws/resource_aws_elasticsearch_domain_test.go index 766b5811dfb..bf1b4d378b8 100644 --- a/aws/resource_aws_elasticsearch_domain_test.go +++ b/aws/resource_aws_elasticsearch_domain_test.go @@ -1002,7 +1002,7 @@ func TestAccAWSElasticSearchDomain_update_volume_type(t *testing.T) { }}) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13867 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/13867 func TestAccAWSElasticSearchDomain_WithVolumeType_Missing(t *testing.T) { var domain elasticsearch.ElasticsearchDomainStatus resourceName := "aws_elasticsearch_domain.test" diff --git a/aws/resource_aws_elb_test.go b/aws/resource_aws_elb_test.go index 227c61a0907..0393b596b4b 100644 --- a/aws/resource_aws_elb_test.go +++ b/aws/resource_aws_elb_test.go @@ -1411,7 +1411,7 @@ resource "aws_elb" "test" { } } -# See https://github.com/terraform-providers/terraform-provider-aws/issues/2498 +# See https://github.com/hashicorp/terraform-provider-aws/issues/2498 output "lb_name" { value = aws_elb.test.name } diff --git a/aws/resource_aws_emr_instance_group_test.go b/aws/resource_aws_emr_instance_group_test.go index 8d014faf611..340f765cfdc 100644 --- a/aws/resource_aws_emr_instance_group_test.go +++ b/aws/resource_aws_emr_instance_group_test.go @@ -172,7 +172,7 @@ func TestAccAWSEMRInstanceGroup_AutoScalingPolicy(t *testing.T) { } // Confirm we can scale down the instance count. -// Regression test for https://github.com/terraform-providers/terraform-provider-aws/issues/1264 +// Regression test for https://github.com/hashicorp/terraform-provider-aws/issues/1264 func TestAccAWSEMRInstanceGroup_InstanceCount(t *testing.T) { var ig emr.InstanceGroup rInt := acctest.RandInt() @@ -201,7 +201,7 @@ func TestAccAWSEMRInstanceGroup_InstanceCount(t *testing.T) { }) } -// Regression test for https://github.com/terraform-providers/terraform-provider-aws/issues/1355 +// Regression test for https://github.com/hashicorp/terraform-provider-aws/issues/1355 func TestAccAWSEMRInstanceGroup_EmrClusterDisappears(t *testing.T) { var cluster emr.Cluster var ig emr.InstanceGroup diff --git a/aws/resource_aws_glue_catalog_table_test.go b/aws/resource_aws_glue_catalog_table_test.go index 3c88a271ef2..900243dc272 100644 --- a/aws/resource_aws_glue_catalog_table_test.go +++ b/aws/resource_aws_glue_catalog_table_test.go @@ -323,7 +323,7 @@ func TestAccAWSGlueCatalogTable_update_replaceValues(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/11784 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/11784 func TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock(t *testing.T) { rName := acctest.RandomWithPrefix("tf-acc-test") resourceName := "aws_glue_catalog_table.test" @@ -345,7 +345,7 @@ func TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock(t *tes }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/11784 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/11784 func TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock(t *testing.T) { rName := acctest.RandomWithPrefix("tf-acc-test") resourceName := "aws_glue_catalog_table.test" @@ -406,7 +406,7 @@ func TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues(t *test }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/11784 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/11784 func TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock(t *testing.T) { rName := acctest.RandomWithPrefix("tf-acc-test") resourceName := "aws_glue_catalog_table.test" diff --git a/aws/resource_aws_iam_service_linked_role_test.go b/aws/resource_aws_iam_service_linked_role_test.go index 14876494113..d90cf651bae 100644 --- a/aws/resource_aws_iam_service_linked_role_test.go +++ b/aws/resource_aws_iam_service_linked_role_test.go @@ -218,7 +218,7 @@ func TestAccAWSIAMServiceLinkedRole_CustomSuffix(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/4439 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/4439 func TestAccAWSIAMServiceLinkedRole_CustomSuffix_DiffSuppressFunc(t *testing.T) { resourceName := "aws_iam_service_linked_role.test" awsServiceName := "custom-resource.application-autoscaling.amazonaws.com" diff --git a/aws/resource_aws_instance.go b/aws/resource_aws_instance.go index e470f621b95..cd615990047 100644 --- a/aws/resource_aws_instance.go +++ b/aws/resource_aws_instance.go @@ -952,12 +952,12 @@ func resourceAwsInstanceRead(d *schema.ResourceData, meta interface{}) error { } // AWS Standard will return InstanceCreditSpecification.NotSupported errors for EC2 Instance IDs outside T2 and T3 instance types - // Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/8055 + // Reference: https://github.com/hashicorp/terraform-provider-aws/issues/8055 if strings.HasPrefix(aws.StringValue(instance.InstanceType), "t2") || strings.HasPrefix(aws.StringValue(instance.InstanceType), "t3") { creditSpecifications, err := getCreditSpecifications(conn, d.Id()) // Ignore UnsupportedOperation errors for AWS China and GovCloud (US) - // Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/4362 + // Reference: https://github.com/hashicorp/terraform-provider-aws/pull/4362 if err != nil && !isAWSErr(err, "UnsupportedOperation", "") { return fmt.Errorf("error getting EC2 Instance (%s) Credit Specifications: %s", d.Id(), err) } @@ -1373,7 +1373,7 @@ func resourceAwsInstanceUpdate(d *schema.ResourceData, meta interface{}) error { if d.HasChange("root_block_device.0.iops") { if v, ok := d.Get("root_block_device.0.iops").(int); ok && v != 0 { // Enforce IOPs usage with a valid volume type - // Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/12667 + // Reference: https://github.com/hashicorp/terraform-provider-aws/issues/12667 if t, ok := d.Get("root_block_device.0.volume_type").(string); ok && t != ec2.VolumeTypeIo1 && t != ec2.VolumeTypeIo2 { if t == "" { // Volume defaults to gp2 @@ -1914,7 +1914,7 @@ func readBlockDeviceMappingsFromConfig(d *schema.ResourceData, conn *ec2.EC2) ([ ebs.Iops = aws.Int64(int64(iops)) } else { // Enforce IOPs usage with a valid volume type - // Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/12667 + // Reference: https://github.com/hashicorp/terraform-provider-aws/issues/12667 return nil, fmt.Errorf("error creating resource: iops attribute not supported for ebs_block_device with volume_type %s", v) } } @@ -1981,7 +1981,7 @@ func readBlockDeviceMappingsFromConfig(d *schema.ResourceData, conn *ec2.EC2) ([ ebs.Iops = aws.Int64(int64(iops)) } else { // Enforce IOPs usage with a valid volume type - // Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/12667 + // Reference: https://github.com/hashicorp/terraform-provider-aws/issues/12667 return nil, fmt.Errorf("error creating resource: iops attribute not supported for root_block_device with volume_type %s", v) } } diff --git a/aws/resource_aws_instance_test.go b/aws/resource_aws_instance_test.go index 1a6ab4ae24c..832bdd39988 100644 --- a/aws/resource_aws_instance_test.go +++ b/aws/resource_aws_instance_test.go @@ -333,7 +333,7 @@ func TestAccAWSInstance_EbsBlockDevice_KmsKeyArn(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/12667 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/12667 func TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType(t *testing.T) { resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { testAccPreCheck(t) }, @@ -455,7 +455,7 @@ func TestAccAWSInstance_GP2IopsDevice(t *testing.T) { // TestAccAWSInstance_GP2WithIopsValue updated in v3.0.0 // to account for apply-time validation of the root_block_device.iops attribute for supported volume types -// Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/14310 +// Reference: https://github.com/hashicorp/terraform-provider-aws/pull/14310 func TestAccAWSInstance_GP2WithIopsValue(t *testing.T) { resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { testAccPreCheck(t) }, @@ -1293,7 +1293,7 @@ func TestAccAWSInstance_associatePublicIPAndPrivateIP(t *testing.T) { } // Allow Empty Private IP -// https://github.com/terraform-providers/terraform-provider-aws/issues/13626 +// https://github.com/hashicorp/terraform-provider-aws/issues/13626 func TestAccAWSInstance_Empty_PrivateIP(t *testing.T) { var v ec2.Instance resourceName := "aws_instance.test" @@ -2039,7 +2039,7 @@ func TestAccAWSInstance_addSecurityGroupNetworkInterface(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7063 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/7063 func TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs(t *testing.T) { var v ec2.Instance resourceName := "aws_instance.test" @@ -2077,7 +2077,7 @@ func TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs(t *te }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7063 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/7063 func TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs(t *testing.T) { var v ec2.Instance resourceName := "aws_instance.test" @@ -2106,7 +2106,7 @@ func TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7063 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/7063 func TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate(t *testing.T) { var v ec2.Instance resourceName := "aws_instance.test" @@ -2152,7 +2152,7 @@ func TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7063 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/7063 func TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs(t *testing.T) { var v ec2.Instance resourceName := "aws_instance.test" @@ -2182,7 +2182,7 @@ func TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs(t *t }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7063 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/7063 func TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate(t *testing.T) { var v ec2.Instance resourceName := "aws_instance.test" @@ -2229,7 +2229,7 @@ func TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdat }) } -// https://github.com/terraform-providers/terraform-provider-aws/issues/227 +// https://github.com/hashicorp/terraform-provider-aws/issues/227 func TestAccAWSInstance_associatePublic_defaultPrivate(t *testing.T) { var v ec2.Instance resourceName := "aws_instance.test" @@ -2257,7 +2257,7 @@ func TestAccAWSInstance_associatePublic_defaultPrivate(t *testing.T) { }) } -// https://github.com/terraform-providers/terraform-provider-aws/issues/227 +// https://github.com/hashicorp/terraform-provider-aws/issues/227 func TestAccAWSInstance_associatePublic_defaultPublic(t *testing.T) { var v ec2.Instance resourceName := "aws_instance.test" @@ -2285,7 +2285,7 @@ func TestAccAWSInstance_associatePublic_defaultPublic(t *testing.T) { }) } -// https://github.com/terraform-providers/terraform-provider-aws/issues/227 +// https://github.com/hashicorp/terraform-provider-aws/issues/227 func TestAccAWSInstance_associatePublic_explicitPublic(t *testing.T) { var v ec2.Instance resourceName := "aws_instance.test" @@ -2313,7 +2313,7 @@ func TestAccAWSInstance_associatePublic_explicitPublic(t *testing.T) { }) } -// https://github.com/terraform-providers/terraform-provider-aws/issues/227 +// https://github.com/hashicorp/terraform-provider-aws/issues/227 func TestAccAWSInstance_associatePublic_explicitPrivate(t *testing.T) { var v ec2.Instance resourceName := "aws_instance.test" @@ -2341,7 +2341,7 @@ func TestAccAWSInstance_associatePublic_explicitPrivate(t *testing.T) { }) } -// https://github.com/terraform-providers/terraform-provider-aws/issues/227 +// https://github.com/hashicorp/terraform-provider-aws/issues/227 func TestAccAWSInstance_associatePublic_overridePublic(t *testing.T) { var v ec2.Instance resourceName := "aws_instance.test" @@ -2369,7 +2369,7 @@ func TestAccAWSInstance_associatePublic_overridePublic(t *testing.T) { }) } -// https://github.com/terraform-providers/terraform-provider-aws/issues/227 +// https://github.com/hashicorp/terraform-provider-aws/issues/227 func TestAccAWSInstance_associatePublic_overridePrivate(t *testing.T) { var v ec2.Instance resourceName := "aws_instance.test" @@ -2496,7 +2496,7 @@ func TestAccAWSInstance_CreditSpecification_Empty_NonBurstable(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/10203 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/10203 func TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable(t *testing.T) { var instance ec2.Instance resourceName := "aws_instance.test" From 14e2f507df138092e300bdc3b3d062bcfc26b67d Mon Sep 17 00:00:00 2001 From: Simon Davis Date: Tue, 27 Oct 2020 11:05:15 -0700 Subject: [PATCH 2/7] a couple more moves --- docs/contributing/running-and-writing-acceptance-tests.md | 6 +++--- infrastructure/repository/main.tf | 2 +- scripts/changelog-links.sh | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/contributing/running-and-writing-acceptance-tests.md b/docs/contributing/running-and-writing-acceptance-tests.md index ae43b8ceeac..8efe8094e60 100644 --- a/docs/contributing/running-and-writing-acceptance-tests.md +++ b/docs/contributing/running-and-writing-acceptance-tests.md @@ -77,7 +77,7 @@ TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudWatchDashboard_update -timeout 120 === RUN TestAccAWSCloudWatchDashboard_update --- PASS: TestAccAWSCloudWatchDashboard_update (26.56s) PASS -ok github.com/terraform-providers/terraform-provider-aws/aws 26.607s +ok github.com/hashicorp/terraform-provider-aws/aws 26.607s ``` Entire resource test suites can be targeted by using the naming convention to @@ -96,7 +96,7 @@ TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudWatchDashboard -timeout 120m === RUN TestAccAWSCloudWatchDashboard_update --- PASS: TestAccAWSCloudWatchDashboard_update (27.81s) PASS -ok github.com/terraform-providers/terraform-provider-aws/aws 55.619s +ok github.com/hashicorp/terraform-provider-aws/aws 55.619s ``` Running acceptance tests requires version 0.12.26 or higher of the Terraform CLI to be installed. @@ -115,7 +115,7 @@ $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDBInstance_DbSubnetGroupName_ TestAccAWSDBInstance_DbSubnetGroupName_RamShared: provider_test.go:386: AWS_ALTERNATE_ACCESS_KEY_ID or AWS_ALTERNATE_PROFILE must be set for acceptance tests --- FAIL: TestAccAWSDBInstance_DbSubnetGroupName_RamShared (2.22s) FAIL -FAIL github.com/terraform-providers/terraform-provider-aws/aws 4.305s +FAIL github.com/hashicorp/terraform-provider-aws/aws 4.305s FAIL ``` diff --git a/infrastructure/repository/main.tf b/infrastructure/repository/main.tf index facd3863d0e..da755c9bbe5 100644 --- a/infrastructure/repository/main.tf +++ b/infrastructure/repository/main.tf @@ -11,5 +11,5 @@ terraform { } provider "github" { - organization = "terraform-providers" + organization = "hashicorp" } diff --git a/scripts/changelog-links.sh b/scripts/changelog-links.sh index 8cd81b43679..f7e2e692d58 100755 --- a/scripts/changelog-links.sh +++ b/scripts/changelog-links.sh @@ -24,7 +24,7 @@ else SED="sed -i.bak -r -e" fi -PROVIDER_URL="https:\/\/github.com\/terraform-providers\/terraform-provider-aws\/issues" +PROVIDER_URL="https:\/\/github.com\/hashicorp\/terraform-provider-aws\/issues" $SED "s/GH-([0-9]+)/\[#\1\]\($PROVIDER_URL\/\1\)/g" -e 's/\[\[#(.+)([0-9])\)]$/(\[#\1\2))/g' CHANGELOG.md From 1afa0ac190632a7492c1c1302813c2033b5c281e Mon Sep 17 00:00:00 2001 From: Simon Davis Date: Tue, 27 Oct 2020 11:11:17 -0700 Subject: [PATCH 3/7] move inheritied hashibot behaviors --- .hashibot.hcl | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/.hashibot.hcl b/.hashibot.hcl index 1c6ff6053dc..7ef40f0621c 100644 --- a/.hashibot.hcl +++ b/.hashibot.hcl @@ -1500,3 +1500,56 @@ behavior "pull_request_path_labeler" "service_labels" { ] } } + +behavior "regexp_issue_labeler" "panic_label" { + regexp = "panic:" + labels = ["crash", "bug"] +} + +behavior "regexp_issue_notifier" "panic_notify" { + regexp = "panic:" + slack_channel = env.COMMITTERS_SLACK_CHANNEL + message = "Panic report! https://github.com/${var.repository}/issues/${var.issue_number} has a panic in it." +} + +behavior "remove_labels_on_reply" "remove_stale" { + labels = ["waiting-response", "stale"] + only_non_maintainers = true +} + +behavior "pull_request_size_labeler" "size" { + label_prefix = "size/" + label_map = { + "size/XS" = { + from = 0 + to = 30 + } + "size/S" = { + from = 31 + to = 60 + } + "size/M" = { + from = 61 + to = 150 + } + "size/L" = { + from = 151 + to = 300 + } + "size/XL" = { + from = 301 + to = 1000 + } + "size/XXL" = { + from = 1001 + to = 0 + } + } +} + +behavior "pull_request_path_labeler" "cross_provider_labels" { + label_map = { + "documentation" = ["website/**/*"] + "dependencies" = ["vendor/**/*"] + } +} \ No newline at end of file From a5d53496e735dd722f50a8580215c1133de5286f Mon Sep 17 00:00:00 2001 From: Simon Davis Date: Thu, 29 Oct 2020 08:47:54 -0700 Subject: [PATCH 4/7] missed url references --- ROADMAP.md | 2 +- ...ata_source_aws_iam_policy_document_test.go | 6 +- ...ource_aws_kinesis_analytics_application.go | 4 +- ...s_kinesis_firehose_delivery_stream_test.go | 4 +- ...urce_aws_kinesisanalyticsv2_application.go | 4 +- aws/resource_aws_kms_key_test.go | 2 +- aws/resource_aws_lambda_function_test.go | 4 +- aws/resource_aws_launch_template_test.go | 2 +- aws/resource_aws_lb_listener_rule_test.go | 2 +- aws/resource_aws_lb_listener_test.go | 2 +- aws/resource_aws_lb_test.go | 2 +- aws/resource_aws_network_acl_rule_test.go | 2 +- aws/resource_aws_opsworks_permission_test.go | 2 +- aws/resource_aws_organizations_policy_test.go | 2 +- aws/resource_aws_rds_cluster_test.go | 12 ++-- aws/resource_aws_s3_bucket_metric_test.go | 2 +- aws/resource_aws_s3_bucket_test.go | 10 +-- ...ce_aws_sagemaker_notebook_instance_test.go | 8 +-- aws/resource_aws_security_group.go | 2 +- aws/resource_aws_security_group_rule_test.go | 2 +- ...ce_discovery_private_dns_namespace_test.go | 4 +- aws/resource_aws_ses_domain_identity_test.go | 2 +- ...rce_aws_vpc_endpoint_subnet_association.go | 2 +- aws/resource_aws_waf_rate_based_rule_test.go | 2 +- aws/resource_aws_wafv2_web_acl_test.go | 2 +- aws/resource_aws_workspaces_workspace_test.go | 2 +- aws/structure.go | 2 +- aws/structure_test.go | 2 +- aws/validators.go | 2 +- .../v2/helper/schema/resource.go | 2 +- docs/FAQ.md | 2 +- docs/MAINTAINING.md | 68 +++++++++---------- docs/contributing/contribution-checklists.md | 2 +- .../issue-reporting-and-lifecycle.md | 16 ++--- docs/roadmaps/2020_May_to_July.md | 14 ++-- examples/README.md | 2 +- website/docs/guides/resource-tagging.html.md | 4 +- website/docs/guides/version-2-upgrade.html.md | 4 +- website/docs/guides/version-3-upgrade.html.md | 2 +- .../r/dx_gateway_association.html.markdown | 2 +- ...gateway_association_proposal.html.markdown | 2 +- ...t_gateway_peering_attachment.html.markdown | 2 +- ...teway_peering_attachment_accepter.markdown | 2 +- ...ansit_gateway_vpc_attachment.html.markdown | 2 +- ...eway_vpc_attachment_accepter.html.markdown | 2 +- website/docs/r/lambda_function.html.markdown | 2 +- website/docs/r/security_group.html.markdown | 2 +- website/docs/r/subnet.html.markdown | 2 +- 48 files changed, 115 insertions(+), 115 deletions(-) diff --git a/ROADMAP.md b/ROADMAP.md index 881e9b54d1b..c6dba0ccd97 100644 --- a/ROADMAP.md +++ b/ROADMAP.md @@ -4,7 +4,7 @@ Every few months, the team will highlight areas of focus for our work and upcomi We select items for inclusion in the roadmap from the Top 10 Community Issues, [Core Services](docs/CORE_SERVICES.md), and internal priorities. Where community sourced contributions exist we will work with the authors to review and merge their work. Where this does not exist or the original contributors, are not available we will create the resources and implementation ourselves. -Each weekly release will include necessary tasks that lead to the completion of the stated goals as well as community pull requests, enhancements, and features that are not highlighted in the roadmap. To view all the items we've prioritized for this quarter, please see the [Roadmap milestone](https://github.com/terraform-providers/terraform-provider-aws/milestone/138). +Each weekly release will include necessary tasks that lead to the completion of the stated goals as well as community pull requests, enhancements, and features that are not highlighted in the roadmap. To view all the items we've prioritized for this quarter, please see the [Roadmap milestone](https://github.com/hashicorp/terraform-provider-aws/milestone/138). This roadmap does not describe all the work that will be included within this timeframe, but it does describe our focus. We will include other work as events occur . diff --git a/aws/data_source_aws_iam_policy_document_test.go b/aws/data_source_aws_iam_policy_document_test.go index ce91e24da2b..31007ca6882 100644 --- a/aws/data_source_aws_iam_policy_document_test.go +++ b/aws/data_source_aws_iam_policy_document_test.go @@ -146,7 +146,7 @@ func TestAccAWSDataSourceIAMPolicyDocument_duplicateSid(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/10777 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/10777 func TestAccAWSDataSourceIAMPolicyDocument_Statement_Principal_Identifiers_StringAndSlice(t *testing.T) { dataSourceName := "data.aws_iam_policy_document.test" @@ -164,8 +164,8 @@ func TestAccAWSDataSourceIAMPolicyDocument_Statement_Principal_Identifiers_Strin }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/10777 -func TestAccAWSDataSourceIAMPolicyDocument_Statement_Principal_Identifiers_MultiplePrincipalsAWS(t *testing.T) { +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/10777 +func TestAccAWSDataSourceIAMPolicyDocument_Statement_Principal_Identifiers_MultiplePrincipals(t *testing.T) { dataSourceName := "data.aws_iam_policy_document.test" resource.ParallelTest(t, resource.TestCase{ diff --git a/aws/resource_aws_kinesis_analytics_application.go b/aws/resource_aws_kinesis_analytics_application.go index ee0a424d3f8..3c703a44a3b 100644 --- a/aws/resource_aws_kinesis_analytics_application.go +++ b/aws/resource_aws_kinesis_analytics_application.go @@ -598,11 +598,11 @@ func resourceAwsKinesisAnalyticsApplicationCreate(d *schema.ResourceData, meta i err := resource.Retry(1*time.Minute, func() *resource.RetryError { output, err := conn.CreateApplication(createOpts) if err != nil { - // Kinesis Stream: https://github.com/terraform-providers/terraform-provider-aws/issues/7032 + // Kinesis Stream: https://github.com/hashicorp/terraform-provider-aws/issues/7032 if isAWSErr(err, kinesisanalytics.ErrCodeInvalidArgumentException, "Kinesis Analytics service doesn't have sufficient privileges") { return resource.RetryableError(err) } - // Kinesis Firehose: https://github.com/terraform-providers/terraform-provider-aws/issues/7394 + // Kinesis Firehose: https://github.com/hashicorp/terraform-provider-aws/issues/7394 if isAWSErr(err, kinesisanalytics.ErrCodeInvalidArgumentException, "Kinesis Analytics doesn't have sufficient privileges") { return resource.RetryableError(err) } diff --git a/aws/resource_aws_kinesis_firehose_delivery_stream_test.go b/aws/resource_aws_kinesis_firehose_delivery_stream_test.go index 248ea010dea..4693011305a 100644 --- a/aws/resource_aws_kinesis_firehose_delivery_stream_test.go +++ b/aws/resource_aws_kinesis_firehose_delivery_stream_test.go @@ -831,7 +831,7 @@ func TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ErrorOutputPrefix(t *tes }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/12600 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/12600 func TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ProcessingConfiguration_Empty(t *testing.T) { var stream firehose.DeliveryStreamDescription rInt := acctest.RandInt() @@ -1326,7 +1326,7 @@ func TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchWithVpcConfigUpdates(t }) } -// Regression test for https://github.com/terraform-providers/terraform-provider-aws/issues/1657 +// Regression test for https://github.com/hashicorp/terraform-provider-aws/issues/1657 func TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration(t *testing.T) { var stream firehose.DeliveryStreamDescription ri := acctest.RandInt() diff --git a/aws/resource_aws_kinesisanalyticsv2_application.go b/aws/resource_aws_kinesisanalyticsv2_application.go index 40dfb68fda0..ab44e7060ad 100644 --- a/aws/resource_aws_kinesisanalyticsv2_application.go +++ b/aws/resource_aws_kinesisanalyticsv2_application.go @@ -2606,12 +2606,12 @@ func kinesisAnalyticsV2RetryIAMEventualConsistency(f func() (interface{}, error) output, err = f() - // Kinesis Stream: https://github.com/terraform-providers/terraform-provider-aws/issues/7032 + // Kinesis Stream: https://github.com/hashicorp/terraform-provider-aws/issues/7032 if isAWSErr(err, kinesisanalyticsv2.ErrCodeInvalidArgumentException, "Kinesis Analytics service doesn't have sufficient privileges") { return resource.RetryableError(err) } - // Kinesis Firehose: https://github.com/terraform-providers/terraform-provider-aws/issues/7394 + // Kinesis Firehose: https://github.com/hashicorp/terraform-provider-aws/issues/7394 if isAWSErr(err, kinesisanalyticsv2.ErrCodeInvalidArgumentException, "Kinesis Analytics doesn't have sufficient privileges") { return resource.RetryableError(err) } diff --git a/aws/resource_aws_kms_key_test.go b/aws/resource_aws_kms_key_test.go index fa8e7d063e5..2831ae4489e 100644 --- a/aws/resource_aws_kms_key_test.go +++ b/aws/resource_aws_kms_key_test.go @@ -199,7 +199,7 @@ func TestAccAWSKmsKey_Policy_IamRole(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7646 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/7646 func TestAccAWSKmsKey_Policy_IamServiceLinkedRole(t *testing.T) { var key kms.KeyMetadata rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_lambda_function_test.go b/aws/resource_aws_lambda_function_test.go index bf006d2346c..01f0ad9b70a 100644 --- a/aws/resource_aws_lambda_function_test.go +++ b/aws/resource_aws_lambda_function_test.go @@ -676,7 +676,7 @@ func TestAccAWSLambdaFunction_tracingConfig(t *testing.T) { // This test is to verify the existing behavior in the Lambda API where the KMS Key ARN // is not returned if environment variables are not in use. If the API begins saving this // value and the kms_key_arn check begins failing, the documentation should be updated. -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/6366 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/6366 func TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables(t *testing.T) { var function1 lambda.GetFunctionOutput @@ -946,7 +946,7 @@ func TestAccAWSLambdaFunction_VPC_withInvocation(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/10044 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/10044 func TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies(t *testing.T) { var function lambda.GetFunctionOutput diff --git a/aws/resource_aws_launch_template_test.go b/aws/resource_aws_launch_template_test.go index f7f21b264dd..589a93e9948 100644 --- a/aws/resource_aws_launch_template_test.go +++ b/aws/resource_aws_launch_template_test.go @@ -642,7 +642,7 @@ func TestAccAWSLaunchTemplate_creditSpecification_t3(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/6757 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/6757 func TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock(t *testing.T) { var template1 ec2.LaunchTemplate rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_lb_listener_rule_test.go b/aws/resource_aws_lb_listener_rule_test.go index 5978fa12cf8..bd7ff2855ce 100644 --- a/aws/resource_aws_lb_listener_rule_test.go +++ b/aws/resource_aws_lb_listener_rule_test.go @@ -576,7 +576,7 @@ func TestAccAWSLBListenerRule_Action_Order(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/6171 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/6171 func TestAccAWSLBListenerRule_Action_Order_Recreates(t *testing.T) { var rule elbv2.Rule key := tlsRsaPrivateKeyPem(2048) diff --git a/aws/resource_aws_lb_listener_test.go b/aws/resource_aws_lb_listener_test.go index f0df931c547..b271acd76d1 100644 --- a/aws/resource_aws_lb_listener_test.go +++ b/aws/resource_aws_lb_listener_test.go @@ -407,7 +407,7 @@ func TestAccAWSLBListener_DefaultAction_Order(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/6171 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/6171 func TestAccAWSLBListener_DefaultAction_Order_Recreates(t *testing.T) { var listener elbv2.Listener key := tlsRsaPrivateKeyPem(2048) diff --git a/aws/resource_aws_lb_test.go b/aws/resource_aws_lb_test.go index 5ca920cf657..ec9bba9bded 100644 --- a/aws/resource_aws_lb_test.go +++ b/aws/resource_aws_lb_test.go @@ -2143,7 +2143,7 @@ resource "aws_lb" "lb_test" { } } -# See https://github.com/terraform-providers/terraform-provider-aws/issues/2498 +# See https://github.com/hashicorp/terraform-provider-aws/issues/2498 output "lb_name" { value = aws_lb.lb_test.name } diff --git a/aws/resource_aws_network_acl_rule_test.go b/aws/resource_aws_network_acl_rule_test.go index 64f84a4dd3a..ea56cdc6650 100644 --- a/aws/resource_aws_network_acl_rule_test.go +++ b/aws/resource_aws_network_acl_rule_test.go @@ -168,7 +168,7 @@ func TestAccAWSNetworkAclRule_ipv6ICMP(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/6710 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/6710 func TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate(t *testing.T) { var vpc ec2.Vpc vpcResourceName := "aws_vpc.test" diff --git a/aws/resource_aws_opsworks_permission_test.go b/aws/resource_aws_opsworks_permission_test.go index f4cef3e0338..75624288e61 100644 --- a/aws/resource_aws_opsworks_permission_test.go +++ b/aws/resource_aws_opsworks_permission_test.go @@ -92,7 +92,7 @@ func TestAccAWSOpsworksPermission_basic(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/4804 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/4804 func TestAccAWSOpsworksPermission_Self(t *testing.T) { var opsperm opsworks.Permission rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_organizations_policy_test.go b/aws/resource_aws_organizations_policy_test.go index 9b9eca99005..e54826ef8c5 100644 --- a/aws/resource_aws_organizations_policy_test.go +++ b/aws/resource_aws_organizations_policy_test.go @@ -51,7 +51,7 @@ func testAccAwsOrganizationsPolicy_basic(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/5073 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/5073 func testAccAwsOrganizationsPolicy_concurrent(t *testing.T) { var policy1, policy2, policy3, policy4, policy5 organizations.Policy rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_rds_cluster_test.go b/aws/resource_aws_rds_cluster_test.go index a5b435ede8c..35dc7cce8f9 100644 --- a/aws/resource_aws_rds_cluster_test.go +++ b/aws/resource_aws_rds_cluster_test.go @@ -1340,7 +1340,7 @@ func TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Provisioned(t *test }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13126 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/13126 func TestAccAWSRDSCluster_GlobalClusterIdentifier_PrimarySecondaryClusters(t *testing.T) { var providers []*schema.Provider var primaryDbCluster, secondaryDbCluster rds.DBCluster @@ -1368,7 +1368,7 @@ func TestAccAWSRDSCluster_GlobalClusterIdentifier_PrimarySecondaryClusters(t *te }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13715 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/13715 func TestAccAWSRDSCluster_GlobalClusterIdentifier_ReplicationSourceIdentifier(t *testing.T) { var providers []*schema.Provider var primaryDbCluster, secondaryDbCluster rds.DBCluster @@ -1489,7 +1489,7 @@ func TestAccAWSRDSCluster_ScalingConfiguration(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/11698 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/11698 func TestAccAWSRDSCluster_ScalingConfiguration_DefaultMinCapacity(t *testing.T) { var dbCluster rds.DBCluster @@ -1737,7 +1737,7 @@ func TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Serverless(t *testing.T) }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/6157 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/6157 func TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different(t *testing.T) { var dbCluster, sourceDbCluster rds.DBCluster var dbClusterSnapshot rds.DBClusterSnapshot @@ -1777,7 +1777,7 @@ func TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different(t *testing. }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/6157 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/6157 func TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal(t *testing.T) { var dbCluster, sourceDbCluster rds.DBCluster var dbClusterSnapshot rds.DBClusterSnapshot @@ -2053,7 +2053,7 @@ func TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds(t *testing.T) { }) } -// Regression reference: https://github.com/terraform-providers/terraform-provider-aws/issues/5450 +// Regression reference: https://github.com/hashicorp/terraform-provider-aws/issues/5450 // This acceptance test explicitly tests when snapshot_identifier is set, // vpc_security_group_ids is set (which triggered the resource update function), // and tags is set which was missing its ARN used for tagging diff --git a/aws/resource_aws_s3_bucket_metric_test.go b/aws/resource_aws_s3_bucket_metric_test.go index 6b498f7d60f..2e5d7bc2c04 100644 --- a/aws/resource_aws_s3_bucket_metric_test.go +++ b/aws/resource_aws_s3_bucket_metric_test.go @@ -293,7 +293,7 @@ func TestAccAWSS3BucketMetric_basic(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/11813 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/11813 // Disallow Empty filter block func TestAccAWSS3BucketMetric_WithEmptyFilter(t *testing.T) { var conf s3.MetricsConfiguration diff --git a/aws/resource_aws_s3_bucket_test.go b/aws/resource_aws_s3_bucket_test.go index 97eed8c9463..6508a0f0a86 100644 --- a/aws/resource_aws_s3_bucket_test.go +++ b/aws/resource_aws_s3_bucket_test.go @@ -197,7 +197,7 @@ func TestAccAWSS3Bucket_basic(t *testing.T) { } // Support for common Terraform 0.11 pattern -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7868 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/7868 func TestAccAWSS3Bucket_Bucket_EmptyString(t *testing.T) { resourceName := "aws_s3_bucket.test" @@ -1366,7 +1366,7 @@ func TestAccAWSS3Bucket_LifecycleExpireMarkerOnly(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/11420 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/11420 func TestAccAWSS3Bucket_LifecycleRule_Expiration_EmptyConfigurationBlock(t *testing.T) { rName := acctest.RandomWithPrefix("tf-acc-test") resourceName := "aws_s3_bucket.bucket" @@ -1386,7 +1386,7 @@ func TestAccAWSS3Bucket_LifecycleRule_Expiration_EmptyConfigurationBlock(t *test }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/15138 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/15138 func TestAccAWSS3Bucket_LifecycleRule_AbortIncompleteMultipartUploadDays_NoExpiration(t *testing.T) { rName := acctest.RandomWithPrefix("tf-acc-test") resourceName := "aws_s3_bucket.bucket" @@ -1627,7 +1627,7 @@ func TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlT }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/12480 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/12480 func TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AddAccessControlTranslation(t *testing.T) { rInt := acctest.RandInt() region := testAccGetRegion() @@ -1771,7 +1771,7 @@ func TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError(t *testing.T) }) } -// Prefix issue: https://github.com/terraform-providers/terraform-provider-aws/issues/6340 +// Prefix issue: https://github.com/hashicorp/terraform-provider-aws/issues/6340 func TestAccAWSS3Bucket_ReplicationWithoutPrefix(t *testing.T) { rInt := acctest.RandInt() alternateRegion := testAccGetAlternateRegion() diff --git a/aws/resource_aws_sagemaker_notebook_instance_test.go b/aws/resource_aws_sagemaker_notebook_instance_test.go index 506f9085560..63d9af3b107 100644 --- a/aws/resource_aws_sagemaker_notebook_instance_test.go +++ b/aws/resource_aws_sagemaker_notebook_instance_test.go @@ -470,10 +470,10 @@ func TestAccAWSSagemakerNotebookInstance_default_code_repository(t *testing.T) { CheckDestroy: testAccCheckAWSSagemakerNotebookInstanceDestroy, Steps: []resource.TestStep{ { - Config: testAccAWSSagemakerNotebookInstanceConfigDefaultCodeRepository(rName, "https://github.com/terraform-providers/terraform-provider-aws.git"), + Config: testAccAWSSagemakerNotebookInstanceConfigDefaultCodeRepository(rName, "https://github.com/hashicorp/terraform-provider-aws.git"), Check: resource.ComposeTestCheckFunc( testAccCheckAWSSagemakerNotebookInstanceExists(resourceName, ¬ebook), - resource.TestCheckResourceAttr(resourceName, "default_code_repository", "https://github.com/terraform-providers/terraform-provider-aws.git"), + resource.TestCheckResourceAttr(resourceName, "default_code_repository", "https://github.com/hashicorp/terraform-provider-aws.git"), ), }, { @@ -489,10 +489,10 @@ func TestAccAWSSagemakerNotebookInstance_default_code_repository(t *testing.T) { ), }, { - Config: testAccAWSSagemakerNotebookInstanceConfigDefaultCodeRepository(rName, "https://github.com/terraform-providers/terraform-provider-aws.git"), + Config: testAccAWSSagemakerNotebookInstanceConfigDefaultCodeRepository(rName, "https://github.com/hashicorp/terraform-provider-aws.git"), Check: resource.ComposeTestCheckFunc( testAccCheckAWSSagemakerNotebookInstanceExists(resourceName, ¬ebook), - resource.TestCheckResourceAttr(resourceName, "default_code_repository", "https://github.com/terraform-providers/terraform-provider-aws.git"), + resource.TestCheckResourceAttr(resourceName, "default_code_repository", "https://github.com/hashicorp/terraform-provider-aws.git"), ), }, }, diff --git a/aws/resource_aws_security_group.go b/aws/resource_aws_security_group.go index 8b43234d871..d1a06b32fc0 100644 --- a/aws/resource_aws_security_group.go +++ b/aws/resource_aws_security_group.go @@ -1229,7 +1229,7 @@ func resourceAwsSecurityGroupCollapseRules(ruleset string, rules []interface{}) // resourceAwsSecurityGroupExpandRules works in pair with // resourceAwsSecurityGroupCollapseRules and is used as a // workaround for the problem explained in -// https://github.com/terraform-providers/terraform-provider-aws/pull/4726 +// https://github.com/hashicorp/terraform-provider-aws/pull/4726 // // This function converts every ingress/egress block that // contains multiple rules to multiple blocks with only one diff --git a/aws/resource_aws_security_group_rule_test.go b/aws/resource_aws_security_group_rule_test.go index f3bbc76adef..963e19447c7 100644 --- a/aws/resource_aws_security_group_rule_test.go +++ b/aws/resource_aws_security_group_rule_test.go @@ -934,7 +934,7 @@ func TestAccAWSSecurityGroupRule_Description_AllPorts_NonZeroPorts(t *testing.T) }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/6416 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/6416 func TestAccAWSSecurityGroupRule_MultipleRuleSearching_AllProtocolCrash(t *testing.T) { var group ec2.SecurityGroup rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_service_discovery_private_dns_namespace_test.go b/aws/resource_aws_service_discovery_private_dns_namespace_test.go index 8db71f45033..b1545bebdcd 100644 --- a/aws/resource_aws_service_discovery_private_dns_namespace_test.go +++ b/aws/resource_aws_service_discovery_private_dns_namespace_test.go @@ -164,8 +164,8 @@ func TestAccAWSServiceDiscoveryPrivateDnsNamespace_Description(t *testing.T) { } // This acceptance test ensures we properly send back error messaging. References: -// * https://github.com/terraform-providers/terraform-provider-aws/issues/2830 -// * https://github.com/terraform-providers/terraform-provider-aws/issues/5532 +// * https://github.com/hashicorp/terraform-provider-aws/issues/2830 +// * https://github.com/hashicorp/terraform-provider-aws/issues/5532 func TestAccAWSServiceDiscoveryPrivateDnsNamespace_error_Overlap(t *testing.T) { rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_ses_domain_identity_test.go b/aws/resource_aws_ses_domain_identity_test.go index e9491ae2664..efa62bb77ea 100644 --- a/aws/resource_aws_ses_domain_identity_test.go +++ b/aws/resource_aws_ses_domain_identity_test.go @@ -111,7 +111,7 @@ func TestAccAWSSESDomainIdentity_disappears(t *testing.T) { } // TestAccAWSSESDomainIdentity_trailingPeriod updated in 3.0 to account for domain plan-time validation -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13510 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/13510 func TestAccAWSSESDomainIdentity_trailingPeriod(t *testing.T) { domain := fmt.Sprintf( "%s.terraformtesting.com.", diff --git a/aws/resource_aws_vpc_endpoint_subnet_association.go b/aws/resource_aws_vpc_endpoint_subnet_association.go index ddf9bfeb68b..477fe03ebc9 100644 --- a/aws/resource_aws_vpc_endpoint_subnet_association.go +++ b/aws/resource_aws_vpc_endpoint_subnet_association.go @@ -53,7 +53,7 @@ func resourceAwsVpcEndpointSubnetAssociationCreate(d *schema.ResourceData, meta return err } - // See https://github.com/terraform-providers/terraform-provider-aws/issues/3382. + // See https://github.com/hashicorp/terraform-provider-aws/issues/3382. // Prevent concurrent subnet association requests and delay between requests. mk := "vpc_endpoint_subnet_association_" + endpointId awsMutexKV.Lock(mk) diff --git a/aws/resource_aws_waf_rate_based_rule_test.go b/aws/resource_aws_waf_rate_based_rule_test.go index bcc9d21fd6c..25ceabd550b 100644 --- a/aws/resource_aws_waf_rate_based_rule_test.go +++ b/aws/resource_aws_waf_rate_based_rule_test.go @@ -151,7 +151,7 @@ func TestAccAWSWafRateBasedRule_changePredicates(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/9659 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/9659 func TestAccAWSWafRateBasedRule_changeRateLimit(t *testing.T) { var ipset waf.IPSet var before, after waf.RateBasedRule diff --git a/aws/resource_aws_wafv2_web_acl_test.go b/aws/resource_aws_wafv2_web_acl_test.go index cbc77d69283..a9a08eb2c55 100644 --- a/aws/resource_aws_wafv2_web_acl_test.go +++ b/aws/resource_aws_wafv2_web_acl_test.go @@ -1169,7 +1169,7 @@ func TestAccAwsWafv2WebACL_Tags(t *testing.T) { }) } -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13862 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/13862 func TestAccAwsWafv2WebACL_MaxNestedRateBasedStatements(t *testing.T) { var v wafv2.WebACL webACLName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/resource_aws_workspaces_workspace_test.go b/aws/resource_aws_workspaces_workspace_test.go index 2c139a5db28..3dadeace622 100644 --- a/aws/resource_aws_workspaces_workspace_test.go +++ b/aws/resource_aws_workspaces_workspace_test.go @@ -215,7 +215,7 @@ func TestAccAwsWorkspacesWorkspace_workspaceProperties(t *testing.T) { // TestAccAwsWorkspacesWorkspace_workspaceProperties_runningModeAlwaysOn // validates workspace resource creation/import when workspace_properties.running_mode is set to ALWAYS_ON -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13558 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/13558 func TestAccAwsWorkspacesWorkspace_workspaceProperties_runningModeAlwaysOn(t *testing.T) { var v1 workspaces.Workspace rName := acctest.RandomWithPrefix("tf-acc-test") diff --git a/aws/structure.go b/aws/structure.go index 3665e6a768c..5cb61ce944b 100644 --- a/aws/structure.go +++ b/aws/structure.go @@ -4147,7 +4147,7 @@ func expandDynamoDbLocalSecondaryIndexes(cfg []interface{}, keySchemaM map[strin m := lsi.(map[string]interface{}) idxName := m["name"].(string) - // TODO: See https://github.com/terraform-providers/terraform-provider-aws/issues/3176 + // TODO: See https://github.com/hashicorp/terraform-provider-aws/issues/3176 if _, ok := m["hash_key"]; !ok { m["hash_key"] = keySchemaM["hash_key"] } diff --git a/aws/structure_test.go b/aws/structure_test.go index 8b3bb4940a8..20cde7b351a 100644 --- a/aws/structure_test.go +++ b/aws/structure_test.go @@ -1628,7 +1628,7 @@ const testExampleXML_from_msdn_flawed = ` // TestExpandRdsClusterScalingConfiguration_serverless removed in v3.0.0 // as all engine_modes are treated equal when expanding scaling_configuration // and an override of min_capacity is no longer needed -// Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/11698 +// Reference: https://github.com/hashicorp/terraform-provider-aws/issues/11698 func TestExpandRdsClusterScalingConfiguration_basic(t *testing.T) { type testCase struct { diff --git a/aws/validators.go b/aws/validators.go index d877c5c39b3..7e5f14243a0 100644 --- a/aws/validators.go +++ b/aws/validators.go @@ -2111,7 +2111,7 @@ func validateAmazonSideAsn(v interface{}, k string) (ws []string, errors []error return } - // https://github.com/terraform-providers/terraform-provider-aws/issues/5263 + // https://github.com/hashicorp/terraform-provider-aws/issues/5263 isLegacyAsn := func(a int64) bool { return a == 7224 || a == 9059 || a == 10124 || a == 17493 } diff --git a/awsproviderlint/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go b/awsproviderlint/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go index f295cab7eef..e6adf25cd80 100644 --- a/awsproviderlint/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go +++ b/awsproviderlint/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go @@ -719,7 +719,7 @@ func isReservedDataSourceFieldName(name string) bool { func isReservedResourceFieldName(name string, s *Schema) bool { // Allow phasing out "id" - // See https://github.com/terraform-providers/terraform-provider-aws/pull/1626#issuecomment-328881415 + // See https://github.com/hashicorp/terraform-provider-aws/pull/1626#issuecomment-328881415 if name == "id" && s.Deprecated != "" { return false } diff --git a/docs/FAQ.md b/docs/FAQ.md index 2b00f9d53e9..b85eb5e00d3 100644 --- a/docs/FAQ.md +++ b/docs/FAQ.md @@ -19,7 +19,7 @@ Unfortunately, due to the volume of issues and new pull requests we receive, we ### How do you decide what gets merged for each release? -The number one factor we look at when deciding what issues to look at are your 👍 [reactions](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue/PR description as these can be [easily discovered](https://github.com/terraform-providers/terraform-provider-aws/issues?q=is%3Aopen+sort%3Areactions-%2B1-desc). Comments that further explain desired use cases or poor user experience are also heavily factored. The items with the most support are always on our radar, and we commit to keep the community updated on their status and potential timelines. +The number one factor we look at when deciding what issues to look at are your 👍 [reactions](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue/PR description as these can be [easily discovered](https://github.com/hashicorp/terraform-provider-aws/issues?q=is%3Aopen+sort%3Areactions-%2B1-desc). Comments that further explain desired use cases or poor user experience are also heavily factored. The items with the most support are always on our radar, and we commit to keep the community updated on their status and potential timelines. We publish a [roadmap](../ROADMAP.md) every quarter which describes major themes or specific product areas of focus. diff --git a/docs/MAINTAINING.md b/docs/MAINTAINING.md index 2bbcc715f68..f30a296d7fd 100644 --- a/docs/MAINTAINING.md +++ b/docs/MAINTAINING.md @@ -48,11 +48,11 @@ Notes for each type of pull request are (or will be) available in subsections be This pull request appears to be related to/solve #1234, so I have edited the pull request description to denote the issue reference. ``` -- Review the contents of the pull request and ensure the change follows the relevant section of the [Contributing Guide](https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/contribution-checklists.md) +- Review the contents of the pull request and ensure the change follows the relevant section of the [Contributing Guide](https://github.com/hashicorp/terraform-provider-aws/blob/master/docs/contributing/contribution-checklists.md) - If the change is not acceptable, leave a long form comment about the reasoning and close the pull request - If the change is acceptable with modifications, leave a pull request review marked using the `Request Changes` option (for maintainer pull requests with minor modification requests, giving feedback with the `Approve` option is recommended so they do not need to wait for another round of review) - If the author is unresponsive for changes (by default we give two weeks), determine importance and level of effort to finish the pull request yourself including their commits or close the pull request -- Run relevant acceptance testing ([locally](https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/running-and-writing-acceptance-tests.md) or in TeamCity) against AWS Commercial and AWS GovCloud (US) to ensure no new failures are being introduced +- Run relevant acceptance testing ([locally](https://github.com/hashicorp/terraform-provider-aws/blob/master/docs/contributing/running-and-writing-acceptance-tests.md) or in TeamCity) against AWS Commercial and AWS GovCloud (US) to ensure no new failures are being introduced - Approve the pull request with a comment outlining what steps you took that ensure the change is acceptable, e.g. acceptance testing output ``````markdown @@ -92,7 +92,7 @@ Ensure that the following steps are tracked within the issue and completed withi - Update `.go-version` - Update `CHANGELOG.md` detailing the update and mention any notes practitioners need to be aware of. -See [#9992](https://github.com/terraform-providers/terraform-provider-aws/issues/9992) / [#10206](https://github.com/terraform-providers/terraform-provider-aws/pull/10206) for a recent example. +See [#9992](https://github.com/hashicorp/terraform-provider-aws/issues/9992) / [#10206](https://github.com/hashicorp/terraform-provider-aws/pull/10206) for a recent example. ##### AWS Go SDK Updates @@ -102,19 +102,19 @@ Authentication changes: Occasionally, there will be changes listed in the authentication pieces of the AWS Go SDK codebase, e.g. changes to `aws/session`. The AWS Go SDK `CHANGELOG` should include a relevant description of these changes under a heading such as `SDK Enhancements` or `SDK Bug Fixes`. If they seem worthy of a callout in the Terraform AWS Provider `CHANGELOG`, then upon merging we should include a similar message prefixed with the `provider` subsystem, e.g. `* provider: ...`. -Additionally, if a `CHANGELOG` addition seemed appropriate, this dependency and version should also be updated in the Terraform S3 Backend, which currently lives in Terraform Core. An example of this can be found with https://github.com/terraform-providers/terraform-provider-aws/pull/9305 and https://github.com/hashicorp/terraform/pull/22055. +Additionally, if a `CHANGELOG` addition seemed appropriate, this dependency and version should also be updated in the Terraform S3 Backend, which currently lives in Terraform Core. An example of this can be found with https://github.com/hashicorp/terraform-provider-aws/pull/9305 and https://github.com/hashicorp/terraform/pull/22055. CloudFront changes: -CloudFront service client updates have previously caused an issue when a new field introduced in the SDK was not included with Terraform and caused all requests to error (https://github.com/terraform-providers/terraform-provider-aws/issues/4091). As a precaution, if you see CloudFront updates, run all the CloudFront resource acceptance testing before merging (`TestAccAWSCloudFront`). +CloudFront service client updates have previously caused an issue when a new field introduced in the SDK was not included with Terraform and caused all requests to error (https://github.com/hashicorp/terraform-provider-aws/issues/4091). As a precaution, if you see CloudFront updates, run all the CloudFront resource acceptance testing before merging (`TestAccAWSCloudFront`). New Regions: These are added to the AWS Go SDK `aws/endpoints/defaults.go` file and generally noted in the AWS Go SDK `CHANGELOG` as `aws/endpoints: Updated Regions`. Since April 2019, new regions added to AWS now require being explicitly enabled before they can be used. Examples of this can be found when `me-south-1` was announced: -- [Terraform AWS Provider issue](https://github.com/terraform-providers/terraform-provider-aws/issues/9545) -- [Terraform AWS Provider AWS Go SDK update pull request](https://github.com/terraform-providers/terraform-provider-aws/pull/9538) -- [Terraform AWS Provider data source update pull request](https://github.com/terraform-providers/terraform-provider-aws/pull/9547) +- [Terraform AWS Provider issue](https://github.com/hashicorp/terraform-provider-aws/issues/9545) +- [Terraform AWS Provider AWS Go SDK update pull request](https://github.com/hashicorp/terraform-provider-aws/pull/9538) +- [Terraform AWS Provider data source update pull request](https://github.com/hashicorp/terraform-provider-aws/pull/9547) - [Terraform S3 Backend issue](https://github.com/hashicorp/terraform/issues/22254) - [Terraform S3 Backend pull request](https://github.com/hashicorp/terraform/pull/22253) @@ -461,59 +461,59 @@ Environment variables (beyond standard AWS Go SDK ones) used by acceptance testi | [![waiting-response][waiting-response-badge]][waiting-response] | Maintainers are waiting on response from community or contributor. | None | [breaking-change-badge]: https://img.shields.io/badge/breaking--change-d93f0b -[breaking-change]: https://github.com/terraform-providers/terraform-provider-aws/labels/breaking-change +[breaking-change]: https://github.com/hashicorp/terraform-provider-aws/labels/breaking-change [bug-badge]: https://img.shields.io/badge/bug-f7c6c7 -[bug]: https://github.com/terraform-providers/terraform-provider-aws/labels/bug +[bug]: https://github.com/hashicorp/terraform-provider-aws/labels/bug [crash-badge]: https://img.shields.io/badge/crash-e11d21 -[crash]: https://github.com/terraform-providers/terraform-provider-aws/labels/crash +[crash]: https://github.com/hashicorp/terraform-provider-aws/labels/crash [dependencies-badge]: https://img.shields.io/badge/dependencies-fad8c7 -[dependencies]: https://github.com/terraform-providers/terraform-provider-aws/labels/dependencies +[dependencies]: https://github.com/hashicorp/terraform-provider-aws/labels/dependencies [documentation-badge]: https://img.shields.io/badge/documentation-fef2c0 -[documentation]: https://github.com/terraform-providers/terraform-provider-aws/labels/documentation +[documentation]: https://github.com/hashicorp/terraform-provider-aws/labels/documentation [enhancement-badge]: https://img.shields.io/badge/enhancement-d4c5f9 -[enhancement]: https://github.com/terraform-providers/terraform-provider-aws/labels/enhancement +[enhancement]: https://github.com/hashicorp/terraform-provider-aws/labels/enhancement [examples-badge]: https://img.shields.io/badge/examples-fef2c0 -[examples]: https://github.com/terraform-providers/terraform-provider-aws/labels/examples +[examples]: https://github.com/hashicorp/terraform-provider-aws/labels/examples [good-first-issue-badge]: https://img.shields.io/badge/good%20first%20issue-128A0C -[good-first-issue]: https://github.com/terraform-providers/terraform-provider-aws/labels/good%20first%20issue +[good-first-issue]: https://github.com/hashicorp/terraform-provider-aws/labels/good%20first%20issue [hacktoberfest-badge]: https://img.shields.io/badge/hacktoberfest-2c0fad -[hacktoberfest]: https://github.com/terraform-providers/terraform-provider-aws/labels/hacktoberfest +[hacktoberfest]: https://github.com/hashicorp/terraform-provider-aws/labels/hacktoberfest [hashibot-ignore-badge]: https://img.shields.io/badge/hashibot%2Fignore-2c0fad -[hashibot-ignore]: https://github.com/terraform-providers/terraform-provider-aws/labels/hashibot-ignore +[hashibot-ignore]: https://github.com/hashicorp/terraform-provider-aws/labels/hashibot-ignore [help-wanted-badge]: https://img.shields.io/badge/help%20wanted-128A0C -[help-wanted]: https://github.com/terraform-providers/terraform-provider-aws/labels/help-wanted +[help-wanted]: https://github.com/hashicorp/terraform-provider-aws/labels/help-wanted [needs-triage-badge]: https://img.shields.io/badge/needs--triage-e236d7 -[needs-triage]: https://github.com/terraform-providers/terraform-provider-aws/labels/needs-triage +[needs-triage]: https://github.com/hashicorp/terraform-provider-aws/labels/needs-triage [new-data-source-badge]: https://img.shields.io/badge/new--data--source-d4c5f9 -[new-data-source]: https://github.com/terraform-providers/terraform-provider-aws/labels/new-data-source +[new-data-source]: https://github.com/hashicorp/terraform-provider-aws/labels/new-data-source [new-resource-badge]: https://img.shields.io/badge/new--resource-d4c5f9 -[new-resource]: https://github.com/terraform-providers/terraform-provider-aws/labels/new-resource +[new-resource]: https://github.com/hashicorp/terraform-provider-aws/labels/new-resource [proposal-badge]: https://img.shields.io/badge/proposal-fbca04 -[proposal]: https://github.com/terraform-providers/terraform-provider-aws/labels/proposal +[proposal]: https://github.com/hashicorp/terraform-provider-aws/labels/proposal [provider-badge]: https://img.shields.io/badge/provider-bfd4f2 -[provider]: https://github.com/terraform-providers/terraform-provider-aws/labels/provider +[provider]: https://github.com/hashicorp/terraform-provider-aws/labels/provider [question-badge]: https://img.shields.io/badge/question-d4c5f9 -[question]: https://github.com/terraform-providers/terraform-provider-aws/labels/question +[question]: https://github.com/hashicorp/terraform-provider-aws/labels/question [regression-badge]: https://img.shields.io/badge/regression-e11d21 -[regression]: https://github.com/terraform-providers/terraform-provider-aws/labels/regression +[regression]: https://github.com/hashicorp/terraform-provider-aws/labels/regression [reinvent-badge]: https://img.shields.io/badge/reinvent-c5def5 -[reinvent]: https://github.com/terraform-providers/terraform-provider-aws/labels/reinvent +[reinvent]: https://github.com/hashicorp/terraform-provider-aws/labels/reinvent [service-badge]: https://img.shields.io/badge/service%2F<*>-bfd4f2 [size-badge]: https://img.shields.io/badge/size%2F<*>-ffffff [stale-badge]: https://img.shields.io/badge/stale-e11d21 -[stale]: https://github.com/terraform-providers/terraform-provider-aws/labels/stale +[stale]: https://github.com/hashicorp/terraform-provider-aws/labels/stale [technical-debt-badge]: https://img.shields.io/badge/technical--debt-1d76db -[technical-debt]: https://github.com/terraform-providers/terraform-provider-aws/labels/technical-debt +[technical-debt]: https://github.com/hashicorp/terraform-provider-aws/labels/technical-debt [tests-badge]: https://img.shields.io/badge/tests-DDDDDD -[tests]: https://github.com/terraform-providers/terraform-provider-aws/labels/tests +[tests]: https://github.com/hashicorp/terraform-provider-aws/labels/tests [thinking-badge]: https://img.shields.io/badge/thinking-bfd4f2 -[thinking]: https://github.com/terraform-providers/terraform-provider-aws/labels/thinking +[thinking]: https://github.com/hashicorp/terraform-provider-aws/labels/thinking [upstream-terraform-badge]: https://img.shields.io/badge/upstream--terraform-CCCCCC -[upstream-terraform]: https://github.com/terraform-providers/terraform-provider-aws/labels/upstream-terraform +[upstream-terraform]: https://github.com/hashicorp/terraform-provider-aws/labels/upstream-terraform [upstream-badge]: https://img.shields.io/badge/upstream-fad8c7 -[upstream]: https://github.com/terraform-providers/terraform-provider-aws/labels/upstream +[upstream]: https://github.com/hashicorp/terraform-provider-aws/labels/upstream [waiting-response-badge]: https://img.shields.io/badge/waiting--response-5319e7 -[waiting-response]: https://github.com/terraform-providers/terraform-provider-aws/labels/waiting-response +[waiting-response]: https://github.com/hashicorp/terraform-provider-aws/labels/waiting-response ## Release Process diff --git a/docs/contributing/contribution-checklists.md b/docs/contributing/contribution-checklists.md index d356f99c04e..15394ea4dc1 100644 --- a/docs/contributing/contribution-checklists.md +++ b/docs/contributing/contribution-checklists.md @@ -236,7 +236,7 @@ Implementing tagging support for Terraform AWS Provider resources requires the f - [ ] _Resource Tagging Acceptance Testing Implementation_: In the resource acceptance testing (e.g. `aws/resource_aws_service_thing_test.go`), implementation of new acceptance test function and configurations to exercise new tagging logic. - [ ] _Resource Tagging Documentation Implementation_: In the resource documentation (e.g. `website/docs/r/service_thing.html.markdown`), addition of `tags` argument -See also a [full example pull request for implementing EKS tagging](https://github.com/terraform-providers/terraform-provider-aws/pull/10307). +See also a [full example pull request for implementing EKS tagging](https://github.com/hashicorp/terraform-provider-aws/pull/10307). ### Adding Service to Tag Generating Code diff --git a/docs/contributing/issue-reporting-and-lifecycle.md b/docs/contributing/issue-reporting-and-lifecycle.md index dcd1be23dae..5bb3d270d7b 100644 --- a/docs/contributing/issue-reporting-and-lifecycle.md +++ b/docs/contributing/issue-reporting-and-lifecycle.md @@ -3,9 +3,9 @@ - [Issue Reporting Checklists](#issue-reporting-checklists) - - [Bug Reports](https://github.com/terraform-providers/terraform-provider-aws/issues/new?template=Bug_Report.md) - - [Feature Requests](https://github.com/terraform-providers/terraform-provider-aws/issues/new?labels=enhancement&template=Feature_Request.md) - - [Questions](https://github.com/terraform-providers/terraform-provider-aws/issues/new?labels=question&template=Question.md) + - [Bug Reports](https://github.com/hashicorp/terraform-provider-aws/issues/new?template=Bug_Report.md) + - [Feature Requests](https://github.com/hashicorp/terraform-provider-aws/issues/new?labels=enhancement&template=Feature_Request.md) + - [Questions](https://github.com/hashicorp/terraform-provider-aws/issues/new?labels=question&template=Question.md) - [Issue Lifecycle](#issue-lifecycle) @@ -16,7 +16,7 @@ We welcome issues of all kinds including feature requests, bug reports, and general questions. Below you'll find checklists with guidelines for well-formed issues of each type. -### [Bug Reports](https://github.com/terraform-providers/terraform-provider-aws/issues/new?template=Bug_Report.md) +### [Bug Reports](https://github.com/hashicorp/terraform-provider-aws/issues/new?template=Bug_Report.md) - [ ] __Test against latest release__: Make sure you test against the latest released version. It is possible we already fixed the bug you're experiencing. @@ -24,7 +24,7 @@ issues of each type. - [ ] __Search for possible duplicate reports__: It's helpful to keep bug reports consolidated to one thread, so do a quick search on existing bug reports to check if anybody else has reported the same thing. You can [scope - searches by the label "bug"](https://github.com/terraform-providers/terraform-provider-aws/issues?q=is%3Aopen+is%3Aissue+label%3Abug) to help narrow things down. + searches by the label "bug"](https://github.com/hashicorp/terraform-provider-aws/issues?q=is%3Aopen+is%3Aissue+label%3Abug) to help narrow things down. - [ ] __Include steps to reproduce__: Provide steps to reproduce the issue, along with your `.tf` files, with secrets removed, so we can try to @@ -34,19 +34,19 @@ issues of each type. create a [gist](https://gist.github.com) of the *entire* generated crash log for us to look at. Double check no sensitive items were in the log. -### [Feature Requests](https://github.com/terraform-providers/terraform-provider-aws/issues/new?labels=enhancement&template=Feature_Request.md) +### [Feature Requests](https://github.com/hashicorp/terraform-provider-aws/issues/new?labels=enhancement&template=Feature_Request.md) - [ ] __Search for possible duplicate requests__: It's helpful to keep requests consolidated to one thread, so do a quick search on existing requests to check if anybody else has reported the same thing. You can [scope searches by - the label "enhancement"](https://github.com/terraform-providers/terraform-provider-aws/issues?q=is%3Aopen+is%3Aissue+label%3Aenhancement) to help narrow things down. + the label "enhancement"](https://github.com/hashicorp/terraform-provider-aws/issues?q=is%3Aopen+is%3Aissue+label%3Aenhancement) to help narrow things down. - [ ] __Include a use case description__: In addition to describing the behavior of the feature you'd like to see added, it's helpful to also lay out the reason why the feature would be important and how it would benefit Terraform users. -### [Questions](https://github.com/terraform-providers/terraform-provider-aws/issues/new?labels=question&template=Question.md) +### [Questions](https://github.com/hashicorp/terraform-provider-aws/issues/new?labels=question&template=Question.md) - [ ] __Search for answers in Terraform documentation__: We're happy to answer questions in GitHub Issues, but it helps reduce issue churn and maintainer diff --git a/docs/roadmaps/2020_May_to_July.md b/docs/roadmaps/2020_May_to_July.md index 3b74eb24209..40651bdaa9f 100644 --- a/docs/roadmaps/2020_May_to_July.md +++ b/docs/roadmaps/2020_May_to_July.md @@ -6,13 +6,13 @@ We select items for inclusion in the roadmap from the Top 10 Community Issues, [ Each weekly release will include necessary tasks that lead to the completion of the stated goals as well as community pull requests, enhancements, and features that are not highlighted in the roadmap. -To make contribution easier, we’ll be using the [`Help Wanted`](https://github.com/terraform-providers/terraform-provider-aws/labels/help%20wanted) tag to point to issues we’d like to include in this quarter’s series of releases. +To make contribution easier, we’ll be using the [`Help Wanted`](https://github.com/hashicorp/terraform-provider-aws/labels/help%20wanted) tag to point to issues we’d like to include in this quarter’s series of releases. This quarter (May-July ‘20) we will be prioritizing the following areas of work: ### 3.0.0 -Milestone: [v3.0.0](https://github.com/terraform-providers/terraform-provider-aws/milestone/70) +Milestone: [v3.0.0](https://github.com/hashicorp/terraform-provider-aws/milestone/70) Each year the TF AWS Provider team releases a major version. [Major releases](https://www.terraform.io/docs/extend/best-practices/versioning.html#example-major-number-increments) include code removals, deprecations, and breaking changes. A corresponding “upgrade guide” will be published alongside the release. @@ -20,7 +20,7 @@ We'll be updating the linked milestone as we work to finalize and complete v3.0. ### WAFv2 -Issue: [#11046](https://github.com/terraform-providers/terraform-provider-aws/issues/11046) +Issue: [#11046](https://github.com/hashicorp/terraform-provider-aws/issues/11046) _AWS WAFv2 is a web application firewall that lets you monitor the HTTP and HTTPS requests that are forwarded to Amazon CloudFront, an Amazon API Gateway API, or an Application Load Balancer._ @@ -45,7 +45,7 @@ Support for WAFv2 will include: ### Amazon Lex -Issue: [#905](https://github.com/terraform-providers/terraform-provider-aws/issues/905) +Issue: [#905](https://github.com/hashicorp/terraform-provider-aws/issues/905) _Amazon Lex is a service for building conversational interfaces into any application using voice and text. Amazon Lex provides the advanced deep learning functionalities of automatic speech recognition (ASR) for converting speech to text, and natural language understanding (NLU) to recognize the intent of the text, to enable you to build applications with highly engaging user experiences and lifelike conversational interactions._ @@ -69,11 +69,11 @@ Support for Amazon Lex will include: ### AWS Certificate Manager -Issue: [#8531](https://github.com/terraform-providers/terraform-provider-aws/issues/8531) +Issue: [#8531](https://github.com/hashicorp/terraform-provider-aws/issues/8531) _AWS Certificate Manager is a service that allows you to easily provision, manage, and deploy public and private Secure Sockets Layer/Transport Layer Security (SSL/TLS) certificates for use with AWS services and your internal connected resources._ -After evaluating the issue linked above, we concluded that the ACM resource was in need of a redesign. We’ll be prioritizing redesigning and updating the resource while we tackle the open bug reports and enhancements. Our research and redesign work will be tracked [here](https://github.com/terraform-providers/terraform-provider-aws/issues/13053). +After evaluating the issue linked above, we concluded that the ACM resource was in need of a redesign. We’ll be prioritizing redesigning and updating the resource while we tackle the open bug reports and enhancements. Our research and redesign work will be tracked [here](https://github.com/hashicorp/terraform-provider-aws/issues/13053). ## Research Topics @@ -81,7 +81,7 @@ Research topics include features, architectural changes, and ideas that we are p ### Global Default Tags -Issue: [#7926](https://github.com/terraform-providers/terraform-provider-aws/issues/7926) +Issue: [#7926](https://github.com/hashicorp/terraform-provider-aws/issues/7926) We’ve been evaluating how users approach tagging their infrastructure in Terraform and the systems and practices that may interact with TF when it comes to tagging. The [initial discussions](https://github.com/hashicorp/terraform/issues/20866) led us to prioritize functionality that allows users to ignore specific tags globally in the AWS provider. As a complement to that feature, we are exploring the ability to supply global default tags to resources defined by the AWS Provider. diff --git a/examples/README.md b/examples/README.md index 6a39e32afec..dce48475c3b 100644 --- a/examples/README.md +++ b/examples/README.md @@ -10,7 +10,7 @@ the example's own directory. For example: ``` -$ git clone https://github.com/terraform-providers/terraform-provider-aws +$ git clone https://github.com/hashicorp/terraform-provider-aws $ cd terraform-provider-aws/examples/two-tier $ terraform apply ... diff --git a/website/docs/guides/resource-tagging.html.md b/website/docs/guides/resource-tagging.html.md index 06b14d5e82e..2148b3952e0 100644 --- a/website/docs/guides/resource-tagging.html.md +++ b/website/docs/guides/resource-tagging.html.md @@ -10,7 +10,7 @@ description: |- Many AWS services implement [resource tags](https://docs.aws.amazon.com/general/latest/gr/aws_tagging.html) as an essential part of managing components. These arbitrary key-value pairs can be utilized for billing, ownership, automation, [access control](https://docs.aws.amazon.com/IAM/latest/UserGuide/access_tags.html), and many other use cases. Given that these tags are an important aspect of successfully managing an AWS environment, the Terraform AWS Provider implements additional functionality beyond the typical one-to-one resource lifecycle management for easier and more customized implementations. --> Not all AWS resources support tagging, which can differ across AWS services and even across resources within the same service. Browse the individual Terraform AWS Provider resource documentation pages for the `tags` argument, to see which support resource tagging. If the AWS API implements tagging support for a resource and it is missing from the Terraform AWS Provider resource, a [feature request](https://github.com/terraform-providers/terraform-provider-aws/issues/new?labels=enhancement&template=Feature_Request.md) can be submitted. +-> Not all AWS resources support tagging, which can differ across AWS services and even across resources within the same service. Browse the individual Terraform AWS Provider resource documentation pages for the `tags` argument, to see which support resource tagging. If the AWS API implements tagging support for a resource and it is missing from the Terraform AWS Provider resource, a [feature request](https://github.com/hashicorp/terraform-provider-aws/issues/new?labels=enhancement&template=Feature_Request.md) can be submitted. @@ -142,7 +142,7 @@ Certain Terraform AWS Provider services support a special resource for managing ~> **NOTE:** This is an advanced use case and can cause conflicting management issues when improperly implemented. These individual tag resources should not be combined with the Terraform resource for managing the parent resource. For example, using `aws_vpc` and `aws_ec2_tag` to manage tags of the same VPC will cause a perpetual difference where the `aws_vpc` resource will try to remove the tag being added by the `aws_ec2_tag` resource. --> Not all services supported by the Terraform AWS Provider implement these resources. Browse the Terraform AWS Provider resource documentation pages for a resource with a type ending in `_tag`. If there is a use case where this type of resource is missing, a [feature request](https://github.com/terraform-providers/terraform-provider-aws/issues/new?labels=enhancement&template=Feature_Request.md) can be submitted. +-> Not all services supported by the Terraform AWS Provider implement these resources. Browse the Terraform AWS Provider resource documentation pages for a resource with a type ending in `_tag`. If there is a use case where this type of resource is missing, a [feature request](https://github.com/hashicorp/terraform-provider-aws/issues/new?labels=enhancement&template=Feature_Request.md) can be submitted. ```hcl # Terraform 0.12 and later syntax diff --git a/website/docs/guides/version-2-upgrade.html.md b/website/docs/guides/version-2-upgrade.html.md index 86fa8957b03..a90c5ae0a3c 100644 --- a/website/docs/guides/version-2-upgrade.html.md +++ b/website/docs/guides/version-2-upgrade.html.md @@ -10,7 +10,7 @@ description: |- Version 2.0.0 of the AWS provider for Terraform is a major release and includes some changes that you will need to consider when upgrading. This guide is intended to help with that process and focuses only on changes from version 1.60.0 to version 2.0.0. -Most of the changes outlined in this guide have been previously marked as deprecated in the Terraform plan/apply output throughout previous provider releases. These changes, such as deprecation notices, can always be found in the [Terraform AWS Provider CHANGELOG](https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md). +Most of the changes outlined in this guide have been previously marked as deprecated in the Terraform plan/apply output throughout previous provider releases. These changes, such as deprecation notices, can always be found in the [Terraform AWS Provider CHANGELOG](https://github.com/hashicorp/terraform-provider-aws/blob/master/CHANGELOG.md). Upgrade topics: @@ -125,7 +125,7 @@ Switch your Terraform configuration to the `name` argument instead. ### Data Source Removal and Migrating to aws_kms_secrets Data Source -The implementation of the `aws_kms_secret` data source, prior to Terraform AWS provider version 2.0.0, used dynamic attribute behavior which is not supported with Terraform 0.12 and beyond (full details available in [this GitHub issue](https://github.com/terraform-providers/terraform-provider-aws/issues/5144)). +The implementation of the `aws_kms_secret` data source, prior to Terraform AWS provider version 2.0.0, used dynamic attribute behavior which is not supported with Terraform 0.12 and beyond (full details available in [this GitHub issue](https://github.com/hashicorp/terraform-provider-aws/issues/5144)). Terraform configuration migration steps: diff --git a/website/docs/guides/version-3-upgrade.html.md b/website/docs/guides/version-3-upgrade.html.md index 86387ddcae3..a889be66ad0 100644 --- a/website/docs/guides/version-3-upgrade.html.md +++ b/website/docs/guides/version-3-upgrade.html.md @@ -10,7 +10,7 @@ description: |- Version 3.0.0 of the AWS provider for Terraform is a major release and includes some changes that you will need to consider when upgrading. This guide is intended to help with that process and focuses only on changes from version 2.X to version 3.0.0. See the [Version 2 Upgrade Guide](/docs/providers/aws/guides/version-2-upgrade.html) for information about upgrading from 1.X to version 2.0.0. -Most of the changes outlined in this guide have been previously marked as deprecated in the Terraform plan/apply output throughout previous provider releases. These changes, such as deprecation notices, can always be found in the [Terraform AWS Provider CHANGELOG](https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md). +Most of the changes outlined in this guide have been previously marked as deprecated in the Terraform plan/apply output throughout previous provider releases. These changes, such as deprecation notices, can always be found in the [Terraform AWS Provider CHANGELOG](https://github.com/hashicorp/terraform-provider-aws/blob/master/CHANGELOG.md). ~> **NOTE:** Version 3.0.0 and later of the AWS Provider can only be automatically installed on Terraform 0.12 and later. diff --git a/website/docs/r/dx_gateway_association.html.markdown b/website/docs/r/dx_gateway_association.html.markdown index 4a323e57706..e2cf50fa28a 100644 --- a/website/docs/r/dx_gateway_association.html.markdown +++ b/website/docs/r/dx_gateway_association.html.markdown @@ -87,7 +87,7 @@ resource "aws_dx_gateway_association" "example" { } ``` -A full example of how to create a VPN Gateway in one AWS account, create a Direct Connect Gateway in a second AWS account, and associate the VPN Gateway with the Direct Connect Gateway via the `aws_dx_gateway_association_proposal` and `aws_dx_gateway_association` resources can be found in [the `./examples/dx-gateway-cross-account-vgw-association` directory within the Github Repository](https://github.com/terraform-providers/terraform-provider-aws/tree/master/examples/dx-gateway-cross-account-vgw-association). +A full example of how to create a VPN Gateway in one AWS account, create a Direct Connect Gateway in a second AWS account, and associate the VPN Gateway with the Direct Connect Gateway via the `aws_dx_gateway_association_proposal` and `aws_dx_gateway_association` resources can be found in [the `./examples/dx-gateway-cross-account-vgw-association` directory within the Github Repository](https://github.com/hashicorp/terraform-provider-aws/tree/master/examples/dx-gateway-cross-account-vgw-association). ## Argument Reference diff --git a/website/docs/r/dx_gateway_association_proposal.html.markdown b/website/docs/r/dx_gateway_association_proposal.html.markdown index 9ca61eb174d..4fae6c595fa 100644 --- a/website/docs/r/dx_gateway_association_proposal.html.markdown +++ b/website/docs/r/dx_gateway_association_proposal.html.markdown @@ -20,7 +20,7 @@ resource "aws_dx_gateway_association_proposal" "example" { } ``` -A full example of how to create a VPN Gateway in one AWS account, create a Direct Connect Gateway in a second AWS account, and associate the VPN Gateway with the Direct Connect Gateway via the `aws_dx_gateway_association_proposal` and `aws_dx_gateway_association` resources can be found in [the `./examples/dx-gateway-cross-account-vgw-association` directory within the Github Repository](https://github.com/terraform-providers/terraform-provider-aws/tree/master/examples/dx-gateway-cross-account-vgw-association). +A full example of how to create a VPN Gateway in one AWS account, create a Direct Connect Gateway in a second AWS account, and associate the VPN Gateway with the Direct Connect Gateway via the `aws_dx_gateway_association_proposal` and `aws_dx_gateway_association` resources can be found in [the `./examples/dx-gateway-cross-account-vgw-association` directory within the Github Repository](https://github.com/hashicorp/terraform-provider-aws/tree/master/examples/dx-gateway-cross-account-vgw-association). ## Argument Reference diff --git a/website/docs/r/ec2_transit_gateway_peering_attachment.html.markdown b/website/docs/r/ec2_transit_gateway_peering_attachment.html.markdown index dbb0a36ce91..acac16792fb 100644 --- a/website/docs/r/ec2_transit_gateway_peering_attachment.html.markdown +++ b/website/docs/r/ec2_transit_gateway_peering_attachment.html.markdown @@ -56,7 +56,7 @@ resource "aws_ec2_transit_gateway_peering_attachment" "example" { } ``` -A full example of how to create a Transit Gateway in one AWS account, share it with a second AWS account, and attach a to a Transit Gateway in the second account via the `aws_ec2_transit_gateway_peering_attachment` resource can be found in [the `./examples/transit-gateway-cross-account-peering-attachment` directory within the Github Repository](https://github.com/terraform-providers/terraform-provider-aws/tree/master/examples/transit-gateway-cross-account-peering-attachment). +A full example of how to create a Transit Gateway in one AWS account, share it with a second AWS account, and attach a to a Transit Gateway in the second account via the `aws_ec2_transit_gateway_peering_attachment` resource can be found in [the `./examples/transit-gateway-cross-account-peering-attachment` directory within the Github Repository](https://github.com/hashicorp/terraform-provider-aws/tree/master/examples/transit-gateway-cross-account-peering-attachment). ## Argument Reference diff --git a/website/docs/r/ec2_transit_gateway_peering_attachment_accepter.markdown b/website/docs/r/ec2_transit_gateway_peering_attachment_accepter.markdown index 95086a4e828..971c88616ba 100644 --- a/website/docs/r/ec2_transit_gateway_peering_attachment_accepter.markdown +++ b/website/docs/r/ec2_transit_gateway_peering_attachment_accepter.markdown @@ -22,7 +22,7 @@ resource "aws_ec2_transit_gateway_peering_attachment_accepter" "example" { } ``` -A full example of how to create a Transit Gateway in one AWS account, share it with a second AWS account, and attach a to a Transit Gateway in the second account via the `aws_ec2_transit_gateway_peering_attachment` resource can be found in [the `./examples/transit-gateway-cross-account-peering-attachment` directory within the Github Repository](https://github.com/terraform-providers/terraform-provider-aws/tree/master/examples/transit-gateway-cross-account-peering-attachment). +A full example of how to create a Transit Gateway in one AWS account, share it with a second AWS account, and attach a to a Transit Gateway in the second account via the `aws_ec2_transit_gateway_peering_attachment` resource can be found in [the `./examples/transit-gateway-cross-account-peering-attachment` directory within the Github Repository](https://github.com/hashicorp/terraform-provider-aws/tree/master/examples/transit-gateway-cross-account-peering-attachment). ## Argument Reference diff --git a/website/docs/r/ec2_transit_gateway_vpc_attachment.html.markdown b/website/docs/r/ec2_transit_gateway_vpc_attachment.html.markdown index f24cc001e53..4b0cc05f9bc 100644 --- a/website/docs/r/ec2_transit_gateway_vpc_attachment.html.markdown +++ b/website/docs/r/ec2_transit_gateway_vpc_attachment.html.markdown @@ -20,7 +20,7 @@ resource "aws_ec2_transit_gateway_vpc_attachment" "example" { } ``` -A full example of how to create a Transit Gateway in one AWS account, share it with a second AWS account, and attach a VPC in the second account to the Transit Gateway via the `aws_ec2_transit_gateway_vpc_attachment` and `aws_ec2_transit_gateway_vpc_attachment_accepter` resources can be found in [the `./examples/transit-gateway-cross-account-vpc-attachment` directory within the Github Repository](https://github.com/terraform-providers/terraform-provider-aws/tree/master/examples/transit-gateway-cross-account-vpc-attachment). +A full example of how to create a Transit Gateway in one AWS account, share it with a second AWS account, and attach a VPC in the second account to the Transit Gateway via the `aws_ec2_transit_gateway_vpc_attachment` and `aws_ec2_transit_gateway_vpc_attachment_accepter` resources can be found in [the `./examples/transit-gateway-cross-account-vpc-attachment` directory within the Github Repository](https://github.com/hashicorp/terraform-provider-aws/tree/master/examples/transit-gateway-cross-account-vpc-attachment). ## Argument Reference diff --git a/website/docs/r/ec2_transit_gateway_vpc_attachment_accepter.html.markdown b/website/docs/r/ec2_transit_gateway_vpc_attachment_accepter.html.markdown index 2123b68cc34..74470bd519a 100644 --- a/website/docs/r/ec2_transit_gateway_vpc_attachment_accepter.html.markdown +++ b/website/docs/r/ec2_transit_gateway_vpc_attachment_accepter.html.markdown @@ -28,7 +28,7 @@ resource "aws_ec2_transit_gateway_vpc_attachment_accepter" "example" { } ``` -A full example of how to how to create a Transit Gateway in one AWS account, share it with a second AWS account, and attach a VPC in the second account to the Transit Gateway via the `aws_ec2_transit_gateway_vpc_attachment` and `aws_ec2_transit_gateway_vpc_attachment_accepter` resources can be found in [the `./examples/transit-gateway-cross-account-vpc-attachment` directory within the Github Repository](https://github.com/terraform-providers/terraform-provider-aws/tree/master/examples/transit-gateway-cross-account-vpc-attachment). +A full example of how to how to create a Transit Gateway in one AWS account, share it with a second AWS account, and attach a VPC in the second account to the Transit Gateway via the `aws_ec2_transit_gateway_vpc_attachment` and `aws_ec2_transit_gateway_vpc_attachment_accepter` resources can be found in [the `./examples/transit-gateway-cross-account-vpc-attachment` directory within the Github Repository](https://github.com/hashicorp/terraform-provider-aws/tree/master/examples/transit-gateway-cross-account-vpc-attachment). ## Argument Reference diff --git a/website/docs/r/lambda_function.html.markdown b/website/docs/r/lambda_function.html.markdown index 8aca6deffd7..18869187a2e 100644 --- a/website/docs/r/lambda_function.html.markdown +++ b/website/docs/r/lambda_function.html.markdown @@ -14,7 +14,7 @@ For information about Lambda and how to use it, see [What is AWS Lambda?][1] For a detailed example of setting up Lambda and API Gateway, see [Serverless Applications with AWS Lambda and API Gateway.][11] -~> **NOTE:** Due to [AWS Lambda improved VPC networking changes that began deploying in September 2019](https://aws.amazon.com/blogs/compute/announcing-improved-vpc-networking-for-aws-lambda-functions/), EC2 subnets and security groups associated with Lambda Functions can take up to 45 minutes to successfully delete. Terraform AWS Provider version 2.31.0 and later automatically handles this increased timeout, however prior versions require setting the customizable deletion timeouts of those Terraform resources to 45 minutes (`delete = "45m"`). AWS and HashiCorp are working together to reduce the amount of time required for resource deletion and updates can be tracked in this [GitHub issue](https://github.com/terraform-providers/terraform-provider-aws/issues/10329). +~> **NOTE:** Due to [AWS Lambda improved VPC networking changes that began deploying in September 2019](https://aws.amazon.com/blogs/compute/announcing-improved-vpc-networking-for-aws-lambda-functions/), EC2 subnets and security groups associated with Lambda Functions can take up to 45 minutes to successfully delete. Terraform AWS Provider version 2.31.0 and later automatically handles this increased timeout, however prior versions require setting the customizable deletion timeouts of those Terraform resources to 45 minutes (`delete = "45m"`). AWS and HashiCorp are working together to reduce the amount of time required for resource deletion and updates can be tracked in this [GitHub issue](https://github.com/hashicorp/terraform-provider-aws/issues/10329). ## Example Usage diff --git a/website/docs/r/security_group.html.markdown b/website/docs/r/security_group.html.markdown index 23f7046062b..584297739a7 100644 --- a/website/docs/r/security_group.html.markdown +++ b/website/docs/r/security_group.html.markdown @@ -19,7 +19,7 @@ a conflict of rule settings and will overwrite rules. ~> **NOTE:** Referencing Security Groups across VPC peering has certain restrictions. More information is available in the [VPC Peering User Guide](https://docs.aws.amazon.com/vpc/latest/peering/vpc-peering-security-groups.html). -~> **NOTE:** Due to [AWS Lambda improved VPC networking changes that began deploying in September 2019](https://aws.amazon.com/blogs/compute/announcing-improved-vpc-networking-for-aws-lambda-functions/), security groups associated with Lambda Functions can take up to 45 minutes to successfully delete. Terraform AWS Provider version 2.31.0 and later automatically handles this increased timeout, however prior versions require setting the [customizable deletion timeout](#timeouts) to 45 minutes (`delete = "45m"`). AWS and HashiCorp are working together to reduce the amount of time required for resource deletion and updates can be tracked in this [GitHub issue](https://github.com/terraform-providers/terraform-provider-aws/issues/10329). +~> **NOTE:** Due to [AWS Lambda improved VPC networking changes that began deploying in September 2019](https://aws.amazon.com/blogs/compute/announcing-improved-vpc-networking-for-aws-lambda-functions/), security groups associated with Lambda Functions can take up to 45 minutes to successfully delete. Terraform AWS Provider version 2.31.0 and later automatically handles this increased timeout, however prior versions require setting the [customizable deletion timeout](#timeouts) to 45 minutes (`delete = "45m"`). AWS and HashiCorp are working together to reduce the amount of time required for resource deletion and updates can be tracked in this [GitHub issue](https://github.com/hashicorp/terraform-provider-aws/issues/10329). ## Example Usage diff --git a/website/docs/r/subnet.html.markdown b/website/docs/r/subnet.html.markdown index e7f6410581c..90f55a30606 100644 --- a/website/docs/r/subnet.html.markdown +++ b/website/docs/r/subnet.html.markdown @@ -10,7 +10,7 @@ description: |- Provides an VPC subnet resource. -~> **NOTE:** Due to [AWS Lambda improved VPC networking changes that began deploying in September 2019](https://aws.amazon.com/blogs/compute/announcing-improved-vpc-networking-for-aws-lambda-functions/), subnets associated with Lambda Functions can take up to 45 minutes to successfully delete. Terraform AWS Provider version 2.31.0 and later automatically handles this increased timeout, however prior versions require setting the [customizable deletion timeout](#timeouts) to 45 minutes (`delete = "45m"`). AWS and HashiCorp are working together to reduce the amount of time required for resource deletion and updates can be tracked in this [GitHub issue](https://github.com/terraform-providers/terraform-provider-aws/issues/10329). +~> **NOTE:** Due to [AWS Lambda improved VPC networking changes that began deploying in September 2019](https://aws.amazon.com/blogs/compute/announcing-improved-vpc-networking-for-aws-lambda-functions/), subnets associated with Lambda Functions can take up to 45 minutes to successfully delete. Terraform AWS Provider version 2.31.0 and later automatically handles this increased timeout, however prior versions require setting the [customizable deletion timeout](#timeouts) to 45 minutes (`delete = "45m"`). AWS and HashiCorp are working together to reduce the amount of time required for resource deletion and updates can be tracked in this [GitHub issue](https://github.com/hashicorp/terraform-provider-aws/issues/10329). ## Example Usage From fcf6e23e445260ccd1ed52b4c556c706acc7b1d3 Mon Sep 17 00:00:00 2001 From: Simon Davis Date: Thu, 29 Oct 2020 08:49:54 -0700 Subject: [PATCH 5/7] remove slack notifier behavior --- .hashibot.hcl | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.hashibot.hcl b/.hashibot.hcl index 7ef40f0621c..06e9bd4ce80 100644 --- a/.hashibot.hcl +++ b/.hashibot.hcl @@ -1506,12 +1506,6 @@ behavior "regexp_issue_labeler" "panic_label" { labels = ["crash", "bug"] } -behavior "regexp_issue_notifier" "panic_notify" { - regexp = "panic:" - slack_channel = env.COMMITTERS_SLACK_CHANNEL - message = "Panic report! https://github.com/${var.repository}/issues/${var.issue_number} has a panic in it." -} - behavior "remove_labels_on_reply" "remove_stale" { labels = ["waiting-response", "stale"] only_non_maintainers = true From 5169a19d59d52251557f1b60c09fca539866cd1a Mon Sep 17 00:00:00 2001 From: Simon Davis Date: Fri, 30 Oct 2020 09:20:25 -0700 Subject: [PATCH 6/7] code review suggestions --- .github/CODEOWNERS | 54 +++++++++---------- .hashibot.hcl | 7 --- .../v2/helper/schema/resource.go | 2 +- 3 files changed, 28 insertions(+), 35 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index a38ee507194..1aa33f206ff 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,42 +1,42 @@ # Default owner for all pull requests -* @hashicorp/aws-provider +* @hashicorp/terraform-aws # Service specific owners -/aws/*apigatewayv2* @ewbankkit @hashicorp/aws-provider -/website/**/apigatewayv2* @ewbankkit @hashicorp/aws-provider +/aws/*apigatewayv2* @ewbankkit @hashicorp/terraform-aws +/website/**/apigatewayv2* @ewbankkit @hashicorp/terraform-aws -/aws/*appmesh* @ewbankkit @hashicorp/aws-provider -/website/**/appmesh* @ewbankkit @hashicorp/aws-provider +/aws/*appmesh* @ewbankkit @hashicorp/terraform-aws +/website/**/appmesh* @ewbankkit @hashicorp/terraform-aws -/aws/*backup* @ewbankkit @hashicorp/aws-provider -/website/**/backup* @ewbankkit @hashicorp/aws-provider +/aws/*backup* @ewbankkit @hashicorp/terraform-aws +/website/**/backup* @ewbankkit @hashicorp/terraform-aws -/aws/*_aws_codeartifact_*.go @DrFaust92 @hashicorp/aws-provider -/website/**/codeartifact* @DrFaust92 @hashicorp/aws-provider +/aws/*_aws_codeartifact_*.go @DrFaust92 @hashicorp/terraform-aws +/website/**/codeartifact* @DrFaust92 @hashicorp/terraform-aws -/aws/*_aws_fsx_*.go @DrFaust92 @hashicorp/aws-provider -/website/**/fsx* @DrFaust92 @hashicorp/aws-provider +/aws/*_aws_fsx_*.go @DrFaust92 @hashicorp/terraform-aws +/website/**/fsx* @DrFaust92 @hashicorp/terraform-aws -/aws/*globalaccelerator* @ewbankkit @hashicorp/aws-provider -/website/**/globalaccelerator* @ewbankkit @hashicorp/aws-provider +/aws/*globalaccelerator* @ewbankkit @hashicorp/terraform-aws +/website/**/globalaccelerator* @ewbankkit @hashicorp/terraform-aws -/aws/*_aws_glue_*.go @DrFaust92 @hashicorp/aws-provider -/website/**/glue* @DrFaust92 @hashicorp/aws-provider +/aws/*_aws_glue_*.go @DrFaust92 @hashicorp/terraform-aws +/website/**/glue* @DrFaust92 @hashicorp/terraform-aws -/aws/*kinesis_analytics* @ewbankkit @hashicorp/aws-provider -/website/**/kinesis_analytics* @ewbankkit @hashicorp/aws-provider +/aws/*kinesis_analytics* @ewbankkit @hashicorp/terraform-aws +/website/**/kinesis_analytics* @ewbankkit @hashicorp/terraform-aws -/aws/*kinesisanalyticsv2* @ewbankkit @hashicorp/aws-provider -/website/**/kinesisanalyticsv2* @ewbankkit @hashicorp/aws-provider +/aws/*kinesisanalyticsv2* @ewbankkit @hashicorp/terraform-aws +/website/**/kinesisanalyticsv2* @ewbankkit @hashicorp/terraform-aws -/aws/*route53_resolver* @ewbankkit @hashicorp/aws-provider -/website/**/route53_resolver* @ewbankkit @hashicorp/aws-provider +/aws/*route53_resolver* @ewbankkit @hashicorp/terraform-aws +/website/**/route53_resolver* @ewbankkit @hashicorp/terraform-aws -/aws/*_aws_storagegateway_*.go @DrFaust92 @hashicorp/aws-provider -/website/**/storagegateway* @DrFaust92 @hashicorp/aws-provider +/aws/*_aws_storagegateway_*.go @DrFaust92 @hashicorp/terraform-aws +/website/**/storagegateway* @DrFaust92 @hashicorp/terraform-aws -/aws/*_aws_sagemaker_*.go @DrFaust92 @hashicorp/aws-provider -/website/**/sagemaker* @DrFaust92 @hashicorp/aws-provider +/aws/*_aws_sagemaker_*.go @DrFaust92 @hashicorp/terraform-aws +/website/**/sagemaker* @DrFaust92 @hashicorp/terraform-aws -/aws/*_aws_workspaces_*.go @Tensho @hashicorp/aws-provider -/website/**/workspaces* @Tensho @hashicorp/aws-provider +/aws/*_aws_workspaces_*.go @Tensho @hashicorp/terraform-aws +/website/**/workspaces* @Tensho @hashicorp/terraform-aws diff --git a/.hashibot.hcl b/.hashibot.hcl index 06e9bd4ce80..3f8e055264f 100644 --- a/.hashibot.hcl +++ b/.hashibot.hcl @@ -1540,10 +1540,3 @@ behavior "pull_request_size_labeler" "size" { } } } - -behavior "pull_request_path_labeler" "cross_provider_labels" { - label_map = { - "documentation" = ["website/**/*"] - "dependencies" = ["vendor/**/*"] - } -} \ No newline at end of file diff --git a/awsproviderlint/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go b/awsproviderlint/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go index e6adf25cd80..f295cab7eef 100644 --- a/awsproviderlint/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go +++ b/awsproviderlint/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go @@ -719,7 +719,7 @@ func isReservedDataSourceFieldName(name string) bool { func isReservedResourceFieldName(name string, s *Schema) bool { // Allow phasing out "id" - // See https://github.com/hashicorp/terraform-provider-aws/pull/1626#issuecomment-328881415 + // See https://github.com/terraform-providers/terraform-provider-aws/pull/1626#issuecomment-328881415 if name == "id" && s.Deprecated != "" { return false } From 7779cffe3ab4ec463d355d4c005daaab0758b36f Mon Sep 17 00:00:00 2001 From: Simon Davis Date: Sun, 1 Nov 2020 16:21:26 -0800 Subject: [PATCH 7/7] fix last weeks url ref additions --- CHANGELOG.md | 146 +++++++++--------- ROADMAP.md | 62 ++++---- aws/resource_aws_s3control_bucket_test.go | 2 +- ...urce_aws_sagemaker_code_repository_test.go | 16 +- ...ce_aws_sagemaker_notebook_instance_test.go | 14 +- docs/roadmaps/2020_August_to_October.md | 28 ++-- .../r/sagemaker_code_repository.htm.markdown | 4 +- .../sagemaker_notebook_instance.html.markdown | 2 +- 8 files changed, 137 insertions(+), 137 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6dc986ddab7..4104150566d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ FEATURES -* **New Data Source:** `aws_sagemaker_prebuilt_ecr_image` ([#15924](https://github.com/terraform-providers/terraform-provider-aws/pull/15924)) +* **New Data Source:** `aws_sagemaker_prebuilt_ecr_image` ([#15924](https://github.com/hashicorp/terraform-provider-aws/pull/15924)) ENHANCEMENTS @@ -12,87 +12,87 @@ ENHANCEMENTS NOTES -* data-source/aws_autoscaling_groups: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_caller_identity: The `id` attribute has changed to the ID of the AWS Account. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ebs_snapshot_ids: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ebs_volumes: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ec2_coip_pools: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ec2_instance_type_offerings: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ec2_local_gateway_route_tables: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ec2_local_gateway_virtual_interface_groups: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ec2_local_gateways: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ec2_spot_price: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_efs_access_points: The `id` attribute has changed to the EFS File System identifier. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_glue_script: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_inspector_rules_packages: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_instances: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_kms_ciphertext: The `id` attribute has changed to the KMS Key. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_kms_secrets: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15725](https://github.com/terraform-providers/terraform-provider-aws/issues/15725)) -* data-source/aws_network_acls: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_network_interfaces: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_organizations_organizational_units: The `id` attribute has changed to the parent identifier. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_outposts_outposts: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_outposts_sites: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_route_tables: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_route53_resolver_rules: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_s3_bucket_objects: The `id` attribute has changed to the name of the S3 Bucket. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_security_groups: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_vpc_peering_connections: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_vpcs: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) +* data-source/aws_autoscaling_groups: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_caller_identity: The `id` attribute has changed to the ID of the AWS Account. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ebs_snapshot_ids: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ebs_volumes: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ec2_coip_pools: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ec2_instance_type_offerings: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ec2_local_gateway_route_tables: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ec2_local_gateway_virtual_interface_groups: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ec2_local_gateways: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ec2_spot_price: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_efs_access_points: The `id` attribute has changed to the EFS File System identifier. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_glue_script: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_inspector_rules_packages: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_instances: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_kms_ciphertext: The `id` attribute has changed to the KMS Key. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_kms_secrets: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15725](https://github.com/hashicorp/terraform-provider-aws/issues/15725)) +* data-source/aws_network_acls: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_network_interfaces: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_organizations_organizational_units: The `id` attribute has changed to the parent identifier. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_outposts_outposts: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_outposts_sites: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_route_tables: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_route53_resolver_rules: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_s3_bucket_objects: The `id` attribute has changed to the name of the S3 Bucket. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_security_groups: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_vpc_peering_connections: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_vpcs: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference. ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) FEATURES -* **New Resource:** `aws_glue_resource_policy` ([#10361](https://github.com/terraform-providers/terraform-provider-aws/issues/10361)) -* **New Resource:** `aws_s3control_bucket` ([#15510](https://github.com/terraform-providers/terraform-provider-aws/issues/15510)) -* **New Resource:** `aws_s3control_bucket_lifecycle_configuration` ([#15604](https://github.com/terraform-providers/terraform-provider-aws/issues/15604)) -* **New Resource:** `aws_s3control_bucket_policy` ([#15575](https://github.com/terraform-providers/terraform-provider-aws/issues/15575)) -* **New Resource:** `aws_s3outposts_endpoint` ([#15585](https://github.com/terraform-providers/terraform-provider-aws/issues/15585)) -* **New Resource:** `aws_sagemaker_code_repository` ([#15809](https://github.com/terraform-providers/terraform-provider-aws/issues/15809)) -* **New Resource:** `aws_storagegateway_tape_pool` ([#15370](https://github.com/terraform-providers/terraform-provider-aws/issues/15370)) +* **New Resource:** `aws_glue_resource_policy` ([#10361](https://github.com/hashicorp/terraform-provider-aws/issues/10361)) +* **New Resource:** `aws_s3control_bucket` ([#15510](https://github.com/hashicorp/terraform-provider-aws/issues/15510)) +* **New Resource:** `aws_s3control_bucket_lifecycle_configuration` ([#15604](https://github.com/hashicorp/terraform-provider-aws/issues/15604)) +* **New Resource:** `aws_s3control_bucket_policy` ([#15575](https://github.com/hashicorp/terraform-provider-aws/issues/15575)) +* **New Resource:** `aws_s3outposts_endpoint` ([#15585](https://github.com/hashicorp/terraform-provider-aws/issues/15585)) +* **New Resource:** `aws_sagemaker_code_repository` ([#15809](https://github.com/hashicorp/terraform-provider-aws/issues/15809)) +* **New Resource:** `aws_storagegateway_tape_pool` ([#15370](https://github.com/hashicorp/terraform-provider-aws/issues/15370)) ENHANCEMENTS -* resource/aws_cloudwatch_event_rule: Add `event_bus_name` ([#15727](https://github.com/terraform-providers/terraform-provider-aws/issues/15727)) -* resource/aws_ecs_service: Add `wait_for_steady_state` argument ([#3485](https://github.com/terraform-providers/terraform-provider-aws/issues/3485)) -* resource/aws_s3_access_point: Support S3 on Outposts ([#15621](https://github.com/terraform-providers/terraform-provider-aws/issues/15621)) -* resource/aws_sagemaker_model: Add `container` configuration block `mode` argument ([#15371](https://github.com/terraform-providers/terraform-provider-aws/issues/15371)) -* resource/aws_sagemaker_notebook_instance: Add support for `additional_code_repositories` ([#15830](https://github.com/terraform-providers/terraform-provider-aws/issues/15830)) -* resource/aws_sagemaker_notebook_instance: Add `url` and `network_interface_id` attributes ([#15802](https://github.com/terraform-providers/terraform-provider-aws/issues/15802)) +* resource/aws_cloudwatch_event_rule: Add `event_bus_name` ([#15727](https://github.com/hashicorp/terraform-provider-aws/issues/15727)) +* resource/aws_ecs_service: Add `wait_for_steady_state` argument ([#3485](https://github.com/hashicorp/terraform-provider-aws/issues/3485)) +* resource/aws_s3_access_point: Support S3 on Outposts ([#15621](https://github.com/hashicorp/terraform-provider-aws/issues/15621)) +* resource/aws_sagemaker_model: Add `container` configuration block `mode` argument ([#15371](https://github.com/hashicorp/terraform-provider-aws/issues/15371)) +* resource/aws_sagemaker_notebook_instance: Add support for `additional_code_repositories` ([#15830](https://github.com/hashicorp/terraform-provider-aws/issues/15830)) +* resource/aws_sagemaker_notebook_instance: Add `url` and `network_interface_id` attributes ([#15802](https://github.com/hashicorp/terraform-provider-aws/issues/15802)) BUG FIXES -* data-source/aws_autoscaling_groups: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_caller_identity: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ebs_snapshot_ids: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ebs_volumes: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ec2_coip_pools: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ec2_instance_type_offerings: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ec2_local_gateway_route_tables: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ec2_local_gateway_virtual_interface_groups: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ec2_local_gateways: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_ec2_spot_price: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_efs_access_points: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_glue_script: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_inspector_rules_packages: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_instances: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_kms_ciphertext: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_kms_secrets: Prevent plan differences with the `id` attribute ([#15725](https://github.com/terraform-providers/terraform-provider-aws/issues/15725)) -* data-source/aws_network_acls: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_network_interfaces: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_organizations_organizational_units: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_outposts_outposts: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_outposts_sites: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_route_tables: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_route53_resolver_rules: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_s3_bucket_objects: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_security_groups: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_vpc_peering_connections: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* data-source/aws_vpcs: Prevent plan differences with the `id` attribute ([#15896](https://github.com/terraform-providers/terraform-provider-aws/issues/15896)) -* resource/aws_apigatewayv2_integration: Correctly handle update of AWS service integrations ([#15894](https://github.com/terraform-providers/terraform-provider-aws/issues/15894)) -* resource/aws_api_gateway_usage_plan: Change `api_stages` to from List to Set ([#14345](https://github.com/terraform-providers/terraform-provider-aws/issues/14345)) -* resource/aws_lambda_function: Update published `version` and `qualified_arn` on config changes ([#15121](https://github.com/terraform-providers/terraform-provider-aws/issues/15121)) -* resource/aws_rds_global_cluster: Prevent recreation when using encrypted `source_db_cluster_identifier` without `storage_encrypted` ([#15916](https://github.com/terraform-providers/terraform-provider-aws/issues/15916)) -* resource/aws_vpc_peering_connection_options: Only modify options that have changed ([#12126](https://github.com/terraform-providers/terraform-provider-aws/issues/12126)) +* data-source/aws_autoscaling_groups: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_caller_identity: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ebs_snapshot_ids: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ebs_volumes: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ec2_coip_pools: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ec2_instance_type_offerings: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ec2_local_gateway_route_tables: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ec2_local_gateway_virtual_interface_groups: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ec2_local_gateways: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_ec2_spot_price: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_efs_access_points: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_glue_script: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_inspector_rules_packages: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_instances: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_kms_ciphertext: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_kms_secrets: Prevent plan differences with the `id` attribute ([#15725](https://github.com/hashicorp/terraform-provider-aws/issues/15725)) +* data-source/aws_network_acls: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_network_interfaces: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_organizations_organizational_units: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_outposts_outposts: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_outposts_sites: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_route_tables: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_route53_resolver_rules: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_s3_bucket_objects: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_security_groups: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_vpc_peering_connections: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* data-source/aws_vpcs: Prevent plan differences with the `id` attribute ([#15896](https://github.com/hashicorp/terraform-provider-aws/issues/15896)) +* resource/aws_apigatewayv2_integration: Correctly handle update of AWS service integrations ([#15894](https://github.com/hashicorp/terraform-provider-aws/issues/15894)) +* resource/aws_api_gateway_usage_plan: Change `api_stages` to from List to Set ([#14345](https://github.com/hashicorp/terraform-provider-aws/issues/14345)) +* resource/aws_lambda_function: Update published `version` and `qualified_arn` on config changes ([#15121](https://github.com/hashicorp/terraform-provider-aws/issues/15121)) +* resource/aws_rds_global_cluster: Prevent recreation when using encrypted `source_db_cluster_identifier` without `storage_encrypted` ([#15916](https://github.com/hashicorp/terraform-provider-aws/issues/15916)) +* resource/aws_vpc_peering_connection_options: Only modify options that have changed ([#12126](https://github.com/hashicorp/terraform-provider-aws/issues/12126)) ## 3.12.0 (October 22, 2020) diff --git a/ROADMAP.md b/ROADMAP.md index c6dba0ccd97..dfba7939bb4 100644 --- a/ROADMAP.md +++ b/ROADMAP.md @@ -15,7 +15,7 @@ From October-January ‘21, we will be prioritizing the following areas of work: ## New Services ### AWS SSO Permission Sets -Issue: [#15108](https://github.com/terraform-providers/terraform-provider-aws/issues/15108) +Issue: [#15108](https://github.com/hashicorp/terraform-provider-aws/issues/15108) _[AWS SSO](https://docs.aws.amazon.com/singlesignon/latest/APIReference/welcome.html) account assignment APIs enable you to build automation to create and update permissions that align with your company's common job functions. You can then assign the permissions to users and groups to entitle them for access in their required accounts. For example, you can give your developers broad control over resources in developer accounts, and limit that control to authorized operations personnel in production accounts. The new AWS CloudFormation support enables you to automate account assignments as you build new accounts. You can also use the APIs to decode user and group names from the unique identifiers that appear in AWS CloudTrail logs._ @@ -34,42 +34,42 @@ Core Services are areas of high usage or strategic importance for our users. We #### RDS -- [#15177](https://github.com/terraform-providers/terraform-provider-aws/issues/15177): Subsequent plan/apply forces global cluster recreation when source cluster's storage_encrypted=true -- [#15583](https://github.com/terraform-providers/terraform-provider-aws/issues/15583): aws db parameter group ... converts keys and values to lowercase and fails 'apply' due to aws_db_parameter_group changes -- [#1198](https://github.com/terraform-providers/terraform-provider-aws/issues/1198): Unable to ignore changes to RDS minor engine version -- [#9401](https://github.com/terraform-providers/terraform-provider-aws/issues/9401): Destroy/recreate DB instance on minor version update rather than updating -- [#2635](https://github.com/terraform-providers/terraform-provider-aws/issues/2635): RDS - storage_encrypted = true does not work -- [#467](https://github.com/terraform-providers/terraform-provider-aws/issues/467): With aws_db_instance when you remove the snapshot_identifier it wants to force a new resource -- [#10197](https://github.com/terraform-providers/terraform-provider-aws/issues/10197): AWS aurora unexpected state 'configuring-iam-database-auth' when modifying the `iam_database_authentication_enabled` flag -- [#13891](https://github.com/terraform-providers/terraform-provider-aws/issues/13891): RDS Cluster is not reattached to Global Cluster after failing deletion +- [#15177](https://github.com/hashicorp/terraform-provider-aws/issues/15177): Subsequent plan/apply forces global cluster recreation when source cluster's storage_encrypted=true +- [#15583](https://github.com/hashicorp/terraform-provider-aws/issues/15583): aws db parameter group ... converts keys and values to lowercase and fails 'apply' due to aws_db_parameter_group changes +- [#1198](https://github.com/hashicorp/terraform-provider-aws/issues/1198): Unable to ignore changes to RDS minor engine version +- [#9401](https://github.com/hashicorp/terraform-provider-aws/issues/9401): Destroy/recreate DB instance on minor version update rather than updating +- [#2635](https://github.com/hashicorp/terraform-provider-aws/issues/2635): RDS - storage_encrypted = true does not work +- [#467](https://github.com/hashicorp/terraform-provider-aws/issues/467): With aws_db_instance when you remove the snapshot_identifier it wants to force a new resource +- [#10197](https://github.com/hashicorp/terraform-provider-aws/issues/10197): AWS aurora unexpected state 'configuring-iam-database-auth' when modifying the `iam_database_authentication_enabled` flag +- [#13891](https://github.com/hashicorp/terraform-provider-aws/issues/13891): RDS Cluster is not reattached to Global Cluster after failing deletion #### Elasticache The Elasticache work will begin with a research spike to ensure that the we can solve the following issues without introducing breaking changes into the provider: -- [#14959](https://github.com/terraform-providers/terraform-provider-aws/issues/14959): Research Spike: Elasticache Service Fixes and Improvements -- [#12708](https://github.com/terraform-providers/terraform-provider-aws/issues/12708): resource/aws_elasticache_replication_group: Add MultiAZ support -- [#13517](https://github.com/terraform-providers/terraform-provider-aws/issues/13517): Feature Request: `aws_elasticache_cluster` allow auto-minor-version-upgrade to be set -- [#5118](https://github.com/terraform-providers/terraform-provider-aws/issues/5118): support setting primary/replica AZ attributes inside NodeGroupConfiguration for RedisClusterModelEnabled +- [#14959](https://github.com/hashicorp/terraform-provider-aws/issues/14959): Research Spike: Elasticache Service Fixes and Improvements +- [#12708](https://github.com/hashicorp/terraform-provider-aws/issues/12708): resource/aws_elasticache_replication_group: Add MultiAZ support +- [#13517](https://github.com/hashicorp/terraform-provider-aws/issues/13517): Feature Request: `aws_elasticache_cluster` allow auto-minor-version-upgrade to be set +- [#5118](https://github.com/hashicorp/terraform-provider-aws/issues/5118): support setting primary/replica AZ attributes inside NodeGroupConfiguration for RedisClusterModelEnabled ### Workflow Improvements We’ll also be tackling some of the top reported issues in the provider that are causing disruptions to high priority workflows: -- [#14373](https://github.com/terraform-providers/terraform-provider-aws/issues/14373): cloudfront: support for cache and origin request policies -- [#11584](https://github.com/terraform-providers/terraform-provider-aws/issues/11584): Add ability to manage VPN tunnel options -- [#13986](https://github.com/terraform-providers/terraform-provider-aws/issues/13986): Feature request: Managed prefix lists -- [#8009](https://github.com/terraform-providers/terraform-provider-aws/issues/8009): S3 settings on aws_dms_endpoint conflict with "extra_connection_attributes" -- [#11220](https://github.com/terraform-providers/terraform-provider-aws/issues/11220): Set account recovery preference -- [#12272](https://github.com/terraform-providers/terraform-provider-aws/issues/12272): CloudWatch composite alarms -- [#4058](https://github.com/terraform-providers/terraform-provider-aws/issues/4058): Support Firewall Manager Policies -- [#1093](https://github.com/terraform-providers/terraform-provider-aws/issues/1093): Resource aws_sns_topic_subscription, new argument redrive_policy -- [#11098](https://github.com/terraform-providers/terraform-provider-aws/issues/11098): Support for AWS Config Conformance Packs -- [#6674](https://github.com/terraform-providers/terraform-provider-aws/issues/6674): Feature Request: Security Hub -- [#3891](https://github.com/terraform-providers/terraform-provider-aws/issues/3891): Adding custom cognito user pool attribute forces new resource -- [#2245](https://github.com/terraform-providers/terraform-provider-aws/issues/2245): AWS security groups not being destroyed -- [#8114](https://github.com/terraform-providers/terraform-provider-aws/issues/8114): Cognito User Pool UI Customization -- [#11348](https://github.com/terraform-providers/terraform-provider-aws/issues/11348): Add Type to AWS SFN State Machine -- [#11586](https://github.com/terraform-providers/terraform-provider-aws/issues/11586): Faulty Read of Client VPN Network associations break state +- [#14373](https://github.com/hashicorp/terraform-provider-aws/issues/14373): cloudfront: support for cache and origin request policies +- [#11584](https://github.com/hashicorp/terraform-provider-aws/issues/11584): Add ability to manage VPN tunnel options +- [#13986](https://github.com/hashicorp/terraform-provider-aws/issues/13986): Feature request: Managed prefix lists +- [#8009](https://github.com/hashicorp/terraform-provider-aws/issues/8009): S3 settings on aws_dms_endpoint conflict with "extra_connection_attributes" +- [#11220](https://github.com/hashicorp/terraform-provider-aws/issues/11220): Set account recovery preference +- [#12272](https://github.com/hashicorp/terraform-provider-aws/issues/12272): CloudWatch composite alarms +- [#4058](https://github.com/hashicorp/terraform-provider-aws/issues/4058): Support Firewall Manager Policies +- [#1093](https://github.com/hashicorp/terraform-provider-aws/issues/1093): Resource aws_sns_topic_subscription, new argument redrive_policy +- [#11098](https://github.com/hashicorp/terraform-provider-aws/issues/11098): Support for AWS Config Conformance Packs +- [#6674](https://github.com/hashicorp/terraform-provider-aws/issues/6674): Feature Request: Security Hub +- [#3891](https://github.com/hashicorp/terraform-provider-aws/issues/3891): Adding custom cognito user pool attribute forces new resource +- [#2245](https://github.com/hashicorp/terraform-provider-aws/issues/2245): AWS security groups not being destroyed +- [#8114](https://github.com/hashicorp/terraform-provider-aws/issues/8114): Cognito User Pool UI Customization +- [#11348](https://github.com/hashicorp/terraform-provider-aws/issues/11348): Add Type to AWS SFN State Machine +- [#11586](https://github.com/hashicorp/terraform-provider-aws/issues/11586): Faulty Read of Client VPN Network associations break state ### Technical Debt Theme @@ -82,17 +82,17 @@ Research topics include features, architectural changes, and ideas that we are p We are interested in your thoughts and feedback about the proposals below and encourage you to comment on the linked issues or schedule time with @maryelizbeth via the link on her GitHub profile to discuss. #### Default Tags Implementation Design -Issue: [#7926](https://github.com/terraform-providers/terraform-provider-aws/issues/7926) +Issue: [#7926](https://github.com/hashicorp/terraform-provider-aws/issues/7926) After completing user research and an internal review of our research conclusions, we will begin conducting engineering research and publish an RFC to address the implementation of this feature. Once the RFC has been approved, we will update the community with our plans for Default Tags. #### API Calls/IAM Actions Per Terraform Resource (Minimum IAM) -Issue: [#9154](https://github.com/terraform-providers/terraform-provider-aws/issues/9154) +Issue: [#9154](https://github.com/hashicorp/terraform-provider-aws/issues/9154) To address security concerns and best practices we are considering how Terraform could surface minimally viable IAM policies for taking actions on resources or executing a TF plan. This is in the early stages of research and we are particularly interested in whether or not this would be useful and the resources or services areas for which it is most valuable. #### Lifecycle: Retain [Add 'retain' attribute to the Terraform lifecycle meta-parameter] -Issue: [#902](https://github.com/terraform-providers/terraform-provider-aws/issues/902) +Issue: [#902](https://github.com/hashicorp/terraform-provider-aws/issues/902) Some resources (e.g. log groups) are intended to be created but never destroyed. Terraform currently does not have a lifecycle attribute for retaining such resources. We are curious as to whether or not retaining resources is a workflow that meets the needs of our community and if so, how and where we might make use of that in the AWS Provider. diff --git a/aws/resource_aws_s3control_bucket_test.go b/aws/resource_aws_s3control_bucket_test.go index bf342a32ebd..f280150b2a8 100644 --- a/aws/resource_aws_s3control_bucket_test.go +++ b/aws/resource_aws_s3control_bucket_test.go @@ -66,7 +66,7 @@ func TestAccAWSS3ControlBucket_disappears(t *testing.T) { } func TestAccAWSS3ControlBucket_Tags(t *testing.T) { - TestAccSkip(t, "S3 Control Bucket resource tagging requires additional eventual consistency handling, see also: https://github.com/terraform-providers/terraform-provider-aws/issues/15572") + TestAccSkip(t, "S3 Control Bucket resource tagging requires additional eventual consistency handling, see also: https://github.com/hashicorp/terraform-provider-aws/issues/15572") rName := acctest.RandomWithPrefix("tf-acc-test") resourceName := "aws_s3control_bucket.test" diff --git a/aws/resource_aws_sagemaker_code_repository_test.go b/aws/resource_aws_sagemaker_code_repository_test.go index 4018a985c55..e7c6c105ff6 100644 --- a/aws/resource_aws_sagemaker_code_repository_test.go +++ b/aws/resource_aws_sagemaker_code_repository_test.go @@ -74,7 +74,7 @@ func TestAccAWSSagemakerCodeRepository_basic(t *testing.T) { resource.TestCheckResourceAttr(resourceName, "code_repository_name", rName), testAccCheckResourceAttrRegionalARN(resourceName, "arn", "sagemaker", fmt.Sprintf("code-repository/%s", rName)), resource.TestCheckResourceAttr(resourceName, "git_config.#", "1"), - resource.TestCheckResourceAttr(resourceName, "git_config.0.repository_url", "https://github.com/terraform-providers/terraform-provider-aws.git"), + resource.TestCheckResourceAttr(resourceName, "git_config.0.repository_url", "https://github.com/hashicorp/terraform-provider-aws.git"), ), }, { @@ -103,7 +103,7 @@ func TestAccAWSSagemakerCodeRepository_gitConfig_branch(t *testing.T) { resource.TestCheckResourceAttr(resourceName, "code_repository_name", rName), testAccCheckResourceAttrRegionalARN(resourceName, "arn", "sagemaker", fmt.Sprintf("code-repository/%s", rName)), resource.TestCheckResourceAttr(resourceName, "git_config.#", "1"), - resource.TestCheckResourceAttr(resourceName, "git_config.0.repository_url", "https://github.com/terraform-providers/terraform-provider-aws.git"), + resource.TestCheckResourceAttr(resourceName, "git_config.0.repository_url", "https://github.com/hashicorp/terraform-provider-aws.git"), resource.TestCheckResourceAttr(resourceName, "git_config.0.branch", "master"), ), }, @@ -133,7 +133,7 @@ func TestAccAWSSagemakerCodeRepository_gitConfig_secret(t *testing.T) { resource.TestCheckResourceAttr(resourceName, "code_repository_name", rName), testAccCheckResourceAttrRegionalARN(resourceName, "arn", "sagemaker", fmt.Sprintf("code-repository/%s", rName)), resource.TestCheckResourceAttr(resourceName, "git_config.#", "1"), - resource.TestCheckResourceAttr(resourceName, "git_config.0.repository_url", "https://github.com/terraform-providers/terraform-provider-aws.git"), + resource.TestCheckResourceAttr(resourceName, "git_config.0.repository_url", "https://github.com/hashicorp/terraform-provider-aws.git"), resource.TestCheckResourceAttrPair(resourceName, "git_config.0.secret_arn", "aws_secretsmanager_secret.test", "arn"), ), }, @@ -149,7 +149,7 @@ func TestAccAWSSagemakerCodeRepository_gitConfig_secret(t *testing.T) { resource.TestCheckResourceAttr(resourceName, "code_repository_name", rName), testAccCheckResourceAttrRegionalARN(resourceName, "arn", "sagemaker", fmt.Sprintf("code-repository/%s", rName)), resource.TestCheckResourceAttr(resourceName, "git_config.#", "1"), - resource.TestCheckResourceAttr(resourceName, "git_config.0.repository_url", "https://github.com/terraform-providers/terraform-provider-aws.git"), + resource.TestCheckResourceAttr(resourceName, "git_config.0.repository_url", "https://github.com/hashicorp/terraform-provider-aws.git"), resource.TestCheckResourceAttrPair(resourceName, "git_config.0.secret_arn", "aws_secretsmanager_secret.test2", "arn"), ), }, @@ -229,7 +229,7 @@ resource "aws_sagemaker_code_repository" "test" { code_repository_name = %[1]q git_config { - repository_url = "https://github.com/terraform-providers/terraform-provider-aws.git" + repository_url = "https://github.com/hashicorp/terraform-provider-aws.git" } } `, rName) @@ -241,7 +241,7 @@ resource "aws_sagemaker_code_repository" "test" { code_repository_name = %[1]q git_config { - repository_url = "https://github.com/terraform-providers/terraform-provider-aws.git" + repository_url = "https://github.com/hashicorp/terraform-provider-aws.git" branch = "master" } } @@ -263,7 +263,7 @@ resource "aws_sagemaker_code_repository" "test" { code_repository_name = %[1]q git_config { - repository_url = "https://github.com/terraform-providers/terraform-provider-aws.git" + repository_url = "https://github.com/hashicorp/terraform-provider-aws.git" secret_arn = aws_secretsmanager_secret.test.arn } @@ -287,7 +287,7 @@ resource "aws_sagemaker_code_repository" "test" { code_repository_name = %[1]q git_config { - repository_url = "https://github.com/terraform-providers/terraform-provider-aws.git" + repository_url = "https://github.com/hashicorp/terraform-provider-aws.git" secret_arn = aws_secretsmanager_secret.test2.arn } diff --git a/aws/resource_aws_sagemaker_notebook_instance_test.go b/aws/resource_aws_sagemaker_notebook_instance_test.go index 63d9af3b107..0768d80a9a2 100644 --- a/aws/resource_aws_sagemaker_notebook_instance_test.go +++ b/aws/resource_aws_sagemaker_notebook_instance_test.go @@ -509,11 +509,11 @@ func TestAccAWSSagemakerNotebookInstance_additional_code_repositories(t *testing CheckDestroy: testAccCheckAWSSagemakerNotebookInstanceDestroy, Steps: []resource.TestStep{ { - Config: testAccAWSSagemakerNotebookInstanceConfigAdditionalCodeRepository1(rName, "https://github.com/terraform-providers/terraform-provider-aws.git"), + Config: testAccAWSSagemakerNotebookInstanceConfigAdditionalCodeRepository1(rName, "https://github.com/hashicorp/terraform-provider-aws.git"), Check: resource.ComposeTestCheckFunc( testAccCheckAWSSagemakerNotebookInstanceExists(resourceName, ¬ebook), resource.TestCheckResourceAttr(resourceName, "additional_code_repositories.#", "1"), - tfawsresource.TestCheckTypeSetElemAttr(resourceName, "additional_code_repositories.*", "https://github.com/terraform-providers/terraform-provider-aws.git"), + tfawsresource.TestCheckTypeSetElemAttr(resourceName, "additional_code_repositories.*", "https://github.com/hashicorp/terraform-provider-aws.git"), ), }, { @@ -529,20 +529,20 @@ func TestAccAWSSagemakerNotebookInstance_additional_code_repositories(t *testing ), }, { - Config: testAccAWSSagemakerNotebookInstanceConfigAdditionalCodeRepository2(rName, "https://github.com/terraform-providers/terraform-provider-aws.git", "https://github.com/hashicorp/terraform.git"), + Config: testAccAWSSagemakerNotebookInstanceConfigAdditionalCodeRepository2(rName, "https://github.com/hashicorp/terraform-provider-aws.git", "https://github.com/hashicorp/terraform.git"), Check: resource.ComposeTestCheckFunc( testAccCheckAWSSagemakerNotebookInstanceExists(resourceName, ¬ebook), resource.TestCheckResourceAttr(resourceName, "additional_code_repositories.#", "2"), - tfawsresource.TestCheckTypeSetElemAttr(resourceName, "additional_code_repositories.*", "https://github.com/terraform-providers/terraform-provider-aws.git"), + tfawsresource.TestCheckTypeSetElemAttr(resourceName, "additional_code_repositories.*", "https://github.com/hashicorp/terraform-provider-aws.git"), tfawsresource.TestCheckTypeSetElemAttr(resourceName, "additional_code_repositories.*", "https://github.com/hashicorp/terraform.git"), ), }, { - Config: testAccAWSSagemakerNotebookInstanceConfigAdditionalCodeRepository1(rName, "https://github.com/terraform-providers/terraform-provider-aws.git"), + Config: testAccAWSSagemakerNotebookInstanceConfigAdditionalCodeRepository1(rName, "https://github.com/hashicorp/terraform-provider-aws.git"), Check: resource.ComposeTestCheckFunc( testAccCheckAWSSagemakerNotebookInstanceExists(resourceName, ¬ebook), resource.TestCheckResourceAttr(resourceName, "additional_code_repositories.#", "1"), - tfawsresource.TestCheckTypeSetElemAttr(resourceName, "additional_code_repositories.*", "https://github.com/terraform-providers/terraform-provider-aws.git"), + tfawsresource.TestCheckTypeSetElemAttr(resourceName, "additional_code_repositories.*", "https://github.com/hashicorp/terraform-provider-aws.git"), ), }, }, @@ -772,7 +772,7 @@ resource "aws_sagemaker_code_repository" "test" { code_repository_name = %[1]q git_config { - repository_url = "https://github.com/terraform-providers/terraform-provider-aws.git" + repository_url = "https://github.com/hashicorp/terraform-provider-aws.git" } } diff --git a/docs/roadmaps/2020_August_to_October.md b/docs/roadmaps/2020_August_to_October.md index 10cb840d91f..37ba4933c57 100644 --- a/docs/roadmaps/2020_August_to_October.md +++ b/docs/roadmaps/2020_August_to_October.md @@ -4,7 +4,7 @@ Every few months, the team will highlight areas of focus for our work and upcomi We select items for inclusion in the roadmap from the Top 10 Community Issues, [core services](../CORE_SERVICES.md), and internal priorities. When community pull requests exist for a given item, we will prioritize working with the original authors to include their contributions. If the author can no longer take on the implementation, HashiCorp will complete any additional work needed. -Each weekly release will include necessary tasks that lead to the completion of the stated goals as well as community pull requests, enhancements, and features that are not highlighted in the roadmap. To view all the items we've prioritized for this quarter, please see the [Roadmap milestone](https://github.com/terraform-providers/terraform-provider-aws/milestone/138). +Each weekly release will include necessary tasks that lead to the completion of the stated goals as well as community pull requests, enhancements, and features that are not highlighted in the roadmap. To view all the items we've prioritized for this quarter, please see the [Roadmap milestone](https://github.com/hashicorp/terraform-provider-aws/milestone/138). Where community sourced contributions exist we will work with the authors to review and merge their work. Where this does not exist we will create the resources and implementation ourselves. @@ -16,7 +16,7 @@ From August-October ‘20, we will be prioritizing the following areas of work: ### EventBridge -Issue: [#9330](https://github.com/terraform-providers/terraform-provider-aws/issues/9330) +Issue: [#9330](https://github.com/hashicorp/terraform-provider-aws/issues/9330) _[Amazon EventBridge](https://aws.amazon.com/eventbridge/) is a serverless event bus that makes it easy to connect applications together using data from your own applications, integrated Software-as-a-Service (SaaS) applications, and AWS services. EventBridge delivers a stream of real-time data from event sources, such as Zendesk, Datadog, or Pagerduty, and routes that data to targets like AWS Lambda. You can set up routing rules to determine where to send your data to build application architectures that react in real time to all of your data sources._ @@ -24,7 +24,7 @@ As EventBridge exists as an addition to existing CloudWatch APIs we will perform ### EC2 Image Builder -Issue: [#11084](https://github.com/terraform-providers/terraform-provider-aws/issues/11084) +Issue: [#11084](https://github.com/hashicorp/terraform-provider-aws/issues/11084) _[EC2 Image Builder](https://aws.amazon.com/image-builder/) simplifies the creation, maintenance, validation, sharing, and deployment of Linux or Windows Server images for use with Amazon EC2 and on-premises._ @@ -45,7 +45,7 @@ New Data Source(s): ### AWS Lake Formation -Issue: [#9700](https://github.com/terraform-providers/terraform-provider-aws/issues/9700) +Issue: [#9700](https://github.com/hashicorp/terraform-provider-aws/issues/9700) _[AWS Lake Formation](https://aws.amazon.com/lake-formation) is a service that makes it easy to set up a secure data lake in days. A data lake is a centralized, curated, and secured repository that stores all your data, both in its original form and prepared for analysis. A data lake enables you to break down data silos and combine different types of analytics to gain insights and guide better business decisions._ @@ -59,7 +59,7 @@ New Resource(s): ### AWS Serverless Application Repository -Issue: [#3981](https://github.com/terraform-providers/terraform-provider-aws/issues/3981) +Issue: [#3981](https://github.com/hashicorp/terraform-provider-aws/issues/3981) _The [AWS Serverless Application Repository](https://aws.amazon.com/serverless/serverlessrepo/) is a managed repository for serverless applications. It enables teams, organizations, and individual developers to store and share reusable applications, and easily assemble and deploy serverless architectures in powerful new ways. Using the Serverless Application Repository, you don't need to clone, build, package, or publish source code to AWS before deploying it. Instead, you can use pre-built applications from the Serverless Application Repository in your serverless architectures, helping you and your teams reduce duplicated work, ensure organizational best practices, and get to market faster. Integration with AWS Identity and Access Management (IAM) provides resource-level control of each application, enabling you to publicly share applications with everyone or privately share them with specific AWS accounts._ @@ -77,13 +77,13 @@ New Data Source(s): The issues below have gained substantial support via our community. As a result, we want to highlight our commitment to addressing them. -- [#12690](https://github.com/terraform-providers/terraform-provider-aws/issues/12690) RDS Proxy Support -- [#11281](https://github.com/terraform-providers/terraform-provider-aws/issues/11281) Home Directory Mappings Support for AWS Transfer User -- [#384](https://github.com/terraform-providers/terraform-provider-aws/issues/384) Add support for CreateVPCAssociationAuthorization AWS API -- [#6562](https://github.com/terraform-providers/terraform-provider-aws/issues/6562) Auto Scaling Plans (Dynamic/Predictive Auto Scaling Groups) -- [#5549](https://github.com/terraform-providers/terraform-provider-aws/issues/5549) Terraform constantly updates resource policy on API Gateway -- [#11569](https://github.com/terraform-providers/terraform-provider-aws/issues/11569) aws_transfer_server: support Elastic IPs -- [#5286](https://github.com/terraform-providers/terraform-provider-aws/issues/5286) Point in time restore support for AWS RDS instances +- [#12690](https://github.com/hashicorp/terraform-provider-aws/issues/12690) RDS Proxy Support +- [#11281](https://github.com/hashicorp/terraform-provider-aws/issues/11281) Home Directory Mappings Support for AWS Transfer User +- [#384](https://github.com/hashicorp/terraform-provider-aws/issues/384) Add support for CreateVPCAssociationAuthorization AWS API +- [#6562](https://github.com/hashicorp/terraform-provider-aws/issues/6562) Auto Scaling Plans (Dynamic/Predictive Auto Scaling Groups) +- [#5549](https://github.com/hashicorp/terraform-provider-aws/issues/5549) Terraform constantly updates resource policy on API Gateway +- [#11569](https://github.com/hashicorp/terraform-provider-aws/issues/11569) aws_transfer_server: support Elastic IPs +- [#5286](https://github.com/hashicorp/terraform-provider-aws/issues/5286) Point in time restore support for AWS RDS instances ## United States Federal Focus @@ -101,13 +101,13 @@ We are interested in your thoughts and feedback about the proposals below and en ### API Calls/IAM Actions Per Terraform Resource (Minimum IAM) -Issue: [#9154](https://github.com/terraform-providers/terraform-provider-aws/issues/9154) +Issue: [#9154](https://github.com/hashicorp/terraform-provider-aws/issues/9154) To address security concerns and best practices we are considering how Terraform could surface minimally viable IAM policies for taking actions on resources or executing a TF plan. This is in the early stages of research and we are particularly interested in whether or not this would be useful and the resources or services areas for which it is most valuable. ### Lifecycle: Retain [Add 'retain' attribute to the Terraform lifecycle meta-parameter] -Issue: [#902](https://github.com/terraform-providers/terraform-provider-aws/issues/902) +Issue: [#902](https://github.com/hashicorp/terraform-provider-aws/issues/902) Some resources (e.g. log groups) are intended to be created but never destroyed. Terraform currently does not have a lifecycle attribute for retaining such resources. We are curious as to whether or not retaining resources is a workflow that meets the needs of our community and if so, how and where we might make use of that in the AWS Provider. diff --git a/website/docs/r/sagemaker_code_repository.htm.markdown b/website/docs/r/sagemaker_code_repository.htm.markdown index d5b8c5e6b5a..2dc1a57bd18 100644 --- a/website/docs/r/sagemaker_code_repository.htm.markdown +++ b/website/docs/r/sagemaker_code_repository.htm.markdown @@ -19,7 +19,7 @@ resource "aws_sagemaker_code_repository" "example" { code_repository_name = "example" git_config { - repository_url = "https://github.com/terraform-providers/terraform-provider-aws.git" + repository_url = "https://github.com/hashicorp/terraform-provider-aws.git" } } ``` @@ -40,7 +40,7 @@ resource "aws_sagemaker_code_repository" "example" { code_repository_name = "example" git_config { - repository_url = "https://github.com/terraform-providers/terraform-provider-aws.git" + repository_url = "https://github.com/hashicorp/terraform-provider-aws.git" secret_arn = aws_secretsmanager_secret.example.arn } diff --git a/website/docs/r/sagemaker_notebook_instance.html.markdown b/website/docs/r/sagemaker_notebook_instance.html.markdown index 67adc650baa..3c5e399e559 100644 --- a/website/docs/r/sagemaker_notebook_instance.html.markdown +++ b/website/docs/r/sagemaker_notebook_instance.html.markdown @@ -33,7 +33,7 @@ resource "aws_sagemaker_code_repository" "example" { code_repository_name = "my-notebook-instance-code-repo" git_config { - repository_url = "https://github.com/terraform-providers/terraform-provider-aws.git" + repository_url = "https://github.com/hashicorp/terraform-provider-aws.git" } }