Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_route: AWS Wavelength support #16961

Merged
merged 3 commits into from
Mar 26, 2021
Merged

r/aws_route: AWS Wavelength support #16961

merged 3 commits into from
Mar 26, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 4, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Builds on: #14014, #16930
Dependents: #17291, #17295

Relates #14518.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 180m
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_disappears
=== PAUSE TestAccAWSRoute_disappears
=== RUN   TestAccAWSRoute_disappears_RouteTable
=== PAUSE TestAccAWSRoute_disappears_RouteTable
=== RUN   TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_InternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_InternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_Instance
=== PAUSE TestAccAWSRoute_IPv6_To_Instance
=== RUN   TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv6_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv6_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv4_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_Instance
=== PAUSE TestAccAWSRoute_IPv4_To_Instance
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
=== RUN   TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv4_To_NatGateway
=== PAUSE TestAccAWSRoute_IPv4_To_NatGateway
=== RUN   TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== RUN   TestAccAWSRoute_IPv4_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv4_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv6_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv6_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv4_To_CarrierGateway
=== PAUSE TestAccAWSRoute_IPv4_To_CarrierGateway
=== RUN   TestAccAWSRoute_IPv4_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv4_To_LocalGateway
=== RUN   TestAccAWSRoute_IPv6_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv6_To_LocalGateway
=== RUN   TestAccAWSRoute_ConditionalCidrBlock
=== PAUSE TestAccAWSRoute_ConditionalCidrBlock
=== RUN   TestAccAWSRoute_IPv4_Update_Target
=== PAUSE TestAccAWSRoute_IPv4_Update_Target
=== RUN   TestAccAWSRoute_IPv6_Update_Target
=== PAUSE TestAccAWSRoute_IPv6_Update_Target
=== RUN   TestAccAWSRoute_IPv4_To_VpcEndpoint
=== PAUSE TestAccAWSRoute_IPv4_To_VpcEndpoint
=== RUN   TestAccAWSRoute_LocalRoute
=== PAUSE TestAccAWSRoute_LocalRoute
=== CONT  TestAccAWSRoute_basic
=== CONT  TestAccAWSRoute_IPv4_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (27.98s)
=== CONT  TestAccAWSRoute_LocalRoute
--- PASS: TestAccAWSRoute_basic (37.06s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcEndpoint
--- PASS: TestAccAWSRoute_LocalRoute (22.92s)
=== CONT  TestAccAWSRoute_IPv6_Update_Target
--- PASS: TestAccAWSRoute_IPv6_Update_Target (222.77s)
=== CONT  TestAccAWSRoute_IPv4_Update_Target
--- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (313.20s)
=== CONT  TestAccAWSRoute_ConditionalCidrBlock
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (54.52s)
=== CONT  TestAccAWSRoute_IPv6_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (0.58s)
=== CONT  TestAccAWSRoute_IPv4_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (0.58s)
=== CONT  TestAccAWSRoute_IPv4_To_CarrierGateway
--- PASS: TestAccAWSRoute_IPv4_To_CarrierGateway (25.04s)
=== CONT  TestAccAWSRoute_IPv6_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (338.50s)
=== CONT  TestAccAWSRoute_IPv4_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv4_Update_Target (615.32s)
=== CONT  TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (43.42s)
=== CONT  TestAccAWSRoute_IPv4_To_NatGateway
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (358.90s)
=== CONT  TestAccAWSRoute_IPv6_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (26.95s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (230.21s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (154.55s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (58.72s)
=== CONT  TestAccAWSRoute_IPv4_To_Instance
=== CONT  TestAccAWSRoute_IPv4_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (360.33s)
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (59.54s)
=== CONT  TestAccAWSRoute_IPv6_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (44.53s)
=== CONT  TestAccAWSRoute_IPv6_To_InternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (36.14s)
=== CONT  TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv4_To_Instance (337.76s)
=== CONT  TestAccAWSRoute_IPv6_To_Instance
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (59.53s)
=== CONT  TestAccAWSRoute_disappears_RouteTable
--- PASS: TestAccAWSRoute_disappears_RouteTable (34.96s)
=== CONT  TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (38.74s)
=== CONT  TestAccAWSRoute_disappears
--- PASS: TestAccAWSRoute_disappears (32.88s)
--- PASS: TestAccAWSRoute_IPv6_To_Instance (358.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2065.270s

@ewbankkit ewbankkit requested a review from a team as a code owner January 4, 2021 20:31
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 4, 2021
@ewbankkit ewbankkit mentioned this pull request Jan 4, 2021
Merged
Base automatically changed from master to main January 23, 2021 01:00
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 24, 2021
This was referenced Jan 26, 2021
Merged
Merged
@YakDriver YakDriver self-assigned this Mar 25, 2021
This was referenced Mar 25, 2021
Merged
Merged
@ewbankkit
r/aws_route: Refactor acceptance tests in preparation for future fixe…
4f38bb7 
…s/enhancements.
@ewbankkit
r/aws_route: AWS Wavelength support.
328a3de 
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_disappears
=== PAUSE TestAccAWSRoute_disappears
=== RUN   TestAccAWSRoute_disappears_RouteTable
=== PAUSE TestAccAWSRoute_disappears_RouteTable
=== RUN   TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_InternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_InternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_Instance
=== PAUSE TestAccAWSRoute_IPv6_To_Instance
=== RUN   TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv6_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv6_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv4_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_Instance
=== PAUSE TestAccAWSRoute_IPv4_To_Instance
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
=== RUN   TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv4_To_NatGateway
=== PAUSE TestAccAWSRoute_IPv4_To_NatGateway
=== RUN   TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== RUN   TestAccAWSRoute_IPv4_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv4_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv6_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv6_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv4_To_CarrierGateway
=== PAUSE TestAccAWSRoute_IPv4_To_CarrierGateway
=== RUN   TestAccAWSRoute_IPv4_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv4_To_LocalGateway
=== RUN   TestAccAWSRoute_IPv6_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv6_To_LocalGateway
=== RUN   TestAccAWSRoute_ConditionalCidrBlock
=== PAUSE TestAccAWSRoute_ConditionalCidrBlock
=== RUN   TestAccAWSRoute_IPv4_Update_Target
=== PAUSE TestAccAWSRoute_IPv4_Update_Target
=== RUN   TestAccAWSRoute_IPv6_Update_Target
=== PAUSE TestAccAWSRoute_IPv6_Update_Target
=== RUN   TestAccAWSRoute_IPv4_To_VpcEndpoint
=== PAUSE TestAccAWSRoute_IPv4_To_VpcEndpoint
=== RUN   TestAccAWSRoute_LocalRoute
=== PAUSE TestAccAWSRoute_LocalRoute
=== CONT  TestAccAWSRoute_basic
=== CONT  TestAccAWSRoute_IPv4_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (27.86s)
=== CONT  TestAccAWSRoute_LocalRoute
--- PASS: TestAccAWSRoute_basic (37.05s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcEndpoint
--- PASS: TestAccAWSRoute_LocalRoute (22.22s)
=== CONT  TestAccAWSRoute_IPv6_Update_Target
--- PASS: TestAccAWSRoute_IPv6_Update_Target (217.77s)
=== CONT  TestAccAWSRoute_IPv4_Update_Target
--- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (314.58s)
=== CONT  TestAccAWSRoute_ConditionalCidrBlock
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (54.25s)
=== CONT  TestAccAWSRoute_IPv6_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (1.28s)
=== CONT  TestAccAWSRoute_IPv4_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (1.16s)
=== CONT  TestAccAWSRoute_IPv4_To_CarrierGateway
--- PASS: TestAccAWSRoute_IPv4_To_CarrierGateway (25.48s)
=== CONT  TestAccAWSRoute_IPv6_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (378.71s)
=== CONT  TestAccAWSRoute_IPv4_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv4_Update_Target (682.34s)
=== CONT  TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (42.49s)
=== CONT  TestAccAWSRoute_IPv4_To_NatGateway
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (187.94s)
=== CONT  TestAccAWSRoute_IPv6_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (378.19s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (26.27s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (173.10s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (58.15s)
=== CONT  TestAccAWSRoute_IPv4_To_Instance
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (330.77s)
=== CONT  TestAccAWSRoute_IPv4_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (38.73s)
=== CONT  TestAccAWSRoute_IPv6_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (37.37s)
=== CONT  TestAccAWSRoute_IPv6_To_InternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (34.74s)
=== CONT  TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (58.78s)
=== CONT  TestAccAWSRoute_IPv6_To_Instance
--- PASS: TestAccAWSRoute_IPv4_To_Instance (310.07s)
=== CONT  TestAccAWSRoute_disappears_RouteTable
--- PASS: TestAccAWSRoute_disappears_RouteTable (34.49s)
=== CONT  TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (37.65s)
=== CONT  TestAccAWSRoute_disappears
--- PASS: TestAccAWSRoute_disappears (32.07s)
--- PASS: TestAccAWSRoute_IPv6_To_Instance (328.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2035.886s
@ewbankkit
Add CHANGELOG entry.
0597561
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Mar 25, 2021
YakDriver
YakDriver approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

I ran a wider set of tests as a sanity check with all the changes yesterday and today.

Acceptance tests on GovCloud: (failures addressed in other PRs)

--- FAIL: TestAccAWSRoute_IPv4_To_VpcEndpoint (32.30s)
--- FAIL: TestAccAWSRoute_IPv4_Update_Target (383.53s)
--- FAIL: TestAccAWSRouteDataSource_basic (108.03s)
--- FAIL: TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway (21.08s)
--- FAIL: TestAccAWSRouteTable_VpcClassicLink (18.07s)
--- PASS: TestAccAWSRoute_basic (59.62s)
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (85.18s)
--- PASS: TestAccAWSRoute_disappears (60.59s)
--- PASS: TestAccAWSRoute_disappears_RouteTable (53.67s)
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (49.53s)
--- PASS: TestAccAWSRoute_IPv4_To_Instance (101.42s)
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (207.70s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (132.20s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (195.78s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (72.59s)
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (407.80s)
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (44.00s)
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (57.30s)
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (53.06s)
--- PASS: TestAccAWSRoute_IPv6_To_Instance (139.15s)
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (50.50s)
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (77.51s)
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (334.68s)
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (48.73s)
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (62.25s)
--- PASS: TestAccAWSRoute_IPv6_Update_Target (260.85s)
--- PASS: TestAccAWSRoute_LocalRoute (42.75s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (330.22s)
--- PASS: TestAccAWSRouteTable_basic (31.95s)
--- PASS: TestAccAWSRouteTable_ConditionalCidrBlock (85.29s)
--- PASS: TestAccAWSRouteTable_disappears (30.31s)
--- PASS: TestAccAWSRouteTable_disappears_SubnetAssociation (39.42s)
--- PASS: TestAccAWSRouteTable_GatewayVpcEndpoint (56.60s)
--- PASS: TestAccAWSRouteTable_IPv4_To_Instance (107.36s)
--- PASS: TestAccAWSRouteTable_IPv4_To_InternetGateway (80.92s)
--- PASS: TestAccAWSRouteTable_IPv4_To_NatGateway (236.26s)
--- PASS: TestAccAWSRouteTable_IPv4_To_TransitGateway (394.78s)
--- PASS: TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection (52.19s)
--- PASS: TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached (92.19s)
--- PASS: TestAccAWSRouteTable_MultipleRoutes (245.05s)
--- PASS: TestAccAWSRouteTable_RequireRouteDestination (340.71s)
--- PASS: TestAccAWSRouteTable_RequireRouteTarget (15.55s)
--- PASS: TestAccAWSRouteTable_Route_ConfigMode (81.22s)
--- PASS: TestAccAWSRouteTable_tags (85.62s)
--- PASS: TestAccAWSRouteTable_vgwRoutePropagation (139.08s)
--- PASS: TestAccAWSRouteTable_VpcMultipleCidrs (64.62s)
--- SKIP: TestAccAWSRoute_IPv4_To_CarrierGateway (0.35s)
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (0.53s)
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (0.62s)
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (0.62s)
--- SKIP: TestAccAWSRouteTable_IPv4_To_LocalGateway (2.03s)
--- SKIP: TestAccAWSRouteTable_IPv4_To_VpcEndpoint (1.79s)

Acceptance tests on commercial:

--- FAIL: TestAccAWSRouteDataSource_basic (126.00s) *** We need to look into this.
--- PASS: TestAccAWSRoute_basic (62.76s)
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (99.13s)
--- PASS: TestAccAWSRoute_disappears (35.27s)
--- PASS: TestAccAWSRoute_disappears_RouteTable (35.74s)
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (47.84s)
--- PASS: TestAccAWSRoute_IPv4_To_CarrierGateway (50.77s)
--- PASS: TestAccAWSRoute_IPv4_To_Instance (106.19s)
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (179.98s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (167.16s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (200.52s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (61.19s)
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (349.42s)
--- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (304.61s)
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (32.75s)
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (70.13s)
--- PASS: TestAccAWSRoute_IPv4_Update_Target (632.93s)
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (43.86s)
--- PASS: TestAccAWSRoute_IPv6_To_Instance (96.45s)
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (40.00s)
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (62.47s)
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (398.52s)
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (31.23s)
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (56.82s)
--- PASS: TestAccAWSRoute_IPv6_Update_Target (300.74s)
--- PASS: TestAccAWSRoute_LocalRoute (44.30s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (384.25s)
--- PASS: TestAccAWSRouteTable_basic (43.41s)
--- PASS: TestAccAWSRouteTable_ConditionalCidrBlock (95.62s)
--- PASS: TestAccAWSRouteTable_disappears (38.80s)
--- PASS: TestAccAWSRouteTable_disappears_SubnetAssociation (44.05s)
--- PASS: TestAccAWSRouteTable_GatewayVpcEndpoint (61.37s)
--- PASS: TestAccAWSRouteTable_IPv4_To_Instance (134.46s)
--- PASS: TestAccAWSRouteTable_IPv4_To_InternetGateway (84.39s)
--- PASS: TestAccAWSRouteTable_IPv4_To_NatGateway (213.04s)
--- PASS: TestAccAWSRouteTable_IPv4_To_TransitGateway (392.25s)
--- PASS: TestAccAWSRouteTable_IPv4_To_VpcEndpoint (304.52s)
--- PASS: TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection (51.99s)
--- PASS: TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway (51.65s)
--- PASS: TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached (100.24s)
--- PASS: TestAccAWSRouteTable_MultipleRoutes (223.65s)
--- PASS: TestAccAWSRouteTable_RequireRouteDestination (318.32s)
--- PASS: TestAccAWSRouteTable_RequireRouteTarget (13.19s)
--- PASS: TestAccAWSRouteTable_Route_ConfigMode (75.52s)
--- PASS: TestAccAWSRouteTable_tags (73.48s)
--- PASS: TestAccAWSRouteTable_vgwRoutePropagation (124.05s)
--- PASS: TestAccAWSRouteTable_VpcClassicLink (47.64s)
--- PASS: TestAccAWSRouteTable_VpcMultipleCidrs (69.72s)
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (0.54s)
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (0.63s)
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (0.55s)
--- SKIP: TestAccAWSRouteTable_IPv4_To_LocalGateway (1.53s)

@YakDriver YakDriver merged commit 43f50a5 into hashicorp:main Mar 26, 2021
@YakDriver YakDriver added this to the v3.35.0 milestone Mar 26, 2021
@ewbankkit ewbankkit deleted the f-aws_route-wavelength branch March 26, 2021 16:12
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ewbankkit @YakDriver @DrFaust92