Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add settings field to ecs.DescribeClustersInput #20720

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Fix: Add settings field to ecs.DescribeClustersInput #20720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edbd923
Add setting field to ecs.DescribeClustersInput
1newsr Aug 30, 2021
d8afa50
Add CHANGELOG entry.
ewbankkit Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/20720.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_ecs_cluster: Ensure that `setting` attribute is set consistently
```
6 changes: 5 additions & 1 deletion aws/internal/service/ecs/finder/finder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ func CapacityProviderByARN(conn *ecs.ECS, arn string) (*ecs.CapacityProvider, er
func ClusterByARN(conn *ecs.ECS, arn string) (*ecs.DescribeClustersOutput, error) {
input := &ecs.DescribeClustersInput{
Clusters: []*string{aws.String(arn)},
Include: []*string{aws.String(ecs.ClusterFieldTags), aws.String(ecs.ClusterFieldConfigurations)},
Include: []*string{
aws.String(ecs.ClusterFieldTags),
aws.String(ecs.ClusterFieldConfigurations),
aws.String(ecs.ClusterFieldSettings),
},
}

output, err := conn.DescribeClusters(input)
Expand Down